morpheus-cli 5.3.1 → 5.3.2.2

data/lib/morpheus/cli/library_option_types_command.rb

@@ -17,10 +17,10 @@ class Morpheus::Cli::LibraryOptionTypesCommand
 
   def connect(opts)
     @api_client = establish_remote_appliance_connection(opts)
-    @library_instance_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).library_instance_types
-    @provision_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).provision_types
-    @option_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).option_types
-    @option_type_lists_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).option_type_lists
+    @library_instance_types_interface = @api_client.library_instance_types
+    @provision_types_interface = @api_client.provision_types
+    @option_types_interface = @api_client.option_types
+    @option_type_lists_interface = @api_client.option_type_lists
   end
 
   def handle(args)
@@ -35,6 +35,10 @@ class Morpheus::Cli::LibraryOptionTypesCommand
       opts.footer = "List option types."
     end
     optparse.parse!(args)
+    # verify_args!(args:args, optparse:optparse, count:0)
+    if args.count > 0
+      options[:phrase] = args.join(" ")
+    end
     connect(options)
     begin
       params = {}

data/lib/morpheus/cli/library_spec_templates_command.rb

@@ -26,12 +26,11 @@ class Morpheus::Cli::LibrarySpecTemplatesCommand
       opts.footer = "List spec templates."
     end
     optparse.parse!(args)
-    connect(options)
+    # verify_args!(args:args, optparse:optparse, count:0)
     if args.count > 0
-      print_error Morpheus::Terminal.angry_prompt
-      puts_error  "wrong number of arguments, expected 0 and got (#{args.count}) #{args.inspect}\n#{optparse}"
-      return 1
+      options[:phrase] = args.join(" ")
     end
+    connect(options)
     begin
       # construct payload
       params.merge!(parse_list_options(options))

data/lib/morpheus/cli/library_upgrades_command.rb

@@ -18,12 +18,12 @@ class Morpheus::Cli::LibraryUpgradesCommand
 
   def connect(opts)
     @api_client = establish_remote_appliance_connection(opts)
-    @library_container_upgrades_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).library_container_upgrades
-    @library_layouts_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).library_layouts
-    @library_instance_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).library_instance_types
-    @provision_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).provision_types
-    @option_types_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).option_types
-    @option_type_lists_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).option_type_lists
+    @library_container_upgrades_interface = @api_client.library_container_upgrades
+    @library_layouts_interface = @api_client.library_layouts
+    @library_instance_types_interface = @api_client.library_instance_types
+    @provision_types_interface = @api_client.provision_types
+    @option_types_interface = @api_client.option_types
+    @option_type_lists_interface = @api_client.option_type_lists
   end
 
   def handle(args)

data/lib/morpheus/cli/license.rb

@@ -20,8 +20,8 @@ class Morpheus::Cli::License
 
   def connect(opts)
     @api_client = establish_remote_appliance_connection(opts)
-    @api_client = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url)		
-    @license_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).license
+    @api_client = @api_client		
+    @license_interface = @api_client.license
   end
 
   def handle(args)

data/lib/morpheus/cli/load_balancer_types.rb

@@ -0,0 +1,37 @@
+# require 'yaml'
+require 'io/console'
+require 'rest_client'
+require 'optparse'
+require 'morpheus/cli/cli_command'
+
+class Morpheus::Cli::LoadBalancerTypes
+  include Morpheus::Cli::CliCommand
+  include Morpheus::Cli::RestCommand
+  include Morpheus::Cli::LoadBalancersHelper
+
+  set_command_name :'load-balancer-types'
+  register_subcommands :list, :get
+
+  # register_interfaces :load_balancer_types
+
+  protected
+
+  def load_balancer_type_column_definitions
+    {
+      "ID" => 'id',
+      "Name" => 'name',
+      "Code" => 'code'
+    }
+  end
+
+  def load_balancer_type_list_column_definitions
+    load_balancer_type_column_definitions
+  end
+
+  # overridden to support name or code
+  def find_load_balancer_type_by_name_or_id(name)
+    load_balancer_type_for_name_or_id(name)
+  end
+
+end
+

data/lib/morpheus/cli/load_balancers.rb

@@ -1,161 +1,106 @@
 # require 'yaml'
-require 'io/console'
-require 'rest_client'
-require 'optparse'
 require 'morpheus/cli/cli_command'
 
 class Morpheus::Cli::LoadBalancers
   include Morpheus::Cli::CliCommand
+  include Morpheus::Cli::RestCommand
+  include Morpheus::Cli::LoadBalancersHelper
 
-  register_subcommands :list, :get, :add, :update, :remove, {:types => :lb_types}
-  alias_subcommand :details, :get
-
-  def initialize() 
-    # @appliance_name, @appliance_url = Morpheus::Cli::Remote.active_appliance
-  end
-
-  def connect(opts)
-    @api_client = establish_remote_appliance_connection(opts)
-    @load_balancers_interface = Morpheus::APIClient.new(@access_token,nil,nil, @appliance_url).load_balancers
-  end
+  set_command_name :'load-balancers'
+  register_subcommands :list, :get, :add, :update, :remove
 
+  # deprecated the `load-balancers types` command in 5.3.2, it moved to `load-balancer-types list`
+  register_subcommands :types
+  set_subcommands_hidden :types
 
-  def handle(args)
-    handle_subcommand(args)
-  end
+  # RestCommand settings
+  register_interfaces :load_balancers, :load_balancer_types
+  set_rest_has_type true
+  # set_rest_type :load_balancer_types
 
-  def list(args)
-    options = {}
-    optparse = Morpheus::Cli::OptionParser.new do |opts|
-      opts.banner = subcommand_usage()
-      build_common_options(opts, options, [:list, :json, :csv, :yaml, :fields, :dry_run, :remote])
-    end
-    optparse.parse!(args)
-    connect(options)
-    begin
-      params = {}
-      [:phrase, :offset, :max, :sort, :direction].each do |k|
-        params[k] = options[k] unless options[k].nil?
-      end
-      @load_balancers_interface.setopts(options)
-      if options[:dry_run]
-        print_dry_run @load_balancers_interface.dry.list(params)
-        return
-      end
-      json_response = @load_balancers_interface.list(params)
-      if options[:json]
-        puts as_json(json_response, options, "loadBalancers")
-        return 0
-      elsif options[:csv]
-        puts records_as_csv(json_response["loadBalancers"], options)
-        return 0
-      elsif options[:yaml]
-        puts as_yaml(json_response, options, "loadBalancers")
-        return 0
-      else
-        lbs = json_response['loadBalancers']
-        print_h1 "Morpheus Load Balancers"
-        if lbs.empty?
-          print cyan,"No load balancers found.",reset,"\n"
-        else
-          columns = [
-            {"ID" => 'id'},
-            {"Name" => 'name'},
-            {"Type" => lambda {|it| it['type'] ? it['type']['name'] : '' } },
-            {"Cloud" => lambda {|it| it['cloud'] ? it['cloud']['name'] : '' } },
-            {"Host" => lambda {|it| it['host'] } },
-          ]
-          print as_pretty_table(lbs, columns, options)
-        end
-        print reset,"\n"
-        return 0
+  def render_response_for_get(json_response, options)
+    render_response(json_response, options, rest_object_key) do
+      record = json_response[rest_object_key]
+      print_h1 rest_label, [], options
+      print cyan
+      print_description_list(rest_column_definitions, record, options)
+      # show LB Ports
+      ports = record['ports']
+      if ports && ports.size > 0
+        print_h2 "LB Ports", options
+        columns = [
+          {"ID" => 'id'},
+          {"Name" => 'name'},
+          #{"Description" => 'description'},
+          {"Port" => lambda {|it| it['port'] } },
+          {"Protocol" => lambda {|it| it['proxyProtocol'] } },
+          {"SSL" => lambda {|it| it['sslEnabled'] ? "Yes (#{it['sslCert'] ? it['sslCert']['name'] : 'none'})" : "No" } },
+        ]
+        print as_pretty_table(ports, columns, options)
       end
-    rescue RestClient::Exception => e
-      print_rest_exception(e, options)
-      return 1
+      print reset,"\n"
     end
   end
 
-  def get(args)
+=begin
+
+# now using RestCommand
+
+  def add(args)
+    lb_type_name = nil
     options = {}
     optparse = Morpheus::Cli::OptionParser.new do |opts|
-      opts.banner = subcommand_usage("[name]")
-      build_common_options(opts, options, [:json, :csv, :yaml, :fields, :dry_run, :remote])
+      opts.banner = subcommand_usage("[name] -t LB_TYPE")
+      opts.on( '-t', '--type CODE', "Load Balancer Type" ) do |val|
+        lb_type_name = val
+      end
+      #build_option_type_options(opts, options, add_load_balancer_option_types)
+      build_standard_add_options(opts, options)
     end
     optparse.parse!(args)
-    if args.count < 1
+    lb_name = args[0]
+    # verify_args!(args:args, optparse:optparse, min:0, max: 1)
+    verify_args!(args:args, optparse:optparse, min:1, max: 1)
+    if lb_type_name.nil?
+      raise_command_error "Load Balancer Type is required.\n#{optparse}"
       puts optparse
       exit 1
     end
-    lb_name = args[0]
     connect(options)
-    begin
-      @load_balancers_interface.setopts(options)
-      if options[:dry_run]
-        if lb_name.to_s =~ /\A\d{1,}\Z/
-          print_dry_run @load_balancers_interface.dry.get(lb_name.to_i)
-        else
-          print_dry_run @load_balancers_interface.dry.list({name:lb_name})
-        end
-        return
-      end
-      lb = find_lb_by_name_or_id(lb_name)
-      exit 1 if lb.nil?
-      # refetch
-      json_response = @load_balancers_interface.get(lb['id'])
-      lb_type = load_balancer_type_for_name_or_id(lb['type']['code'])
-      #puts "LB TYPE: #{lb_type}"
-      if options[:json]
-        puts JSON.pretty_generate({loadBalancer: lb})
-        puts as_json(json_response, options, "loadBalancer")
-        return 0
-      elsif options[:csv]
-        puts records_as_csv(json_response["loadBalancer"], options)
-        return 0
-      elsif options[:yaml]
-        puts as_yaml(json_response, options, "loadBalancer")
-        return 0
-      else
-        print_h1 "Load Balancer Details"
-        description_cols = {
-          "ID" => 'id',
-          "Name" => 'name',
-          "Description" => 'description',
-          "Type" => lambda {|it| it['type'] ? it['type']['name'] : '' },
-          "Cloud" => lambda {|it| it['cloud'] ? it['cloud']['name'] : '' },
-          "Visibility" => 'visibility',
-          "IP" => 'ip',
-          "Host" => 'host',
-          "Port" => 'port',
-          "Username" => 'username',
-          # "SSL Enabled" => lambda {|it| format_boolean it['sslEnabled'] },
-          # "SSL Cert" => lambda {|it| it['sslCert'] ? it['sslCert']['name'] : '' },
-          # "SSL" => lambda {|it| it['sslEnabled'] ? "Yes (#{it['sslCert'] ? it['sslCert']['name'] : 'none'})" : "No" },
-          "Created" => lambda {|it| format_local_dt(it['dateCreated']) },
-          "Updated" => lambda {|it| format_local_dt(it['lastUpdated']) }
-        }
-        print_description_list(description_cols, lb)
-
-
-        if lb['ports'] && lb['ports'].size > 0
-          print_h2 "LB Ports"
-          columns = [
-            {"ID" => 'id'},
-            {"Name" => 'name'},
-            #{"Description" => 'description'},
-            {"Port" => lambda {|it| it['port'] } },
-            {"Protocol" => lambda {|it| it['proxyProtocol'] } },
-            {"SSL" => lambda {|it| it['sslEnabled'] ? "Yes (#{it['sslCert'] ? it['sslCert']['name'] : 'none'})" : "No" } },
-          ]
-          print as_pretty_table(lb['ports'], columns, options)
-        end
-        print reset,"\n"
-        return 0
-      end
-    rescue RestClient::Exception => e
-      print_rest_exception(e, options)
+    lb_type = load_balancer_type_for_name_or_id(lb_type_name)
+    if lb_type.nil?
+      print_red_alert "LB Type #{lb_type_name} not found!"
       exit 1
     end
+    passed_options = parse_passed_options(options)
+    payload = {}
+    if options[:payload]
+      payload = options[:payload]
+      payload.deep_merge!({load_balancer_object_key => passed_options})
+    else
+      load_balancer_payload = {'name' => lb_name, 'type' => {'code' =>  lb_type['code'], 'id' => lb_type['id']}}
+      load_balancer_payload.deep_merge!({load_balancer_object_key => passed_options})
+      # options by type
+      my_option_types = lb_type['optionTypes']
+      if my_option_types && !my_option_types.empty?
+        v_prompt = Morpheus::Cli::OptionTypes.prompt(my_option_types, options[:options], @api_client, options[:params])
+        v_prompt.deep_compact!
+        load_balancer_payload.deep_merge!(v_prompt)
+      end
+      payload[load_balancer_object_key] = load_balancer_payload
+    end
+    @load_balancers_interface.setopts(options)
+    if options[:dry_run]
+      print_dry_run @load_balancers_interface.dry.create(payload)
+      return
+    end      
+    json_response = @load_balancers_interface.create(payload)
+    render_response(json_response, options, load_balancer_object_key) do
+      load_balancer = json_response[load_balancer_object_key]
+      print_green_success "Added load balancer #{load_balancer['name']}"
+      return _get(load_balancer["id"], {}, options)
+    end
+    return 0, nil
   end
 
   def update(args)
@@ -163,8 +108,8 @@ class Morpheus::Cli::LoadBalancers
     options = {}
     account_name = nil
     optparse = Morpheus::Cli::OptionParser.new do |opts|
-      opts.banner = subcommand_usage("[name] [options]")
-      build_common_options(opts, options, [:options, :json, :dry_run, :remote])
+      opts.banner = subcommand_usage("[lb] [options]")
+      build_standard_update_options(opts, options)
     end
     optparse.parse!(args)
     if args.count < 1
@@ -172,141 +117,47 @@ class Morpheus::Cli::LoadBalancers
       exit 1
     end
     connect(options)
-    begin
-
-      lb = find_lb_by_name_or_id(lb_name)
-      exit 1 if lb.nil?
-      lb_type = load_balancer_type_for_name_or_id(lb['type']['code'])
-
-      #params = Morpheus::Cli::OptionTypes.prompt(add_load_balancer_option_types, options[:options], @api_client, options[:params]) # options[:params] is mysterious
-      params = options[:options] || {}
-
-      if params.empty?
-        puts optparse
-        option_lines = update_task_option_types(lb_type).collect {|it| "\t-O #{it['fieldContext'] ? (it['fieldContext'] + '.') : ''}#{it['fieldName']}=\"value\"" }.join("\n")
-        puts "\nAvailable Options:\n#{option_lines}\n\n"
-        exit 1
-      end
 
-      # todo: fix this...
-      #puts "parsed params is : #{params.inspect}"
-      lb_keys = ['name']
-      changes_payload = (params.select {|k,v| task_keys.include?(k) })
-      task_payload = task
-      if changes_payload
-        task_payload.merge!(changes_payload)
-      end
-      puts params
-      if params['taskOptions']
-        task_payload['taskOptions'].merge!(params['taskOptions'])
-      end
-      payload = {task: task_payload}
-      @load_balancers_interface.setopts(options)
-      if options[:dry_run]
-        print_dry_run @load_balancers_interface.dry.update(task['id'], payload)
-        return
+    passed_options = parse_passed_options(options)
+    payload = nil
+    if options[:payload]
+      payload = options[:payload]
+      payload.deep_merge!({load_balancer_object_key => passed_options}) unless passed_options.empty?
+    else
+      load_balancer_payload = passed_options
+      if tenants_list
+        load_balancer_payload['accounts'] = tenants_list
       end
-      response = @load_balancers_interface.update(task['id'], payload)
-      if options[:json]
-        print JSON.pretty_generate(json_response)
-        if !response['success']
-          exit 1
-        end
+      # metadata tags
+      if options[:tags]
+        load_balancer_payload['tags'] = parse_metadata(options[:tags])
       else
-        print "\n", cyan, "Task #{response['task']['name']} updated", reset, "\n\n"
+        # tags = prompt_metadata(options)
+        # payload[load_balancer_object_key]['tags'] = tags of tags
       end
-    rescue RestClient::Exception => e
-      print_rest_exception(e, options)
-      exit 1
-    end
-  end
-
-
-  def lb_types(args)
-    options = {}
-    optparse = Morpheus::Cli::OptionParser.new do |opts|
-      opts.banner = subcommand_usage()
-      build_common_options(opts, options, [:json, :dry_run, :remote])
-    end
-    optparse.parse!(args)
-    connect(options)
-    begin
-      @load_balancers_interface.setopts(options)
-      if options[:dry_run]
-        print_dry_run @load_balancers_interface.dry.load_balancer_types()
-        return
+      # metadata tags
+      if options[:add_tags]
+        load_balancer_payload['addTags'] = parse_metadata(options[:add_tags])
       end
-      json_response = @load_balancers_interface.load_balancer_types()
-      if options[:json]
-        print JSON.pretty_generate(json_response)
-      else
-        lb_types = json_response['loadBalancerTypes']
-        print_h1 "Morpheus Load Balancer Types"
-        if lb_types.nil? || lb_types.empty?
-          print cyan,"No load balancer types found.",reset,"\n"
-        else
-          print cyan
-          lb_table_data = lb_types.collect do |lb_type|
-            {name: lb_type['name'], id: lb_type['id'], code: lb_type['code']}
-          end
-          print as_pretty_table(lb_table_data, [:id, :name, :code], options)
-        end
-
-        print reset,"\n"
+      if options[:remove_tags]
+        load_balancer_payload['removeTags'] = parse_metadata(options[:remove_tags])
       end
-          rescue RestClient::Exception => e
-      print_rest_exception(e, options)
-      exit 1
-    end
-  end
-
-  # JD: This is broken.. copied from tasks? should optionTypes exist?
-  def add(args)
-    lb_type_name = nil
-    options = {}
-    optparse = Morpheus::Cli::OptionParser.new do |opts|
-      opts.banner = subcommand_usage("[name] -t LB_TYPE")
-      opts.on( '-t', '--type LB_TYPE', "Load Balancer Type" ) do |val|
-        lb_type_name = val
+      if load_balancer_payload.empty?
+        raise_command_error "Specify at least one option to update.\n#{optparse}"
       end
-      build_common_options(opts, options, [:options, :json, :dry_run, :remote])
-    end
-    optparse.parse!(args)
-    lb_name = args[0]
-    if args.count < 1
-      puts optparse
-      exit 1
+      payload = {'virtualImage' => load_balancer_payload}
     end
-    if lb_type_name.nil?
-      puts optparse
-      exit 1
+    @load_balancers_interface.setopts(options)
+    if options[:dry_run]
+      print_dry_run @load_balancers_interface.dry.update(load_balancer['id'], payload)
+      return
     end
-    connect(options)
-    begin
-      lb_type = load_balancer_type_for_name_or_id(lb_type_name)
-      if lb_type.nil?
-        print_red_alert "LB Type #{lb_type_name} not found!"
-        exit 1
-      end
-
-      payload = {loadBalancer: {name: lb_name, type: {code: lb_type['code'], id: lb_type['id']}}}
-      # todo: The options available here are specific by type...
-      #input_options = Morpheus::Cli::OptionTypes.prompt(lb_type['optionTypes'],options[:options],@api_client, options[:params])
-      @load_balancers_interface.setopts(options)
-      if options[:dry_run]
-        print_dry_run @load_balancers_interface.dry.create(payload)
-        return
-      end      
-      json_response = @load_balancers_interface.create(payload)
-      if options[:json]
-        print JSON.pretty_generate(json_response)
-      else
-        print "\n", cyan, "LB #{json_response['loadBalancer']['name']} created successfully", reset, "\n\n"
-      end
-    rescue RestClient::Exception => e
-      print_rest_exception(e, options)
-      exit 1
+    json_response = @load_balancers_interface.update(load_balancer['id'], payload)
+    render_response(json_response, options, 'virtualImage') do
+      print_green_success "Updated virtual image #{load_balancer['name']}"
+      _get(load_balancer["id"], {}, options)
     end
+    return 0, nil
   end
 
   def remove(args)
@@ -323,7 +174,7 @@ class Morpheus::Cli::LoadBalancers
     end
     connect(options)
     begin
-      lb = find_lb_by_name_or_id(lb_name)
+      lb = find_load_balancer_by_name_or_id(lb_name)
       exit 1 if lb.nil?
       unless options[:yes] || Morpheus::Cli::OptionTypes.confirm("Are you sure you want to delete the load balancer #{lb['name']}?")
         exit
@@ -344,67 +195,51 @@ class Morpheus::Cli::LoadBalancers
       exit 1
     end
   end
+=end
 
-
-  private
-
-  def find_lb_by_name_or_id(val)
-    if val.to_s =~ /\A\d{1,}\Z/
-      return find_lb_by_id(val)
-    else
-      return find_lb_by_name(val)
-    end
+  # deprecated, to be removed in the future.
+  def types(args)
+    print_error yellow,"[DEPRECATED] The command `load-balancers types` is deprecated and replaced by `load-balancer-types list`.",reset,"\n"
+    my_terminal.execute("load-balancer-types list #{args.join(' ')}")
   end
 
-  def find_lb_by_id(id)
-    begin
-      json_response = @load_balancers_interface.get(id.to_i)
-      return json_response['loadBalancer']
-    rescue RestClient::Exception => e
-      if e.response && e.response.code == 404
-        print_red_alert "Load Balancer not found by id #{id}"
-      else
-        raise e
-      end
-    end
-  end
+  protected
 
-  def find_lb_by_name(name)
-    lbs = @load_balancers_interface.list({name: name.to_s})['loadBalancers']
-    if lbs.empty?
-      print_red_alert "Load Balancer not found by name #{name}"
-      return nil
-    elsif lbs.size > 1
-      print_red_alert "#{lbs.size} load balancers found by name #{name}"
-      #print_lbs_table(lbs, {color: red})
-      print reset,"\n\n"
-      return nil
-    else
-      return lbs[0]
-    end
+  def load_balancer_list_column_definitions()
+    {
+      "ID" => 'id',
+      "Name" => 'name',
+      "Type" => lambda {|it| it['type'] ? it['type']['name'] : '' },
+      "Cloud" => lambda {|it| it['cloud'] ? it['cloud']['name'] : '' },
+      "Host" => lambda {|it| it['host'] }
+    }
   end
 
-  def get_available_load_balancer_types(refresh=false)
-    if !@available_load_balancer_types || refresh
-      @available_load_balancer_types = @load_balancers_interface.load_balancer_types['loadBalancerTypes']
-    end
-    return @available_load_balancer_types
+  def load_balancer_column_definitions()
+    {
+      "ID" => 'id',
+      "Name" => 'name',
+      "Description" => 'description',
+      "Type" => lambda {|it| it['type'] ? it['type']['name'] : '' },
+      "Cloud" => lambda {|it| it['cloud'] ? it['cloud']['name'] : '' },
+      "Visibility" => 'visibility',
+      "IP" => 'ip',
+      "Host" => 'host',
+      "Port" => 'port',
+      "Username" => 'username',
+      # "SSL Enabled" => lambda {|it| format_boolean it['sslEnabled'] },
+      # "SSL Cert" => lambda {|it| it['sslCert'] ? it['sslCert']['name'] : '' },
+      # "SSL" => lambda {|it| it['sslEnabled'] ? "Yes (#{it['sslCert'] ? it['sslCert']['name'] : 'none'})" : "No" },
+      "Created" => lambda {|it| format_local_dt(it['dateCreated']) },
+      "Updated" => lambda {|it| format_local_dt(it['lastUpdated']) }
+    }
   end
 
-  def load_balancer_type_for_name_or_id(val)
-    if val.to_s =~ /\A\d{1,}\Z/
-      return load_balancer_type_for_id(val)
-    else
-      return load_balancer_type_for_name(val)
-    end
+  # overridden to work with name or code
+  def find_load_balancer_type_by_name_or_id(name)
+    load_balancer_type_for_name_or_id(name)
   end
 
-  def load_balancer_type_for_id(id)
-    return get_available_load_balancer_types().find { |z| z['id'].to_i == id.to_i}
-  end
 
-  def load_balancer_type_for_name(name)
-    return get_available_load_balancer_types().find { |z| z['name'].downcase == name.downcase || z['code'].downcase == name.downcase}
-  end
 
 end