moose-inventory 1.0.9 → 2.0

data/spec/lib/moose_inventory/operations/group_child_relations_spec.rb

@@ -0,0 +1,76 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/group_child_relations'
+
+RSpec.describe Moose::Inventory::Operations::GroupChildRelations do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'adds child groups and reports duplicate and auto-create events' do
+    parent = @db.models[:group].create(name: 'parent')
+    existing = @db.models[:group].create(name: 'existing')
+    parent.add_child(existing)
+
+    result = operation.add_children(
+      parent_group: parent,
+      parent_name: 'parent',
+      child_names: %w[existing created]
+    )
+
+    expect(result.warning_count).to eq(2)
+    expect(result.events.map(&:type)).to include(
+      :child_association_exists,
+      :child_group_missing
+    )
+    expect(parent.children_dataset[name: 'created']).not_to be_nil
+  end
+
+  it 'removes child groups and recursively deletes orphan groups when requested' do
+    parent = @db.models[:group].create(name: 'parent')
+    child = @db.models[:group].create(name: 'child')
+    grandchild = @db.models[:group].create(name: 'grandchild')
+    host = @db.models[:host].create(name: 'child-host')
+    child.add_host(host)
+    parent.add_child(child)
+    child.add_child(grandchild)
+
+    result = operation.remove_children(
+      parent_group: parent,
+      parent_name: 'parent',
+      child_names: %w[missing child],
+      delete_orphans: true
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :child_association_missing,
+      :recursively_delete_orphaned_group,
+      :destroying_group,
+      :adding_automatic_group_to_host
+    )
+    expect(@db.models[:group].find(name: 'child')).to be_nil
+    expect(@db.models[:group].find(name: 'grandchild')).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+end

data/spec/lib/moose_inventory/operations/remove_associations_spec.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/remove_associations'
+
+RSpec.describe Moose::Inventory::Operations::RemoveAssociations do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'removes groups from a host and reports missing associations and ungrouped reattachment' do
+    host = @db.models[:host].create(name: 'host1')
+    group = @db.models[:group].create(name: 'group1')
+    other = @db.models[:group].create(name: 'group2')
+    host.add_group(group)
+    host.add_group(other)
+
+    result = operation.host_from_groups(
+      host: host,
+      host_name: 'host1',
+      group_names: %w[group1 missing group2]
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :host_group_association_missing,
+      :adding_automatic_group
+    )
+    expect(host.groups_dataset[name: 'group1']).to be_nil
+    expect(host.groups_dataset[name: 'group2']).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+
+  it 'removes hosts from a group and reports missing associations and ungrouped reattachment' do
+    group = @db.models[:group].create(name: 'group1')
+    host1 = @db.models[:host].create(name: 'host1')
+    host2 = @db.models[:host].create(name: 'host2')
+    extra = @db.models[:group].create(name: 'extra')
+    host2.add_group(extra)
+    group.add_host(host1)
+    group.add_host(host2)
+
+    result = operation.group_from_hosts(
+      group: group,
+      group_name: 'group1',
+      host_names: %w[host1 missing host2]
+    )
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(
+      :group_host_association_missing,
+      :adding_automatic_group
+    )
+    expect(group.hosts_dataset[name: 'host1']).to be_nil
+    expect(group.hosts_dataset[name: 'host2']).to be_nil
+    expect(host1.groups_dataset[name: 'ungrouped']).not_to be_nil
+    expect(host2.groups_dataset[name: 'ungrouped']).to be_nil
+  end
+end

data/spec/lib/moose_inventory/operations/remove_groups_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'inventory_context'
+require 'operations/remove_groups'
+
+RSpec.describe Moose::Inventory::Operations::RemoveGroups do
+  before(:all) do
+    @mockargs = [
+      '--config', File.join(spec_root, 'config/config.yml'),
+      '--format', 'yaml',
+      '--env', 'test'
+    ]
+
+    Moose::Inventory::Config.init(@mockargs)
+    @db = Moose::Inventory::DB
+    @db.init if @db.db.nil?
+  end
+
+  before(:each) do
+    @db.reset
+  end
+
+  def operation
+    described_class.new(
+      context: Moose::Inventory::InventoryContext.new(db: @db)
+    )
+  end
+
+  it 'reports missing groups as warnings' do
+    result = operation.call(names: ['missing'], recursive: false)
+
+    expect(result.warning_count).to eq(1)
+    expect(result.events.map(&:type)).to include(:group_missing)
+  end
+
+  it 'removes groups and recursively cleans orphaned children when requested' do
+    parent = @db.models[:group].create(name: 'parent')
+    child = @db.models[:group].create(name: 'child')
+    host = @db.models[:host].create(name: 'child-host')
+    child.add_host(host)
+    parent.add_child(child)
+
+    result = operation.call(names: ['parent'], recursive: true)
+
+    expect(result.warning_count).to eq(0)
+    expect(result.events.map(&:type)).to include(
+      :removing_child_association,
+      :recursively_delete_orphaned_group,
+      :adding_automatic_group_to_host,
+      :destroying_group
+    )
+    expect(@db.models[:group].find(name: 'parent')).to be_nil
+    expect(@db.models[:group].find(name: 'child')).to be_nil
+    expect(host.groups_dataset[name: 'ungrouped']).not_to be_nil
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: moose-inventory
 version: !ruby/object:Gem::Version
-  version: 1.0.9
+  version: '2.0'
 platform: ruby
 authors:
 - Russell Davies
@@ -163,6 +163,46 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: bundler-audit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.9'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1'
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.10'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -197,6 +237,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.72'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.72'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -220,7 +280,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/workflows/ci.yml"
+- ".github/workflows/release.yml"
 - ".gitignore"
+- ".gitleaks.toml"
+- ".rubocop.yml"
 - BACKLOG.md
 - Gemfile
 - Gemfile.lock
@@ -231,6 +294,8 @@ files:
 - docs/release/publishing.md
 - docs/release/release-readiness.md
 - docs/security-audit-2026-05-21.md
+- docs/security-audit-2026-05-26-rerun.md
+- docs/security-audit-2026-05-26.md
 - lib/moose_inventory.rb
 - lib/moose_inventory/cli/application.rb
 - lib/moose_inventory/cli/formatter.rb
@@ -246,6 +311,7 @@ files:
 - lib/moose_inventory/cli/group_rmchild.rb
 - lib/moose_inventory/cli/group_rmhost.rb
 - lib/moose_inventory/cli/group_rmvar.rb
+- lib/moose_inventory/cli/helpers.rb
 - lib/moose_inventory/cli/host.rb
 - lib/moose_inventory/cli/host_add.rb
 - lib/moose_inventory/cli/host_addgroup.rb
@@ -260,11 +326,22 @@ files:
 - lib/moose_inventory/db/db.rb
 - lib/moose_inventory/db/exceptions.rb
 - lib/moose_inventory/db/models.rb
+- lib/moose_inventory/inventory_context.rb
+- lib/moose_inventory/operations/add_associations.rb
+- lib/moose_inventory/operations/add_groups.rb
+- lib/moose_inventory/operations/add_hosts.rb
+- lib/moose_inventory/operations/group_child_relations.rb
+- lib/moose_inventory/operations/group_cleanup.rb
+- lib/moose_inventory/operations/remove_associations.rb
+- lib/moose_inventory/operations/remove_groups.rb
 - lib/moose_inventory/version.rb
 - moose-inventory.gemspec
 - scripts/check.sh
 - scripts/ci/check_permissions.sh
+- scripts/ci/check_rubocop.sh
+- scripts/ci/check_secrets.sh
 - scripts/ci/check_security.sh
+- scripts/ci/install_security_tools.sh
 - scripts/ci/package_sanity.sh
 - scripts/files.rb
 - scripts/install_dependencies.sh
@@ -299,6 +376,12 @@ files:
 - spec/lib/moose_inventory/config/config_spec.rb
 - spec/lib/moose_inventory/db/db_spec.rb
 - spec/lib/moose_inventory/db/models_spec.rb
+- spec/lib/moose_inventory/operations/add_associations_spec.rb
+- spec/lib/moose_inventory/operations/add_groups_spec.rb
+- spec/lib/moose_inventory/operations/add_hosts_spec.rb
+- spec/lib/moose_inventory/operations/group_child_relations_spec.rb
+- spec/lib/moose_inventory/operations/remove_associations_spec.rb
+- spec/lib/moose_inventory/operations/remove_groups_spec.rb
 - spec/shared/shared_config_setup.rb
 - spec/spec_helper.rb
 homepage: https://github.com/RusDavies/moose-inventory
@@ -352,5 +435,11 @@ test_files:
 - spec/lib/moose_inventory/config/config_spec.rb
 - spec/lib/moose_inventory/db/db_spec.rb
 - spec/lib/moose_inventory/db/models_spec.rb
+- spec/lib/moose_inventory/operations/add_associations_spec.rb
+- spec/lib/moose_inventory/operations/add_groups_spec.rb
+- spec/lib/moose_inventory/operations/add_hosts_spec.rb
+- spec/lib/moose_inventory/operations/group_child_relations_spec.rb
+- spec/lib/moose_inventory/operations/remove_associations_spec.rb
+- spec/lib/moose_inventory/operations/remove_groups_spec.rb
 - spec/shared/shared_config_setup.rb
 - spec/spec_helper.rb