moose-inventory 1.0.8 → 1.0.9

data/spec/lib/moose_inventory/cli/group_addchild_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -19,7 +19,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
 
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
@@ -49,66 +49,65 @@ RSpec.describe Moose::Inventory::Cli::Group do
         @app.start(%w(group addchild))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
-    
+
     #------------------------
     it 'ungrouped ... should abort with an error' do
-      parent_name = "ungrouped"
-      child_name = "fake"
-      
-      actual = runner  do
+      parent_name = 'ungrouped'
+      child_name = 'fake'
+
+      actual = runner do
         @app.start(%W(group addchild #{parent_name} #{child_name}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-      
+
       ############################
-      # Should work the other way round too, when the child in the ungrouped item      
-      parent_name = "fake"
-      child_name = "ungrouped"
-      
-      actual = runner  do
+      # Should work the other way round too, when the child in the ungrouped item
+      parent_name = 'fake'
+      child_name = 'ungrouped'
+
+      actual = runner do
         @app.start(%W(group addchild #{parent_name} #{child_name}))
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-      
-    end    
+    end
 
     #------------------------
     it 'GROUP CHILDGROUP  ... should abort if GROUP does not exist' do
       # TODO: Why don't we just create GROUP?  Likewise for all similar functions?
-      
+
       pname = 'parent_group'
       cname = 'child group'
-      
+
       actual = runner do
         @app.start(%W(group addchild #{pname} #{cname}))
       end
 
-      #@console.out(actual, 'y')
+      # @console.out(actual, 'y')
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Associate parent group '#{pname}' with child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "ERROR: The group '#{pname}' does not exist.\n"\
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
@@ -121,12 +120,12 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       runner { @app.start(%W(group add #{pname} #{cname})) }
 
-      actual = runner { @app.start(%W(group addchild #{pname} #{cname} )) }
+      actual = runner { @app.start(%W(group addchild #{pname} #{cname})) }
 
-      #@console.out(actual, 'y')
-       
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual, 'y')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate parent group '#{pname}' with child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"\
         "    - OK\n"\
@@ -138,26 +137,26 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       # We should have the correct group associations
       pgroup = @db.models[:group].find(name: pname)
-      cgroups = pgroup.children_dataset 
+      cgroups = pgroup.children_dataset
       expect(cgroups.count).to eq(1)
       expect(cgroups[name: cname]).not_to be_nil
     end
-    
+
     #------------------------
     it 'GROUP CHILDGROUP... should associate GROUP with a CHILDGROUP '\
       'creating it if necessary' do
-      #  
+      #
       pname = 'parent_group'
-      cname = 'child_group' 
-  
+      cname = 'child_group'
+
       runner { @app.start(%W(group add #{pname})) } # <- don't pre-create the child
-  
-      actual = runner { @app.start(%W(group addchild #{pname} #{cname} )) }
-  
-      #@console.out(actual, 'y')
-       
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+
+      actual = runner { @app.start(%W(group addchild #{pname} #{cname})) }
+
+      # @console.out(actual, 'y')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate parent group '#{pname}' with child group(s) '#{cname}':\n"\
         "  - retrieve group '#{pname}'...\n"\
         "    - OK\n"\
@@ -167,15 +166,14 @@ RSpec.describe Moose::Inventory::Cli::Group do
         "    - OK\n"\
         "  - all OK\n"\
         "Succeeded, with warnings.\n"
-      desired[:STDERR] = "WARNING: Group '#{cname}' does not exist and will be created.\n" 
+      desired[:STDERR] = "WARNING: Group '#{cname}' does not exist and will be created.\n"
       expected(actual, desired)
-  
+
       # We should have the correct group associations
       pgroup = @db.models[:group].find(name: pname)
-      cgroups = pgroup.children_dataset 
+      cgroups = pgroup.children_dataset
       expect(cgroups.count).to eq(1)
       expect(cgroups[name: cname]).not_to be_nil
     end
-    
   end
 end

data/spec/lib/moose_inventory/cli/group_addhost_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -19,7 +19,7 @@ RSpec.describe Moose::Inventory::Cli::Group do
     end
 
     @console = Moose::Inventory::Cli::Formatter
-    
+
     @config = Moose::Inventory::Config
     @config.init(@mockargs)
 
@@ -45,35 +45,34 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
     #------------------------
     it 'addhost <missing args> ... should abort with an error' do
-      actual = runner  do
+      actual = runner do
         @app.start(%w(group addhost)) # <- no group given
       end
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
 
     #------------------------
     it 'GROUP HOST ... should abort if the group does not exist' do
-      
       host_name = 'example'
       group_name = 'not-a-group'
-      
+
       actual = runner do
         @app.start(%W(group addhost #{group_name} #{host_name}))
       end
 
-      #@console.out(actual, 'y')
+      # @console.out(actual, 'y')
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "ERROR: The group '#{group_name}' does not exist.\n"\
         "An error occurred during a transaction, any changes have been rolled back.\n"
       expected(actual, desired)
@@ -83,18 +82,18 @@ RSpec.describe Moose::Inventory::Cli::Group do
     it 'GROUP HOST... should add the host to an existing group' do
       # 1. Should add the host to the group
       # 2. Should remove the host from the 'ungrouped' automatic group
-      
+
       host_name = 'test1'
       group_name = 'testgroup1'
 
       runner { @app.start(%W(host add #{host_name})) }
       @db.models[:group].create(name: group_name)
 
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
 
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -109,28 +108,27 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       # We should have the correct group associations
       host = @db.models[:host].find(name: host_name)
-      groups = host.groups_dataset 
+      groups = host.groups_dataset
       expect(groups.count).to eq(1)
       expect(groups[name: group_name]).not_to be_nil
-      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
     end
 
     #------------------------
     it '\'ungrouped\' HOST... should abort with an error' do
-      
       host_name = 'test1'
       group_name = 'ungrouped'
-    
+
       runner { @app.start(%W(host add #{host_name})) }
-    
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-    
-      desired = { aborted: true}
-      desired[:STDERR] = 
+
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      desired = { aborted: true }
+      desired[:STDERR] =
         "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-    end 
-    
+    end
+
     #------------------------
     it 'GROUP HOST ... should add the host to an group, creating the host if necessary' do
       host_name = 'test1'
@@ -140,11 +138,11 @@ RSpec.describe Moose::Inventory::Cli::Group do
 
       # DON'T CREATE THE HOST! That's the point of the test. ;o)
 
-      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
 
       # Check output
       desired = {}
-      desired[:STDOUT] = 
+      desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"\
@@ -155,54 +153,54 @@ RSpec.describe Moose::Inventory::Cli::Group do
         "  - all OK\n"\
         "Succeeded, with warnings.\n"
       desired[:STDERR] =
-        "WARNING: Host '#{host_name}' does not exist and will be created.\n" 
+        "WARNING: Host '#{host_name}' does not exist and will be created.\n"
       expected(actual, desired)
 
-      # Check db          
+      # Check db
       group = @db.models[:group].find(name: group_name)
       hosts = group.hosts_dataset
       expect(hosts.count).to eq(1)
       expect(hosts[name: host_name]).not_to be_nil
     end
-    
+
     #------------------------
     it 'GROUP HOST... should skip associations that already '\
        ' exist, but raise a warning.' do
-       host_name = 'test1'
-       group_name = 'testgroup1'
-    
-       runner { @app.start(%W(group add #{group_name})) }
-       runner { @app.start(%W(host add #{host_name})) }
-    
-       # Run once to make the initial association
-       runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-         
-       # Run again, to prove expected result
-       actual = runner { @app.start(%W(group addhost #{group_name} #{host_name} )) }
-
-       #@console.out(actual,'y')
-           
-       # Check output
-       desired = {}
-       desired[:STDOUT] = 
-         "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
-         "  - retrieve group \'#{group_name}\'...\n"\
-         "    - OK\n"\
-         "  - add association {group:#{group_name} <-> host:#{host_name}}...\n"\
-         "    - already exists, skipping.\n"\
-         "    - OK\n"\
-         "  - all OK\n"\
-         "Succeeded, with warnings.\n"
-       desired[:STDERR] = 
-         "WARNING: Association {group:#{group_name} <-> host:#{host_name}} already exists, skipping.\n"
-       expected(actual, desired)
-    
-       # Check db          
-       group = @db.models[:group].find(name: group_name)
-       hosts = group.hosts_dataset
-       expect(hosts.count).to eq(1)
-       expect(hosts[name: host_name]).not_to be_nil
-     end    
+      host_name = 'test1'
+      group_name = 'testgroup1'
+
+      runner { @app.start(%W(group add #{group_name})) }
+      runner { @app.start(%W(host add #{host_name})) }
+
+      # Run once to make the initial association
+      runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      # Run again, to prove expected result
+      actual = runner { @app.start(%W(group addhost #{group_name} #{host_name})) }
+
+      # @console.out(actual,'y')
+
+      # Check output
+      desired = {}
+      desired[:STDOUT] =
+        "Associate group '#{group_name}' with host(s) '#{host_name}':\n"\
+        "  - retrieve group \'#{group_name}\'...\n"\
+        "    - OK\n"\
+        "  - add association {group:#{group_name} <-> host:#{host_name}}...\n"\
+        "    - already exists, skipping.\n"\
+        "    - OK\n"\
+        "  - all OK\n"\
+        "Succeeded, with warnings.\n"
+      desired[:STDERR] =
+        "WARNING: Association {group:#{group_name} <-> host:#{host_name}} already exists, skipping.\n"
+      expected(actual, desired)
+
+      # Check db
+      group = @db.models[:group].find(name: group_name)
+      hosts = group.hosts_dataset
+      expect(hosts.count).to eq(1)
+      expect(hosts[name: host_name]).not_to be_nil
+    end
 
     #------------------------
     it 'GROUP HOST1 HOST2 ... should associate the group with '\
@@ -214,32 +212,31 @@ RSpec.describe Moose::Inventory::Cli::Group do
       host_names.each do |host|
         runner { @app.start(%W(host add #{host})) }
       end
-      
+
       actual = runner { @app.start(%W(group addhost #{group_name}) + host_names) }
 
-      #@console.out(actual, 'y')
-      
+      # @console.out(actual, 'y')
+
       # Check output
-      desired = { aborted: false, STDERR: ''}
+      desired = { aborted: false, STDERR: '' }
       desired[:STDOUT] =
         "Associate group '#{group_name}' with host(s) '#{host_names.join(',')}':\n"\
         "  - retrieve group '#{group_name}'...\n"\
         "    - OK\n"
       host_names.each do |host|
-        desired[:STDOUT] = desired[:STDOUT] + 
-          "  - add association {group:#{group_name} <-> host:#{host}}...\n"\
-          "    - OK\n"\
-          "  - remove automatic association {group:ungrouped <-> host:#{host}}...\n"\
-          "    - OK\n"\
-
-        #desired[:STDERR] = desired[:STDERR] +  
-        #  "WARNING: Host '#{host}' does not exist and will be created.\n" 
+        desired[:STDOUT] = desired[:STDOUT] +
+                           "  - add association {group:#{group_name} <-> host:#{host}}...\n"\
+                           "    - OK\n"\
+                           "  - remove automatic association {group:ungrouped <-> host:#{host}}...\n"\
+                           "    - OK\n"\
+
+        # desired[:STDERR] = desired[:STDERR] +
+        #  "WARNING: Host '#{host}' does not exist and will be created.\n"
       end
-      desired[:STDOUT]  = desired[:STDOUT]  + 
-        "  - all OK\n"\
-        "Succeeded.\n"
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "  - all OK\n"\
+                         "Succeeded.\n"
       expected(actual, desired)
-      
 
       # We should have group associations
       group = @db.models[:group].find(name: group_name)