moose-inventory 1.0.7 → 1.0.9

data/spec/lib/moose_inventory/cli/host_addgroup_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -42,12 +42,12 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
     #------------------------
     it 'host addgroup <missing args> ... should abort with an error' do
-      actual = runner  do
+      actual = runner do
         @app.start(%w(host addgroup)) # <- no group given
       end
 
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
@@ -59,11 +59,11 @@ RSpec.describe Moose::Inventory::Cli::Host do
       end
 
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Associate host 'not-a-host' with groups 'example':\n"\
         "  - Retrieve host 'not-a-host'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "An error occurred during a transaction, any changes have been rolled back.\n"\
         "ERROR: The host 'not-a-host' was not found in the database.\n"
       expected(actual, desired)
@@ -73,18 +73,18 @@ RSpec.describe Moose::Inventory::Cli::Host do
     it 'host addgroup HOST GROUP ... should add the host to an existing group' do
       # 1. Should add the host to the group
       # 2. Should remove the host from the 'ungrouped' automatic group
-      
+
       name = 'test1'
       group_name = 'testgroup1'
 
       runner { @app.start(%W(host add #{name})) }
       @db.models[:group].create(name: group_name)
 
-      actual = runner { @app.start(%W(host addgroup #{name} #{group_name} )) }
+      actual = runner { @app.start(%W(host addgroup #{name} #{group_name})) }
 
       # rubocop:disable Metrics/LineLength
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate host '#{name}' with groups '#{group_name}':\n"\
         "  - Retrieve host '#{name}'...\n"\
         "    - OK\n"\
@@ -102,25 +102,24 @@ RSpec.describe Moose::Inventory::Cli::Host do
       groups = host.groups_dataset
       expect(groups.count).to eq(1)
       expect(groups[name: group_name]).not_to be_nil
-      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
     end
 
     #------------------------
     it 'HOST \'ungrouped\' ... should abort with an error' do
-      
       name = 'test1'
       group_name = 'ungrouped'
-    
+
       runner { @app.start(%W(host add #{name})) }
-    
-      actual = runner { @app.start(%W(host addgroup #{name} #{group_name} )) }
-    
-      desired = { aborted: true}
-      desired[:STDERR] = 
+
+      actual = runner { @app.start(%W(host addgroup #{name} #{group_name})) }
+
+      desired = { aborted: true }
+      desired[:STDERR] =
         "ERROR: Cannot manually manipulate the automatic group 'ungrouped'.\n"
       expected(actual, desired)
-    end 
-    
+    end
+
     #------------------------
     it 'HOST GROUP ... should add the host to an group, creating the group if necessary' do
       name = 'test1'
@@ -130,11 +129,11 @@ RSpec.describe Moose::Inventory::Cli::Host do
 
       # DON'T CREATE THE GROUP! That's the point of the test. ;o)
 
-      actual = runner { @app.start(%W(host addgroup #{name} #{group_name} )) }
+      actual = runner { @app.start(%W(host addgroup #{name} #{group_name})) }
 
       # Check output
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Associate host '#{name}' with groups '#{group_name}':\n"\
         "  - Retrieve host '#{name}'...\n"\
         "    - OK\n"\
@@ -147,56 +146,56 @@ RSpec.describe Moose::Inventory::Cli::Host do
         "  - All OK\n"\
         "Succeeded\n"
       desired[:STDERR] =
-        "WARNING: Group '#{group_name}' does not exist and will be created." 
+        "WARNING: Group '#{group_name}' does not exist and will be created."
       expected(actual, desired)
 
-      # Check db          
+      # Check db
       host = @db.models[:host].find(name: name)
       groups = host.groups_dataset
       expect(groups.count).to eq(1)
       expect(groups[name: group_name]).not_to be_nil
-      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
     end
-    
+
     #------------------------
-     it 'HOST GROUP ... should skip associations that already '\
-       ' exist, but raise a warning.' do
-       name = 'test1'
-       group_name = 'testgroup1'
-    
-       runner { @app.start(%W(host add #{name})) }
-    
-       # DON'T CREATE THE GROUP! That's the point of the test. ;o)
-    
-       # Run once to make the association
-       runner { @app.start(%W(host addgroup #{name} #{group_name} )) }
-         
-       # Run again, to prove expected result
-       actual = runner { @app.start(%W(host addgroup #{name} #{group_name} )) }
-    
-       # Check output
-       # Note: This time, we don't expect to see any messages about 
-       # dissociation from 'ungrouped'
-       desired = { aborted: false}
-       desired[:STDOUT] = 
-         "Associate host '#{name}' with groups '#{group_name}':\n"\
-         "  - Retrieve host \'#{name}\'...\n"\
-         "    - OK\n"\
-         "  - Add association {host:#{name} <-> group:#{group_name}}...\n"\
-         "    - Already exists, skipping.\n"\
-         "    - OK\n"\
-         "  - All OK\n"\
-         "Succeeded\n"
-       desired[:STDERR] = "WARNING: Association {host:#{name} <-> group:#{group_name}} already exists, skipping."
-       expected(actual, desired)
-    
-       # Check db          
-       host = @db.models[:host].find(name: name)
-       groups = host.groups_dataset
-       expect(groups.count).to eq(1)
-       expect(groups[name: group_name]).not_to be_nil
-       expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!      
-     end    
+    it 'HOST GROUP ... should skip associations that already '\
+      ' exist, but raise a warning.' do
+      name = 'test1'
+      group_name = 'testgroup1'
+
+      runner { @app.start(%W(host add #{name})) }
+
+      # DON'T CREATE THE GROUP! That's the point of the test. ;o)
+
+      # Run once to make the association
+      runner { @app.start(%W(host addgroup #{name} #{group_name})) }
+
+      # Run again, to prove expected result
+      actual = runner { @app.start(%W(host addgroup #{name} #{group_name})) }
+
+      # Check output
+      # Note: This time, we don't expect to see any messages about
+      # dissociation from 'ungrouped'
+      desired = { aborted: false }
+      desired[:STDOUT] =
+        "Associate host '#{name}' with groups '#{group_name}':\n"\
+        "  - Retrieve host \'#{name}\'...\n"\
+        "    - OK\n"\
+        "  - Add association {host:#{name} <-> group:#{group_name}}...\n"\
+        "    - Already exists, skipping.\n"\
+        "    - OK\n"\
+        "  - All OK\n"\
+        "Succeeded\n"
+      desired[:STDERR] = "WARNING: Association {host:#{name} <-> group:#{group_name}} already exists, skipping."
+      expected(actual, desired)
+
+      # Check db
+      host = @db.models[:host].find(name: name)
+      groups = host.groups_dataset
+      expect(groups.count).to eq(1)
+      expect(groups[name: group_name]).not_to be_nil
+      expect(groups[name: 'ungrouped']).to be_nil # redundant, but for clarity!
+    end
 
     #------------------------
     it 'host addgroup GROUP1 GROUP1 ... should add the host to'\
@@ -209,28 +208,27 @@ RSpec.describe Moose::Inventory::Cli::Host do
       actual = runner { @app.start(%W(host addgroup #{name}) + group_names) }
 
       # Check output
-      desired = { aborted: false, STDERR: ''}
+      desired = { aborted: false, STDERR: '' }
       desired[:STDOUT] =
         "Associate host '#{name}' with groups '#{group_names.join(',')}':\n"\
         "  - Retrieve host '#{name}'...\n"\
         "    - OK\n"
       group_names.each do |group|
-        desired[:STDOUT] = desired[:STDOUT] + 
-          "  - Add association {host:#{name} <-> group:#{group}}...\n"\
-          "    - Group does not exist, creating now...\n"\
-          "      - OK\n"\
-          "    - OK\n"
-
-        desired[:STDERR] = desired[:STDERR] +  
-          "WARNING: Group '#{group}' does not exist and will be created." 
+        desired[:STDOUT] = desired[:STDOUT] +
+                           "  - Add association {host:#{name} <-> group:#{group}}...\n"\
+                           "    - Group does not exist, creating now...\n"\
+                           "      - OK\n"\
+                           "    - OK\n"
+
+        desired[:STDERR] = desired[:STDERR] +
+                           "WARNING: Group '#{group}' does not exist and will be created."
       end
-      desired[:STDOUT]  = desired[:STDOUT]  + 
-        "  - Remove automatic association {host:#{name} <-> group:ungrouped}...\n"\
-        "    - OK\n"\
-        "  - All OK\n"\
-        "Succeeded\n"
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "  - Remove automatic association {host:#{name} <-> group:ungrouped}...\n"\
+                         "    - OK\n"\
+                         "  - All OK\n"\
+                         "Succeeded\n"
       expected(actual, desired)
-      
 
       # We should have group associations
       host = @db.models[:host].find(name: name)

data/spec/lib/moose_inventory/cli/host_addvar_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
     @mockarg_parts = {
       config:  File.join(spec_root, 'config/config.yml'),
       format:  'yaml',
-      env:     'test'
+      env:     'test',
     }
 
     @mockargs = []
@@ -40,95 +40,95 @@ RSpec.describe Moose::Inventory::Cli::Host do
       result = @host.instance_methods(false).include?(:addvar)
       expect(result).to eq(true)
     end
-     
+
     #-----------------
     it 'host addvar <missing args> ... should abort with an error' do
-      actual = runner  do
+      actual = runner do
         @app.start(%w(host addvar)) # <- no group given
       end
 
       # Check output
-      desired = { aborted: true}
+      desired = { aborted: true }
       desired[:STDERR] = "ERROR: Wrong number of arguments, 0 for 2 or more.\n"
       expected(actual, desired)
     end
 
     #------------------------
     it 'host addvar HOST key=value ... should abort if the host does not exist' do
-      host_name ='not-a-host'
-      host_var = "foo=bar"
-      
+      host_name = 'not-a-host'
+      host_var = 'foo=bar'
+
       actual = runner do
         @app.start(%W(host addvar #{host_name} #{host_var}))
       end
 
       # Check output
-      desired = { aborted: true}
-      desired[:STDOUT] = 
+      desired = { aborted: true }
+      desired[:STDOUT] =
         "Add variables '#{host_var}' to host '#{host_name}':\n"\
         "  - retrieve host '#{host_name}'...\n"
-      desired[:STDERR] = 
+      desired[:STDERR] =
         "An error occurred during a transaction, any changes have been rolled back.\n"\
         "ERROR: The host '#{host_name}' does not exist.\n"
       expected(actual, desired)
     end
 
     #------------------------
-     it 'host addvar HOST <malformed> ... should abort with an error' do
-       # 1. Should add the var to the db
-       # 2. Should associate the host with the var
-       
-       host_name = 'test1'
-       @db.models[:host].create(name: host_name)
- 
-       var  = {name: 'var1', value: "testval"}
-       cases = %W(
-         testvar 
-         testvar= 
-         =testval 
-         testvar=testval=
-         =testvar=testval
-         testvar=testval=extra
-       )      
-     
-       cases.each do |args| 
-         actual = runner do
-           @app.start(%W(host addvar #{host_name} #{args} ))
-         end
-         #@console.out(actual,'p')
-   
-         desired = { aborted: true}
-         desired[:STDOUT] = 
-         "Add variables '#{args}' to host '#{host_name}':\n"\
-         "  - retrieve host '#{host_name}'...\n"\
-         "    - OK\n"\
-         "  - add variable '#{args}'...\n"
-         
-         desired[:STDERR] = 
-           "An error occurred during a transaction, any changes have been rolled back.\n"\
-           "ERROR: Incorrect format in '{#{args}}'. Expected 'key=value'.\n"
-           
-         expected(actual, desired)
-       end
-     end
-    
+    it 'host addvar HOST <malformed> ... should abort with an error' do
+      # 1. Should add the var to the db
+      # 2. Should associate the host with the var
+
+      host_name = 'test1'
+      @db.models[:host].create(name: host_name)
+
+      var = { name: 'var1', value: 'testval' }
+      cases = %w(
+        testvar
+        testvar=
+        =testval
+        testvar=testval=
+        =testvar=testval
+        testvar=testval=extra
+      )
+
+      cases.each do |args|
+        actual = runner do
+          @app.start(%W(host addvar #{host_name} #{args}))
+        end
+        # @console.out(actual,'p')
+
+        desired = { aborted: true }
+        desired[:STDOUT] =
+          "Add variables '#{args}' to host '#{host_name}':\n"\
+          "  - retrieve host '#{host_name}'...\n"\
+          "    - OK\n"\
+          "  - add variable '#{args}'...\n"
+
+        desired[:STDERR] =
+          "An error occurred during a transaction, any changes have been rolled back.\n"\
+          "ERROR: Incorrect format in '{#{args}}'. Expected 'key=value'.\n"
+
+        expected(actual, desired)
+      end
+    end
+
     #------------------------
     fit 'host addvar HOST key=value ... should associate the host with the key/value pair' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       host_name = 'test1'
-      var  = {name: 'var1', value: "testval"}
+      var = { name: 'var1', value: 'testval' }
 
       @db.models[:host].create(name: host_name)
-      
+
       actual = runner do
-        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]} ))
+        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]}))
       end
-      #@console.out(actual,'p')
-      
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual,'p')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{var[:name]}=#{var[:value]}' to host '#{host_name}':\n"\
         "  - retrieve host '#{host_name}'...\n"\
         "    - OK\n"\
@@ -150,19 +150,19 @@ RSpec.describe Moose::Inventory::Cli::Host do
     fit 'host addvar HOST "my val"="hello world" ... should associate the host with the key/value pair' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       host_name = 'test1'
-      var  = {name: 'my val', value: "hello world"}
-    
+      var = { name: 'my val', value: 'hello world' }
+
       @db.models[:host].create(name: host_name)
-      
+
       actual = runner do
-        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]} ))
+        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]}))
       end
-      #@console.out(actual,'p')
-      
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual,'p')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{var[:name]}=#{var[:value]}' to host '#{host_name}':\n"\
         "  - retrieve host '#{host_name}'...\n"\
         "    - OK\n"\
@@ -171,7 +171,7 @@ RSpec.describe Moose::Inventory::Cli::Host do
         "  - all OK\n"\
         "Succeeded.\n"
       expected(actual, desired)
-    
+
       # We should have the correct hostvar associations
       host = @db.models[:host].find(name: host_name)
       hostvars = host.hostvars_dataset
@@ -179,70 +179,70 @@ RSpec.describe Moose::Inventory::Cli::Host do
       expect(hostvars[name: var[:name]]).not_to be_nil
       expect(hostvars[name: var[:name]][:value]).to eq(var[:value])
     end
-    
-  #------------------------
-  it 'host addvar HOST key1=value1 key2=value2 ... should associate the host with multiple key/value pairs' do
-    # 1. Should add the var to the db
-    # 2. Should associate the host with the var
-    
-    host_name = 'test1'
-    varsarray  = [
-      {name: 'var1', value: "val1"},
-      {name: 'var2', value: "val2"}
-    ]
-  
-    vars = []
-    varsarray.each do |var|
-      vars << "#{var[:name]}=#{var[:value]}"
-    end
-      
-    @db.models[:host].create(name: host_name)
-    
-    actual = runner do
-      @app.start(%W(host addvar #{host_name}) + vars )
-    end
-    #@console.out(actual,'p')
-    
-    desired = { aborted: false}
-    desired[:STDOUT] = 
-      "Add variables '#{vars.join(',')}' to host '#{host_name}':\n"\
-      "  - retrieve host '#{host_name}'...\n"\
-      "    - OK\n"
-    vars.each do |var|
-      desired[:STDOUT] =  desired[:STDOUT] + 
-        "  - add variable '#{var}'...\n"\
+
+    #------------------------
+    it 'host addvar HOST key1=value1 key2=value2 ... should associate the host with multiple key/value pairs' do
+      # 1. Should add the var to the db
+      # 2. Should associate the host with the var
+
+      host_name = 'test1'
+      varsarray = [
+        { name: 'var1', value: 'val1' },
+        { name: 'var2', value: 'val2' },
+      ]
+
+      vars = []
+      varsarray.each do |var|
+        vars << "#{var[:name]}=#{var[:value]}"
+      end
+
+      @db.models[:host].create(name: host_name)
+
+      actual = runner do
+        @app.start(%W(host addvar #{host_name}) + vars)
+      end
+      # @console.out(actual,'p')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
+        "Add variables '#{vars.join(',')}' to host '#{host_name}':\n"\
+        "  - retrieve host '#{host_name}'...\n"\
         "    - OK\n"
+      vars.each do |var|
+        desired[:STDOUT] =  desired[:STDOUT] +
+                            "  - add variable '#{var}'...\n"\
+                            "    - OK\n"
+      end
+      desired[:STDOUT] = desired[:STDOUT] +
+                         "  - all OK\n"\
+                         "Succeeded.\n"
+      expected(actual, desired)
+
+      # We should have the correct hostvar associations
+      host = @db.models[:host].find(name: host_name)
+      hostvars = host.hostvars_dataset
+      expect(hostvars.count).to eq(vars.length)
     end
-    desired[:STDOUT] =  desired[:STDOUT] + 
-      "  - all OK\n"\
-      "Succeeded.\n"
-    expected(actual, desired)
-  
-    # We should have the correct hostvar associations
-    host = @db.models[:host].find(name: host_name)
-    hostvars = host.hostvars_dataset
-    expect(hostvars.count).to eq(vars.length)
-  end    
 
     #------------------------
     it 'host addvar HOST key=value ... should update an already existing association' do
       # 1. Should add the var to the db
       # 2. Should associate the host with the var
-      
+
       host_name = 'test1'
-      var  = {name: 'var1', value: "testval"}
-    
+      var = { name: 'var1', value: 'testval' }
+
       @db.models[:host].create(name: host_name)
-      runner { @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]} )) }
-    
-      var[:value]  = "newtestval"
+      runner { @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]})) }
+
+      var[:value] = 'newtestval'
       actual = runner do
-        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]} ))
+        @app.start(%W(host addvar #{host_name} #{var[:name]}=#{var[:value]}))
       end
-      #@console.out(actual,'p')
-      
-      desired = { aborted: false}
-      desired[:STDOUT] = 
+      # @console.out(actual,'p')
+
+      desired = { aborted: false }
+      desired[:STDOUT] =
         "Add variables '#{var[:name]}=#{var[:value]}' to host '#{host_name}':\n"\
         "  - retrieve host '#{host_name}'...\n"\
         "    - OK\n"\
@@ -252,16 +252,16 @@ RSpec.describe Moose::Inventory::Cli::Host do
         "  - all OK\n"\
         "Succeeded.\n"
       expected(actual, desired)
-    
+
       # We should have the correct hostvar associations
       host = @db.models[:host].find(name: host_name)
       hostvars = host.hostvars_dataset
       expect(hostvars.count).to eq(1)
       expect(hostvars[name: var[:name]]).not_to be_nil
       expect(hostvars[name: var[:name]][:value]).to eq(var[:value])
-        
+
       hostvars = @db.models[:hostvar].all
-      expect(hostvars.count).to eq(1)   
+      expect(hostvars.count).to eq(1)
     end
   end
 end