moonshot 2.0.0.beta6 → 2.0.0.beta7

data/lib/moonshot/stack_parameter_printer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   # Displays information about existing stack parameters to the user, with
   # information on what a stack update would do.
@@ -18,7 +20,7 @@ module Moonshot
 
     def format_value(value)
       if value.size > 60
-        value[0..60] + '...'
+        "#{value[0..60]}..."
       else
         value
       end

data/lib/moonshot/stack_template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   # A StackTemplate loads the template from disk and stores information
   # about it.

data/lib/moonshot/task.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 module Moonshot
   class Task
     attr_reader :name, :desc, :block
+
     def initialize(name, desc, &block)
       @name = name.to_sym
       @desc = desc

data/lib/moonshot/tools/asg_rollout/asg.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Tools
     class ASGRollout
@@ -20,14 +22,15 @@ module Moonshot
           autoscaling.update_auto_scaling_group(
             auto_scaling_group_name: @name,
             max_size: max,
-            desired_capacity: desired)
+            desired_capacity: desired
+          )
         end
 
         def non_conforming_instances
           asg = load_asg
 
           asg.instances
-             .select { |i| i.launch_configuration_name != asg.launch_configuration_name }
+             .reject { |i| i.launch_configuration_name == asg.launch_configuration_name }
              .map(&:instance_id)
         end
 
@@ -59,17 +62,17 @@ module Moonshot
           resp = autoscaling.detach_instances(
             auto_scaling_group_name: @name,
             instance_ids: [id],
-            should_decrement_desired_capacity: decrement)
+            should_decrement_desired_capacity: decrement
+          )
 
           activity = resp.activities.first
-          unless activity
-            raise 'Did not receive Activity from DetachInstances call!'
-          end
+          raise 'Did not receive Activity from DetachInstances call!' unless activity
 
           # Wait for the detach activity to complete:
           loop do
             resp = autoscaling.describe_scaling_activities(
-              auto_scaling_group_name: @name)
+              auto_scaling_group_name: @name
+            )
 
             current_status = resp.activities
                                  .find { |a| a.activity_id == activity.activity_id }
@@ -97,7 +100,8 @@ module Moonshot
 
         def asg_instance_state(id)
           resp = autoscaling.describe_auto_scaling_instances(
-            instance_ids: [id])
+            instance_ids: [id]
+          )
 
           instance_info = resp.auto_scaling_instances.first
           return 'Missing' unless instance_info
@@ -108,14 +112,11 @@ module Moonshot
         def elb_instance_state(id)
           resp = loadbalancing.describe_instance_health(
             load_balancer_name: elb_name,
-            instances: [
-              { instance_id: id }
-            ])
+            instances: [{ instance_id: id }]
+          )
 
           instance_info = resp.instance_states.first
-          unless instance_info
-            raise "Failed to call DescribeInstanceHealth for #{id}!"
-          end
+          raise "Failed to call DescribeInstanceHealth for #{id}!" unless instance_info
 
           instance_info.state
         rescue Aws::ElasticLoadBalancing::Errors::InvalidInstance
@@ -133,11 +134,10 @@ module Moonshot
 
         def load_asg
           resp = autoscaling.describe_auto_scaling_groups(
-            auto_scaling_group_names: [@name])
+            auto_scaling_group_names: [@name]
+          )
 
-          if resp.auto_scaling_groups.empty?
-            raise "Failed to call DescribeAutoScalingGroups for #{@name}!"
-          end
+          raise "Failed to call DescribeAutoScalingGroups for #{@name}!" if resp.auto_scaling_groups.empty?
 
           asg = resp.auto_scaling_groups.first
           @last_seen_ids = asg.instances.map(&:instance_id)
@@ -149,9 +149,7 @@ module Moonshot
           return @elb_name if @elb_name
 
           asg = load_asg
-          if asg.load_balancer_names.size > 1
-            raise 'ASGRollout does not support configurations with multiple ELBs!'
-          end
+          raise 'ASGRollout does not support configurations with multiple ELBs!' if asg.load_balancer_names.size > 1
 
           @elb_name ||= asg.load_balancer_names.first
         end

data/lib/moonshot/tools/asg_rollout/asg_instance.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Tools
     class ASGRollout

data/lib/moonshot/tools/asg_rollout/hook_exec_environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'moonshot/ssh_fork_executor'
 
 module Moonshot

data/lib/moonshot/tools/asg_rollout/instance_health.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Tools
     class ASGRollout

data/lib/moonshot/tools/asg_rollout.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Tools
-    class ASGRollout # rubocop:disable ClassLength
+    class ASGRollout # rubocop:disable Metrics/ClassLength
       attr_accessor :config
 
       def initialize(controller:, logical_id:)
@@ -16,7 +18,7 @@ module Moonshot
           new_instance = wait_for_new_instance
           begin
             wait_for_in_service(new_instance)
-          rescue
+          rescue StandardError
             next
           end
           break
@@ -74,6 +76,7 @@ module Moonshot
               raise "Instance #{new_instance.blue} went OutOfService while waiting to join..."
             end
             break if instance_health.in_service?
+
             s.continue "Instance #{new_instance.blue} is #{instance_health}..."
             sleep @config.instance_health_delay
           end
@@ -83,22 +86,22 @@ module Moonshot
       end
 
       def run_pre_detach(instance)
-        if @config.pre_detach
-          log.start_threaded "Running PreDetach hook on #{instance.blue}..." do |s|
-            he = HookExecEnvironment.new(@controller.config, instance)
-            if false == @config.pre_detach.call(he)
-              s.failure "PreDetach hook failed for #{instance.blue}!"
-              raise "PreDetach hook failed for #{instance.blue}!"
-            end
+        return unless @config.pre_detach
 
-            s.success "PreDetach hook complete for #{instance.blue}!"
+        log.start_threaded "Running PreDetach hook on #{instance.blue}..." do |s|
+          he = HookExecEnvironment.new(@controller.config, instance)
+          if @config.pre_detach.call(he) == false
+            s.failure "PreDetach hook failed for #{instance.blue}!"
+            raise "PreDetach hook failed for #{instance.blue}!"
           end
+
+          s.success "PreDetach hook complete for #{instance.blue}!"
         end
       end
 
       def detach(instance, decrement:)
         log.start_threaded "Detaching instance #{instance.blue}..." do |s|
-          asg.detach_instance(instance, decrement: decrement)
+          asg.detach_instance(instance, decrement:)
 
           if decrement
             s.success "Detached instance #{instance.blue}, and decremented DesiredCapacity."
@@ -115,6 +118,7 @@ module Moonshot
           loop do
             instance_health = asg.instance_health(instance)
             break if instance_health.out_of_service?
+
             s.continue "Instance #{instance.blue} is #{instance_health}..."
             sleep @config.instance_health_delay
           end
@@ -155,9 +159,7 @@ module Moonshot
         return @asg if @asg
 
         asg_name = @controller.stack.physical_id_for(@logical_id)
-        unless asg_name
-          raise "Could not find Auto Scaling Group #{@logical_id}!"
-        end
+        raise "Could not find Auto Scaling Group #{@logical_id}!" unless asg_name
 
         @asg ||= ASGRollout::ASG.new(asg_name)
       end

data/lib/moonshot/tools/asg_rollout_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Tools
     class ASGRolloutConfig

data/lib/moonshot/unicode_table.rb

@@ -1,4 +1,4 @@
-# coding: utf-8
+# frozen_string_literal: true
 
 require 'colorize'
 

data/lib/moonshot/yaml_stack_template.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 
 module Moonshot

data/lib/moonshot.rb

@@ -1,5 +1,14 @@
+# frozen_string_literal: true
+
 require 'English'
-require 'aws-sdk'
+
+require 'aws-sdk-cloudformation'
+require 'aws-sdk-codedeploy'
+require 'aws-sdk-ec2'
+require 'aws-sdk-iam'
+require 'aws-sdk-autoscaling'
+require 'aws-sdk-s3'
+
 require 'logger'
 require 'thor'
 require 'interactive-logger'
@@ -16,10 +25,13 @@ module Moonshot
 
   module ArtifactRepository
   end
+
   module BuildMechanism
   end
+
   module DeploymentMechanism
   end
+
   module Plugins
   end
 end

data/lib/plugins/backup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubygems/package'
 require 'zlib'
 require 'yaml'
@@ -20,7 +22,7 @@ module Moonshot
       def initialize
         yield self if block_given?
         validate_configuration
-        @target_name ||= '%{app_name}_%{timestamp}_%{user}.tar.gz'
+        @target_name ||= '%<app_name>s_%<timestamp>s_%<user>s.tar.gz'
       end
 
       # Factory method to create preconfigured Backup plugins. Uploads current
@@ -29,11 +31,12 @@ module Moonshot
       # @return [Backup] configured backup object
       def self.to_bucket(bucket)
         raise ArgumentError if bucket.nil? || bucket.empty?
+
         Moonshot::Plugins::Backup.new do |b|
           b.bucket = bucket
           b.backup_parameters = true
           b.backup_template = true
-          b.hooks = [:post_create, :post_update]
+          b.hooks = %i[post_create post_update]
         end
       end
 
@@ -53,18 +56,16 @@ module Moonshot
         return if @target_bucket.nil?
 
         resources.ilog.start("#{log_message} in progress.") do |s|
-          begin
-            tar_out = tar(@files)
-            zip_out = zip(tar_out)
-            upload(zip_out)
-
-            s.success("#{log_message} succeeded.")
-          rescue => e
-            s.failure("#{log_message} failed: #{e}")
-          ensure
-            tar_out.close unless tar_out.nil?
-            zip_out.close unless zip_out.nil?
-          end
+          tar_out = tar(@files)
+          zip_out = zip(tar_out)
+          upload(zip_out)
+
+          s.success("#{log_message} succeeded.")
+        rescue StandardError => e
+          s.failure("#{log_message} failed: #{e}")
+        ensure
+          tar_out&.close
+          zip_out&.close
         end
       end
 
@@ -110,7 +111,7 @@ module Moonshot
 
           # adding template file
           if @backup_template
-            template_file_path = render('cloud_formation/%{app_name}.json')
+            template_file_path = render('cloud_formation/%<app_name>s.json')
             add_file_to_tar(writer, template_file_path)
           end
         end
@@ -123,12 +124,10 @@ module Moonshot
       # @param writer [TarWriter]
       # @param file_name [String]
       def add_file_to_tar(writer, file_name)
-        writer.add_file(File.basename(file_name), 0644) do |io|
-          begin
-            File.open(file_name, 'r') { |f| io.write(f.read) }
-          rescue Errno::ENOENT
-            warn "'#{file_name}' was not found."
-          end
+        writer.add_file(File.basename(file_name), 0o644) do |io|
+          File.open(file_name, 'r') { |f| io.write(f.read) }
+        rescue Errno::ENOENT
+          warn "'#{file_name}' was not found."
         end
       end
 
@@ -139,7 +138,7 @@ module Moonshot
       # @param target_filename [String]
       # @param content [String]
       def add_str_to_tar(writer, target_filename, content)
-        writer.add_file(File.basename(target_filename), 0644) do |io|
+        writer.add_file(File.basename(target_filename), 0o644) do |io|
           io.write(content.to_yaml)
         end
       end
@@ -196,17 +195,12 @@ module Moonshot
       end
 
       def define_bucket
-        case
         # returning already calculated bucket name
-        when @target_bucket
-          @target_bucket
+        return @target_bucket if @target_bucket
         # single bucket for all accounts
-        when @bucket
-          @bucket
+        return @bucket if @bucket
         # calculating bucket based on account name
-        when @buckets
-          bucket_by_account(iam_account)
-        end
+        return bucket_by_account(iam_account) if @buckets
       end
 
       def bucket_by_account(account)

data/lib/plugins/code_deploy_setup.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Plugins
     # Plugin to ensure CodeDeploy has all necessary S3 buckets created.
@@ -33,11 +35,11 @@ module Moonshot
       # Create an S3 bucket in each supported region for CodeDeploy
       def setup_code_deploy_s3_buckets
         @regions.uniq.each do |region|
-          client = s3_client(region: region)
+          client = s3_client(region:)
           name = bucket_name(region)
           bucket = Aws::S3::Bucket.new(
             name,
-            client: client
+            client:
           )
           bucket.create unless bucket.exists?
         end

data/lib/plugins/dynamic_template.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module Moonshot
+  module Plugins
+    class DynamicTemplate
+      def initialize(source:, parameters:, destination:)
+        @dynamic_template = ::Moonshot::DynamicTemplate.new(
+          source:,
+          parameters:,
+          destination:
+        )
+      end
+
+      def run_hook
+        @dynamic_template.process
+      end
+
+      def cli_hook(parser)
+        parser.on('--template-file=FILE', 'Override the path to the CloudFormation template.') do |v|
+          @dynamic_template.destination = v
+          Moonshot.config.template_file = v
+        end
+      end
+
+      # Moonshot hooks to trigger this plugin.
+      alias setup_create run_hook
+      alias setup_update run_hook
+      alias setup_delete run_hook
+
+      # Moonshot hooks to add CLI options.
+      alias create_cli_hook cli_hook
+      alias delete_cli_hook cli_hook
+      alias update_cli_hook cli_hook
+    end
+  end
+end

data/lib/plugins/encrypted_parameters/kms_key.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Moonshot
   module Plugins
     class EncryptedParameters

data/lib/plugins/encrypted_parameters/parameter_encrypter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 module Moonshot
   module Plugins

data/lib/plugins/encrypted_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This plugin encrypts parameters of the stack using a KMS Key,
 # storing and passing the key used to the stack as a parameter as
 # well. The resources in the stack can then use that KMS Key to
@@ -96,7 +98,7 @@ module Moonshot
 
         @ilog.start_threaded "Checking for KMS Key #{@kms_key_parameter_name}" do |s|
           if Moonshot.config.parameters.key?(@kms_key_parameter_name)
-            if 'Auto' == Moonshot.config.parameters[@kms_key_parameter_name].value
+            if Moonshot.config.parameters[@kms_key_parameter_name].value == 'Auto'
               s.continue "Auto-generating KMS Key for #{@kms_key_parameter_name.blue}... "
               key_arn = KmsKey.create.arn
               Moonshot.config.parameters[@kms_key_parameter_name].set(key_arn)