moodle_rb 1.0.0 → 1.0.1

data/lib/moodle_rb/grades.rb

@@ -20,8 +20,11 @@ module MoodleRb
           }
         }
       )
-      response.parsed_response.is_a?(Hash) &&
+      if error_response?(response)
+        raise MoodleError.new(response.parsed_response)
+      else
         response.parsed_response['assignments']
+      end
     end
 
     def by_course(course_id, *user_ids)
@@ -35,8 +38,11 @@ module MoodleRb
           }
         }
       )
-      response.parsed_response.is_a?(Hash) &&
+      if error_response?(response)
+        raise MoodleError.new(response.parsed_response)
+      else
         response.parsed_response['items']
+      end
     end
   end
 end

data/lib/moodle_rb/version.rb

@@ -1,5 +1,5 @@
 module MoodleRb
-  VERSION = '1.0.0' unless defined?(self::VERSION)
+  VERSION = '1.0.1' unless defined?(self::VERSION)
 
   def self.version
     VERSION

data/spec/cassettes/MoodleRb_Grades/_by_course/when_invalid_parameters/.yml

@@ -0,0 +1,39 @@
+--- 
+http_interactions: 
+- request: 
+    method: post
+    uri: http://localhost:8888/moodle28/webservice/rest/server.php?moodlewsrestformat=json&wsfunction=core_grades_get_grades&wstoken=60fc9c9415259404795094957e4ab32f
+    body: 
+      string: userids[0]=ABC&courseid=8
+    headers: {}
+
+  response: 
+    status: 
+      code: 200
+      message: OK
+    headers: 
+      Content-Length: 
+      - "119"
+      Expires: 
+      - Thu, 01 Jan 1970 00:00:00 GMT
+      Pragma: 
+      - no-cache
+      Accept-Ranges: 
+      - none
+      Content-Type: 
+      - application/json
+      X-Powered-By: 
+      - PHP/5.6.2
+      Cache-Control: 
+      - private, must-revalidate, pre-check=0, post-check=0, max-age=0
+      Access-Control-Allow-Origin: 
+      - "*"
+      Date: 
+      - Wed, 10 Jun 2015 03:06:02 GMT
+      Server: 
+      - Apache/2.2.29 (Unix) mod_fastcgi/2.4.6 mod_wsgi/3.4 Python/2.7.8 PHP/5.6.2 mod_ssl/2.2.29 OpenSSL/0.9.8zd DAV/2 mod_perl/2.0.8 Perl/v5.20.0
+    body: 
+      string: "{\"exception\":\"invalid_parameter_exception\",\"errorcode\":\"invalidparameter\",\"message\":\"Invalid parameter value detected\"}"
+    http_version: 
+  recorded_at: Wed, 10 Jun 2015 03:06:02 GMT
+recorded_with: VCR 2.9.3

data/spec/lib/moodle_rb/grades_spec.rb

@@ -28,5 +28,16 @@ describe MoodleRb::Grades do
       expect(result).to be_a Array
       expect(result.first).to have_key 'activityid'
     end
+
+    context 'when invalid parameters' do
+      let(:user_ids) { 'ABC' }
+
+      specify do
+        expect{ result }.to raise_error(
+          MoodleRb::MoodleError,
+          'Invalid parameter value detected'
+        )
+      end
+    end
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: moodle_rb
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Sam Giffney
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2015-06-04 00:00:00 Z
+date: 2015-06-10 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: bundler
@@ -167,6 +167,7 @@ files:
 - spec/cassettes/MoodleRb_Enrolments/_create/when_user_or_course_id_is_invalid/.yml
 - spec/cassettes/MoodleRb_Grades/_by_assignment/.yml
 - spec/cassettes/MoodleRb_Grades/_by_course/.yml
+- spec/cassettes/MoodleRb_Grades/_by_course/when_invalid_parameters/.yml
 - spec/cassettes/MoodleRb_Users/_create/.yml
 - spec/cassettes/MoodleRb_Users/_create/when_missing_required_parameters/.yml
 - spec/cassettes/MoodleRb_Users/_destroy/.yml
@@ -234,6 +235,7 @@ test_files:
 - spec/cassettes/MoodleRb_Enrolments/_create/when_user_or_course_id_is_invalid/.yml
 - spec/cassettes/MoodleRb_Grades/_by_assignment/.yml
 - spec/cassettes/MoodleRb_Grades/_by_course/.yml
+- spec/cassettes/MoodleRb_Grades/_by_course/when_invalid_parameters/.yml
 - spec/cassettes/MoodleRb_Users/_create/.yml
 - spec/cassettes/MoodleRb_Users/_create/when_missing_required_parameters/.yml
 - spec/cassettes/MoodleRb_Users/_destroy/.yml