monolens 0.2.0 → 0.3.0

data/spec/monolens/object/test_transform.rb

@@ -1,15 +1,102 @@
 require 'spec_helper'
 
 describe Monolens, 'object.transform' do
-  subject do
-    Monolens.lens('object.transform' => { firstname: 'str.upcase' })
+  context 'with default options' do
+    subject do
+      Monolens.lens('object.transform' => {
+        defn: { firstname: 'str.upcase' }
+      })
+    end
+
+    it 'works as expected' do
+      expect(subject.call(firstname: 'Bernard')).to eql(firstname: 'BERNARD')
+    end
+
+    it 'works as expected on an object with String keys' do
+      expect(subject.call('firstname' => 'Bernard')).to eql('firstname' => 'BERNARD')
+    end
+
+    it 'raises an error if input object does not have a key' do
+      expect {
+        subject.call(lastname: 'Lambeau')
+      }.to raise_error(Monolens::LensError, /firstname/)
+    end
+  end
+
+  context 'with on_missing: skip' do
+    subject do
+      Monolens.lens('object.transform' => {
+        on_missing: :skip,
+        defn: { firstname: 'str.upcase' }
+      })
+    end
+
+    it 'works as expected' do
+      expect(subject.call(firstname: 'Bernard')).to eql(firstname: 'BERNARD')
+    end
+
+    it 'skpis if missing' do
+      expect(subject.call(lastname: 'Lambeau')).to eql(lastname: 'Lambeau')
+    end
   end
 
-  it 'works as expected' do
-    expect(subject.call(firstname: 'Bernard')).to eql(firstname: 'BERNARD')
+  context 'with on_missing: null' do
+    subject do
+      Monolens.lens('object.transform' => {
+        on_missing: :null,
+        defn: { firstname: 'str.upcase' }
+      })
+    end
+
+    it 'works as expected' do
+      expect(subject.call(firstname: 'Bernard')).to eql(firstname: 'BERNARD')
+    end
+
+    it 'skpis if missing' do
+      expect(subject.call(lastname: 'Lambeau')).to eql(firstname: nil, lastname: 'Lambeau')
+    end
   end
 
-  it 'works as expected on an object with String keys' do
-    expect(subject.call('firstname' => 'Bernard')).to eql('firstname' => 'BERNARD')
+  describe 'error traceability' do
+    let(:lens) do
+      Monolens.lens({
+        'array.map' => {
+          :lenses => {
+            'object.transform' => {
+              defn: { firstname: 'str.upcase' }
+            }
+          }
+        }
+      })
+    end
+
+    subject do
+      lens.call(input)
+      nil
+    rescue Monolens::LensError => ex
+      ex
+    end
+
+    context 'when missing key' do
+      let(:input) do
+        [{}]
+      end
+
+      it 'correctly updates the location' do
+        expect(subject.location).to eql([0])
+      end
+    end
+
+    context 'when an error down the line' do
+      let(:input) do
+        [{
+          firstname: nil
+        }]
+      end
+
+      it 'correctly updates the location' do
+        expect(subject.location).to eql([0, :firstname])
+      end
+    end
   end
 end

data/spec/monolens/object/test_values.rb

@@ -1,19 +1,117 @@
 require 'spec_helper'
 
 describe Monolens, 'object.values' do
-  subject do
-    Monolens.lens('object.values' => ['str.upcase'])
+  context 'with default options' do
+    subject do
+      Monolens.lens('object.values' => ['str.upcase'])
+    end
+
+    it 'works as expected' do
+      input = {
+        firstname: 'Bernard',
+        lastname: 'Lambeau'
+      }
+      expected = {
+        firstname: 'BERNARD',
+        lastname: 'LAMBEAU'
+      }
+      expect(subject.call(input)).to eql(expected)
+    end
+
+    it 'raises an error on any problem' do
+      input = {
+        firstname: nil,
+        lastname: 'Lambeau'
+      }
+      expect {
+        subject.call(input)
+      }.to raise_error(Monolens::LensError)
+    end
+  end
+
+  context 'with on_error: skip' do
+    subject do
+      Monolens.lens('object.values' => {
+        'on_error' => 'skip',
+        'lenses' => ['str.upcase']
+      })
+    end
+
+    it 'skips key/value when an error occurs' do
+      input = {
+        firstname: nil,
+        lastname: 'Lambeau'
+      }
+      expected = {
+        lastname: 'LAMBEAU'
+      }
+      expect(subject.call(input)).to eql(expected)
+    end
+  end
+
+  context 'with on_error: null' do
+    subject do
+      Monolens.lens('object.values' => {
+        'on_error' => 'null',
+        'lenses' => ['str.upcase']
+      })
+    end
+
+    it 'uses nil as value' do
+      input = {
+        firstname: 12,
+        lastname: 'Lambeau'
+      }
+      expected = {
+        firstname: nil,
+        lastname: 'LAMBEAU'
+      }
+      expect(subject.call(input)).to eql(expected)
+    end
+  end
+
+  context 'with on_error: keep' do
+    subject do
+      Monolens.lens('object.values' => {
+        'on_error' => 'keep',
+        'lenses' => ['str.upcase']
+      })
+    end
+
+    it 'uses nil as value' do
+      input = {
+        firstname: 12,
+        lastname: 'Lambeau'
+      }
+      expected = {
+        firstname: 12,
+        lastname: 'LAMBEAU'
+      }
+      expect(subject.call(input)).to eql(expected)
+    end
   end
 
-  it 'works as expected' do
-    input = {
-      firstname: 'Bernard',
-      lastname: 'Lambeau'
-    }
-    expected = {
-      firstname: 'BERNARD',
-      lastname: 'LAMBEAU'
-    }
-    expect(subject.call(input)).to eql(expected)
+  describe 'error traceability' do
+    let(:lens) do
+      Monolens.lens('object.values' => ['str.upcase'])
+    end
+
+    subject do
+      lens.call(input)
+      nil
+    rescue Monolens::LensError => ex
+      ex
+    end
+
+    let(:input) do
+      {
+        'firstname' => 'Bernard',
+        'lastname' => nil
+      }
+    end
+
+    it 'correctly updates the location' do
+      expect(subject.location).to eql(['lastname'])
+    end
   end
 end

data/spec/monolens/test_error_traceability.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe Monolens, 'error traceability' do
+  context 'on a leaf monolens' do
+    let(:lens) do
+      Monolens.lens('str.upcase')
+    end
+
+    subject do
+      begin
+        lens.call(nil)
+      rescue => ex
+        ex
+      end
+    end
+
+    it 'works as expected' do
+      expect(subject).to be_a(Monolens::LensError)
+      expect(subject.location).to eql([])
+    end
+  end
+
+  context 'on array.map' do
+    let(:lens) do
+      Monolens.lens('array.map' => 'str.upcase')
+    end
+
+    subject do
+      begin
+        lens.call(['foo', nil])
+      rescue => ex
+        ex
+      end
+    end
+
+    it 'works as expected' do
+      expect(subject).to be_a(Monolens::LensError)
+      expect(subject.location).to eql([1])
+    end
+  end
+
+  context 'on array.map => object.values' do
+    let(:lens) do
+      Monolens.lens('array.map' => { lenses: { 'object.values' => 'str.upcase' } })
+    end
+
+    subject do
+      begin
+        lens.call([{ hello: 'foo' }, { hello: nil }])
+      rescue Monolens::LensError => ex
+        ex
+      end
+    end
+
+    it 'works as expected' do
+      expect(subject).to be_a(Monolens::LensError)
+      expect(subject.location).to eql([1, :hello])
+    end
+  end
+end

data/spec/monolens/test_lens.rb

@@ -16,7 +16,7 @@ describe Monolens, '.lens' do
   it 'preserves options' do
     got = Monolens.lens(:"coerce.date" => { formats: ['%Y'] })
     expect(got).to be_a(Monolens::Coerce::Date)
-    expect(got.options).to eql({ formats: ['%Y'] })
+    expect(got.options.to_h).to eql({ formats: ['%Y'] })
   end
 
   it 'allows using an Array, factors a Chain with coercion recursion' do

data/spec/test_readme.rb

@@ -23,12 +23,14 @@ describe "What's said in README" do
     lenses:
     - array.map:
       - object.transform:
-          status:
-          - str.upcase
-          body:
-          - str.strip
+          defn:
+            status:
+            - str.upcase
+            body:
+            - str.strip
       - object.rename:
-          body: description
+          defn:
+            body: description
     YML
   }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: monolens
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Bernard Lambeau
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-05-05 00:00:00.000000000 Z
+date: 2022-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -70,12 +70,16 @@ files:
 - lib/monolens/coerce.rb
 - lib/monolens/coerce/date.rb
 - lib/monolens/coerce/date_time.rb
+- lib/monolens/coerce/string.rb
 - lib/monolens/core.rb
 - lib/monolens/core/chain.rb
 - lib/monolens/core/mapping.rb
 - lib/monolens/error.rb
 - lib/monolens/file.rb
 - lib/monolens/lens.rb
+- lib/monolens/lens/fetch_support.rb
+- lib/monolens/lens/location.rb
+- lib/monolens/lens/options.rb
 - lib/monolens/object.rb
 - lib/monolens/object/keys.rb
 - lib/monolens/object/rename.rb
@@ -98,7 +102,9 @@ files:
 - spec/monolens/array/test_map.rb
 - spec/monolens/coerce/test_date.rb
 - spec/monolens/coerce/test_datetime.rb
+- spec/monolens/coerce/test_string.rb
 - spec/monolens/core/test_mapping.rb
+- spec/monolens/lens/test_options.rb
 - spec/monolens/object/test_keys.rb
 - spec/monolens/object/test_rename.rb
 - spec/monolens/object/test_select.rb
@@ -109,6 +115,7 @@ files:
 - spec/monolens/str/test_split.rb
 - spec/monolens/str/test_strip.rb
 - spec/monolens/str/test_upcase.rb
+- spec/monolens/test_error_traceability.rb
 - spec/monolens/test_lens.rb
 - spec/spec_helper.rb
 - spec/test_monolens.rb