mongomatic 0.7.1 → 0.7.2

data/lib/mongomatic/base.rb

@@ -71,8 +71,6 @@ module Mongomatic
         do_callback(:after_drop)
       end
       
-      private
-      
       def do_callback(meth)
         return false unless respond_to?(meth, true)
         send(meth)
@@ -292,8 +290,6 @@ module Mongomatic
       @doc || {}
     end
     
-    protected
-    
     def hash_for_field(field, break_if_dne=false)
       parts = field.split(".")
       curr_hash = self.doc
@@ -313,5 +309,11 @@ module Mongomatic
       return false unless respond_to?(meth, true)
       send(meth)
     end
+    
+    def transaction(key=nil, duration=5, &block)
+      raise Mongomatic::Exceptions::DocumentIsNew if new?
+      key ||= [self.class.name, self["_id"].to_s].join("-")
+      TransactionLock.start(key, duration, &block)
+    end
   end
 end

data/lib/mongomatic/exceptions.rb

@@ -6,5 +6,7 @@ module Mongomatic
     class DocumentIsNew      < Base; end
     class DocumentWasRemoved < Base; end
     class DocumentNotValid   < Base; end
+    
+    class CannotGetTransactionLock < Base; end
   end
 end

data/lib/mongomatic/transaction_lock.rb

@@ -0,0 +1,35 @@
+module Mongomatic
+
+  class TransactionLock < Base
+    def self.create_indexes
+      collection.create_index("key", :unique => true, :drop_dups => true)
+      collection.create_index("expire_at")
+    end
+    
+    def self.start(key, duration, &block)
+      lock = new(:key => key, :expire_at => Time.now.utc + duration)
+      
+      # we need to get a lock
+      begin
+        lock.insert!
+      rescue Mongo::OperationFailure => e
+        remove_stale_locks
+        if find_one(:key => key) == nil
+          return start(key, duration, &block)
+        end
+        raise Mongomatic::Exceptions::CannotGetTransactionLock
+      end
+      
+      begin
+        block.call
+      ensure
+        lock.remove
+      end
+    end
+    
+    def self.remove_stale_locks
+      collection.remove({:expire_at => {"$lte" => Time.now.utc}}, {:safe => true})
+    end
+  end
+  
+end

data/lib/mongomatic.rb

@@ -45,3 +45,4 @@ require "#{File.dirname(__FILE__)}/mongomatic/active_model_compliancy"
 require "#{File.dirname(__FILE__)}/mongomatic/type_converters"
 require "#{File.dirname(__FILE__)}/mongomatic/typed_fields"
 require "#{File.dirname(__FILE__)}/mongomatic/base"
+require "#{File.dirname(__FILE__)}/mongomatic/transaction_lock"

data/test/helper.rb

@@ -122,5 +122,15 @@ class Rig < Mongomatic::Base
   typed_field "friends_rig_id",     :type => :object_id, :cast => true
 end
 
-
-
+class Clock < Mongomatic::Base
+  typed_field "ticks", :type => :fixnum, :cast => true
+  
+  def tick!
+    transaction do
+      self.reload
+      self["ticks"] ||= 0
+      self["ticks"] += 1
+      self.update!
+    end
+  end
+end

data/test/test_transaction_lock.rb

@@ -0,0 +1,76 @@
+require 'helper'
+require 'minitest/autorun'
+
+class TestTransactionLock < MiniTest::Unit::TestCase
+  def setup
+    Person.collection.drop
+    Mongomatic::TransactionLock.collection.drop
+    Mongomatic::TransactionLock.create_indexes
+  end
+  
+  def test_will_rm_lock_when_complete
+    assert_equal 0, Mongomatic::TransactionLock.count
+    p1 = Person.new(:name => "Jordan")
+    p1.insert!
+    p1.transaction { assert_equal 1, Mongomatic::TransactionLock.count }
+    assert_equal 0, Mongomatic::TransactionLock.count
+    p1.transaction { assert_equal 1, Mongomatic::TransactionLock.count }
+  end
+  
+  def test_will_raise_if_cant_get_lock
+    p1 = Person.new(:name => "Jordan")
+    p1.insert!
+    
+    l = Mongomatic::TransactionLock.new(:key => "Person-#{p1["_id"]}", :expire_at => Time.now.utc + 1.day)
+    l.insert!
+    
+    assert_raises(Mongomatic::Exceptions::CannotGetTransactionLock) do
+      p1.transaction { true }
+    end
+    
+    assert_raises(Mongomatic::Exceptions::CannotGetTransactionLock) do
+      p1.transaction { true }
+    end
+    
+    l.remove!
+
+    p1.transaction { assert_equal 1, Mongomatic::TransactionLock.count }
+  end
+  
+  def test_will_rm_stale_locks
+    p1 = Person.new(:name => "Jordan")
+    p1.insert!
+    
+    l = Mongomatic::TransactionLock.new(:key => "Person-#{p1["_id"]}", :expire_at => Time.now.utc - 1.day)
+    l.insert!
+    
+    p1.transaction { assert_equal 1, Mongomatic::TransactionLock.count }
+  end
+  
+  def test_race_condition
+    c = Clock.new
+    c.insert!
+    threads = []
+
+    lock_errors = 0
+
+    50.times do
+      threads << Thread.new do
+        begin
+          Mongomatic.db = Mongo::Connection.new.db("mongomatic_test")
+          c = Clock.find_one(c["_id"])
+          c.tick!
+        rescue Mongomatic::Exceptions::CannotGetTransactionLock => e
+          lock_errors += 1
+          sleep(0.05); retry
+        end
+      end
+    end
+    threads.each { |th| th.join }
+
+    c = Clock.find_one(c["_id"])
+    assert_equal 50, c["ticks"]
+    
+    assert lock_errors > 0
+  end
+end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 7
-  - 1
-  version: 0.7.1
+  - 2
+  version: 0.7.2
 platform: ruby
 authors: 
 - Ben Myles
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-18 00:00:00 -08:00
+date: 2010-11-19 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -101,6 +101,7 @@ files:
 - lib/mongomatic/modifiers.rb
 - lib/mongomatic/observable.rb
 - lib/mongomatic/observer.rb
+- lib/mongomatic/transaction_lock.rb
 - lib/mongomatic/type_converters.rb
 - lib/mongomatic/typed_fields.rb
 - lib/mongomatic/util.rb
@@ -113,6 +114,7 @@ files:
 - test/test_modifiers.rb
 - test/test_observable.rb
 - test/test_persistence.rb
+- test/test_transaction_lock.rb
 - test/test_typed_fields.rb
 - test/test_validations.rb
 has_rdoc: true
@@ -120,8 +122,8 @@ homepage: http://mongomatic.com/
 licenses: []
 
 post_install_message: 
-rdoc_options: 
-- --charset=UTF-8
+rdoc_options: []
+
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -155,5 +157,6 @@ test_files:
 - test/test_modifiers.rb
 - test/test_observable.rb
 - test/test_persistence.rb
+- test/test_transaction_lock.rb
 - test/test_typed_fields.rb
 - test/test_validations.rb