mongoid_slug 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f02a3cbeacca56a521287827c0a7650b8d0b07e
-  data.tar.gz: 8b9d08075c34fabf26e1f5a27c635626520bf649
+  metadata.gz: 8ce4dfe55677a1b8cb8d39718cf595933dd7eae7
+  data.tar.gz: 799033738af175e6233c03268c73bafe0d17a259
 SHA512:
-  metadata.gz: 175e6e37b7072bc78fe66959bc3990e7c095091d14ea100df80ace7d1312ff1b019503818797b5ae9a82451e261cf75976917fdfa583f9a5d8929cafb16ed744
-  data.tar.gz: 77e501773a14a495ae9103623ca5375ea33e93f0973f50523c7161958b0c5fd1a0d4526a405fe137cf4260a02a708422669baba17860c350f2e780ca952ae912
+  metadata.gz: 50ff4db23d6243bb38678fc957d369ff8277607503a1c301d4841a8c835c93925100187549451d550cf4fea6b27b698e700de48962d12b9c5d0d3497fbb0c218
+  data.tar.gz: 56d4bb715d1977746ebcf7c7ca94f58040e3d083028dcaeff7b15fc9963ef256fd20fafbdcf2d9ccff51596a21da53b96efee562be13666b68d9777bad87f814

data/lib/mongoid/slug.rb

@@ -131,13 +131,21 @@ module Mongoid
     # @return [true]
     def build_slug
       _new_slug = find_unique_slug
+
+      #skip slug generation and use Mongoid id
+      #to find document instead
+      return true if _new_slug.size == 0
+
       self._slugs.delete(_new_slug) if self._slugs
+
       if !!self.history && self._slugs.is_a?(Array)
         self._slugs << _new_slug
       else
         self._slugs = [_new_slug]
       end
+
       true
+
     end
 
     # Finds a unique slug, were specified string used to generate a slug.

data/lib/mongoid/slug/version.rb

@@ -1,5 +1,5 @@
 module Mongoid #:nodoc:
   module Slug
-    VERSION = '3.1.0'
+    VERSION = '3.1.1'
   end
 end

data/spec/mongoid/slug_spec.rb

@@ -17,14 +17,19 @@ module Mongoid
         #I believe this will now fail
         x.name = 'te'
         x.valid?
-        x.slug.should_not == 'te'  
+        x.slug.should_not == 'te'
 
-        #I believe this will persist the 'te' 
+        #I believe this will persist the 'te'
         x.name = 'testb'
         x.save!
 
       end
 
+      it "doesn't persist blank strings" do
+        book = Book.create!(:title => "")
+        book.reload.slugs.should be_empty
+      end
+
     end
 
     context "when option skip_id_check is used with UUID _id " do
@@ -646,8 +651,8 @@ module Mongoid
       let!(:integer_id2) { IntegerId.new(:name => integer_id.id.to_s).tap { |d| d.id = 456; d.save } }
       let!(:string_id) { StringId.new(:name => "I have string ids").tap { |d| d.id = 'abc'; d.save } }
       let!(:string_id2) { StringId.new(:name => string_id.id.to_s).tap { |d| d.id = 'def'; d.save } }
-      let!(:subject) { Subject.create(:title  => "A Subject", :book => book) }
-      let!(:subject2) { Subject.create(:title  => "A Subject", :book => book2) }
+      let!(:subject) { Subject.create(:name  => "A Subject", :book => book) }
+      let!(:subject2) { Subject.create(:name  => "A Subject", :book => book2) }
       let!(:without_slug) { WithoutSlug.new().tap { |d| d.id = 456; d.save } }
 
       context "when the model does not use mongoid slugs" do
@@ -770,8 +775,8 @@ module Mongoid
       let!(:integer_id2) { IntegerId.new(:name => integer_id.id.to_s).tap { |d| d.id = 456; d.save } }
       let!(:string_id) { StringId.new(:name => "I have string ids").tap { |d| d.id = 'abc'; d.save } }
       let!(:string_id2) { StringId.new(:name => string_id.id.to_s).tap { |d| d.id = 'def'; d.save } }
-      let!(:subject) { Subject.create(:title  => "A Subject", :book => book) }
-      let!(:subject2) { Subject.create(:title  => "A Subject", :book => book2) }
+      let!(:subject) { Subject.create(:name  => "A Subject", :book => book) }
+      let!(:subject2) { Subject.create(:name  => "A Subject", :book => book2) }
 
       context "(single)" do
         context "and a document is found" do
@@ -835,18 +840,25 @@ module Mongoid
           book.to_param
           book.should_not be_persisted
         end
+
       end
 
       context "when called on an existing record with no slug" do
+        let!(:book_no_title) { Book.create() }
+
         before do
           Book.collection.insert(:title => "Proust and Signs")
         end
 
-        it "should return the id" do
+        it "should return the id if there is no slug" do
           book = Book.first
           book.to_param.should == book.id.to_s
           book.reload.slugs.should be_empty
         end
+
+        it "should not persist the record" do
+          book_no_title.to_param.should == book_no_title._id.to_s
+        end
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_slug
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Andreas Saebjoernsen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-08 00:00:00.000000000 Z
+date: 2013-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid