mongoid_orderable 6.0.6 → 6.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8aa24afe094eaa9ccb1f6c7e275d59f7b8219630bec83ad3f42c813489631cd4
-  data.tar.gz: b91011af6ad450b488ff82c57bc2e07181dfff0eaac4e65ca424fd754bf48734
+  metadata.gz: c7c9edf55be552b8dfa6fdfa8a11df19801f66696361d567fda9e645d8736674
+  data.tar.gz: 579bfbee824451e8d58ca9bddde51bd95b2cb103571c22a9dc6beb045da3af14
 SHA512:
-  metadata.gz: 83e12a1cb61bc2b17d4ff33cbca0ee004c3d04360b414cb111caaccc0d57be054239417a2ff4bdc35030a7612f516e7476c7dff03c3984be5e8b11c347646202
-  data.tar.gz: 2e7c87452089acf630302775c0ece1ecd7eb71a52ab4c277de69bbea7049240a4d3657daad8531e9465f421d292d02ef81ee1c62963f0f7233a2413b3a43df8a
+  metadata.gz: 1a8f4c43964e53a772900978f5a0155ea53bfeffc0cf2775bc10a6db086073adbe855b0bced555abbf4b2a5808c1a92753acaed853783b67ece7f8b2d1520802
+  data.tar.gz: d6cb3996dd6577d5cf52eb8fb487fbcb9fffbd5f708074cf1e0e2185e0a44394eb8c23260f019a30802ad79d0d4623c8fa7a30ec82781d6e378d2810e1d5135e

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 6.0.7 (2026/10/18)
+
+* [#92](https://github.com/mongoid/mongoid_orderable/pull/92): Fix direct position assignment for embedded documents while retaining the movement API, based on regression tests by [@johnnyshields](https://github.com/johnnyshields) - [@dblock](https://github.com/dblock).
+
 ### 6.0.6 (2026/10/14)
 
 * [#90](https://github.com/mongoid/mongoid_orderable/pull/90): Explicitly load Logger for modern ActiveSupport compatibility.

data/README.md

@@ -28,10 +28,10 @@ For older versions, please use Mongoid::Orderable 5.x and earlier.
 
 Transaction support requires MongoDB 4.2+ (4.4+ recommended.)
 
-CI tests representative compatible combinations through Ruby 4.0, Mongoid 9, and MongoDB Server 8.0, retaining Ruby 2.6 / Mongoid 7 / MongoDB 4.4 coverage. See [the test matrix](.github/workflows/test.yml); this is not a Cartesian product of supported versions. Every CI test job uses an isolated single-node replica set, so transaction and non-transaction tests both run. Set `MONGOID_VERSION` to select a Mongoid major version and `MONGODB_HOST` to override the default `localhost:27017` when running tests.
-
 ## Usage
 
+See [UPGRADING](UPGRADING.md) for migration notes, including embedded position assignment changes in 6.0.7.
+
 ### Getting Started
 
 ```ruby
@@ -187,6 +187,22 @@ end
 To ensure the position is written correctly, you will need to set
 `cascade_callbacks: true` on the relation.
 
+Assigning an embedded document's position reorders its siblings when either the child or its parent is saved:
+
+```ruby
+survey = Survey.create!
+3.times { survey.questions.create! }
+question = survey.questions.last
+
+question.position = 1
+survey.save! # question.save! also works
+survey.reload.questions.map(&:position) # => [2, 3, 1]
+```
+
+Positions below the top or above the bottom are clamped to the list bounds. Assigning `nil` moves an existing child to the bottom. New children with a position are inserted at that position, shifting later siblings. Existing `move_to`, `move_to!`, and their helper methods remain supported; an explicit movement request takes precedence over a direct position assignment.
+
+This changes the previous behavior where assigning an existing embedded child's position could leave duplicate positions instead of shifting its siblings. See [UPGRADING](UPGRADING.md).
+
 ### Disable Ordering
 
 You can disable position tracking for specific documents using the `:if` and `:unless` options.

data/lib/mongoid/orderable/handlers/base.rb

@@ -60,6 +60,7 @@ module Handlers
       set_lock(field) if use_transactions
 
       f = orderable_field(field)
+      target_position ||= orderable_position(field) || :bottom if embedded? && doc.send("#{f}_changed?")
       scope = orderable_scope(field)
       scope_changed = orderable_scope_changed?(field)
 
@@ -74,6 +75,8 @@ module Handlers
                   nil
                 elsif persisted? && !embedded?
                   scope.where(_id: _id).pluck(f).first
+                elsif persisted? && embedded?
+                  doc.send("#{f}_was")
                 else
                   orderable_position(field)
                 end

data/lib/mongoid/orderable/mixins/helpers.rb

@@ -29,7 +29,13 @@ module Mixins
     def orderable_bottom(field = nil, in_list = true)
       field ||= default_orderable_field
       f = orderable_field(field)
-      max = orderable_scope(field).ne(f => nil).max(f)
+      scope = orderable_scope(field)
+      scope = scope.ne(_id: _id) if embedded?
+      max = scope.ne(f => nil).max(f)
+      if embedded? && in_list && persisted?
+        previous_position = send("#{f}_was")
+        max = [max, previous_position].compact.max
+      end
       return orderable_top(field) unless max
       in_list ? max : max.next
     end

data/lib/mongoid/orderable/version.rb

@@ -2,6 +2,6 @@
 
 module Mongoid
   module Orderable
-    VERSION = '6.0.6'
+    VERSION = '6.0.7'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_orderable
 version: !ruby/object:Gem::Version
-  version: 6.0.6
+  version: 6.0.7
 platform: ruby
 authors:
 - pyromaniac
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-15 00:00:00.000000000 Z
+date: 2026-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid