mongoid_orderable 0.9.0 → 0.9.1

data/lib/mongoid/orderable.rb

@@ -13,7 +13,7 @@ module Mongoid::Orderable
       }
 
       configuration.update options if options.is_a?(Hash)
-      field configuration[:column], type: Integer
+      field configuration[:column], :type => Integer
       index configuration[:column]
 
       configuration[:scope] = "#{configuration[:scope]}_id".to_sym if configuration[:scope].is_a?(Symbol) && configuration[:scope].to_s !~ /_id$/
@@ -36,128 +36,124 @@ module Mongoid::Orderable
     end
   end
 
-  module InstanceMethods
+  def move_to! target_position
+    @move_to = target_position
+    save
+  end
+  alias_method :insert_at!, :move_to!
 
-    def move_to! target_position
-      @move_to = target_position
-      save
-    end
-    alias_method :insert_at!, :move_to!
+  def move_to target_position
+    @move_to = target_position
+  end
+  alias_method :insert_at, :move_to
 
-    def move_to target_position
-      @move_to = target_position
-    end
-    alias_method :insert_at, :move_to
+  def move_to= target_position
+    @move_to = target_position
+  end
+  alias_method :insert_at=, :move_to=
 
-    def move_to= target_position
-      @move_to = target_position
+  [:top, :bottom].each do |symbol|
+    define_method "move_to_#{symbol}" do
+      move_to symbol
     end
-    alias_method :insert_at=, :move_to=
 
-    [:top, :bottom].each do |symbol|
-      define_method "move_to_#{symbol}" do
-        move_to symbol
-      end
-
-      define_method "move_to_#{symbol}!" do
-        move_to! symbol
-      end
+    define_method "move_to_#{symbol}!" do
+      move_to! symbol
     end
+  end
 
-    [:higher, :lower].each do |symbol|
-      define_method "move_#{symbol}" do
-        move_to symbol
-      end
-
-      define_method "move_#{symbol}!" do
-        move_to! symbol
-      end
+  [:higher, :lower].each do |symbol|
+    define_method "move_#{symbol}" do
+      move_to symbol
     end
 
-    def first?
-      in_list? && orderable_position == 1
+    define_method "move_#{symbol}!" do
+      move_to! symbol
     end
+  end
 
-    def last?
-      in_list? && orderable_position == bottom_orderable_position
-    end
+  def first?
+    in_list? && orderable_position == 1
+  end
 
-    def in_list?
-      !orderable_position.nil?
-    end
+  def last?
+    in_list? && orderable_position == bottom_orderable_position
+  end
 
-    def add_to_list
-      apply_position @move_to
-    end
+  def in_list?
+    !orderable_position.nil?
+  end
 
-    def remove_from_list
-      orderable_scoped.where(orderable_column.gt => orderable_position).inc(orderable_column => -1)
-    end
+  def add_to_list
+    apply_position @move_to
+  end
 
-  private
+  def remove_from_list
+    orderable_scoped.where(orderable_column.gt => orderable_position).inc(orderable_column => -1)
+  end
 
-    def orderable_position
-      send orderable_column
-    end
+private
 
-    def orderable_position= value
-      send "#{orderable_column}=", value
-    end
+  def orderable_position
+    send orderable_column
+  end
 
-    def orderable_scoped
-      if embedded?
-        send(metadata.inverse).send(metadata.name).orderable_scope(self)
-      else
-        self.class.orderable_scope(self)
-      end
-    end
+  def orderable_position= value
+    send "#{orderable_column}=", value
+  end
 
-    def orderable_scope_changed?
-      !orderable_scoped.where(:_id => _id).exists?
+  def orderable_scoped
+    if embedded?
+      send(metadata.inverse).send(metadata.name).orderable_scope(self)
+    else
+      self.class.orderable_scope(self)
     end
+  end
 
-    def apply_position target_position
-      if persisted? && !embedded? && orderable_scope_changed?
-        self.class.find(_id).remove_from_list
-        self.orderable_position = nil
-      end
-        
-      return if !target_position && in_list?
+  def orderable_scope_changed?
+    !orderable_scoped.where(:_id => _id).exists?
+  end
 
-      target_position = target_position_to_position target_position
+  def apply_position target_position
+    if persisted? && !embedded? && orderable_scope_changed?
+      self.class.find(_id).remove_from_list
+      self.orderable_position = nil
+    end
 
-      unless in_list?
-        orderable_scoped.where(orderable_column.gte => target_position).inc(orderable_column => 1)
-      else
-        orderable_scoped.where(orderable_column.gte => target_position, orderable_column.lt => orderable_position).inc(orderable_column => 1) if target_position < orderable_position
-        orderable_scoped.where(orderable_column.gt => orderable_position, orderable_column.lte => target_position).inc(orderable_column => -1) if target_position > orderable_position
-      end
+    return if !target_position && in_list?
 
-      self.orderable_position = target_position
+    target_position = target_position_to_position target_position
+
+    unless in_list?
+      orderable_scoped.where(orderable_column.gte => target_position).inc(orderable_column => 1)
+    else
+      orderable_scoped.where(orderable_column.gte => target_position, orderable_column.lt => orderable_position).inc(orderable_column => 1) if target_position < orderable_position
+      orderable_scoped.where(orderable_column.gt => orderable_position, orderable_column.lte => target_position).inc(orderable_column => -1) if target_position > orderable_position
     end
 
-    def target_position_to_position target_position
-      target_position = :bottom unless target_position
+    self.orderable_position = target_position
+  end
+
+  def target_position_to_position target_position
+    target_position = :bottom unless target_position
 
-      target_position = case target_position.to_sym
-        when :top then 1
-        when :bottom then bottom_orderable_position
-        when :higher then orderable_position.pred
-        when :lower then orderable_position.next
-      end unless target_position.is_a? Numeric
+    target_position = case target_position.to_sym
+      when :top then 1
+      when :bottom then bottom_orderable_position
+      when :higher then orderable_position.pred
+      when :lower then orderable_position.next
+    end unless target_position.is_a? Numeric
 
-      target_position = 1 if target_position < 1
-      target_position = bottom_orderable_position if target_position > bottom_orderable_position
-      target_position
-    end
+    target_position = 1 if target_position < 1
+    target_position = bottom_orderable_position if target_position > bottom_orderable_position
+    target_position
+  end
 
-    def bottom_orderable_position
-      @bottom_orderable_position = begin
-        max = orderable_scoped.max(orderable_column).to_i
-        in_list? ? max : max.next
-      end
+  def bottom_orderable_position
+    @bottom_orderable_position = begin
+      max = orderable_scoped.max(orderable_column).to_i
+      in_list? ? max : max.next
     end
-
   end
 
 end

data/lib/mongoid_orderable/version.rb

@@ -1,3 +1,3 @@
 module MongoidOrderable
-  VERSION = "0.9.0"
+  VERSION = "0.9.1"
 end

data/spec/mongoid/orderable_spec.rb

@@ -36,6 +36,12 @@ describe Mongoid::Orderable do
     embedded_in :embeds_orderable
   end
 
+  class CustomizedOrderable
+    include Mongoid::Document
+    include Mongoid::Orderable
+
+    orderable :column => :pos
+  end
 
   describe SimpleOrderable do
     before :each do
@@ -251,4 +257,14 @@ describe Mongoid::Orderable do
 
   end
 
+  describe CustomizedOrderable do
+    it 'does not have default position field' do
+      CustomizedOrderable.fields.should_not have_key('position')
+    end
+
+    it 'should have custom pos field' do
+      CustomizedOrderable.fields.should have_key('pos')
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_orderable
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-23 00:00:00.000000000Z
+date: 2012-02-03 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &21250020 !ruby/object:Gem::Requirement
+  requirement: &69828211577180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *21250020
+  version_requirements: *69828211577180
 - !ruby/object:Gem::Dependency
   name: mongoid
-  requirement: &21298420 !ruby/object:Gem::Requirement
+  requirement: &69828211576700 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *21298420
+  version_requirements: *69828211576700
 description: Gem allows mongoid model behave as orderable list
 email:
 - kinwizard@gmail.com
@@ -75,7 +75,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: mongoid_orderable
-rubygems_version: 1.8.6
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Acts as list mongoid implementation