mongoid_money_field 3.2.1 → 4.0.0

data/spec/money_spec.rb

@@ -6,7 +6,7 @@ describe Mongoid::MoneyField do
 
   describe 'when money field is required' do
     it 'should be valid to save when field is filled in' do
-      dummy = DummyMoneyRequired.new
+      dummy       = DummyMoneyRequired.new
       dummy.price = '$10'
       dummy.should be_valid
       dummy.save.should eq true
@@ -19,19 +19,11 @@ describe Mongoid::MoneyField do
       dummy.errors.messages[:price][0].should eq "can't be blank"
       dummy.save.should eq false
     end
-
-    it 'should be valid to save when field is filled in but currency is not' do
-      dummy = DummyMoneyRequired.new
-      dummy.price_cents = 123
-      dummy.should be_valid
-      dummy.save.should eq true
-      dummy.price_currency.should eq Money.default_currency.iso_code
-    end
   end
 
   describe 'when value is filled from code' do
     it 'should raise the error when value consists non digits' do
-      dummy = DummyNotANumber.new
+      dummy       = DummyNotANumber.new
       dummy.price = 'incorrect1'
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
@@ -40,7 +32,7 @@ describe Mongoid::MoneyField do
     end
 
     it 'should raise the error when value consists more then one decimal separator' do
-      dummy = DummyNotANumber.new
+      dummy       = DummyNotANumber.new
       dummy.price = '121,212,22'
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
@@ -57,7 +49,7 @@ describe Mongoid::MoneyField do
     end
 
     it 'should raise the error when value is not present' do
-      dummy = DummyNotANumber.new( price: '' )
+      dummy = DummyNotANumber.new(price: '')
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
       dummy.errors.messages[:price][0].should eq "is not a number"
@@ -67,8 +59,8 @@ describe Mongoid::MoneyField do
 
   describe 'when value is filled from SimpleForm' do
     it 'should raise the error when value consists non digits' do
-      dummy = DummyNotANumber.new
-      dummy.price_plain = 'incorrect1'
+      dummy       = DummyNotANumber.new
+      dummy.price = 'incorrect1'
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
       dummy.errors.messages[:price][0].should eq "is not a number"
@@ -76,8 +68,8 @@ describe Mongoid::MoneyField do
     end
 
     it 'should raise the error when value consists more then one decimal separator' do
-      dummy = DummyNotANumber.new
-      dummy.price_plain = '121,212,22'
+      dummy       = DummyNotANumber.new
+      dummy.price = '121,212,22'
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
       dummy.errors.messages[:price][0].should eq "is not a number"
@@ -87,7 +79,7 @@ describe Mongoid::MoneyField do
 
   describe 'when value should be a positive number' do
     it 'should raise the error when value lesser than 1' do
-      dummy = DummyPositiveNumber.new( price: '-10' )
+      dummy = DummyPositiveNumber.new(price: '-10')
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
       dummy.errors.messages[:price][0].should eq "must be greater than 1"
@@ -96,7 +88,15 @@ describe Mongoid::MoneyField do
     end
 
     it 'should raise the error when value lesser than 1' do
-      dummy = DummyPositiveNumber.new( price: '0' )
+      dummy = DummyPositiveNumber.new(price: '-1000')
+      dummy.should_not be_valid
+      dummy.errors.count.should eq 1
+      dummy.errors.messages[:price][0].should eq "must be greater than 1"
+      dummy.save.should eq false
+    end
+
+    it 'should raise the error when value lesser than 1' do
+      dummy = DummyPositiveNumber.new(price: '0')
       dummy.should_not be_valid
       dummy.errors.count.should eq 1
       dummy.errors.messages[:price][0].should eq "must be greater than 1"
@@ -104,13 +104,19 @@ describe Mongoid::MoneyField do
     end
 
     it 'should be ok when value is greater than 1' do
-      dummy = DummyPositiveNumber.new( price: '10' )
+      dummy = DummyPositiveNumber.new(price: '10')
+      dummy.should be_valid
+      dummy.save.should eq true
+    end
+
+    it 'should be ok when value is greater than 1' do
+      dummy = DummyPositiveNumber.new(price: '1000')
       dummy.should be_valid
       dummy.save.should eq true
     end
 
     it 'should be ok when value is not present' do
-      dummy = DummyPositiveNumber.new( price: '' )
+      dummy = DummyPositiveNumber.new(price: '')
       dummy.should be_valid
       dummy.save.should eq true
     end
@@ -133,25 +139,25 @@ describe Mongoid::MoneyField do
 
   describe 'when persisting a document with a Money datatype' do
     it 'should be persisted normally when set as dollars' do
-      dummy = DummyMoney.new
+      dummy       = DummyMoney.new
       dummy.price = '$10'
       dummy.save.should eq true
     end
-    
+
     it 'should be persisted normally when set as cents' do
-      dummy = DummyMoney.new
+      dummy       = DummyMoney.new
       dummy.price = '$9.99'
       dummy.save.should eq true
     end
-    
+
     it 'should be persisted normally when set as Money' do
-      dummy = DummyMoney.new
+      dummy       = DummyMoney.new
       dummy.price = Money.parse(1.23)
       dummy.save.should eq true
     end
 
     it 'should be possible to set value to nil' do
-      dummy = DummyMoney.new
+      dummy       = DummyMoney.new
       dummy.price = Money.parse(1.23)
       dummy.save.should eq true
 
@@ -163,50 +169,50 @@ describe Mongoid::MoneyField do
       dummy.price.should be_nil
     end
   end
-  
+
   describe 'when accessing a document from the datastore with a Money datatype' do
     before(:each) do
       DummyMoney.create(:description => "Test", :price => '9.99')
     end
-    
+
     it 'should have a Money value that matches the money value that was initially persisted' do
       dummy = DummyMoney.first
       dummy.price.should eq Money.parse('9.99')
     end
   end
-  
+
   describe 'when accessing a document from the datastore with a Money datatype set as money' do
     before(:each) do
-      dm = DummyMoney.create(:description => "Test")
+      dm       = DummyMoney.create(:description => "Test")
       dm.price = Money.parse('1.23')
       dm.save!
     end
-    
+
     it 'should have a Money value that matches the money value that was initially persisted' do
       dummy = DummyMoney.first
       dummy.price.cents.should eq 123
     end
   end
-  
+
   describe 'when accessing a document from the datastore with a Money datatype set as money with mass asignment' do
     before(:each) do
       DummyMoney.create(:description => "Test", :price => Money.parse('1.23'))
     end
-    
+
     it 'should have a Money value that matches the money value that was initially persisted' do
       dummy = DummyMoney.first
       dummy.price.cents.should eq 123
     end
   end
-  
+
   describe 'when accessing a document from the datastore with a Money datatype and empty value' do
     it 'should be nil' do
       dummy = DummyMoneyWithoutDefault.new
       dummy.save.should eq true
       DummyMoneyWithoutDefault.first.price.should be_nil
     end
-    
-      it 'should be 0 when used with default' do
+
+    it 'should be 0 when used with default' do
       dummy = DummyMoney.new
       dummy.save.should eq true
       DummyMoney.first.price.cents.should eq 0
@@ -226,7 +232,7 @@ describe Mongoid::MoneyField do
       dummy = DummyPrices.first
       dummy.price.currency.iso_code.should eq Money.default_currency.iso_code
       dummy.price.cents.should eq 100
-      
+
       dummy.price2.should be_nil
 
       dummy.price1.cents.should eq 0
@@ -277,17 +283,25 @@ describe Mongoid::MoneyField do
       dummy.price.should eq Money.parse('1.23 USD')
     end
   end
-  
+
   describe 'when accessing a document from the datastore with a Money datatype and blank value' do
     before(:each) do
       DummyMoney.create(description: "Test", price: '')
     end
-    
+
     it 'should be nil' do
       dummy = DummyMoney.first
       dummy.price.should be_nil
     end
 
+    it 'stays nil' do
+      dummy = DummyMoney.first
+      dummy.price = ''
+      dummy.price.should be_nil
+      dummy.save.should be_true
+      DummyMoney.first.price.should be_nil
+    end
+
     it 'should be updated correctly' do
       dummy = DummyMoney.first
       dummy.price.should be_nil
@@ -298,7 +312,7 @@ describe Mongoid::MoneyField do
       dummy.price.cents.should eq 123
     end
   end
-  
+
   describe 'when accessing a document from the datastore with embedded documents with money fields' do
     before(:each) do
       o = DummyOrder.new(first_name: 'test')
@@ -306,26 +320,26 @@ describe Mongoid::MoneyField do
       o.dummy_line_items << DummyLineItem.new({name: 'item 1', price: Money.new(1299)})
       li = DummyLineItem.new({name: 'item 2', price: Money.new(1499)})
       o.dummy_line_items.push li
-      
+
       o.save
     end
-    
+
     it 'should have correct value for first item' do
       o = DummyOrder.first
       o.dummy_line_items.first.price.should eq Money.parse('12.99')
     end
-    
+
     it 'should have correct value for first item' do
       o = DummyOrder.first
       o.dummy_line_items.last.price.should eq Money.parse('14.99')
-    end    
+    end
   end
-  
+
   describe 'when accessing a document from the datastore with multiple Money datatypes' do
     before(:each) do
       DummyPrices.create(description: "Test", price3: '1', price1: '1.23', price2: '2.33')
     end
-    
+
     it 'should have correct Money value for field 1' do
       dummy = DummyPrices.first
       dummy.price1.should eq Money.parse('1.23')

data/spec/ruby_money_spec.rb

@@ -0,0 +1,62 @@
+# coding: utf-8
+
+require 'spec_helper'
+
+# from https://github.com/RubyMoney/money-rails/blob/master/spec/mongoid/three_spec.rb
+
+describe Money do
+  let!(:priceable) { Priceable.create(:price => Money.new(100, 'EUR')) }
+  let!(:priceable_from_num) { Priceable.create(:price => 1) }
+  let!(:priceable_from_string) { Priceable.create(:price => '1 EUR' )}
+  let!(:priceable_from_hash) { Priceable.create(:price => {:cents=>100, :currency_iso=>"EUR"} )}
+  let!(:priceable_from_hash_with_indifferent_access) {
+    Priceable.create(:price => {:cents=>100, :currency_iso=>"EUR"}.with_indifferent_access)
+  }
+
+  context "mongoize" do
+    it "mongoizes correctly a Money object to a hash of cents and currency" do
+      priceable.price.cents.should == 100
+      priceable.price.currency.should == Money::Currency.find('EUR')
+    end
+
+    it "mongoizes correctly a Numeric object to a hash of cents and currency" do
+      priceable_from_num.price.cents.should == 100
+      priceable_from_num.price.currency.should == Money.default_currency
+    end
+
+    it "mongoizes correctly a String object to a hash of cents and currency" do
+      priceable_from_string.price.cents.should == 100
+      priceable_from_string.price.currency.should == Money::Currency.find('EUR')
+    end
+
+    it "mongoizes correctly a hash of cents and currency" do
+      priceable_from_hash.price.cents.should == 100
+      priceable_from_hash.price.currency.should == Money::Currency.find('EUR')
+    end
+
+    it "mongoizes correctly a HashWithIndifferentAccess of cents and currency" do
+      priceable_from_hash_with_indifferent_access.price.cents.should == 100
+      priceable_from_hash_with_indifferent_access.price.currency.should == Money::Currency.find('EUR')
+    end
+  end
+
+  context "demongoize" do
+    subject { Priceable.first.price }
+    it { should be_an_instance_of(Money) }
+    it { should == Money.new(100, 'EUR') }
+    it "returns nil if a nil value was stored" do
+      nil_priceable = Priceable.create(:price => nil)
+      nil_priceable.price.should be_nil
+    end
+    it 'returns nil if an unknown value was stored' do
+      zero_priceable = Priceable.create(:price => [])
+      zero_priceable.price.should be_nil
+    end
+  end
+
+  context "evolve" do
+    it "transforms correctly a Money object to a Mongo friendly value" do
+      Priceable.where(:price => Money.new(100, 'EUR')).first.should == priceable
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,15 +1,17 @@
 # coding: utf-8
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-require 'rspec'
-require 'simplecov'
-require 'mongoid'
 
-require 'database_cleaner'
+require 'rubygems'
 
+require 'simplecov'
 SimpleCov.start
 
+require 'bundler/setup'
+require 'mongoid'
+require 'database_cleaner'
+require 'mongoid-rspec'
+
 require 'mongoid_money_field'
 
 Money.default_currency = Money::Currency.new("RUB")
@@ -18,32 +20,29 @@ Money.default_currency = Money::Currency.new("RUB")
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
+ENV["MONGOID_ENV"] = "test"
+Mongoid.load!("spec/support/mongoid.yml")
+
 def mongoid3?
   defined?(Mongoid::VERSION) && Gem::Version.new(Mongoid::VERSION) >= Gem::Version.new('3.0.0.rc')
 end
 
 Mongoid.configure do |config|
   if mongoid3?
-    config.sessions[:default] = { :database => 'mongoid_money_field_test', :hosts => ['localhost:27017'] }
+    ENV["MONGOID_ENV"] = "test"
+    Mongoid.load!("spec/support/mongoid.yml")
   else
     config.master = Mongo::Connection.new.db('mongoid_money_field_test')
   end
 end
 
-DatabaseCleaner.orm = "mongoid"
-
 RSpec.configure do |config|
-  config.before(:all) do
+  config.before :suite do
     DatabaseCleaner.strategy = :truncation
   end
-
-  config.before(:each) do
-    DatabaseCleaner.start
-  end
-
-  config.after(:each) do
+  config.after :each do
     DatabaseCleaner.clean
   end
-
+  config.include Mongoid::Matchers
   config.mock_with :rspec
 end

data/spec/support/money3.rb

@@ -0,0 +1,30 @@
+class Money3
+  include Mongoid::Document
+  store_in collection: 'compat3'
+
+  include Mongoid::MoneyField
+
+  field :description
+
+  field :price_currency, type: String
+  field :price_cents, type: Integer
+
+  field :price_no_default_currency, type: String
+  field :price_no_default_cents, type: Integer
+
+  field :price_with_fix_currency, type: String
+  field :price_with_fix_cents, type: Integer
+end
+
+class Money3Compat
+  include Mongoid::Document
+  store_in collection: 'compat3'
+
+  include Mongoid::MoneyField
+
+  field :description
+
+  money_field :price, default: 0
+  money_field :price_no_default
+  money_field :price_with_fix, fixed_currency: 'GBP'
+end

data/spec/support/mongoid.yml

@@ -0,0 +1,8 @@
+test:
+  sessions:
+    default:
+      database: mongoid_money_field
+      hosts:
+        - localhost:27017
+      options:
+        consistency: :strong