mongoid_listable 0.0.2 → 0.0.3

data/README.md

@@ -8,7 +8,7 @@ relation.
 
     class User
       include Mongoid::Document
-      include Mongoid:Listable
+      include Mongoid:Lists
     
       has_many :photos
       

data/lib/mongoid/lists.rb

@@ -6,12 +6,6 @@ module Mongoid
 
     extend ActiveSupport::Concern
 
-    FIELD_SUFFIX = '_position'    
-
-    include do 
-      after_add 
-    end
-
     module ClassMethods
 
       # Macro to set relation on which to make a list
@@ -24,29 +18,34 @@ module Mongoid
       # @since 0.0.1
       def lists relation, options={}
         meta       = reflect_on_association relation
-        field_name = options[:column] || (meta.foreign_key.to_s.gsub(/_?id$/, FIELD_SUFFIX)).to_sym
-        klass      = meta.klass        
+        field_name = options[:column] || 
+          (meta.foreign_key.to_s.gsub(/_?id$/, '_position')).to_sym
+        
 
-        ids_setter_name = "#{relation.to_s.singularize}_ids="
-        ids_setter      = instance_method ids_setter_name
-        re_define_method ids_setter_name do |ids|
-          # assign new position int
+        # Override model#{name}_ids=        
+        before_method self, "#{relation.to_s.singularize}_ids=" do |ids|
           ids.each_with_index do |id, index|
-            klass.find(id).update_attribute field_name, index + 1
+            meta.klass.find(id).update_attribute field_name, index + 1
           end
 
-          # unassign old position ints
-          klass.where(meta.foreign_key => id).not_in(id: ids).each do |obj|
+          meta.klass.where(meta.foreign_key => id).not_in(id: ids).each do |obj|
             obj.update_attribute field_name, nil
           end
-
-          # invoke original method
-          ids_setter.bind(self).call(ids)
         end
 
         meta[:order] = "#{field_name} asc"
       end
 
+      private
+
+      def before_method owner, method, &block
+        original_method = instance_method method
+        owner.re_define_method method do |*args|
+          block.call *args
+          original_method.bind(self).call *args
+        end
+      end
+
     end
 
   end

data/mongoid_listable.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'mongoid_listable'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = [ 'richardcalahan' ]
   spec.email         = [ 'richard@calahan.me' ]
   spec.description   = ''

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_listable
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-03 00:00:00.000000000 Z
+date: 2013-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid