mongoid_atomic_votes 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c011039cca7f56e8f6da3de59f97510592784434
-  data.tar.gz: 6724540bc0728cc2da34b6b450f0ee3fa8e91653
+  metadata.gz: 1471df3a89ef9456b35bc2e078fb8b73d0fc89a9
+  data.tar.gz: 561f2eac6abec232a1966ee23181bbb09b290325
 SHA512:
-  metadata.gz: 27e37c374f7b11244dae7a7e77bcc1700204db22ac6257d6831f5a296c9ceb82381b3605af14f689effa3b19e90f8e14d29627b5f7a9fc882d3ecac5e2499027
-  data.tar.gz: 11d7461bfec82ae8d1b19a76dff29cc5c54660f24ca793999b0d0ee955a87e9c092aa22824cdb6409b8afeef2aefe277907adc44547fe046b165e42eb2975879
+  metadata.gz: 3583b0c8a866dab57c14cfeef6e98555d7ceab20779e83d89e7722be0e076607ae13d8d0b2ba0a787866e33131892d608792366504bc12fffce836e1ac8da472
+  data.tar.gz: 0151bda82246b40cb8bc37e62fda203d66b2c95a9dcd1fee9f4bd34688e6d2495ba30c30efe3347d9cc4870316745cfd699c92469bf3a5a63b18cb49f7670c25

data/Gemfile

@@ -8,4 +8,5 @@ group :test do
   gem 'factory_girl'
   gem 'simplecov'
   gem 'database_cleaner'
+  gem 'pry'
 end

data/lib/mongoid_atomic_votes/atomic_votes.rb

@@ -15,8 +15,8 @@ module Mongoid
       end
 
       def define_scopes(base)
-        base.scope :not_voted, base.where(:vote_value.exists => false)
-        base.scope :voted, base.where(:vote_value.exists => true)
+        base.scope :not_voted, -> { base.where(:vote_value.exists => false) }
+        base.scope :voted, -> { base.where(:vote_value.exists => true) }
         base.scope :voted_by, ->(resource) do
           base.where('votes.voted_by_id' => resource.id, 'votes.voter_type' => resource.class.name)
         end
@@ -69,7 +69,7 @@ module Mongoid
         opts['$push'] = {votes: mark.as_json}
       end
 
-      self.collection.find(_id: self.id).update(opts).nil?
+      self.collection.find(_id: self.id).update(opts)['ok'] > 0
     end
 
     def update_vote_value(mark, retract=false)

data/lib/mongoid_atomic_votes/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module AtomicVotes
-    VERSION = "0.1.1"
+    VERSION = "0.2.0"
   end
 end

data/lib/mongoid_atomic_votes/vote.rb

@@ -5,7 +5,7 @@ class Mongoid::AtomicVotes::Vote
   embedded_in :atomic_voteable, polymorphic: true
 
   field :value,       type: Integer
-  field :voted_by_id, type: Moped::BSON::ObjectId
+  field :voted_by_id, type: BSON::ObjectId
   field :voter_type,  type: String
 
   validates_presence_of  :value, :voted_by_id, :voter_type

data/mongoid_atomic_votes.gemspec

@@ -14,5 +14,5 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = Mongoid::AtomicVotes::VERSION
 
-  gem.add_runtime_dependency 'mongoid', ['>= 3.0']
+  gem.add_runtime_dependency 'mongoid', ['>= 4.0']
 end

data/spec/atomic_votes_spec.rb

@@ -1,3 +1,4 @@
+require 'pry'
 require 'spec_helper'
 
 describe Post do
@@ -7,73 +8,79 @@ describe Post do
   end
 
   it "has Mongoid::AtomicVotes module" do
-    subject.class.ancestors.include?(Mongoid::AtomicVotes).should be_true
+    expect(subject.class.ancestors).to include(Mongoid::AtomicVotes)
   end
 
-  it { should respond_to :vote }
-  it { should respond_to :retract }
-  it { should respond_to :has_votes? }
-  it { should respond_to :vote_count }
-  it { should respond_to :vote_value }
-  it { should respond_to :votes }
+  it { expect(subject).to respond_to(:vote) }
+  it { expect(subject).to respond_to(:retract) }
+  it { expect(subject).to respond_to(:has_votes?) }
+  it { expect(subject).to respond_to(:vote_count) }
+  it { expect(subject).to respond_to(:vote_value) }
+  it { expect(subject).to respond_to(:votes) }
 
-  it { subject.class.respond_to?(:set_vote_range).should be_true }
-  it { ->{subject.class.set_vote_range(1)}.should raise_exception }
+  it { expect(subject.class).to respond_to(:set_vote_range) }
+  it { expect { subject.class.set_vote_range(1) }.to raise_exception }
 
   describe '#votes' do
     it 'is array of votes' do
-      @post.votes.should be_an_instance_of Array
+      expect(@post.votes).to be_an_instance_of(Array)
     end
   end
 
   describe 'when does not have votes' do
     it 'is in not_voted scope' do
-      subject.class.not_voted.include?(@post).should be_true
+      expect(subject.class.not_voted).to include(@post)
     end
 
     it 'is not in voted scope' do
-      subject.class.voted.include?(@post).should be_false
+      expect(subject.class.voted).not_to include(@post)
     end
 
     it 'is not in voted_by scope' do
       @users.each do |u|
-        subject.class.voted_by(u).include?(@post).should be_false
+        expect(subject.class.voted_by(u)).not_to include(@post)
       end
     end
 
     it '#vote_count returns 0' do
-      @post.vote_count.should == 0
+      expect(@post.vote_count).to eq(0)
     end
 
     it '#vote_value returns nil' do
-      @post.vote_value.should be_nil
+      expect(@post.vote_value).to be_nil
     end
 
     it '#votes returns empty array' do
-      @post.votes.should == []
+      expect(@post.votes).to eq([])
     end
 
     it '#has_votes? returns false' do
-      @post.vote_count.should == 0
-      @post.has_votes?.should be_false
+      expect(@post.vote_count).to eq(0)
+      expect(@post.has_votes?).to be_falsey
     end
 
     it '#voted_by? returns false with any resource' do
-      @users.each{|u| @post.voted_by?(u).should be_false}
+      @users.each do |u|
+        expect(@post.voted_by?(u)).to be_falsey
+      end
     end
 
     it '#vote returns true on successful vote' do
-      @users.each{|u| @post.vote(rand(1..10), u).should be_true}
+      @users.each do |u|
+        expect(@post.vote(rand(1..10), u)).to be_truthy
+      end
 
       vote_value = @post.votes.map(&:value).sum.to_f/@post.votes.size
       
-      @post.vote_value.should == vote_value
-      @post.vote_count.should == @users.size
-      @post.votes.size.should == @users.size
-
-      Post.find(@post.id).vote_value.should == vote_value
-      Post.find(@post.id).vote_count.should == @users.size
-      Post.find(@post.id).votes.size.should == @users.size
+      expect(@post.vote_value).to eq(vote_value)
+      expect(@post.vote_count).to eq(@users.size)
+      expect(@post.votes.size).to eq(@users.size)
+
+      Post.find(@post.id).tap do |post|
+        expect(post.vote_value).to eq(vote_value)
+        expect(post.vote_count).to eq(@users.size)
+        expect(post.votes.size).to eq(@users.size)
+      end
     end
   end
 
@@ -83,59 +90,63 @@ describe Post do
     end
 
     it 'is not in the not_voted scope' do
-      subject.class.not_voted.include?(@post).should be_false
+      expect(subject.class.not_voted).not_to include(@post)
     end
 
     it 'is in voted scope' do
-      subject.class.voted.include?(@post).should be_true
+      expect(subject.class.voted).to include(@post)
     end
 
     it 'is in voted_by scope for each voted user' do
-      @users.each{|u| subject.class.voted_by(u).include?(@post).should be_true}
+      @users.each do |u|
+        expect(subject.class.voted_by(u)).to include(@post)
+      end
     end
 
     it '#vote_count returns count of votes' do
-      @post.vote_count.should eq(@post.votes.size)
+      expect(@post.vote_count).to eq(@post.votes.size)
     end
 
     it '#vote_value returns actual vote value' do
       vote_value = @post.votes.map(&:value).sum.to_f/@post.votes.size
-      @post.vote_value.should eq(vote_value)
+      expect(@post.vote_value).to eq(vote_value)
     end
 
     it '#votes returns array of vote marks' do
       @post.votes.tap do |votes|
-        votes.class.should == Array
-        votes.empty?.should be_false
-        votes.size.should == @users.size
-        votes.map(&:voted_by_id).sort.should == @users.map(&:id).sort
+        expect(votes.class).to eq(Array)
+        expect(votes).not_to be_empty
+        expect(votes.size).to eq(@users.size)
+        expect(votes.map(&:voted_by_id).sort).to eq(@users.map(&:id).sort)
       end
     end
 
     it '#has_votes? returns true' do
-      @post.vote_count.should == @post.votes.size
-      @post.has_votes?.should be_true
+      expect(@post.vote_count).to eq(@post.votes.size)
+      expect(@post.has_votes?).to be_truthy
     end
 
     it '#voted_by? returns true for all voted resource' do
-      @users.each{|u| @post.voted_by?(u).should be_true}
+      @users.each do |u|
+        expect(@post.voted_by?(u)).to be_truthy
+      end
     end
 
     it '#retract returns true on successful vote retract' do
       cnt = @users.size
 
       @users.each do |u|
-        @post.retract(u).should be_true
+        expect(@post.retract(u)).to be_truthy
         cnt -= 1
 
         vote_value = @post.votes.size == 0 ? nil : @post.votes.map(&:value).sum.to_f/@post.votes.size
 
-        @post.vote_value.should == vote_value
-        @post.vote_count.should == @post.votes.size
-        @post.vote_count.should == cnt
+        expect(@post.vote_value).to eq(vote_value)
+        expect(@post.vote_count).to eq(@post.votes.size)
+        expect(@post.vote_count).to eq(cnt)
 
-        Post.find(@post.id).vote_value.should == vote_value
-        Post.find(@post.id).vote_count.should == cnt
+        expect(Post.find(@post.id).vote_value).to eq(vote_value)
+        expect(Post.find(@post.id).vote_count).to eq(cnt)
         Post.find(@post.id).votes.size == cnt
       end
     end
@@ -148,13 +159,13 @@ describe Post do
     end
 
     it 'Vote has vote_range set up' do
-      Mongoid::AtomicVotes::Vote.vote_range.should == (1..5)
+      expect(Mongoid::AtomicVotes::Vote.vote_range).to eq((1..5))
     end
 
     it 'Vote is not valid if its value is not in specified vote_range' do
       @vote = Mongoid::AtomicVotes::Vote.new(value: rand(6..10), voted_by_id: @users.first.id, voter_type: @users.first.class.name)
-      @vote.should_not be_valid
-      @vote.errors.messages[:value].first.should =~ /included in the list/
+      expect(@vote).not_to be_valid
+      expect(@vote.errors.messages[:value].first).to match(/included in the list/)
     end
   end
 end

metadata

@@ -1,38 +1,38 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_atomic_votes
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Hck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-23 00:00:00.000000000 Z
+date: 2014-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mongoid
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '4.0'
 description: Atomic votes for mongoid models
 email: 
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -56,17 +56,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Atomic votes implementation for mongoid