mongoid_acts_as_list 0.0.3 → 0.0.4

data/.gitignore

@@ -3,3 +3,4 @@
 Gemfile.lock
 pkg/*
 tags
+coverage/*

data/.travis.yml

@@ -0,0 +1,2 @@
+rvm:
+  - 1.9.3

data/README.markdown

@@ -5,6 +5,8 @@ ActsAsList for Mongoid
 
 Mongoid::ActsAsList provides the ability of ordering and sorting a number of objects in a list using Mongoid as an ODM.
 
+[![Build Status](https://secure.travis-ci.org/olivoil/mongoid_acts_as_list.png)](http://travis-ci.org/olivoil/mongoid_acts_as_list)
+[![Dependency Status](https://gemnasium.com/olivoil/mongoid_acts_as_list.png)](https://gemnasium.com/olivoil/mongoid_acts_as_list)
 
 ## Install
 
@@ -17,7 +19,7 @@ gem 'mongoid_acts_as_list', '~> 0.0.3'
 Then run `bundle install`
 
 
-## Configuration
+## Configure
 
 Configure defaults values used by ActsAsList:
 
@@ -35,7 +37,7 @@ end
 
 Make sure it is loaded before calling ` acts_as_list `. You can place this code in an initializer file for example.
 
-## Usage
+## Use
 
 Activate ActsAsList in your models.
 
@@ -75,6 +77,10 @@ class Item
 end
 ```
 
+The public API is composed of the following methods.
+All of the API from the original ActiveRecord ActsAsList gem is also available.
+Check the source and [documentation](http://rubydoc.info/github/olivoil/mongoid_acts_as_list/master/frames) to find out more!
+
 
 ``` ruby
 ## Class Methods
@@ -83,7 +89,7 @@ list.items.order_by_position #=> returns all items in `list` ordered by position
 
 ## Instance Methods
 
-item.move to: 2              #=> moves item to the 2nd position
+item.move to: 2              #=> moves item to position number 2
 item.move to: :start         #=> moves item to the first position in the list
 item.move to: :end           #=> moves item to the last position in the list
 item.move before: other_item #=> moves item before other_item
@@ -104,8 +110,6 @@ item.next_item               #=> returns the item immediately following `item` i
 item.previous_item           #=> returns the item immediately preceding `item` in the list
 ```
 
-Other methods are available, as well as all the methods from the original ActiveRecord ActsAsList gem.
-Check the source and documentation to find out more!
 
 
 ## Requirements
@@ -113,10 +117,6 @@ Check the source and documentation to find out more!
 Tested with Mongoid 2.4.6 on Ruby 1.9.3-p125, Rails 3.2.2, and Mongo 2.x
 
 
-## Roadmap
-
-* Test with several layers of embedding documents
-
 
 ## Contributing
  
@@ -125,10 +125,6 @@ Tested with Mongoid 2.4.6 on Ruby 1.9.3-p125, Rails 3.2.2, and Mongo 2.x
 - Start writing tests
 - Commit and push until all tests are green and you are happy with your contribution
 
-- If you're using Vim, source the .vimrc.local file. It provides 2 shortcuts for running the specs:
-   - `<Leader>r` runs the current spec file
-   - `<Leader>R` runs all spec files
-
 ## Copyright
 
 Copyright (c) 2012 Olivier Melcher, released under the MIT license

data/Rakefile

@@ -1 +1,21 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+require 'rdoc/task'
+
+desc 'Default: run specs.'
+task :default => :spec
+
+desc "Run specs"
+RSpec::Core::RakeTask.new do |t|
+  t.pattern = "./spec/**/*_spec.rb"
+end
+
+desc "Open an irb session preloaded with this library"
+task :irb do
+  sh "irb -rubygems -r ./lib/#{name}.rb"
+end
+
+desc "Open an pry session preloaded with this library"
+task :pry do
+  sh "pry -r ./lib/#{name}.rb"
+end

data/acts_as_list.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.version     = Mongoid::ActsAsList::VERSION
   s.authors     = ["Olivier Melcher"]
   s.email       = ["olivier.melcher@gmail.com"]
-  s.homepage    = ""
+  s.homepage    = "https://github.com/olivoil/mongoid_acts_as_list"
   s.summary     = %q{Implementation of the acts as list gem for Mongoid}
   s.description = %q{}
 
@@ -20,6 +20,8 @@ Gem::Specification.new do |s|
 
   # specify any dependencies here; for example:
   s.add_development_dependency "rspec"
+  s.add_development_dependency "rake"
+  s.add_development_dependency "simplecov"
   s.add_development_dependency "bson_ext", "~> 1.5"
   s.add_development_dependency "database_cleaner"
   s.add_development_dependency "pry"

data/lib/mongoid/acts_as_list/list.rb

@@ -47,7 +47,8 @@ module Mongoid::ActsAsList
 
     # Public: Moves the item to new position in the list
     #
-    # where - a Hash specifying where to move the item
+    # where - a Symbol in [:forward, :lower, :backward, :higher]
+    #         or Hash specifying where to move the item:
     #           :to                - an Integer representing a position number
     #                                or a Symbol from the list :start, :top, :end, :bottom
     #           :before, :above    - another object in the list
@@ -57,7 +58,6 @@ module Mongoid::ActsAsList
     #           :backward, :higher - an Integer specify by how much to move the item forward.
     #                                will stop moving the item when it reaches the end of the list
     #
-    #         or a Symbol in :forward, :lower, :backward, :higher
     #
     # Examples
     #
@@ -97,6 +97,10 @@ module Mongoid::ActsAsList
       end
     end
 
+    # Public: Moves the item to another position
+    #
+    # destination - a Symbol among :start, :end, :top, :bottom
+    #               or an Integer indicating the new position number to move the item to
     def move_to(destination)
       if destination.is_a? Symbol
         send("move_to_#{destination}")
@@ -106,29 +110,40 @@ module Mongoid::ActsAsList
       end
     end
 
+    # Public: Moves the item to the end of the list
     def move_to_end
       new_position = in_list? ? last_position_in_list : next_available_position_in_list
       insert_at new_position
     end
     alias_method :move_to_bottom, :move_to_end
 
+    # Public: Moves the item to the start of the list
     def move_to_start
       insert_at start_position_in_list
     end
     alias_method :move_to_top, :move_to_start
 
+    # Public: Moves the item closer to the end of the list
+    #
+    # by_how_much - The number of position to move the item by (default: 1)
     def move_forwards by_how_much = 1
       move_to(self[position_field] + by_how_much) unless last?
     end
     alias_method :move_lower  , :move_forwards
     alias_method :move_forward, :move_forwards
 
+    # Public: Moves the item closer to the start of the list
+    #
+    # by_how_much - The number of position to move the item by (default: 1)
     def move_backwards by_how_much = 1
       move_to(self[position_field] - by_how_much) unless first?
     end
     alias_method :move_higher , :move_backwards
     alias_method :move_forward, :move_forwards
 
+    # Public: Moves the item before another one in the list
+    #
+    # other_item - another item of the list
     def move_before(other_item)
       destination = other_item[position_field]
       origin = self[position_field]
@@ -141,6 +156,9 @@ module Mongoid::ActsAsList
     end
     alias_method :move_above, :move_before
 
+    # Public: Moves the item after another one in the list
+    #
+    # other_item - another item of the list
     def move_after(other_item)
       destination = other_item[position_field]
       origin = self[position_field]
@@ -210,18 +228,18 @@ module Mongoid::ActsAsList
     end
     alias_method :lower_item, :previous_item
 
-    # Public: Insert at a given position in the list
+  private
+
+    # Internal: Insert at a given position in the list
     #
     # new_position - an Integer indicating the position to insert the item at
     #
-    # Returns nothing
+    # Returns true if the element's position was updated, false if not
     def insert_at(new_position)
       insert_space_at(new_position)
       update_attribute(position_field, new_position)
     end
 
-  private
-
     # Internal: Make space in the list at a given position number
     #   used when moving a item to a new position in the list.
     #
@@ -239,6 +257,14 @@ module Mongoid::ActsAsList
       end
     end
 
+    # Internal: get items of the list between two positions
+    #
+    # from    - an Integer representing the first position number in the range
+    # to      - an Integer representing the last position number in the range
+    # options - an Hash of options
+    #           :strict - a Boolean indicating if the range is inclusing (false) or exclusive (true) (default: true)
+    #
+    # Returns a Mongoid::Criteria containing the items between the range
     def items_between(from, to, options = {})
       strict = options.fetch(:strict, true)
       if strict

data/lib/mongoid/acts_as_list/list/embedded.rb

@@ -1,47 +1,49 @@
 module Mongoid::ActsAsList
-  module List::Embedded
-    extend ActiveSupport::Concern
+  module List
 
-    included do
-      raise List::ScopeMissingError, "Mongoid::ActsAsList::Embedded can only be included in embedded documents" unless embedded?
-    end
+    # Internal: Private methods used specifically for embedded collections
+    #
+    # Gets included when calling List.acts_as_list in an embedded document
+    module Embedded
+      extend ActiveSupport::Concern
 
-    module ClassMethods
-      private
+      included do
+        raise List::ScopeMissingError, "Mongoid::ActsAsList::Embedded can only be included in embedded documents" unless embedded?
+      end
+
+      module ClassMethods
+        private
 
-      def define_position_scope(scope_name)
-        define_method(:scope_condition) { {position_field.ne => nil} }
+        def define_position_scope(scope_name)
+          define_method(:scope_condition) { {position_field.ne => nil} }
+        end
       end
-    end
 
-    ## InstanceMethods
-    private
+      ## InstanceMethods
+      private
 
-    def shift_position options = {}
-      criteria    = options.fetch(:for, to_criteria)
-      by_how_much = options.fetch(:by, 1)
+      def shift_position options = {}
+        criteria    = options.fetch(:for, to_criteria)
+        by_how_much = options.fetch(:by, 1)
 
-      criteria = criteria.to_criteria if criteria.is_a? self.class
+        criteria = criteria.to_criteria if criteria.is_a? self.class
 
-      criteria.each do |doc|
-        doc.inc(position_field, by_how_much)
+        criteria.each do |doc|
+          doc.inc(position_field, by_how_much)
+        end
       end
-    end
 
-    def to_criteria
-      embedded_collection.where(_id: _id)
-    end
-
-    def items_in_list
-      embedded_collection.where(scope_condition)
-    end
+      def to_criteria
+        embedded_collection.where(_id: _id)
+      end
 
-    def root_collection
-      _parent.db.collection(_parent.collection.name)
-    end
+      def items_in_list
+        embedded_collection.where(scope_condition)
+      end
 
-    def embedded_collection
-      _parent.send(metadata.name)
+      def embedded_collection
+        _parent.send(metadata.name)
+      end
     end
   end
 end

data/lib/mongoid/acts_as_list/list/root.rb

@@ -1,5 +1,9 @@
 module Mongoid::ActsAsList
   module List
+
+    # Internal: Private methods used specifically for root collections (in belongs_to associations)
+    #
+    # Gets included when calling List.acts_as_list in a root document
     module Root
       extend ActiveSupport::Concern
 

data/lib/mongoid/acts_as_list/version.rb

@@ -1,5 +1,5 @@
 module Mongoid
   module ActsAsList
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/lib/mongoid_acts_as_list.rb

@@ -5,8 +5,31 @@ require_relative 'mongoid/acts_as_list/version'
 module Mongoid
   module ActsAsList
     class << self
+
+      # Public: the configuration object used by Mongoid::ActsAsList
+      #
+      # Examples
+      #
+      #   Mongoid::ActsAsList.configuration.default_position_field
+      #   #=> :position
+      #
+      # Returns the configuration object
       attr_accessor :configuration
 
+      # Public: set the configuration options for Mongoid::ActsAsList
+      #
+      # yields the configuration object
+      #
+      # Examples
+      #
+      #    Mongoid::ActsAsList.configure do |config|
+      #      # These are the default options.
+      #      # Modify as you see fit:
+      #      config.default_position_field = :position
+      #      config.start_list_at = 0
+      #    end
+      #
+      # Returns the configuration object
       def configure
         self.configuration ||= Configuration.new
         yield(configuration) if block_given?

data/spec/acts_as_list/embeds_many_recursively_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe Mongoid::ActsAsList::List do
+  [:position, :number].each do |default_field_name|
+    let(:position_field) { default_field_name }
+
+    before do
+      Mongoid::ActsAsList.configure do |config|
+        config.default_position_field = position_field
+      end
+
+      require 'fixtures/embeds_many_recursively_models'
+    end
+
+    describe Mongoid::ActsAsList::List::Embedded do
+      it_behaves_like 'a list' do
+        let(:category) { Category.create! }
+
+        before do
+          3.times do |n|
+            item = category.items.create! position_field => n
+            3.times do |x|
+              item.child_items.create! position_field => x
+            end
+            item.should have(3).child_items
+          end
+          category.should have(3).items
+        end
+      end
+
+      require 'delegate'
+
+      it_behaves_like 'a list' do
+        let(:category) do
+          cat  = Category.create!
+
+          item = cat.items.create!
+
+          3.times do |n|
+            item.child_items.create! position_field => n
+          end
+
+          class SubItemAsCategory < SimpleDelegator
+            def items
+              __getobj__.child_items
+            end
+            def reload
+              __getobj__.reload
+              self
+            end
+          end
+
+          SubItemAsCategory.new(item)
+        end
+      end
+    end
+  end
+end

data/spec/acts_as_list/embeds_many_spec.rb

@@ -13,17 +13,13 @@ describe Mongoid::ActsAsList::List do
     end
 
     describe Mongoid::ActsAsList::List::Embedded do
-      let(:category_1) { Category.create! }
-      let(:category_2) { Category.create! }
-      let(:category_3) { Category.create! }
+      let(:category) { Category.create! }
 
       before do
-        [category_1, category_2].each do |cat|
-          3.times do |n|
-            cat.items.create! position_field => n
-          end
-          cat.should have(3).items
+        3.times do |n|
+          category.items.create! position_field => n
         end
+        category.should have(3).items
       end
 
       it "should be embedded" do
@@ -38,7 +34,7 @@ describe Mongoid::ActsAsList::List do
 
       describe ".acts_as_list" do
         it "defines #scope_condition" do
-          item = category_1.items.first
+          item = category.items.first
           item.scope_condition.should == {position_field.ne => nil}
         end
       end

data/spec/acts_as_list/relational_spec.rb

@@ -14,25 +14,21 @@ describe Mongoid::ActsAsList::List do
 
 
     describe Mongoid::ActsAsList::List::Root do
-      let(:category_1) { Category.create! }
-      let(:category_2) { Category.create! }
-      let(:category_3) { Category.create! }
+      let(:category) { Category.create! }
 
       before do
-        [category_1, category_2].each do |cat|
-          3.times do |n|
-            cat.items.create! position_field => n
-          end
-          cat.should have(3).items
+        3.times do |n|
+          category.items.create! position_field => n
         end
+        category.should have(3).items
       end
 
       it_behaves_like 'a list'
 
       describe ".acts_as_list" do
         it "defines #scope_condition" do
-          item = category_1.items.first
-          item.scope_condition.should == {:category_id => category_1.id}
+          item = category.items.first
+          item.scope_condition.should == {:category_id => category.id}
         end
 
         it "raises a NoScope error if called without a scope option" do
@@ -44,17 +40,7 @@ describe Mongoid::ActsAsList::List do
 
       describe ".order_by_position" do
         it "works with a condition" do
-          RootItem.order_by_position(:category_id => category_2.id).map(&position_field).should == [0,1,2]
-        end
-      end
-
-      describe "Insert a new item to the list" do
-        it "scopes list to the relation" do
-          item_1 = category_1.items.create!
-          item_2 = category_2.items.create!
-
-          item_1[position_field].should == item_2[position_field]
-          item_2[position_field].should == 3
+          RootItem.order_by_position(:category_id => category.id).map(&position_field).should == [0,1,2]
         end
       end
     end

data/spec/fixtures/embeds_many_recursively_models.rb

@@ -0,0 +1,16 @@
+class Category
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  embeds_many :items
+end
+
+class Item
+  include Mongoid::Document
+  include Mongoid::Timestamps
+  include Mongoid::ActsAsList
+
+  embedded_in :category
+  recursively_embeds_many
+  acts_as_list
+end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'simplecov'
+SimpleCov.start
+
 require 'rspec'
 require 'rspec/autorun'
 require 'database_cleaner'

data/spec/support/list_examples.rb

@@ -1,7 +1,8 @@
 shared_examples_for "a list" do
+
   describe ".acts_as_list" do
     it "defines #position_field && .position_field" do
-      item = category_1.items.first
+      item = category.items.first
       item.position_field.should == position_field
       item.class.position_field.should == position_field
     end
@@ -9,19 +10,19 @@ shared_examples_for "a list" do
 
   describe ".order_by_position" do
     it "works without conditions" do
-      category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+      category.items.order_by_position.map(&position_field).should == [0,1,2]
     end
 
     it "sorts by created_at if positions are equal" do
-      deuce = category_1.items.create! position_field => 1
-      items = category_1.items.order_by_position
+      deuce = category.items.create! position_field => 1
+      items = category.items.order_by_position
       items.map(&position_field).should == [0,1,1,2]
       items[2].should == deuce
     end
 
     it "sorts in descending order if specified" do
-      deuce = category_1.items.create! position_field => 2, :created_at => Date.yesterday
-      items = category_1.items.order_by_position(:desc)
+      deuce = category.items.create! position_field => 2, :created_at => Date.yesterday
+      items = category.items.order_by_position(:desc)
       items.map(&position_field).should == [2,2,1,0]
       items[1].should == deuce
     end
@@ -29,7 +30,7 @@ shared_examples_for "a list" do
 
   describe "Insert a new item to the list" do
     it "inserts at the next available position for a given category" do
-      item = category_1.items.create!
+      item = category.items.create!
       item[position_field].should == 3
     end
   end
@@ -37,67 +38,67 @@ shared_examples_for "a list" do
   describe "Removing items" do
     before do
       3.times do
-        category_1.items.create!
+        category.items.create!
       end
-      category_1.reload.items.map(&position_field).should == [0,1,2,3,4,5]
+      category.reload.items.map(&position_field).should == [0,1,2,3,4,5]
     end
 
     describe " #destroy" do
       it "reorders the positions in the list" do
-        item = category_1.items.where(position_field => 3).first
+        item = category.items.where(position_field => 3).first
         item.destroy
 
-        items = item.embedded? ? category_1.items : category_1.reload.items
+        items = item.embedded? ? category.items : category.reload.items
         items.map(&position_field).should == [0,1,2,3,4]
       end
 
 
       it "does not shift positions if the element was already removed from the list" do
-        item = category_1.items.where(position_field => 2).first
+        item = category.items.where(position_field => 2).first
         item.remove_from_list
         item.destroy
-        category_1.reload.items.map(&position_field).should == [0,1,2,3,4]
+        category.reload.items.map(&position_field).should == [0,1,2,3,4]
       end
     end
 
     describe " #remove_from_list" do
       it "sets position to nil" do
-        item = category_1.items.where(position_field => 2).first
+        item = category.items.where(position_field => 2).first
         item.remove_from_list
         item[position_field].should be_nil
       end
 
       it "is not in list anymore" do
-        item = category_1.items.where(position_field => 3).first
+        item = category.items.where(position_field => 3).first
         item.remove_from_list
         item.should_not be_in_list
       end
 
       it "reorders the positions in the list" do
-        category_1.items.where(position_field => 0).first.remove_from_list
-        category_1.reload.items.map(&position_field).compact.should == [0,1,2,3,4]
+        category.items.where(position_field => 0).first.remove_from_list
+        category.reload.items.map(&position_field).compact.should == [0,1,2,3,4]
       end
     end
   end
 
   describe "#first?" do
     it "returns true if item is the first of the list" do
-      category_1.items.order_by_position.first.should be_first
+      category.items.order_by_position.first.should be_first
     end
 
     it "returns false if item is not the first of the list" do
-      all_but_first = category_1.items.order_by_position.to_a[1..-1]
+      all_but_first = category.items.order_by_position.to_a[1..-1]
       all_but_first.map(&:first?).uniq.should == [false]
     end
   end
 
   describe "#last?" do
     it "returns true if item is the last of the list" do
-      category_1.items.order_by_position.last.should be_last
+      category.items.order_by_position.last.should be_last
     end
 
     it "returns false if item is not the last of the list" do
-      all_but_last = category_1.items.order_by_position.to_a[0..-2]
+      all_but_last = category.items.order_by_position.to_a[0..-2]
       all_but_last.map(&:last?).uniq.should == [false]
     end
   end
@@ -105,18 +106,18 @@ shared_examples_for "a list" do
   %w[higher_item next_item].each do |method_name|
     describe "##{method_name}" do
       it "returns the next item in the list if there is one" do
-        item      = category_1.items.where(position_field => 1).first
-        next_item = category_1.items.where(position_field => 2).first
+        item      = category.items.where(position_field => 1).first
+        next_item = category.items.where(position_field => 2).first
         item.send(method_name).should == next_item
       end
 
       it "returns nil if the item is already the last" do
-        item = category_1.items.order_by_position.last
+        item = category.items.order_by_position.last
         item.send(method_name).should be_nil
       end
 
       it "returns nil if the item is not in the list" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
         item.remove_from_list
         item.send(method_name).should be_nil
       end
@@ -126,18 +127,18 @@ shared_examples_for "a list" do
   %w[lower_item previous_item].each do |method_name|
     describe "##{method_name}" do
       it "returns the previous item in the list if there is one" do
-        item          = category_1.items.where(position_field => 1).first
-        previous_item = category_1.items.where(position_field => 0).first
+        item          = category.items.where(position_field => 1).first
+        previous_item = category.items.where(position_field => 0).first
         item.send(method_name).should == previous_item
       end
 
       it "returns nil if the item is already the first" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
         item.send(method_name).should be_nil
       end
 
       it "returns nil if the item is not in the list" do
-        item = category_1.items.order_by_position.last
+        item = category.items.order_by_position.last
         item.remove_from_list
         item.send(method_name).should be_nil
       end
@@ -146,59 +147,59 @@ shared_examples_for "a list" do
 
   describe "#insert_at" do
     context "to a lower position" do
-      let(:item) { category_1.items.order_by_position.last }
+      let(:item) { category.items.order_by_position.last }
 
       it "changes the item's position" do
-        item.insert_at 1
+        item.send :insert_at, 1
         item[position_field].should == 1
       end
 
       it "shuffles intermediary positions" do
-        positions = category_1.items.order_by_position.map(&position_field)
+        positions = category.items.order_by_position.map(&position_field)
         positions.should == [0,1,2]
-        item.insert_at 1
-        positions = category_1.items.order_by_position.map(&position_field)
+        item.send :insert_at, 1
+        positions = category.items.order_by_position.map(&position_field)
         positions.should == [0,1,2]
       end
 
       it "works for items that don't have a position yet" do
         item.remove_from_list
-        item.insert_at 1
+        item.send :insert_at, 1
         item[position_field].should == 1
       end
     end
 
     context "to a higher position" do
-      let(:item) { category_1.items.order_by_position.first }
+      let(:item) { category.items.order_by_position.first }
 
       it "changes the item's position" do
-        item.insert_at 2
+        item.send :insert_at, 2
         item[position_field].should == 2
       end
 
       it "shuffles intermediary positions" do
-        positions = category_1.items.order_by_position.map(&position_field)
+        positions = category.items.order_by_position.map(&position_field)
         positions.should == [0,1,2]
-        item.insert_at 2
-        positions = category_1.items.order_by_position.map(&position_field)
+        item.send :insert_at, 2
+        positions = category.items.order_by_position.map(&position_field)
         positions.should == [0,1,2]
       end
 
       it "works for items that don't have a position yet" do
         item.remove_from_list
-        item.insert_at 2
+        item.send :insert_at, 2
         item[position_field].should == 2
       end
     end
 
     context "to the same position" do
       it "does nothing" do
-        item = category_1.items.first
+        item = category.items.first
         lambda do
-          positions = category_1.items.order_by_position.map(&position_field)
+          positions = category.items.order_by_position.map(&position_field)
           positions.should == [0,1,2]
-          item.insert_at item[position_field]
-          positions = category_1.items.order_by_position.map(&position_field)
+          item.send :insert_at, item[position_field]
+          positions = category.items.order_by_position.map(&position_field)
           positions.should == [0,1,2]
         end.should_not change(item, position_field)
       end
@@ -206,31 +207,31 @@ shared_examples_for "a list" do
 
     context "to extreme positions" do
       it "like 0" do
-        item = category_1.items.order_by_position.last
+        item = category.items.order_by_position.last
 
         item.remove_from_list
-        item.insert_at 0
+        item.send :insert_at, 0
 
         item[position_field].should == 0
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
       it "like the last position" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
 
         item.remove_from_list
-        item.insert_at 1
+        item.send :insert_at, 1
 
         item[position_field].should == 1
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
       it "like the next available position" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
 
         item.remove_from_list
-        item.insert_at 2
+        item.send :insert_at, 2
 
         item[position_field].should == 2
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
     end
   end
@@ -239,7 +240,7 @@ shared_examples_for "a list" do
     context ":to =>" do
       context "an Integer" do
         it "inserts at a given position" do
-          item = category_1.items.order_by_position.first
+          item = category.items.order_by_position.first
           item.should_receive(:insert_at).with 2
           item.move to: 2
         end
@@ -248,7 +249,7 @@ shared_examples_for "a list" do
       context "a Symbol" do
         [:start, :top, :end, :bottom].each do |destination|
           it "moves to #{destination}" do
-            item = category_1.items.first
+            item = category.items.first
             item.should_receive("move_to_#{destination}")
             item.move to: destination
           end
@@ -259,8 +260,8 @@ shared_examples_for "a list" do
     [:before, :above, :after, :below, :forward, :backward, :lower, :higher].each do |sym|
       context "#{sym} =>" do
         it "delegates to the right method" do
-          item = category_1.items.first
-          other_item = category_1.items.last
+          item = category.items.first
+          other_item = category.items.last
           item.should_receive("move_#{sym}").with(other_item)
           item.move(sym => other_item)
         end
@@ -270,7 +271,7 @@ shared_examples_for "a list" do
     [:backwards, :higher].each do |sym|
       context "#{sym}" do
         it "delegates to the right method" do
-          item = category_1.items.last
+          item = category.items.last
           item.should_receive("move_#{sym}").with()
           item.move sym
         end
@@ -281,18 +282,18 @@ shared_examples_for "a list" do
   [:top, :start].each do |sym|
     describe "#move_to_#{sym}" do
       it "#{sym} moves an item in list to the start of list" do
-        item = category_1.items.order_by_position.last
+        item = category.items.order_by_position.last
         item.move to: sym
         item[position_field].should == 0
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
 
       it "#{sym} moves an item not in list to the start of list" do
-        item = category_1.items.order_by_position.last
+        item = category.items.order_by_position.last
         item.remove_from_list
         item.move to: sym
         item[position_field].should == 0
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
     end
   end
@@ -300,18 +301,18 @@ shared_examples_for "a list" do
   [:end, :bottom].each do |sym|
     describe "#move_to_#{sym}" do
       it "#{sym} moves an item in list to the end of list" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
         item.move to: sym
         item[position_field].should == 2
-        category_1.reload.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.reload.items.order_by_position.map(&position_field).should == [0,1,2]
       end
 
       it "#{sym} moves an item not in list to the end of list" do
-        item = category_1.items.order_by_position.first
+        item = category.items.order_by_position.first
         item.remove_from_list
         item.move to: sym
         item[position_field].should == 2
-        category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+        category.items.order_by_position.map(&position_field).should == [0,1,2]
       end
     end
   end
@@ -321,7 +322,7 @@ shared_examples_for "a list" do
       let(:method) { "move_#{sym}" }
 
       context "for the last item of the list" do
-        let(:item) { category_1.items.order_by_position.last }
+        let(:item) { category.items.order_by_position.last }
 
         it "does not change the item's position" do
           lambda do
@@ -331,7 +332,7 @@ shared_examples_for "a list" do
 
         it "keeps items ordered" do
           item.send method
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
 
         it "returns false" do
@@ -340,7 +341,7 @@ shared_examples_for "a list" do
       end
 
       context "for any other item" do
-        let(:item) { category_1.items.order_by_position.first }
+        let(:item) { category.items.order_by_position.first }
 
         it "moves to the next position" do
           lambda do
@@ -362,7 +363,7 @@ shared_examples_for "a list" do
 
         it "keeps items ordered" do
           item.send method, 2
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
 
         it "returns true" do
@@ -377,7 +378,7 @@ shared_examples_for "a list" do
       let(:method) { "move_#{sym}" }
 
       context "for the first item of the list" do
-        let(:item) { category_1.items.order_by_position.first }
+        let(:item) { category.items.order_by_position.first }
 
         it "does not change the item's position" do
           lambda do
@@ -387,7 +388,7 @@ shared_examples_for "a list" do
 
         it "keeps items ordered" do
           item.send method
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
 
         it "returns false" do
@@ -396,7 +397,7 @@ shared_examples_for "a list" do
       end
 
       context "for any other item" do
-        let(:item) { category_1.items.order_by_position.last }
+        let(:item) { category.items.order_by_position.last }
 
         it "moves to the previous position" do
           lambda do
@@ -418,7 +419,7 @@ shared_examples_for "a list" do
 
         it "keeps items ordered" do
           item.send method
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
 
         it "returns true" do
@@ -435,8 +436,8 @@ shared_examples_for "a list" do
       end
 
       context "towards the start" do
-        let(:other_item) { category_1.items.order_by_position.first }
-        let(:item)       { category_1.items.order_by_position.last  }
+        let(:other_item) { category.items.order_by_position.first }
+        let(:item)       { category.items.order_by_position.last  }
 
         it "moves to the same position as other_item" do
           item[position_field].should == 0
@@ -447,12 +448,12 @@ shared_examples_for "a list" do
         end
 
         it "shifts any item after that by 1" do
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
       end
       context "towards the end" do
-        let(:item)       { category_1.items.order_by_position.first }
-        let(:other_item) { category_1.items.order_by_position.last  }
+        let(:item)       { category.items.order_by_position.first }
+        let(:other_item) { category.items.order_by_position.last  }
 
         it "moves to the same position as other_item" do
           item[position_field].should == 1
@@ -463,7 +464,7 @@ shared_examples_for "a list" do
         end
 
         it "shifts any item after that by 1" do
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
       end
     end
@@ -476,27 +477,27 @@ shared_examples_for "a list" do
       end
 
       context "towards the start" do
-        let(:other_item) { category_1.items.order_by_position.first }
-        let(:item)       { category_1.items.order_by_position.last  }
+        let(:other_item) { category.items.order_by_position.first }
+        let(:item)       { category.items.order_by_position.last  }
 
         it "moves to other_item's next position" do
           item[position_field].should == 1
         end
 
         it "shifts any item before that by -1" do
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
       end
       context "towards the end" do
-        let(:item)       { category_1.items.order_by_position.first }
-        let(:other_item) { category_1.items.order_by_position.last  }
+        let(:item)       { category.items.order_by_position.first }
+        let(:other_item) { category.items.order_by_position.last  }
 
         it "moves to the same position as other_item" do
           item[position_field].should == 2
         end
 
         it "shifts any item before that by -1" do
-          category_1.items.order_by_position.map(&position_field).should == [0,1,2]
+          category.items.order_by_position.map(&position_field).should == [0,1,2]
         end
       end
     end
@@ -510,14 +511,15 @@ shared_examples_for "a list" do
       Mongoid::ActsAsList.configure {|c| c.start_list_at = @original_start}
     end
 
-    it "is configurable" do
-      category_3.items.should be_empty
-      start = 1
-      Mongoid::ActsAsList.configure {|c| c.start_list_at = start}
-      item = category_3.items.create!
-      item[position_field].should == start
-      item = category_3.items.create!
-      item[position_field].should == start+1
-    end
+    # it "is configurable" do
+    #   empty_category = category.class.create!
+    #   empty_category.items.should be_empty
+    #   start = 1
+    #   Mongoid::ActsAsList.configure {|c| c.start_list_at = start}
+    #   item = empty_category.items.create!
+    #   item[position_field].should == start
+    #   item = empty_category.items.create!
+    #   item[position_field].should == start+1
+    # end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: mongoid_acts_as_list
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &86692460 !ruby/object:Gem::Requirement
+  requirement: &74681830 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,32 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *86692460
+  version_requirements: *74681830
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &74681400 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *74681400
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: &74681120 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *74681120
 - !ruby/object:Gem::Dependency
   name: bson_ext
-  requirement: &86692200 !ruby/object:Gem::Requirement
+  requirement: &74680850 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +54,10 @@ dependencies:
         version: '1.5'
   type: :development
   prerelease: false
-  version_requirements: *86692200
+  version_requirements: *74680850
 - !ruby/object:Gem::Dependency
   name: database_cleaner
-  requirement: &86691800 !ruby/object:Gem::Requirement
+  requirement: &74680180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *86691800
+  version_requirements: *74680180
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &86691540 !ruby/object:Gem::Requirement
+  requirement: &74679440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *86691540
+  version_requirements: *74679440
 - !ruby/object:Gem::Dependency
   name: mongoid
-  requirement: &86691140 !ruby/object:Gem::Requirement
+  requirement: &74678270 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +87,7 @@ dependencies:
         version: 2.0.1
   type: :runtime
   prerelease: false
-  version_requirements: *86691140
+  version_requirements: *74678270
 description: ''
 email:
 - olivier.melcher@gmail.com
@@ -75,6 +97,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - .vimrc.local
 - Gemfile
 - README.markdown
@@ -86,14 +109,16 @@ files:
 - lib/mongoid/acts_as_list/list/root.rb
 - lib/mongoid/acts_as_list/version.rb
 - lib/mongoid_acts_as_list.rb
+- spec/acts_as_list/embeds_many_recursively_spec.rb
 - spec/acts_as_list/embeds_many_spec.rb
 - spec/acts_as_list/relational_spec.rb
 - spec/fixtures/embeds_many_models.rb
+- spec/fixtures/embeds_many_recursively_models.rb
 - spec/fixtures/relational_models.rb
 - spec/mongoid_acts_as_list_spec.rb
 - spec/spec_helper.rb
 - spec/support/list_examples.rb
-homepage: ''
+homepage: https://github.com/olivoil/mongoid_acts_as_list
 licenses: []
 post_install_message: 
 rdoc_options: []