mongoid 9.0.7 → 9.0.9

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1819,6 +1819,400 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     end
   end
 
+  describe '#pluck' do
+    let(:person) do
+      Person.create!
+    end
+
+    let!(:post) do
+      Post.create!(person_id: person.id, title: 'Test Title')
+    end
+
+    let(:base) { Person }
+    let(:association) { Person.relations[:posts] }
+
+    let(:criteria) do
+      Post.where(person_id: person.id)
+    end
+
+    context 'when the enumerable is not loaded' do
+      let!(:enumerable) do
+        described_class.new(criteria, base, association)
+      end
+
+      context 'when the criteria is present' do
+        it 'delegates to the criteria pluck method' do
+          result = enumerable.pluck(:title)
+          expect(result).to eq(['Test Title'])
+        end
+
+        context 'when added docs are present' do
+          it 'combines the results from the criteria and the added docs' do
+            added_post = Post.new(title: 'Added Title', person_id: person.id)
+            enumerable << added_post
+
+            expect(criteria).to receive(:pluck).with(:title).and_return(['Test Title'])
+            result = enumerable.pluck(:title)
+            expect(result).to eq(['Test Title', 'Added Title'])
+          end
+        end
+      end
+
+      context 'when the criteria is not present' do
+        let(:enumerable) { described_class.new([], base, association) }
+
+        it 'returns nothing' do
+          result = enumerable.pluck(:title)
+          expect(result).to eq([])
+        end
+
+        context 'when added docs are present' do
+          it 'returns the values from the added docs' do
+            added_post = Post.new(title: 'Added Title', person_id: person.id)
+            enumerable << added_post
+
+            result = enumerable.pluck(:title)
+            expect(result).to eq(['Added Title'])
+          end
+        end
+      end
+    end
+
+    context 'when the enumerable is loaded' do
+      let(:enumerable) { described_class.new([post], base, association) }
+
+      it 'returns the values from the loaded documents' do
+        result = enumerable.pluck(:title)
+        expect(result).to eq(['Test Title'])
+      end
+
+      context 'when added docs are present' do
+        it 'returns the values from both loaded and added docs' do
+          added_post = Post.new(title: 'Added Title', person_id: person.id)
+          enumerable << added_post
+
+          result = enumerable.pluck(:title)
+          expect(result).to eq(['Test Title', 'Added Title'])
+        end
+      end
+    end
+  end
+
+  describe '#pluck with aliases' do
+    let!(:parent) do
+      Company.create!
+    end
+
+    context 'when the field is aliased' do
+      let!(:expensive) do
+        parent.products.create!(price: 100000)
+      end
+
+      let!(:cheap) do
+        parent.products.create!(price: 1)
+      end
+
+      context 'when using alias_attribute' do
+
+        let(:plucked) do
+          parent.products.pluck(:price)
+        end
+
+        it 'uses the aliases' do
+          expect(plucked).to eq([ 100000, 1 ])
+        end
+      end
+    end
+
+    context 'when plucking a localized field' do
+      with_default_i18n_configs
+
+      before do
+        I18n.locale = :en
+        p = parent.products.create!(name: 'english-text')
+        I18n.locale = :de
+        p.name = 'deutsch-text'
+        p.save!
+      end
+
+      context 'when plucking the entire field' do
+        let(:plucked) do
+          parent.products.all.pluck(:name)
+        end
+
+        let(:plucked_translations) do
+          parent.products.all.pluck(:name_translations)
+        end
+
+        let(:plucked_translations_both) do
+          parent.products.all.pluck(:name_translations, :name)
+        end
+
+        it 'returns the demongoized translations' do
+          expect(plucked.first).to eq('deutsch-text')
+        end
+
+        it 'returns the full translations hash to _translations' do
+          expect(plucked_translations.first).to eq({'de'=>'deutsch-text', 'en'=>'english-text'})
+        end
+
+        it 'returns both' do
+          expect(plucked_translations_both.first).to eq([{'de'=>'deutsch-text', 'en'=>'english-text'}, 'deutsch-text'])
+        end
+      end
+
+      context 'when plucking a specific locale' do
+
+        let(:plucked) do
+          parent.products.all.pluck(:'name.de')
+        end
+
+        it 'returns the specific translations' do
+          expect(plucked.first).to eq('deutsch-text')
+        end
+      end
+
+      context 'when plucking a specific locale from _translations field' do
+
+        let(:plucked) do
+          parent.products.all.pluck(:'name_translations.de')
+        end
+
+        it 'returns the specific translations' do
+          expect(plucked.first).to eq('deutsch-text')
+        end
+      end
+
+      context 'when fallbacks are enabled with a locale list' do
+        require_fallbacks
+
+        before do
+          I18n.fallbacks[:he] = [ :en ]
+        end
+
+        let(:plucked) do
+          parent.products.all.pluck(:name).first
+        end
+
+        it 'correctly uses the fallback' do
+          I18n.locale = :en
+          parent.products.create!(name: 'english-text')
+          I18n.locale = :he
+          expect(plucked).to eq 'english-text'
+        end
+      end
+
+      context 'when the localized field is aliased' do
+        before do
+          I18n.locale = :en
+          parent.products.delete_all
+          p = parent.products.create!(name: 'ACME Rocket Skates', tagline: 'english-text')
+          I18n.locale = :de
+          p.tagline = 'deutsch-text'
+          p.save!
+        end
+
+        context 'when plucking the entire field' do
+          let(:plucked) do
+            parent.products.all.pluck(:tagline)
+          end
+
+          let(:plucked_unaliased) do
+            parent.products.all.pluck(:tl)
+          end
+
+          let(:plucked_translations) do
+            parent.products.all.pluck(:tagline_translations)
+          end
+
+          let(:plucked_translations_both) do
+            parent.products.all.pluck(:tagline_translations, :tagline)
+          end
+
+          it 'returns the demongoized translations' do
+            expect(plucked.first).to eq('deutsch-text')
+          end
+
+          it 'returns the demongoized translations when unaliased' do
+            expect(plucked_unaliased.first).to eq('deutsch-text')
+          end
+
+          it 'returns the full translations hash to _translations' do
+            expect(plucked_translations.first).to eq({ 'de' => 'deutsch-text', 'en' => 'english-text' })
+          end
+
+          it 'returns both' do
+            expect(plucked_translations_both.first).to eq([{ 'de' => 'deutsch-text', 'en' => 'english-text' }, 'deutsch-text'])
+          end
+        end
+
+        context 'when plucking a specific locale' do
+
+          let(:plucked) do
+            parent.products.all.pluck(:'tagline.de')
+          end
+
+          it 'returns the specific translations' do
+            expect(plucked.first).to eq('deutsch-text')
+          end
+        end
+
+        context 'when plucking a specific locale from _translations field' do
+
+          let(:plucked) do
+            parent.products.all.pluck(:'tagline_translations.de')
+          end
+
+          it 'returns the specific translations' do
+            expect(plucked.first).to eq('deutsch-text')
+          end
+        end
+
+        context 'when fallbacks are enabled with a locale list' do
+          require_fallbacks
+
+          before do
+            I18n.fallbacks[:he] = [:en]
+          end
+
+          let(:plucked) do
+            parent.products.all.pluck(:tagline).first
+          end
+
+          it 'correctly uses the fallback' do
+            I18n.locale = :en
+            parent.products.create!(tagline: 'english-text')
+            I18n.locale = :he
+            expect(plucked).to eq 'english-text'
+          end
+        end
+      end
+
+      context 'when the localized field is embedded' do
+        with_default_i18n_configs
+
+        before do
+          s = Seo.new
+          I18n.locale = :en
+          s.name = 'english-text'
+          I18n.locale = :de
+          s.name = 'deutsch-text'
+
+          parent.products.delete_all
+          parent.products.create!(name: 'ACME Tunnel Paint', seo: s)
+        end
+
+        let(:plucked) do
+          parent.products.pluck('seo.name').first
+        end
+
+        let(:plucked_translations) do
+          parent.products.pluck('seo.name_translations').first
+        end
+
+        let(:plucked_translations_field) do
+          parent.products.pluck('seo.name_translations.en').first
+        end
+
+        it 'returns the translation for the current locale' do
+          expect(plucked).to eq('deutsch-text')
+        end
+
+        it 'returns the full _translation hash' do
+          expect(plucked_translations).to eq({ 'en' => 'english-text', 'de' => 'deutsch-text' })
+        end
+
+        it 'returns the translation for the requested locale' do
+          expect(plucked_translations_field).to eq('english-text')
+        end
+      end
+    end
+
+    context 'when the localized field is embedded and aliased' do
+      with_default_i18n_configs
+
+      before do
+        s = Seo.new
+        I18n.locale = :en
+        s.description = 'english-text'
+        I18n.locale = :de
+        s.description = 'deutsch-text'
+
+        parent.products.delete_all
+        parent.products.create!(name: 'ACME Tunnel Paint', seo: s)
+      end
+
+      let(:plucked) do
+        parent.products.pluck('seo.description').first
+      end
+
+      let(:plucked_unaliased) do
+        parent.products.pluck('seo.desc').first
+      end
+
+      let(:plucked_translations) do
+        parent.products.pluck('seo.description_translations').first
+      end
+
+      let(:plucked_translations_field) do
+        parent.products.pluck('seo.description_translations.en').first
+      end
+
+      it 'returns the translation for the current locale' do
+        I18n.with_locale(:en) do
+          expect(plucked).to eq('english-text')
+        end
+      end
+
+      it 'returns the translation for the current locale when unaliased' do
+        I18n.with_locale(:en) do
+          expect(plucked_unaliased).to eq('english-text')
+        end
+      end
+
+      it 'returns the full _translation hash' do
+        expect(plucked_translations).to eq({ 'en' => 'english-text', 'de' => 'deutsch-text' })
+      end
+
+      it 'returns the translation for the requested locale' do
+        expect(plucked_translations_field).to eq('english-text')
+      end
+    end
+
+    context 'when plucking an embedded field' do
+      let(:label) { Label.new(sales: '1E2') }
+      let!(:band) { Band.create!(label: label) }
+
+      let(:plucked) { Band.where(_id: band.id).pluck('label.sales') }
+
+      it 'demongoizes the field' do
+        expect(plucked).to eq([ BigDecimal('1E2') ])
+      end
+    end
+
+    context 'when plucking an embeds_many field' do
+      let(:label) { Label.new(sales: '1E2') }
+      let!(:band) { Band.create!(labels: [label]) }
+
+      let(:plucked) { Band.where(_id: band.id).pluck('labels.sales') }
+
+      it 'demongoizes the field' do
+        expect(plucked.first).to eq([ BigDecimal('1E2') ])
+      end
+    end
+
+    context 'when plucking a nonexistent embedded field' do
+      let(:label) { Label.new(sales: '1E2') }
+      let!(:band) { Band.create!(label: label) }
+
+      let(:plucked) { Band.where(_id: band.id).pluck('label.qwerty') }
+
+      it 'returns nil' do
+        expect(plucked.first).to eq(nil)
+      end
+    end
+  end
+
   describe "#reset" do
 
     let(:person) do

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -96,3 +96,27 @@ class HmmAnimal
 
   belongs_to :trainer, class_name: 'HmmTrainer', scope: -> { where(name: 'Dave') }
 end
+
+class HmmPost
+  include Mongoid::Document
+
+  field :title, type: String
+
+  has_many :comments, class_name: 'HmmComment', as: :container
+
+  accepts_nested_attributes_for :comments, allow_destroy: true
+end
+
+class HmmComment
+  include Mongoid::Document
+
+  field :title, type: String
+  field :num, type: Integer, default: 0
+
+  belongs_to :container, polymorphic: true
+  has_many :comments, class_name: 'HmmComment', as: :container
+
+  accepts_nested_attributes_for :comments, allow_destroy: true
+
+  validates :num, numericality: { greater_than_or_equal_to: 0 }
+end

data/spec/mongoid/association/referenced/has_one_models.rb

@@ -102,13 +102,21 @@ class HomPost
 
   field :title, type: String
 
-  has_one :comment, inverse_of: :post, class_name: 'HomComment'
+  has_one :comment, as: :container, class_name: 'HomComment'
+
+  accepts_nested_attributes_for :comment, allow_destroy: true
 end
 
 class HomComment
   include Mongoid::Document
 
   field :content, type: String
+  field :num, type: Integer, default: 0
+
+  validates :num, numericality: { greater_than_or_equal_to: 0 }
+
+  belongs_to :container, polymorphic: true, optional: true
+  has_one :comment, as: :container, class_name: 'HomComment'
 
-  belongs_to :post, inverse_of: :comment, optional: true, class_name: 'HomPost'
+  accepts_nested_attributes_for :comment, allow_destroy: true
 end

data/spec/mongoid/attributes_spec.rb

@@ -1729,6 +1729,19 @@ describe Mongoid::Attributes do
         end
       end
     end
+
+    context 'when map_big_decimal_to_decimal128 is enabled' do
+      config_override :map_big_decimal_to_decimal128, true
+
+      context 'when writing an identical number' do
+        let(:band) { Band.create!(name: 'Nirvana', sales: 123456.78).reload }
+
+        it 'does not mark the document as changed' do
+          band.sales = 123456.78
+          expect(band.changed?).to be false
+        end
+      end
+    end
   end
 
   describe "#typed_value_for" do

data/spec/mongoid/clients/transactions_spec.rb

@@ -716,7 +716,7 @@ describe Mongoid::Clients::Sessions do
       require_transaction_support
 
       context 'when no error raised' do
-        before do
+        let!(:person) do
           Mongoid.transaction do
             Person.create!
           end
@@ -727,6 +727,10 @@ describe Mongoid::Clients::Sessions do
           expect(other_events.count { |e| e.command_name == 'commitTransaction'}).to be(1)
         end
 
+        it 'returns the value from the block' do
+          expect(person).to be_a(Person)
+        end
+
         it 'executes the commands inside the transaction' do
           expect(Person.count).to be(1)
         end
@@ -787,8 +791,12 @@ describe Mongoid::Clients::Sessions do
         Mongoid::Clients.with_name(:default).database.collections.each(&:drop)
         TransactionsSpecPerson.collection.create
         TransactionsSpecPersonWithOnCreate.collection.create
+        TransactionsSpecPersonWithAfterCreateCommit.collection.create
         TransactionsSpecPersonWithOnUpdate.collection.create
+        TransactionsSpecPersonWithAfterUpdateCommit.collection.create
+        TransactionsSpecPersonWithAfterSaveCommit.collection.create
         TransactionsSpecPersonWithOnDestroy.collection.create
+        TransactionsSpecPersonWithAfterDestroyCommit.collection.create
         TransactionSpecRaisesBeforeSave.collection.create
         TransactionSpecRaisesAfterSave.collection.create
       end
@@ -818,6 +826,18 @@ describe Mongoid::Clients::Sessions do
 
             it_behaves_like 'commit callbacks are called'
           end
+
+          context 'when callback is after_create_commit' do
+            let!(:subject) do
+              person = nil
+              TransactionsSpecPersonWithAfterCreateCommit.transaction do
+                person = TransactionsSpecPersonWithAfterCreateCommit.create!(name: 'James Bond')
+              end
+              person
+            end
+
+            it_behaves_like 'commit callbacks are called'
+          end
         end
 
         context 'save' do
@@ -886,6 +906,94 @@ describe Mongoid::Clients::Sessions do
               it_behaves_like 'commit callbacks are called'
             end
           end
+
+          context 'with after_update_commit callback' do
+            let(:subject) do
+              TransactionsSpecPersonWithAfterUpdateCommit.create!(name: 'James Bond').tap do |subject|
+                subject.after_commit_counter.reset
+                subject.after_rollback_counter.reset
+              end
+            end
+
+            context 'when modified once' do
+              before do
+                subject.transaction do
+                  subject.name = 'Austin Powers'
+                  subject.save!
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+
+            context 'when modified multiple times' do
+              before do
+                subject.transaction do
+                  subject.name = 'Austin Powers'
+                  subject.save!
+                  subject.name = 'Jason Bourne'
+                  subject.save!
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+          end
+
+          context 'with after_save_commit callback' do
+            let(:subject) do
+              TransactionsSpecPersonWithAfterSaveCommit.create!(name: 'James Bond').tap do |subject|
+                subject.after_commit_counter.reset
+                subject.after_rollback_counter.reset
+              end
+            end
+
+            context 'when modified once' do
+              before do
+                subject.transaction do
+                  subject.name = 'Austin Powers'
+                  subject.save!
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+
+            context 'when created' do
+              before do
+                TransactionsSpecPersonWithAfterSaveCommit.transaction do
+                  subject
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+
+            context 'when modified multiple times' do
+              before do
+                subject.transaction do
+                  subject.name = 'Austin Powers'
+                  subject.save!
+                  subject.name = 'Jason Bourne'
+                  subject.save!
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+
+            context 'when created and modified' do
+              before do
+                TransactionsSpecPersonWithAfterSaveCommit.transaction do
+                  subject
+                  subject.name = 'Jason Bourne'
+                  subject.save!
+                end
+              end
+
+              it_behaves_like 'commit callbacks are called'
+            end
+          end
         end
 
         context 'update_attributes' do
@@ -919,6 +1027,34 @@ describe Mongoid::Clients::Sessions do
 
             it_behaves_like 'commit callbacks are called'
           end
+
+          context 'when callback is after_update_commit' do
+            let(:subject) do
+              TransactionsSpecPersonWithAfterUpdateCommit.create!(name: 'Jason Bourne')
+            end
+
+            before do
+              TransactionsSpecPersonWithAfterUpdateCommit.transaction do
+                subject.update_attributes!(name: 'Foma Kiniaev')
+              end
+            end
+
+            it_behaves_like 'commit callbacks are called'
+          end
+
+          context 'when callback is after_save_commit' do
+            let(:subject) do
+              TransactionsSpecPersonWithAfterSaveCommit.create!(name: 'Jason Bourne')
+            end
+
+            before do
+              TransactionsSpecPersonWithAfterSaveCommit.transaction do
+                subject.update_attributes!(name: 'Foma Kiniaev')
+              end
+            end
+
+            it_behaves_like 'commit callbacks are called'
+          end
         end
 
         context 'destroy' do
@@ -971,6 +1107,31 @@ describe Mongoid::Clients::Sessions do
 
             it_behaves_like 'commit callbacks are called'
           end
+
+          context 'with after_destroy_commit' do
+            let(:after_commit_counter) do
+              TransactionsSpecCounter.new
+            end
+
+            let(:after_rollback_counter) do
+              TransactionsSpecCounter.new
+            end
+
+            let(:subject) do
+              TransactionsSpecPersonWithAfterDestroyCommit.create!(name: 'James Bond').tap do |p|
+                p.after_commit_counter = after_commit_counter
+                p.after_rollback_counter = after_rollback_counter
+              end
+            end
+
+            before do
+              subject.transaction do
+                subject.destroy
+              end
+            end
+
+            it_behaves_like 'commit callbacks are called'
+          end
         end
       end