mongoid 9.0.10 → 9.1.0

data/spec/mongoid/errors/document_not_found_spec.rb

@@ -1,182 +1,179 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::DocumentNotFound do
-
-  describe "#message" do
-
-    context "when providing an id" do
-
+  describe '#message' do
+    context 'when providing an id' do
       let(:error) do
         described_class.new(Person, 1, 1)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Document(s) not found for class Person with id(s) 1."
+          'Document(s) not found for class Person with id(s) 1.'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "When calling Person.find with an id or array of ids"
+          'When calling Person.find with an id or array of ids'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Search for an id that is in the database or set the"
+          'Search for an id that is in the database or set the'
         )
       end
     end
 
-    context "when providing ids" do
-
+    context 'when providing ids' do
       let(:error) do
         described_class.new(Person, [ 1, 2, 3 ], [ 1 ])
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Document(s) not found for class Person with id(s) 1."
+          'Document(s) not found for class Person with id(s) 1.'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "When calling Person.find with an id or array of ids"
+          'When calling Person.find with an id or array of ids'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Search for an id that is in the database or set the"
+          'Search for an id that is in the database or set the'
         )
       end
     end
 
-    context "when providing attributes" do
-
+    context 'when providing attributes' do
       let(:error) do
-        described_class.new(Person, { name: "syd" }, nil)
+        described_class.new(Person, { name: 'syd' }, nil)
       end
 
-      it "contains the problem in the message" do
-        expect(error.message).to include(
-          "Document not found for class Person with attributes {:name=>\"syd\"}."
-        )
+      it 'contains the problem in the message' do
+        # Ruby 3.4+ changed Hash#inspect format from {:name=>"syd"} to {name: "syd"}
+        if RUBY_VERSION >= '3.4'
+          expect(error.message).to include(
+            'Document not found for class Person with attributes {name: "syd"}.'
+          )
+        else
+          expect(error.message).to include(
+            'Document not found for class Person with attributes {:name=>"syd"}.'
+          )
+        end
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "When calling Person.find_by with a hash of attributes"
+          'When calling Person.find_by with a hash of attributes'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Search for attributes that are in the database or set"
+          'Search for attributes that are in the database or set'
         )
       end
     end
 
-    context "when providing an _id and a shard key" do
-
+    context 'when providing an _id and a shard key' do
       let(:id) { BSON::ObjectId.new }
-      let(:doc) { { _id: id, a: "syd" } }
+      let(:doc) { { _id: id, a: 'syd' } }
       let(:error) do
         described_class.new(Person, id, doc)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Document not found for class Person with id #{id.to_s} and shard key a: syd."
+          "Document not found for class Person with id #{id} and shard key a: syd."
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "When calling Person.find with an id and a shard key"
+          'When calling Person.find with an id and a shard key'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Search for an id/shard key that is in the database or set"
+          'Search for an id/shard key that is in the database or set'
         )
       end
     end
 
-    context "when providing an id in a hash without a shard key" do
-
+    context 'when providing an id in a hash without a shard key' do
       let(:error) do
         described_class.new(Person, 1, { _id: 1 })
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Document(s) not found for class Person with id(s) 1."
+          'Document(s) not found for class Person with id(s) 1.'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "When calling Person.find with an id or array of ids"
+          'When calling Person.find with an id or array of ids'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Search for an id that is in the database or set the"
+          'Search for an id that is in the database or set the'
         )
       end
     end
 
-    context "when not providing params or unmatched" do
+    context 'when not providing params or unmatched' do
       let(:error) do
         described_class.new(Person, nil, nil)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Could not find a document of class Person."
+          'Could not find a document of class Person.'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "Mongoid attempted to find a document of the class Person but none exist."
+          'Mongoid attempted to find a document of the class Person but none exist.'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Create a document of class Person or use a finder method that does not raise an exception when no documents are found."
+          'Create a document of class Person or use a finder method that does not raise an exception when no documents are found.'
         )
       end
     end
   end
 
-  describe "#params" do
-
+  describe '#params' do
     let(:error) do
       described_class.new(Person, 1, 1)
     end
 
-    it "returns the parameters passed to the find" do
+    it 'returns the parameters passed to the find' do
       expect(error.params).to eq(1)
     end
   end
 
-  describe "#klass" do
-
+  describe '#klass' do
     let(:error) do
       described_class.new(Person, 1, 1)
     end
 
-    it "returns the model class" do
+    it 'returns the model class' do
       expect(error.klass).to eq(Person)
     end
   end

data/spec/mongoid/errors/invalid_collection_spec.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidCollection do
-
-  describe "#message" do
-
-    context "default" do
-
+  describe '#message' do
+    context 'default' do
       let(:klass) do
         Address
       end
@@ -17,21 +13,21 @@ describe Mongoid::Errors::InvalidCollection do
         described_class.new(klass)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Access to the collection for Address is not allowed."
+          'Access to the collection for Address is not allowed.'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "Address.collection was called, and Address is an embedded document"
+          'Address.collection was called, and Address is an embedded document'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "For access to the collection that the embedded document is in"
+          'For access to the collection that the embedded document is in'
         )
       end
     end

data/spec/mongoid/errors/invalid_config_file_spec.rb

@@ -1,31 +1,28 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidConfigFile do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new('/my/path')
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Invalid configuration file: /my/path."
+        'Invalid configuration file: /my/path.'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "Your mongoid.yml configuration file does not contain the"
+        'Your mongoid.yml configuration file does not contain the'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Ensure your configuration file contains the correct contents."
+        'Ensure your configuration file contains the correct contents.'
       )
     end
   end

data/spec/mongoid/errors/invalid_config_option_spec.rb

@@ -1,31 +1,28 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidConfigOption do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new(:bad_option)
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Invalid configuration option: bad_option."
+        'Invalid configuration option: bad_option.'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "A invalid configuration option was provided in your mongoid.yml,"
+        'A invalid configuration option was provided in your mongoid.yml,'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Remove the invalid option or fix the typo."
+        'Remove the invalid option or fix the typo.'
       )
     end
   end

data/spec/mongoid/errors/invalid_field_option_spec.rb

@@ -1,29 +1,26 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidFieldOption do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new(Person, :testing, :localized, [ :localize ])
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Invalid option :localized provided for field :testing."
+        'Invalid option :localized provided for field :testing.'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "Mongoid requires that you only provide valid options"
+        'Mongoid requires that you only provide valid options'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
         "When defining the field :testing on 'Person', please"
       )

data/spec/mongoid/errors/invalid_field_spec.rb

@@ -1,39 +1,38 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidField do
-
-  describe "#message" do
-
+  describe '#message' do
     module MyModule
-      def crazy_method; self; end
+      def crazy_method
+        self
+      end
     end
 
     before do
-      Object.send(:include, MyModule)
+      Object.include MyModule
     end
 
     let(:error) do
       described_class.new(Person, :crazy_method, :crazy_method)
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
         "Defining a field named 'crazy_method' is not allowed."
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
         "Defining this field would override the method 'crazy_method'"
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Use Mongoid.destructive_fields to see what names are not allowed"
+        'Use Mongoid.destructive_fields to see what names are not allowed'
       )
     end
   end

data/spec/mongoid/errors/invalid_field_type_spec.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidFieldType do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new(Person, :first_name, :stringgy)
     end
@@ -16,13 +13,13 @@ describe Mongoid::Errors::InvalidFieldType do
         described_class.new(Person, :first_name, :stringgy)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
           "Invalid field type :stringgy for field 'first_name' on model 'Person'."
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
           "Model 'Person' defines a field 'first_name' with an unknown type value :stringgy."
         )
@@ -34,20 +31,20 @@ describe Mongoid::Errors::InvalidFieldType do
         described_class.new(Person, :first_name, 'stringgy')
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          %q,Invalid field type "stringgy" for field 'first_name' on model 'Person'.,
+          %q(Invalid field type "stringgy" for field 'first_name' on model 'Person'.)
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          %q,Model 'Person' defines a field 'first_name' with an unknown type value "stringgy".,
+          %q(Model 'Person' defines a field 'first_name' with an unknown type value "stringgy".)
         )
       end
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
         'Please provide a valid type value for the field.'
       )

data/spec/mongoid/errors/invalid_find_spec.rb

@@ -1,31 +1,28 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidFind do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Calling Document.find with nil is invalid"
+        'Calling Document.find with nil is invalid'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "Document.find expects the parameters to be 1 or more ids"
+        'Document.find expects the parameters to be 1 or more ids'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Most likely this is caused by passing parameters directly"
+        'Most likely this is caused by passing parameters directly'
       )
     end
   end

data/spec/mongoid/errors/invalid_includes_spec.rb

@@ -1,14 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidIncludes do
-
-  describe "#message" do
-
-    context "default" do
-
+  describe '#message' do
+    context 'default' do
       let(:klass) do
         Band
       end
@@ -21,21 +17,21 @@ describe Mongoid::Errors::InvalidIncludes do
         described_class.new(klass, args)
       end
 
-      it "contains the problem in the message" do
+      it 'contains the problem in the message' do
         expect(error.message).to include(
-          "Invalid includes directive: Band.includes(:members)"
+          'Invalid includes directive: Band.includes(:members)'
         )
       end
 
-      it "contains the summary in the message" do
+      it 'contains the summary in the message' do
         expect(error.message).to include(
-          "Eager loading in Mongoid only supports providing arguments to Band.includes"
+          'Eager loading in Mongoid only supports providing arguments to Band.includes'
         )
       end
 
-      it "contains the resolution in the message" do
+      it 'contains the resolution in the message' do
         expect(error.message).to include(
-          "Ensure that each parameter passed to Band.includes is a valid name"
+          'Ensure that each parameter passed to Band.includes is a valid name'
         )
       end
     end

data/spec/mongoid/errors/invalid_index_spec.rb

@@ -1,31 +1,28 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::InvalidIndex do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:error) do
       described_class.new(Band, { name: 1 }, { invalid: true })
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Invalid index specification on Band:"
+        'Invalid index specification on Band:'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "Indexes in Mongoid are defined as a hash of field name and direction"
+        'Indexes in Mongoid are defined as a hash of field name and direction'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Ensure that the index conforms to the correct syntax"
+        'Ensure that the index conforms to the correct syntax'
       )
     end
   end