mongoid 8.1.9 → 9.0.0

data/spec/mongoid/document_fields_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/document_persistence_context_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -29,4 +30,80 @@ describe Mongoid::Document do
       Person.collection_name.should == :people
     end
   end
+
+  context 'when loaded with an overridden persistence context' do
+    let(:options) { { collection: 'extra_people' } }
+    let(:person) { Person.with(options) { Person.create username: 'zyg14' } }
+
+    # Mongoid 9+ default persistence behavior
+    context 'when Mongoid.legacy_persistence_context_behavior is false' do
+      config_override :legacy_persistence_context_behavior, false
+
+      it 'remembers its persistence context when created' do
+        expect(person.collection_name).to be == :extra_people
+      end
+
+      it 'remembers its context when queried specifically' do
+        person_by_id = Person.with(options) { Person.find(_id: person._id) }
+        expect(person_by_id.collection_name).to be == :extra_people
+      end
+
+      it 'remembers its context when queried generally' do
+        person # force the person to be created
+        person_generally = Person.with(options) { Person.all[0] }
+        expect(person_generally.collection_name).to be == :extra_people
+      end
+
+      it 'can be reloaded without specifying the context' do
+        expect { person.reload }.not_to raise_error
+        expect(person.collection_name).to be == :extra_people
+      end
+
+      it 'can be updated without specifying the context' do
+        person.update username: 'zyg15'
+        expect(Person.with(options) { Person.first.username }).to be == 'zyg15'
+      end
+
+      it 'an explicit context takes precedence over a remembered context when persisting' do
+        person.username = 'bob'
+        # should not actually save -- the person does not exist in the
+        # `other` collection and so cannot be updated.
+        Person.with(collection: 'other') { person.save! }
+        expect(person.reload.username).to eq 'zyg14'
+      end
+
+      it 'an explicit context takes precedence over a remembered context when reloading' do
+        expect { Person.with(collection: 'other') { person.reload } }.to raise_error(Mongoid::Errors::DocumentNotFound)
+      end
+    end
+
+    # pre-9.0 default persistence behavior
+    context 'when Mongoid.legacy_persistence_context_behavior is true' do
+      config_override :legacy_persistence_context_behavior, true
+
+      it 'does not remember its persistence context when created' do
+        expect(person.collection_name).to be == :people
+      end
+
+      it 'does not remember its context when queried specifically' do
+        person_by_id = Person.with(options) { Person.find(_id: person._id) }
+        expect(person_by_id.collection_name).to be == :people
+      end
+
+      it 'does not remember its context when queried generally' do
+        person # force the person to be created
+        person_generally = Person.with(options) { Person.all[0] }
+        expect(person_generally.collection_name).to be == :people
+      end
+
+      it 'cannot be reloaded without specifying the context' do
+        expect { person.reload }.to raise_error
+      end
+
+      it 'cannot be updated without specifying the context' do
+        person.update username: 'zyg15'
+        expect(Person.with(options) { Person.first.username }).to be == 'zyg14'
+      end
+    end
+  end
 end

data/spec/mongoid/document_query_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -14,11 +15,11 @@ describe Mongoid::Document do
     it 'populates specified fields only' do
       expect do
         person.title
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
       # has a default value specified in the model
       expect do
         person.age
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'age' on Person which was not loaded/)
       expect(person.attributes.keys).to eq(['_id', 'username'])
     end
 
@@ -27,7 +28,7 @@ describe Mongoid::Document do
 
       expect do
         person.age
-      end.to raise_error(ActiveModel::MissingAttributeError)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded)
       person.age = 42
       expect(person.age).to be 42
       person.save!
@@ -82,7 +83,7 @@ describe Mongoid::Document do
       it 'prohibits the retrieval' do
         lambda do
           person.pet.name
-        end.should raise_error(ActiveModel::MissingAttributeError)
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'name' on Animal which was not loaded/)
       end
     end
   end

data/spec/mongoid/document_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -183,20 +184,8 @@ describe Mongoid::Document do
 
       let(:from_db) { Person.first }
 
-      context "when legacy_attributes is false" do
-        config_override :legacy_attributes, false
-
-        it "returns a Hash" do
-          expect(from_db.attributes.class).to eq(Hash)
-        end
-      end
-
-      context "when legacy_attributes is true" do
-        config_override :legacy_attributes, true
-
-        it "returns a BSON::Document" do
-          expect(from_db.attributes.class).to eq(BSON::Document)
-        end
+      it "returns a Hash" do
+        expect(from_db.attributes.class).to eq(Hash)
       end
     end
   end
@@ -440,113 +429,6 @@ describe Mongoid::Document do
         end
       end
     end
-
-    context "when the Mongoid-specific options are provided" do
-
-      let(:options) do
-        { compact: true }
-      end
-
-      it "applies the Mongoid-specific options" do
-        expect(person.as_json(options)["title"]).to eq("Sir")
-        expect(person.as_json(options)["age"]).to eq(100)
-        expect(person.as_json(options).keys).not_to include("lunch_time")
-      end
-
-      context "when options for the super method are provided" do
-
-        let(:options) do
-          { compact: true, only: [:title, :pets, :ssn] }
-        end
-
-        it "passes the options through to the super method" do
-          expect(person.as_json(options)["title"]).to eq("Sir")
-          expect(person.as_json(options)["pets"]).to eq(false)
-        end
-
-        it "applies the Mongoid-specific options" do
-          expect(person.as_json(options).keys).not_to include("ssn")
-        end
-      end
-    end
-
-    context 'deprecated :compact option' do
-      # Since rails 6 differs in how it treats id fields,
-      # run this test on one version of rails. Currently rails 6 is in beta,
-      # when it is released this version should be changed to 6.
-      max_rails_version '5.2'
-
-      before do
-        # These tests require a specific set of defined attributes
-        # on the model
-        expect(church.as_json.keys.sort).to eq(%w(_id location name))
-      end
-
-      context 'deprecation' do
-        let(:church) do
-          Church.create!(name: 'St. Basil')
-        end
-
-        let(:message) do
-          '#as_json :compact option is deprecated. Please call #compact on the returned Hash object instead.'
-        end
-
-        it 'logs a deprecation warning when :compact is given' do
-          expect(Mongoid::Warnings).to receive(:warn_as_json_compact_deprecated)
-          church.as_json(compact: true)
-        end
-
-        it 'does not log a deprecation warning when :compact is not given' do
-          expect(Mongoid::Warnings).to_not receive(:warn_as_json_compact_deprecated)
-          church.as_json
-        end
-      end
-
-      context 'there is a nil valued attribute' do
-        let(:church) do
-          Church.create!(name: 'St. Basil')
-        end
-
-        it 'returns non-nil fields and _id only' do
-          actual = church.as_json(compact: true)
-          expect(actual).to eq('_id' => church.id, 'name' => 'St. Basil')
-        end
-      end
-
-      context 'all attrbutes are nil valued' do
-        let(:church) do
-          Church.create!
-        end
-
-        it 'returns a hash with _id only' do
-          actual = church.as_json(compact: true)
-          expect(actual).to eq('_id' => church.id)
-        end
-      end
-
-      context 'there are no nil valued attributes' do
-        let(:church) do
-          Church.create!(name: 'St. Basil', location: {})
-        end
-
-        it 'returns all fields and _id' do
-          actual = church.as_json(compact: true)
-          expect(actual).to eq('_id' => church.id, 'name' => 'St. Basil',
-            'location' => {})
-        end
-      end
-
-      context 'when option is specified as a truthy value' do
-        let(:church) do
-          Church.create!(name: 'St. Basil')
-        end
-
-        it 'returns non-nil fields and _id only' do
-          actual = church.as_json(compact: 1)
-          expect(actual).to eq('_id' => church.id, 'name' => 'St. Basil')
-        end
-      end
-    end
   end
 
   describe "#as_document" do
@@ -591,33 +473,6 @@ describe Mongoid::Document do
       expect(person.as_document["addresses"].first).to have_key(:locations)
     end
 
-    context 'when modifying the returned object' do
-      let(:record) do
-        RootCategory.create(categories: [{ name: 'tests' }]).reload
-      end
-
-      shared_examples_for 'an object with protected internal state' do
-        it 'does not expose internal state' do
-          before_change = record.as_document.dup
-          record.categories.first.name = 'things'
-          after_change = record.as_document
-          expect(before_change['categories'].first['name']).not_to eq('things')
-        end
-      end
-
-      context 'when legacy_attributes is true' do
-        config_override :legacy_attributes, true
-
-        it_behaves_like 'an object with protected internal state'
-      end
-
-      context 'when legacy_attributes is false' do
-        config_override :legacy_attributes, false
-
-        it_behaves_like 'an object with protected internal state'
-      end
-    end
-
     context "with relation define store_as option in embeded_many" do
 
       let!(:phone) do

data/spec/mongoid/equality_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -85,194 +86,91 @@ describe Mongoid::Equality do
 
   describe ".===" do
 
-    context "when legacy_triple_equals is not set" do
-      config_override :legacy_triple_equals, false
+    context "when comparable is an instance of this document" do
 
-      context "when comparable is an instance of this document" do
-
-        it "returns true" do
-          expect(klass === person).to be true
-        end
-      end
-
-      context "when comparable is a relation of this document" do
-
-        let(:relation) do
-          Post.new(person: person).person
-        end
-
-        it "returns true" do
-          expect(klass === relation).to be true
-        end
-      end
-
-      context "when comparable is the same class" do
-
-        it "returns false" do
-          expect(klass === Person).to be false
-        end
-      end
-
-      context "when the comparable is a subclass" do
-
-        it "returns false" do
-          expect(Person === Doctor).to be false
-        end
-      end
-
-      context "when the comparable is an instance of a subclass" do
-
-        it "returns true" do
-          expect(Person === Doctor.new).to be true
-        end
+      it "returns true" do
+        expect(klass === person).to be true
       end
     end
 
-    context "when legacy_triple_equals is set" do
-      config_override :legacy_triple_equals, true
-
-      context "when comparable is an instance of this document" do
+    context "when comparable is a relation of this document" do
 
-        it "returns true" do
-          expect(klass === person).to be true
-        end
+      let(:relation) do
+        Post.new(person: person).person
       end
 
-      context "when comparable is a relation of this document" do
-
-        let(:relation) do
-          Post.new(person: person).person
-        end
-
-        it "returns true" do
-          expect(klass === relation).to be true
-        end
+      it "returns true" do
+        expect(klass === relation).to be true
       end
+    end
 
-      context "when comparable is the same class" do
+    context "when comparable is the same class" do
 
-        it "returns true" do
-          expect(klass === Person).to be true
-        end
+      it "returns false" do
+        expect(klass === Person).to be false
       end
+    end
 
-      context "when the comparable is a subclass" do
+    context "when the comparable is a subclass" do
 
-        it "returns false" do
-          expect(Person === Doctor).to be false
-        end
+      it "returns false" do
+        expect(Person === Doctor).to be false
       end
+    end
 
-      context "when the comparable is an instance of a subclass" do
+    context "when the comparable is an instance of a subclass" do
 
-        it "returns true" do
-          expect(Person === Doctor.new).to be true
-        end
+      it "returns true" do
+        expect(Person === Doctor.new).to be true
       end
     end
   end
 
   describe "#===" do
 
-    context "when legacy_triple_equals is set" do
-      config_override :legacy_triple_equals, true
-
-      context "when comparable is the same type" do
+    context "when comparable is the same type" do
 
-        context "when the instance is different" do
-
-          it "returns false" do
-            expect(person === Person.new).to be false
-          end
-        end
-
-        context "when the instance is the same" do
-
-          it "returns true" do
-            expect(person === person).to be true
-          end
-        end
-      end
-
-      context "when the comparable is a subclass" do
+      context "when the instance is different" do
 
         it "returns false" do
-          expect(person === Doctor.new).to be false
+          expect(person === Person.new).to be false
         end
       end
 
-      context "when comparing to a class" do
-
-        context "when the class is the same" do
-
-          it "returns true" do
-            expect(person === Person).to be true
-          end
-        end
-
-        context "when the class is a subclass" do
-
-          it "returns false" do
-            expect(person === Doctor).to be false
-          end
-        end
-
-        context "when the class is a superclass" do
+      context "when the instance is the same" do
 
-          it "returns true" do
-            expect(Doctor.new === Person).to be true
-          end
+        it "returns true" do
+          expect(person === person).to be true
         end
       end
     end
 
-    context "when legacy_triple_equals is not set" do
-      config_override :legacy_triple_equals, false
-
-      context "when comparable is the same type" do
-
-        context "when the instance is different" do
+    context "when the comparable is a subclass" do
 
-          it "returns false" do
-            expect(person === Person.new).to be false
-          end
-        end
-
-        context "when the instance is the same" do
-
-          it "returns true" do
-            expect(person === person).to be true
-          end
-        end
+      it "returns false" do
+        expect(person === Doctor.new).to be false
       end
+    end
 
-      context "when the comparable is a subclass" do
+    context "when comparing to a class" do
+      context "when the class is the same" do
 
         it "returns false" do
-          expect(person === Doctor.new).to be false
+          expect(person === Person).to be false
         end
       end
 
-      context "when comparing to a class" do
-        context "when the class is the same" do
+      context "when the class is a subclass" do
 
-          it "returns false" do
-            expect(person === Person).to be false
-          end
-        end
-
-        context "when the class is a subclass" do
-
-          it "returns false" do
-            expect(person === Doctor).to be false
-          end
+        it "returns false" do
+          expect(person === Doctor).to be false
         end
+      end
 
-        context "when the class is a superclass" do
+      context "when the class is a superclass" do
 
-          it "returns false" do
-            expect(Doctor.new === Person).to be false
-          end
+        it "returns false" do
+          expect(Doctor.new === Person).to be false
         end
       end
     end
@@ -291,12 +189,6 @@ describe Mongoid::Equality do
     it "compares based on the document id" do
       expect(first <=> second).to eq(-1)
     end
-    
-    it "doesn't break if one isn't a document" do
-      expect do
-        first <=> "Foo"
-      end.to_not raise_error
-    end
   end
 
   describe "#eql?" do

data/spec/mongoid/errors/ambiguous_relationship_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require 'spec_helper'
 

data/spec/mongoid/errors/attribute_not_loaded_spec.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require "spec_helper"
+
+describe Mongoid::Errors::AttributeNotLoaded do
+
+  describe "#message" do
+
+    let(:error) do
+      described_class.new(Band, :label)
+    end
+
+    it "contains the problem in the message" do
+      expect(error.message).to include(
+        "Attempted to access attribute 'label' on Band which was not loaded."
+      )
+    end
+
+    it "contains the summary in the message" do
+      expect(error.message).to include(
+        "You loaded an instance of Band using a query projection method"
+      )
+    end
+
+    it "contains the resolution in the message" do
+      expect(error.message).to include(
+        "Ensure your query projection methods such as `.only` and `.without`"
+      )
+    end
+  end
+end

data/spec/mongoid/errors/callback_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/delete_restriction_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/document_not_destroyed_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/document_not_found_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_collection_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_config_file_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_config_option_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_field_option_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_field_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_field_type_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_find_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/errors/invalid_includes_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"