mongoid 8.1.7 → 9.0.0

data/spec/mongoid/touchable_spec_models.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 module TouchableSpec
   module Embedded
@@ -16,9 +17,13 @@ module TouchableSpec
       include Mongoid::Document
       include Mongoid::Timestamps
 
+      field :last_used_at, type: Time
+      field :level, type: Integer
+
       embedded_in :building, touch: false, class_name: "TouchableSpec::Embedded::Building"
 
-      field :last_used_at, type: Time
+      embeds_many :keypads, class_name: "TouchableSpec::Embedded::Keypad"
+      embeds_many :cameras, class_name: "TouchableSpec::Embedded::Camera"
     end
 
     class Floor
@@ -26,8 +31,40 @@ module TouchableSpec
       include Mongoid::Timestamps
 
       field :level, type: Integer
+      field :last_used_at, type: Time
 
       embedded_in :building, touch: true, class_name: "TouchableSpec::Embedded::Building"
+
+      embeds_many :chairs, class_name: "TouchableSpec::Embedded::Chair"
+      embeds_many :sofas, class_name: "TouchableSpec::Embedded::Sofa"
+    end
+
+    class Keypad
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: false, class_name: "TouchableSpec::Embedded::Entrance"
+    end
+
+    class Camera
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: true, class_name: "TouchableSpec::Embedded::Entrance"
+    end
+
+    class Chair
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: false, class_name: "TouchableSpec::Embedded::Floor"
+    end
+
+    class Sofa
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: true, class_name: "TouchableSpec::Embedded::Floor"
     end
   end
 
@@ -44,7 +81,15 @@ module TouchableSpec
       include Mongoid::Document
       include Mongoid::Timestamps
 
+      field :level, type: Integer
+
       belongs_to :building, touch: false, class_name: "TouchableSpec::Referenced::Building"
+
+      embeds_many :keypads, class_name: "TouchableSpec::Referenced::Keypad"
+      embeds_many :cameras, class_name: "TouchableSpec::Referenced::Camera"
+
+      has_many :plants, class_name: "TouchableSpec::Referenced::Plant"
+      has_many :windows, class_name: "TouchableSpec::Referenced::Window"
     end
 
     class Floor
@@ -54,6 +99,56 @@ module TouchableSpec
       field :level, type: Integer
 
       belongs_to :building, touch: true, class_name: "TouchableSpec::Referenced::Building"
+
+      embeds_many :chairs, class_name: "TouchableSpec::Referenced::Chair"
+      embeds_many :sofas, class_name: "TouchableSpec::Referenced::Sofa"
+
+      has_many :plants, class_name: "TouchableSpec::Referenced::Plant"
+      has_many :windows, class_name: "TouchableSpec::Referenced::Window"
+    end
+
+    class Plant
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :floor, touch: false, class_name: "TouchableSpec::Referenced::Floor"
+      belongs_to :entrance, touch: false, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Window
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      belongs_to :floor, touch: true, class_name: "TouchableSpec::Referenced::Floor"
+      belongs_to :entrance, touch: true, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Keypad
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: false, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Camera
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :entrance, touch: true, class_name: "TouchableSpec::Referenced::Entrance"
+    end
+
+    class Chair
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: false, class_name: "TouchableSpec::Referenced::Floor"
+    end
+
+    class Sofa
+      include Mongoid::Document
+      include Mongoid::Timestamps
+
+      embedded_in :floor, touch: true, class_name: "TouchableSpec::Referenced::Floor"
     end
   end
 end

data/spec/mongoid/traversable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/associated_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -37,18 +38,12 @@ describe Mongoid::Validatable::AssociatedValidator do
           User.new(name: "test")
         end
 
-        let(:description1) do
-          Description.new
-        end
-
-        let(:description2) do
+        let(:description) do
           Description.new
         end
 
         before do
-          user.descriptions << description1
-          user.descriptions << description2
-          user.valid?
+          user.descriptions << description
         end
 
         it "only validates the parent once" do
@@ -56,16 +51,12 @@ describe Mongoid::Validatable::AssociatedValidator do
         end
 
         it "adds the errors from the relation" do
+          user.valid?
           expect(user.errors[:descriptions]).to_not be_nil
         end
 
-        it 'reports all failed validations' do
-          errors = user.descriptions.flat_map { |d| d.errors[:details] }
-          expect(errors.length).to be == 2
-        end
-
         it "only validates the child once" do
-          expect(description1).to_not be_valid
+          expect(description).to_not be_valid
         end
       end
 

data/spec/mongoid/validatable/format_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/length_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/numericality_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/validatable/presence_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require_relative '../association/referenced/has_one_models'

data/spec/mongoid/validatable/uniqueness_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -8,6 +9,28 @@ describe Mongoid::Validatable::UniquenessValidator do
 
     context "when the document is a root document" do
 
+      context "when setting the read preference to non-primary" do
+
+        before do
+          Dictionary.validates_uniqueness_of :name
+        end
+
+        after do
+          Dictionary.reset_callbacks(:validate)
+        end
+
+        it "reads from the primary" do
+          expect_any_instance_of(Mongoid::Criteria).to receive(:read).once.and_wrap_original do |m, *args, **kwargs|
+            crit = m.call(*args, **kwargs)
+            expect(crit.view.options["read"]).to eq({ "mode" => :primary })
+            crit
+          end
+          Dictionary.with(read: { mode: :secondary }) do |klass|
+            klass.create!(name: "Websters")
+          end
+        end
+      end
+
       context "when adding custom persistence options" do
 
         before do
@@ -1634,6 +1657,30 @@ describe Mongoid::Validatable::UniquenessValidator do
         word.definitions.create!(description: "2")
       end
 
+      context "when setting the read preference to non-primary" do
+
+        before do
+          Definition.validates_uniqueness_of :description
+        end
+
+        after do
+          Definition.reset_callbacks(:validate)
+        end
+
+        let(:word) { Word.create! }
+
+        it "reads from the primary" do
+          expect_any_instance_of(Mongoid::Criteria).to receive(:read).once.and_wrap_original do |m, *args, **kwargs|
+            crit = m.call(*args, **kwargs)
+            expect(crit.options[:read]).to eq({ mode: :primary })
+            crit
+          end
+          Definition.with(read: { mode: :secondary }) do |klass|
+            word.definitions.create!
+          end
+        end
+      end
+
       context "when a document is being destroyed" do
 
         before do
@@ -2486,9 +2533,7 @@ describe Mongoid::Validatable::UniquenessValidator do
       end
 
       after do
-        # i18n 1.0 requires +send+ because +translations+ aren't public.
-        # Newer i18n versions have it as public.
-        I18n.backend.send(:translations).delete(:fr)
+        I18n.backend.translations.delete(:fr)
       end
 
       it "correctly translates the error message" do

data/spec/mongoid/validatable_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/warnings_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -80,6 +81,32 @@ describe Mongoid do
       end
       Mongoid.disconnect_clients
     end
+
+    it "returns true" do
+      expect(Mongoid.disconnect_clients).to eq(true)
+    end
+  end
+
+  describe ".reconnect_clients" do
+
+    let(:clients) do
+      Mongoid::Clients.clients.values
+    end
+
+    before do
+      Band.all.entries
+    end
+
+    it "reconnects all active clients" do
+      clients.each do |client|
+        expect(client).to receive(:reconnect).and_call_original
+      end
+      Mongoid.reconnect_clients
+    end
+
+    it "returns true" do
+      expect(Mongoid.reconnect_clients).to eq(true)
+    end
   end
 
   describe ".client" do

data/spec/rails/controller_extension/controller_runtime_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 require "mongoid/railties/controller_runtime"

data/spec/rails/mongoid_spec.rb

@@ -1,48 +1,41 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
+require "support/feature_sandbox"
 
 describe "Rails::Mongoid" do
+  let(:model_root) do
+    File.absolute_path(
+      File.join(
+        File.dirname(__FILE__),
+        "../support/models/sandbox"
+      ))
+  end
 
-  before(:all) do
-    require "rails/mongoid"
-    ::Mongoid.models.delete_if do |model|
-      ![ User, Account, Address, AddressNumber ].include?(model)
+  around :each do |example|
+    FeatureSandbox.quarantine do
+      require "rails/mongoid"
+      $LOAD_PATH.push(model_root)
+      example.run
     end
   end
 
   describe ".preload_models" do
+    let(:app) { double(config: config) }
+    let(:config) { double(paths: paths) }
+    let(:paths) { { "app/models" => path } }
+    let(:path) { double(expanded: [ model_root ]) }
 
-    let(:app) do
-      double(config: config)
-    end
-
-    let(:config) do
-      double(paths: paths)
-    end
-
-    let(:paths) do
-      double('[]' => path)
-    end
-
-    let(:path) do
-      double(expanded: [ "/rails/root/app/models" ])
-    end
+    before { Rails::Mongoid.preload_models(app) }
 
     context "when preload models config is false" do
       config_override :preload_models, false
 
-      let(:files) do
-        [
-          "/rails/root/app/models/user.rb",
-          "/rails/root/app/models/address.rb"
-        ]
-      end
-
       it "does not load any models" do
-        allow(Dir).to receive(:glob).with("/rails/root/app/models/**/*.rb").and_return(files)
-        expect(Rails::Mongoid).to receive(:load_model).never
-        Rails::Mongoid.preload_models(app)
+        expect(defined?(SandboxMessage)).to be_nil
+        expect(defined?(SandboxUser)).to be_nil
+        expect(defined?(SandboxComment)).to be_nil
       end
     end
 
@@ -50,96 +43,12 @@ describe "Rails::Mongoid" do
       config_override :preload_models, true
 
       context "when all models are in the models directory" do
-
-        let(:files) do
-          [
-            "/rails/root/app/models/user.rb",
-            "/rails/root/app/models/address.rb"
-          ]
-        end
-
-        before do
-          expect(Dir).to receive(:glob).with("/rails/root/app/models/**/*.rb").and_return(files)
-        end
-
-        it "requires the models by basename" do
-          expect(Rails::Mongoid).to receive(:load_model).with("address")
-          expect(Rails::Mongoid).to receive(:load_model).with("user")
-          Rails::Mongoid.preload_models(app)
-        end
-      end
-
-      context "when models exist in subdirectories" do
-
-        let(:files) do
-          [ "/rails/root/app/models/mongoid/behavior.rb" ]
-        end
-
-        before do
-          expect(Dir).to receive(:glob).with("/rails/root/app/models/**/*.rb").and_return(files)
-        end
-
-        it "requires the models by subdirectory and basename" do
-          expect(Rails::Mongoid).to receive(:load_model).with("mongoid/behavior")
-          Rails::Mongoid.preload_models(app)
+        it "requires the models" do
+          expect(SandboxMessage.ancestors).to include(Mongoid::Document)
+          expect(SandboxUser.ancestors).to include(Mongoid::Document)
+          expect(SandboxComment.ancestors).to include(Mongoid::Document)
         end
       end
     end
   end
-
-  describe ".load_models" do
-
-    let(:app) do
-      double(config: config)
-    end
-
-    let(:config) do
-      double(paths: paths)
-    end
-
-    let(:paths) do
-      double('[]' => path)
-    end
-
-    let(:path) do
-      double(expanded: [ "/rails/root/app/models" ])
-    end
-
-    context "even when preload models config is false" do
-      config_override :preload_models, false
-
-      let(:files) do
-        [
-          "/rails/root/app/models/user.rb",
-          "/rails/root/app/models/address.rb"
-        ]
-      end
-
-      it "loads all models" do
-        allow(Dir).to receive(:glob).with("/rails/root/app/models/**/*.rb").and_return(files)
-        expect(Rails::Mongoid).to receive(:load_model).with("address")
-        expect(Rails::Mongoid).to receive(:load_model).with("user")
-        Rails::Mongoid.load_models(app)
-      end
-    end
-
-    context "when list of models to load was configured" do
-      config_override :preload_models, %w(user AddressNumber)
-
-      let(:files) do
-        [
-          "/rails/root/app/models/user.rb",
-          "/rails/root/app/models/address.rb"
-        ]
-      end
-
-      it "loads selected models only" do
-        allow(Dir).to receive(:glob).with("/rails/root/app/models/**/*.rb").and_return(files)
-        expect(Rails::Mongoid).to receive(:load_model).with("user")
-        expect(Rails::Mongoid).to receive(:load_model).with("address_number")
-        expect(Rails::Mongoid).to receive(:load_model).with("address").never
-        Rails::Mongoid.load_models(app)
-      end
-    end
-  end
 end

data/spec/shared/LICENSE

@@ -0,0 +1,20 @@
+Copyright (c) 2020 MongoDB, Inc.
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/spec/shared/bin/get-mongodb-download-url

@@ -0,0 +1,17 @@
+#!/usr/bin/env ruby
+
+desired_version, arch = ARGV
+if arch.nil?
+  STDERR.puts "Usage: get-mongodb-download-url desired-version arch"
+  exit 1
+end
+
+$: << File.join(File.dirname(__FILE__), '../lib')
+require 'mrss/server_version_registry'
+
+begin
+  puts Mrss::ServerVersionRegistry.new(desired_version, arch).download_url
+rescue Mrss::ServerVersionRegistry::Error => exc
+  STDERR.puts "Error: #{exc}"
+  exit 2
+end

data/spec/shared/bin/s3-copy

@@ -0,0 +1,45 @@
+#!/usr/bin/env ruby
+
+require 'optparse'
+require 'aws-sdk-s3'
+
+options = {}
+OptionParser.new do |opts|
+  opts.banner = "Usage: s3-copy options"
+
+  opts.on("-r", "--region=REGION", "AWS region to use (default us-east-1)") do |v|
+    options[:region] = v
+  end
+
+  opts.on("-p", "--param=KEY=VALUE", "Specify parameter for new files") do |v|
+    options[:params] ||= {}
+    k, v = v.split('=', 2)
+    options[:params][k.to_sym] = v
+  end
+
+  opts.on("-f", "--from=BUCKET:PATH", "Bucket name and key (or path) to copy from") do |v|
+    options[:from] = v
+  end
+
+  opts.on("-t", "--to=BUCKET:PATH", "Bucket name and key (or path) to write to (may be specified more than once)") do |v|
+    options[:to] ||= []
+    options[:to] << v
+  end
+end.parse!
+
+ENV['AWS_REGION'] ||= options[:region] || 'us-east-1'
+
+bucket, key = options.fetch(:from).split(':', 2)
+
+s3 = Aws::S3::Client.new
+
+options.fetch(:to).each do |dest|
+  STDERR.puts "Copying to #{dest}"
+  dbucket, dkey = dest.split(':', 2)
+  s3.copy_object(
+    bucket: dbucket,
+    key: dkey,
+    copy_source: "/#{bucket}/#{key}",
+    **options[:params] || {},
+  )
+end

data/spec/shared/bin/s3-upload

@@ -0,0 +1,69 @@
+#!/usr/bin/env ruby
+
+require 'optparse'
+require 'aws-sdk-s3'
+
+options = {}
+OptionParser.new do |opts|
+  opts.banner = "Usage: s3-upload options"
+
+  opts.on("-r", "--region=REGION", "AWS region to use (default us-east-1)") do |v|
+    options[:region] = v
+  end
+
+  opts.on("-p", "--param=KEY=VALUE", "Specify parameter for S3 upload") do |v|
+    options[:params] ||= {}
+    k, v = v.split('=', 2)
+    options[:params][k.to_sym] = v
+  end
+
+  opts.on("-f", "--file=PATH", "Path to the file to upload, - to upload standard input") do |v|
+    options[:file] = v
+  end
+
+  opts.on("-w", "--write=BUCKET:PATH", "Bucket name and key (or path) to upload to") do |v|
+    options[:write] = v
+  end
+
+  opts.on("-c", "--copy=BUCKET:PATH", "Bucket name and key (or path) to copy to (may be specified more than once)") do |v|
+    options[:copy] ||= []
+    options[:copy] << v
+  end
+end.parse!
+
+ENV['AWS_REGION'] ||= options[:region] || 'us-east-1'
+
+def upload(f, options)
+  s3 = Aws::S3::Client.new
+  write = options.fetch(:write)
+  STDERR.puts "Writing #{write}"
+  bucket, key = write.split(':', 2)
+  s3.put_object(
+    body: f.read,
+    bucket: bucket,
+    key: key,
+    **options[:params] || {},
+  )
+  if copy = options[:copy]
+    copy.each do |dest|
+      STDERR.puts "Copying to #{dest}"
+      dbucket, dkey = dest.split(':', 2)
+      s3.copy_object(
+        bucket: dbucket,
+        key: dkey,
+        copy_source: "/#{bucket}/#{key}",
+        **options[:params] || {},
+      )
+    end
+  end
+end
+
+if options[:file] == '-'
+  upload(STDIN, options)
+elsif options[:file]
+  File.open(options[:file]) do |f|
+    upload(f, options)
+  end
+else
+  upload(STDIN, options)
+end