mongoid 8.1.6 → 9.0.0

data/spec/mongoid/extensions/false_class_spec.rb

@@ -1,16 +1,10 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
 describe Mongoid::Extensions::FalseClass do
 
-  describe "#__sortable__" do
-
-    it "returns 0" do
-      expect(false.__sortable__).to eq(0)
-    end
-  end
-
   describe "#is_a?" do
 
     context "when provided a Boolean" do

data/spec/mongoid/extensions/float_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -20,19 +21,12 @@ describe Mongoid::Extensions::Float do
 
     let(:expected_time) { Time.at(float).in_time_zone }
 
-    context "when using active support's time zone" do
-      include_context 'using AS time zone'
+    context "when setting ActiveSupport time zone" do
+      include_context 'setting ActiveSupport time zone'
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
       it_behaves_like 'maintains precision when mongoized'
     end
-
-    context "when not using active support's time zone" do
-      include_context 'not using AS time zone'
-
-      it_behaves_like 'mongoizes to Time'
-      it_behaves_like 'maintains precision when mongoized'
-    end
   end
 
   [ :mongoize, :demongoize ].each do |method|

data/spec/mongoid/extensions/hash_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -162,125 +163,6 @@ describe Mongoid::Extensions::Hash do
     end
   end
 
-  describe "#__consolidate__" do
-
-    context "when the hash already contains the key" do
-
-      context "when the $set is first" do
-
-        let(:hash) do
-          { "$set" => { name: "Tool" }, likes: 10, "$inc" => { plays: 1 }}
-        end
-
-        let(:consolidated) do
-          hash.__consolidate__(Band)
-        end
-
-        it "moves the non hash values under the provided key" do
-          expect(consolidated).to eq({
-            "$set" => { 'name' => "Tool", likes: 10 }, "$inc" => { 'plays' => 1 }
-          })
-        end
-      end
-
-      context "when the $set is not first" do
-
-        let(:hash) do
-          { likes: 10, "$inc" => { plays: 1 }, "$set" => { name: "Tool" }}
-        end
-
-        let(:consolidated) do
-          hash.__consolidate__(Band)
-        end
-
-        it "moves the non hash values under the provided key" do
-          expect(consolidated).to eq({
-            "$set" => { likes: 10, 'name' => "Tool" }, "$inc" => { 'plays' => 1 }
-          })
-        end
-      end
-    end
-
-    context "when the hash does not contain the key" do
-
-      let(:hash) do
-        { likes: 10, "$inc" => { plays: 1 }, name: "Tool"}
-      end
-
-      let(:consolidated) do
-        hash.__consolidate__(Band)
-      end
-
-      it "moves the non hash values under the provided key" do
-        expect(consolidated).to eq({
-          "$set" => { likes: 10, name: "Tool" }, "$inc" => { 'plays' => 1 }
-        })
-      end
-    end
-  end
-
-  context "when the hash key is a string" do
-
-    let(:hash) do
-      { "100" => { "name" => "hundred" } }
-    end
-
-    let(:nested) do
-      hash.__nested__("100.name")
-    end
-
-    it "should retrieve a nested value under the provided key" do
-      expect(nested).to eq "hundred"
-    end
-
-    context 'and the value is falsey' do
-      let(:hash) do
-        { "100" => { "name" => false } }
-      end
-      it "should retrieve the falsey nested value under the provided key" do
-        expect(nested).to eq false
-      end
-    end
-
-    context 'and the value is nil' do
-      let(:hash) do
-        { "100" => { 0 => "Please don't return this value!" } }
-      end
-      it "should retrieve the nil nested value under the provided key" do
-        expect(nested).to eq nil
-      end
-    end
-  end
-
-  context "when the hash key is an integer" do
-    let(:hash) do
-      { 100 => { "name" => "hundred" } }
-    end
-
-    let(:nested) do
-      hash.__nested__("100.name")
-    end
-
-    it "should retrieve a nested value under the provided key" do
-      expect(nested).to eq("hundred")
-    end
-  end
-
-  context "when the parent key is not present" do
-
-    let(:hash) do
-      { "101" => { "name" => "hundred and one" } }
-    end
-
-    let(:nested) do
-      hash.__nested__("100.name")
-    end
-
-    it "should return nil" do
-      expect(nested).to eq(nil)
-    end
-  end
-
   describe ".demongoize" do
 
     let(:hash) do
@@ -335,6 +217,10 @@ describe Mongoid::Extensions::Hash do
       it "converts the elements properly" do
         expect(mongoized[:date]).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
       end
+
+      it "mongoizes to a BSON::Document" do
+        expect(mongoized).to be_a(BSON::Document)
+      end
     end
 
     context "when object is nil" do
@@ -356,6 +242,20 @@ describe Mongoid::Extensions::Hash do
         expect(mongoized).to be_nil
       end
     end
+
+    describe "when mongoizing a BSON::Document" do
+      let(:mongoized) do
+        Hash.mongoize(BSON::Document.new({ x: 1, y: 2 }))
+      end
+
+      it "returns the same hash" do
+        expect(mongoized).to eq({ "x" => 1, "y" => 2 })
+      end
+
+      it "returns a BSON::Document" do
+        expect(mongoized).to be_a(BSON::Document)
+      end
+    end
   end
 
   describe "#mongoize" do
@@ -394,107 +294,4 @@ describe Mongoid::Extensions::Hash do
       expect(Hash).to be_resizable
     end
   end
-
-  shared_examples_for 'unsatisfiable criteria method' do
-
-    context "when the hash has only an empty _id criteria" do
-
-      let(:hash) do
-        { "_id" => { "$in" => [] }}
-      end
-
-      it "is true" do
-        expect(hash.send(meth)).to be true
-      end
-    end
-
-    context "when the hash has an empty _id criteria and another criteria" do
-
-      let(:hash) do
-        { "_id" => { "$in" => [] }, 'foo' => 'bar'}
-      end
-
-      it "is false" do
-        expect(hash.send(meth)).to be false
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $and" do
-
-      let(:hash) do
-        {'$and' => [{ "_id" => { "$in" => [] }}]}
-      end
-
-      it "is true" do
-        expect(hash.send(meth)).to be true
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $and and another criteria at top level" do
-
-      let(:hash) do
-        {'$and' => [{ "_id" => { "$in" => [] }}], 'foo' => 'bar'}
-      end
-
-      it "is false" do
-        expect(hash.send(meth)).to be false
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $and and another criteria in $and" do
-
-      let(:hash) do
-        {'$and' => [{ "_id" => { "$in" => [] }}, {'foo' => 'bar'}]}
-      end
-
-      it "is true" do
-        expect(hash.send(meth)).to be true
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $and and another criteria in $and value" do
-
-      let(:hash) do
-        {'$and' => [{ "_id" => { "$in" => [] }, 'foo' => 'bar'}]}
-      end
-
-      it "is false" do
-        expect(hash.send(meth)).to be false
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $or" do
-
-      let(:hash) do
-        {'$or' => [{ "_id" => { "$in" => [] }}]}
-      end
-
-      it "is false" do
-        expect(hash.send(meth)).to be false
-      end
-    end
-
-    context "when the hash has an empty _id criteria via $nor" do
-
-      let(:hash) do
-        {'$nor' => [{ "_id" => { "$in" => [] }}]}
-      end
-
-      it "is false" do
-        expect(hash.send(meth)).to be false
-      end
-    end
-  end
-
-  describe "#blank_criteria?" do
-    let(:meth) { :blank_criteria? }
-
-    it_behaves_like 'unsatisfiable criteria method'
-  end
-
-  describe "#_mongoid_unsatisfiable_criteria?" do
-    let(:meth) { :_mongoid_unsatisfiable_criteria? }
-
-    it_behaves_like 'unsatisfiable criteria method'
-  end
 end

data/spec/mongoid/extensions/integer_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -20,17 +21,11 @@ describe Mongoid::Extensions::Integer do
 
     let(:expected_time) { Time.at(integer).in_time_zone }
 
-    context "when using active support's time zone" do
-      include_context 'using AS time zone'
+    context "when setting ActiveSupport time zone" do
+      include_context 'setting ActiveSupport time zone'
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
     end
-
-    context "when not using active support's time zone" do
-      include_context 'not using AS time zone'
-
-      it_behaves_like 'mongoizes to Time'
-    end
   end
 
   [ :mongoize, :demongoize ].each do |method|

data/spec/mongoid/extensions/module_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/nil_class_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/object_id_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/object_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -15,13 +16,6 @@ describe Mongoid::Extensions::Object do
     end
   end
 
-  describe "#__find_args__" do
-
-    it "returns self" do
-      expect(object.__find_args__).to eq(object)
-    end
-  end
-
   describe "#__mongoize_object_id__" do
 
     it "returns self" do
@@ -29,111 +23,6 @@ describe Mongoid::Extensions::Object do
     end
   end
 
-  describe ".__mongoize_fk__" do
-
-    context "when the related model uses object ids" do
-
-      let(:association) do
-        Game.relations["person"]
-      end
-
-      context "when provided an object id" do
-
-        let(:object_id) do
-          BSON::ObjectId.new
-        end
-
-        let(:fk) do
-          Object.__mongoize_fk__(association, object_id)
-        end
-
-        it "returns the object id" do
-          expect(fk).to eq(object_id)
-        end
-      end
-
-      context "when provided a string" do
-
-        context "when the string is a legal object id" do
-
-          let(:object_id) do
-            BSON::ObjectId.new
-          end
-
-          let(:fk) do
-            Object.__mongoize_fk__(association, object_id.to_s)
-          end
-
-          it "returns the object id" do
-            expect(fk).to eq(object_id)
-          end
-        end
-
-        context "when the string is not a legal object id" do
-
-          let(:string) do
-            "blah"
-          end
-
-          let(:fk) do
-            Object.__mongoize_fk__(association, string)
-          end
-
-          it "returns the string" do
-            expect(fk).to eq(string)
-          end
-        end
-
-        context "when the string is blank" do
-
-          let(:fk) do
-            Object.__mongoize_fk__(association, "")
-          end
-
-          it "returns nil" do
-            expect(fk).to be_nil
-          end
-        end
-      end
-
-      context "when provided nil" do
-
-        let(:fk) do
-          Object.__mongoize_fk__(association, nil)
-        end
-
-        it "returns nil" do
-          expect(fk).to be_nil
-        end
-      end
-
-      context "when provided an empty array" do
-
-        let(:fk) do
-          Object.__mongoize_fk__(association, [])
-        end
-
-        it "returns an empty array" do
-          expect(fk).to eq([])
-        end
-      end
-    end
-  end
-
-  describe "#__mongoize_time__" do
-
-    it "returns self" do
-      expect(object.__mongoize_time__).to eq(object)
-    end
-  end
-
-  describe "#__sortable__" do
-
-    it "returns self" do
-      expect(object.__sortable__).to eq(object)
-    end
-  end
-
   describe ".demongoize" do
 
     let(:object) do
@@ -145,45 +34,6 @@ describe Mongoid::Extensions::Object do
     end
   end
 
-  describe "#do_or_do_not" do
-
-    context "when the object is nil" do
-
-      let(:result) do
-        nil.do_or_do_not(:not_a_method, "The force is strong with you")
-      end
-
-      it "returns nil" do
-        expect(result).to be_nil
-      end
-    end
-
-    context "when the object is not nil" do
-
-      context "when the object responds to the method" do
-
-        let(:result) do
-          [ "Yoda", "Luke" ].do_or_do_not(:join, ",")
-        end
-
-        it "returns the result of the method" do
-          expect(result).to eq("Yoda,Luke")
-        end
-      end
-
-      context "when the object does not respond to the method" do
-
-        let(:result) do
-          "Yoda".do_or_do_not(:use, "The Force", 1000)
-        end
-
-        it "returns the result of the method" do
-          expect(result).to be_nil
-        end
-      end
-    end
-  end
-
   describe ".mongoize" do
 
     let(:object) do
@@ -213,24 +63,6 @@ describe Mongoid::Extensions::Object do
     end
   end
 
-  describe "#you_must" do
-
-    context "when the object is frozen" do
-
-      let(:person) do
-        Person.new.tap { |peep| peep.freeze }
-      end
-
-      let(:result) do
-        person.you_must(:aliases=, [])
-      end
-
-      it "returns nil" do
-        expect(result).to be_nil
-      end
-    end
-  end
-
   describe "#remove_ivar" do
 
     context "when the instance variable is defined" do
@@ -278,11 +110,4 @@ describe Mongoid::Extensions::Object do
       expect(object.numeric?).to eq(false)
     end
   end
-
-  describe "#blank_criteria?" do
-
-    it "is false" do
-      expect(object.blank_criteria?).to be false
-    end
-  end
 end

data/spec/mongoid/extensions/range_spec.rb

@@ -1,20 +1,10 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
 describe Mongoid::Extensions::Range do
 
-  describe "#__find_args__" do
-
-    let(:range) do
-      1..3
-    end
-
-    it "returns the range as an array" do
-      expect(range.__find_args__).to eq([ 1, 2, 3 ])
-    end
-  end
-
   describe ".demongoize" do
     subject { Range.demongoize(hash) }
 

data/spec/mongoid/extensions/raw_value_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+# rubocop:todo all
+
+require "spec_helper"
+
+describe Mongoid::RawValue do
+
+  describe "::()" do
+    subject { Mongoid::RawValue(raw_value).raw_value }
+
+    context 'when raw_value is a String' do
+      let(:raw_value) { 'Hello World!' }
+
+      it 'returns the value' do
+        is_expected.to eq 'Hello World!'
+      end
+    end
+
+    context 'when raw_value is an Integer' do
+      let(:raw_value) { 42 }
+
+      it 'returns the value' do
+        is_expected.to eq 42
+      end
+    end
+  end
+
+  describe "#raw_value" do
+    subject { described_class.new(raw_value).raw_value }
+
+    context 'when raw_value is a String' do
+      let(:raw_value) { 'Hello World!' }
+
+      it 'returns the value' do
+        is_expected.to eq 'Hello World!'
+      end
+    end
+
+    context 'when raw_value is an Integer' do
+      let(:raw_value) { 42 }
+
+      it 'returns the value' do
+        is_expected.to eq 42
+      end
+    end
+  end
+
+  describe "#inspect" do
+    subject { described_class.new(raw_value).inspect }
+
+    context 'when raw_value is a String' do
+      let(:raw_value) { 'Hello World!' }
+
+      it 'returns the inspection' do
+        is_expected.to eq 'RawValue: "Hello World!"'
+      end
+    end
+
+    context 'when raw_value is an Integer' do
+      let(:raw_value) { 42 }
+
+      it 'returns the inspection' do
+        is_expected.to eq 'RawValue: 42'
+      end
+    end
+  end
+end

data/spec/mongoid/extensions/regexp_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 

data/spec/mongoid/extensions/set_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+# rubocop:todo all
 
 require "spec_helper"
 
@@ -112,9 +113,7 @@ describe Mongoid::Extensions::Set do
       end
 
       before do
-        expect(BigDecimal).to receive(:mongoize).exactly(4).times.and_wrap_original do |m, *args|
-          1
-        end
+        expect(BigDecimal).to receive(:mongoize).exactly(4).times.and_return(1)
       end
 
       context "when the input is a set" do