mongoid 8.0.3 → 8.1.0

data/spec/mongoid/findable_spec.rb

@@ -75,12 +75,7 @@ describe Mongoid::Findable do
       context "when the document is not found" do
 
         context "when raising a not found error" do
-
-          let!(:raise_option) { Mongoid.raise_not_found_error }
-
-          before { Mongoid.raise_not_found_error = true }
-
-          after { Mongoid.raise_not_found_error = raise_option }
+          config_override :raise_not_found_error, true
 
           it "raises an error" do
             expect {
@@ -90,12 +85,7 @@ describe Mongoid::Findable do
         end
 
         context "when raising no error" do
-
-          let!(:raise_option) { Mongoid.raise_not_found_error }
-
-          before { Mongoid.raise_not_found_error = false }
-
-          after { Mongoid.raise_not_found_error = raise_option }
+          config_override :raise_not_found_error, false
 
           it "returns nil" do
             expect(person.messages.find_by(body: 'bar')).to be_nil
@@ -134,12 +124,7 @@ describe Mongoid::Findable do
     context "when the document is not found" do
 
       context "when raising a not found error" do
-
-        let!(:raise_option) { Mongoid.raise_not_found_error }
-
-        before { Mongoid.raise_not_found_error = true }
-
-        after { Mongoid.raise_not_found_error = raise_option }
+        config_override :raise_not_found_error, true
 
         it "raises an error" do
           expect {
@@ -149,12 +134,7 @@ describe Mongoid::Findable do
       end
 
       context "when raising no error" do
-
-        let!(:raise_option) { Mongoid.raise_not_found_error }
-
-        before { Mongoid.raise_not_found_error = false }
-
-        after { Mongoid.raise_not_found_error = raise_option }
+        config_override :raise_not_found_error, false
 
         context "when no block is provided" do
 
@@ -222,31 +202,411 @@ describe Mongoid::Findable do
 
     describe "##{method}" do
 
-      let!(:person) do
+      let!(:person1) do
+        Person.create!
+      end
+
+      let!(:person2) do
         Person.create!
       end
 
       it "returns the first matching document" do
-        expect(Person.send(method)).to eq(person)
+        expect(Person.send(method)).to eq(person1)
       end
 
       it "passes the limit through" do
-        expect(Person.last(1)).to eq([ person ])
+        expect(Person.send(method, 1)).to eq([ person1 ])
       end
+
+      it "returns nil when no documents are found" do
+        expect(Band.send(method)).to be_nil
+      end
+    end
+  end
+
+  describe "#first!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the first matching document" do
+      expect(Person.first!).to eq(person1)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.first!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
     end
   end
 
   describe "#last" do
-    let!(:person) do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
       Person.create!
     end
 
     it "returns the first matching document" do
-      expect(Person.last).to eq(person)
+      expect(Person.last).to eq(person2)
     end
 
     it "passes the limit through" do
-      expect(Person.last(1)).to eq([ person ])
+      expect(Person.last(1)).to eq([ person2 ])
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.last).to be_nil
+    end
+  end
+
+  describe "#last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the last matching document" do
+      expect(Person.last!).to eq(person2)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#second" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the second matching document" do
+      expect(Person.second).to eq(person2)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.second).to be_nil
+    end
+  end
+
+  describe "#second!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the second matching document" do
+      expect(Person.second!).to eq(person2)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.second!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#third" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    it "returns the third matching document" do
+      expect(Person.third).to eq(person3)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.third).to be_nil
+    end
+  end
+
+  describe "#third!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    it "returns the third matching document" do
+      expect(Person.third!).to eq(person3)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.third!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#fourth" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    it "returns the fourth matching document" do
+      expect(Person.fourth).to eq(person4)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.fourth).to be_nil
+    end
+  end
+
+  describe "#fourth!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    it "returns the fourth matching document" do
+      expect(Person.fourth!).to eq(person4)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.fourth!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#fifth" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the fifth matching document" do
+      expect(Person.fifth).to eq(person5)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.fifth).to be_nil
+    end
+  end
+
+  describe "#fifth!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the fifth matching document" do
+      expect(Person.fifth!).to eq(person5)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.fifth!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#second_to_last" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the second to last matching document" do
+      expect(Person.second_to_last).to eq(person4)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.second_to_last).to be_nil
+    end
+  end
+
+  describe "#second_to_last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the second to last matching document" do
+      expect(Person.second_to_last!).to eq(person4)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.second_to_last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#third_to_last" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the third to last matching document" do
+      expect(Person.third_to_last).to eq(person3)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.third_to_last).to be_nil
+    end
+  end
+
+  describe "#third_to_last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the third to last matching document" do
+      expect(Person.third_to_last!).to eq(person3)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.third_to_last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
     end
   end
 
@@ -541,10 +901,7 @@ describe Mongoid::Findable do
   context 'when Mongoid is configured to use activesupport time zone' do
     config_override :use_utc, false
     config_override :use_activesupport_time_zone, true
-
-    before do
-      Time.zone = "Asia/Kolkata"
-    end
+    time_zone_override "Asia/Kolkata"
 
     let!(:time) do
       Time.zone.now.tap do |t|

data/spec/mongoid/indexable_spec.rb

@@ -109,7 +109,6 @@ describe Mongoid::Indexable do
 
       after do
         klass.remove_indexes
-        Mongoid::Config.background_indexing = false
       end
 
       let(:indexes) do
@@ -118,20 +117,27 @@ describe Mongoid::Indexable do
         end
       end
 
-      it "creates the indexes by using default background_indexing option" do
-        klass.create_indexes
+      context "when the background_indexing option is false" do
+        config_override :background_indexing, false
+
+        it "creates the indexes correctly" do
+          klass.create_indexes
 
-        index = indexes.get(_type: 1)
-        expect(index[:background]).to eq(Mongoid::Config.background_indexing)
+          index = indexes.get(_type: 1)
+          expect(index[:background]).to be false
+        end
       end
 
-      it "creates the indexes by using specified background_indexing option" do
-        Mongoid::Config.background_indexing = true
+      context "when the background_indexing option is true" do
+        config_override :background_indexing, true
 
-        klass.create_indexes
+        it "creates the indexes correctly" do
 
-        index = indexes.get(_type: 1)
-        expect(index[:background]).to eq(true)
+          klass.create_indexes
+
+          index = indexes.get(_type: 1)
+          expect(index[:background]).to be true
+        end
       end
     end
 

data/spec/mongoid/interceptable_spec.rb

@@ -580,10 +580,22 @@ describe Mongoid::Interceptable do
         end
 
         context "when saving the root" do
+          context 'with prevent_multiple_calls_of_embedded_callbacks enabled' do
+            config_override :prevent_multiple_calls_of_embedded_callbacks, true
 
-          it "only executes the callbacks once for each embed" do
-            expect(note).to receive(:update_saved).twice
-            band.save!
+            it "executes the callbacks only once for each document" do
+              expect(note).to receive(:update_saved).once
+              band.save!
+            end
+          end
+
+          context 'with prevent_multiple_calls_of_embedded_callbacks disabled' do
+            config_override :prevent_multiple_calls_of_embedded_callbacks, false
+
+            it "executes the callbacks once for each ember" do
+              expect(note).to receive(:update_saved).twice
+              band.save!
+            end
           end
         end
       end

data/spec/mongoid/persistable/deletable_spec.rb

@@ -12,14 +12,34 @@ describe Mongoid::Persistable::Deletable do
 
     context "when deleting a readonly document" do
 
-      let(:from_db) do
-        Person.only(:_id).first
+      context "when legacy_attributes is true" do
+        config_override :legacy_readonly, true
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect(from_db.readonly?).to be true
+          expect {
+            from_db.delete
+          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
       end
 
-      it "raises an error" do
-        expect {
-          from_db.delete
-        }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+      context "when legacy_attributes is false" do
+        config_override :legacy_readonly, false
+
+        let(:from_db) do
+          Person.first.tap(&:readonly!)
+        end
+
+        it "raises an error" do
+          expect(from_db.readonly?).to be true
+          expect {
+            from_db.delete
+          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
       end
     end
 

data/spec/mongoid/persistable/destroyable_spec.rb

@@ -12,14 +12,34 @@ describe Mongoid::Persistable::Destroyable do
 
     context "when destroying a readonly document" do
 
-      let(:from_db) do
-        Person.only(:_id).first
+      context "when legacy_attributes is true" do
+        config_override :legacy_readonly, true
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect(from_db.readonly?).to be true
+          expect {
+            from_db.destroy
+          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
       end
 
-      it "raises an error" do
-        expect {
-          from_db.destroy
-        }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+      context "when legacy_attributes is false" do
+        config_override :legacy_readonly, false
+
+        let(:from_db) do
+          Person.first.tap(&:readonly!)
+        end
+
+        it "raises an error" do
+          expect(from_db.readonly?).to be true
+          expect {
+            from_db.destroy
+          }.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
       end
     end
 

data/spec/mongoid/persistable/incrementable_spec.rb

@@ -237,5 +237,42 @@ describe Mongoid::Persistable::Incrementable do
         end
       end
     end
+
+    context "when executing on a readonly document" do
+
+      let(:person) do
+        Person.create!(age: 10, score: 100)
+      end
+
+      context "when legacy_readonly is true" do
+        config_override :legacy_readonly, true
+
+        before do
+          person.__selected_fields = { "age" => 1, "score" => 1 }
+        end
+
+        it "persists the changes" do
+          expect(person).to be_readonly
+          person.inc(age: 15, score: 2)
+          expect(person.age).to eq(25)
+          expect(person.score).to eq(102)
+        end
+      end
+
+      context "when legacy_readonly is false" do
+        config_override :legacy_readonly, false
+
+        before do
+          person.readonly!
+        end
+
+        it "raises a ReadonlyDocument error" do
+          expect(person).to be_readonly
+          expect do
+            person.inc(age: 15, score: 2)
+          end.to raise_error(Mongoid::Errors::ReadonlyDocument)
+        end
+      end
+    end
   end
 end