mongoid 8.0.2 → 8.0.4

data/spec/mongoid/criteria/translator_spec.rb

@@ -0,0 +1,132 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Mongoid::Criteria::Translator do
+  describe "#to_direction" do
+    context "when the value is a string" do
+      context "when ascending" do
+        it "returns 1" do
+          expect(described_class.to_direction("ascending")).to eq(1)
+        end
+      end
+
+      context "when asc" do
+        it "returns 1" do
+          expect(described_class.to_direction("asc")).to eq(1)
+        end
+      end
+
+      context "when ASCENDING" do
+        it "returns 1" do
+          expect(described_class.to_direction("ASCENDING")).to eq(1)
+        end
+      end
+
+      context "when ASC" do
+        it "returns 1" do
+          expect(described_class.to_direction("ASC")).to eq(1)
+        end
+      end
+
+      context "when descending" do
+        it "returns -1" do
+          expect(described_class.to_direction("descending")).to eq(-1)
+        end
+      end
+
+      context "when desc" do
+        it "returns -1" do
+          expect(described_class.to_direction("desc")).to eq(-1)
+        end
+      end
+
+      context "when DESCENDING" do
+        it "returns -1" do
+          expect(described_class.to_direction("DESCENDING")).to eq(-1)
+        end
+      end
+
+      context "when DESC" do
+        it "returns -1" do
+          expect(described_class.to_direction("DESC")).to eq(-1)
+        end
+      end
+    end
+
+    context "when the value is a symbol" do
+      context "when ascending" do
+        it "returns 1" do
+          expect(described_class.to_direction(:ascending)).to eq(1)
+        end
+      end
+  
+      context "when asc" do
+        it "returns 1" do
+          expect(described_class.to_direction(:asc)).to eq(1)
+        end
+      end
+  
+      context "when ASCENDING" do
+        it "returns 1" do
+          expect(described_class.to_direction(:ASCENDING)).to eq(1)
+        end
+      end
+  
+      context "when ASC" do
+        it "returns 1" do
+          expect(described_class.to_direction(:ASC)).to eq(1)
+        end
+      end
+  
+      context "when descending" do
+        it "returns -1" do
+          expect(described_class.to_direction(:descending)).to eq(-1)
+        end
+      end
+  
+      context "when desc" do
+        it "returns -1" do
+          expect(described_class.to_direction(:desc)).to eq(-1)
+        end
+      end
+  
+      context "when DESCENDING" do
+        it "returns -1" do
+          expect(described_class.to_direction(:DESCENDING)).to eq(-1)
+        end
+      end
+  
+      context "when DESC" do
+        it "returns -1" do
+          expect(described_class.to_direction(:DESC)).to eq(-1)
+        end
+      end
+    end
+
+    context "when the value is numeric" do
+      it "should pass the value through unchanged" do
+        expect(described_class.to_direction(1)).to eq(1)
+        expect(described_class.to_direction(-1)).to eq(-1)
+        expect(described_class.to_direction(Math::PI)).to eq(Math::PI)
+      end
+    end
+
+    context "when the value is a hash" do
+      it "should pass the value through unchanged" do
+        expect(described_class.to_direction({})).to eq({})
+        expect(described_class.to_direction(scope: { "$meta" => "textScore" }))
+          .to eq(scope: { "$meta" => "textScore" })
+        expect(described_class.to_direction(a: 1, b: 2)).to eq(a: 1, b: 2)
+      end
+    end
+
+    context "when the value is an unrecognized type" do
+      it "should raise ArgumentError" do
+        expect { described_class.to_direction([]) }.to raise_error(ArgumentError)
+        expect { described_class.to_direction(/a/) }.to raise_error(ArgumentError)
+        expect { described_class.to_direction(Object.new) }.to raise_error(ArgumentError)
+      end
+    end
+  end
+end

data/spec/mongoid/criteria_projection_spec.rb

@@ -171,7 +171,6 @@ describe Mongoid::Criteria do
 
         let(:dictionary) do
           Dictionary.only(:description).first
-
         end
 
         it 'loads all translations' do

data/spec/mongoid/criteria_spec.rb

@@ -2059,7 +2059,7 @@ describe Mongoid::Criteria do
       end
 
       context 'when fallbacks are enabled with a locale list' do
-        require_fallbacks
+        with_i18n_fallbacks
 
         around(:all) do |example|
           prev_fallbacks = I18n.fallbacks.dup

data/spec/mongoid/extensions/big_decimal_spec.rb

@@ -273,6 +273,21 @@ describe Mongoid::Extensions::BigDecimal do
         end
       end
 
+      context "when the value is castable" do
+
+        let(:value) do
+          2.hours
+        end
+
+        before do
+          expect(value).to be_a(ActiveSupport::Duration)
+        end
+
+        it "returns nil" do
+          expect(mongoized).to eq(7200)
+        end
+      end
+
       context "when the value is nil" do
 
         let(:value) do

data/spec/mongoid/extensions/float_spec.rb

@@ -100,10 +100,10 @@ describe Mongoid::Extensions::Float do
           end
         end
 
-        context "when the string is numerical" do
+        context "when the string starts with a number" do
 
-          it "returns the float value for the string" do
-            expect(Float.send(method, "3")).to eq(3)
+          it "returns nil" do
+            expect(Float.send(method, "42bogus")).to be_nil
           end
         end
 
@@ -120,6 +120,13 @@ describe Mongoid::Extensions::Float do
             expect(Float.send(method, nil)).to be_nil
           end
         end
+
+        context "when giving an object that is castable to an Float" do
+
+          it "returns the integer value" do
+            expect(Float.send(method, 2.hours)).to eq(7200)
+          end
+        end
       end
     end
   end

data/spec/mongoid/extensions/integer_spec.rb

@@ -94,10 +94,10 @@ describe Mongoid::Extensions::Integer do
           end
         end
 
-        context "when the string is numerical" do
+        context "when the string starts with a number" do
 
-          it "returns the integer value for the string" do
-            expect(Integer.send(method, "3")).to eq(3)
+          it "returns nil" do
+            expect(Integer.send(method, "42bogus")).to be_nil
           end
         end
 
@@ -114,6 +114,13 @@ describe Mongoid::Extensions::Integer do
             expect(Integer.send(method, nil)).to be_nil
           end
         end
+
+        context "when giving an object that is castable to an Integer" do
+
+          it "returns the integer value" do
+            expect(Integer.send(method, 2.hours)).to eq(7200)
+          end
+        end
       end
     end
   end

data/spec/mongoid/fields/localized_spec.rb

@@ -102,6 +102,29 @@ describe Mongoid::Fields::Localized do
           end
         end
 
+        context "when key is a symbol" do
+
+          let(:value) do
+            field.demongoize({ :de => "This is a test" })
+          end
+
+          it "returns the string from the set locale" do
+            expect(value).to eq("This is a test")
+          end
+        end
+
+
+        context "passing a bogus value" do
+
+          let(:value) do
+            field.demongoize("bogus")
+          end
+
+          it "returns nil" do
+            expect(value).to be_nil
+          end
+        end
+
         context "when the value does not exist" do
 
           context "when not using fallbacks" do
@@ -117,10 +140,7 @@ describe Mongoid::Fields::Localized do
 
           context "when using fallbacks" do
 
-            before(:all) do
-              require "i18n/backend/fallbacks"
-              I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
-            end
+            with_i18n_fallbacks
 
             context "when fallbacks are defined" do
 
@@ -139,6 +159,17 @@ describe Mongoid::Fields::Localized do
                 end
               end
 
+              context "when the fallback translation exists and is a symbol" do
+
+                let(:value) do
+                  field.demongoize({ :es => "testing" })
+                end
+
+                it "returns the fallback translation" do
+                  expect(value).to eq("testing")
+                end
+              end
+
               context "when another fallback translation exists" do
 
                 let(:value) do
@@ -275,10 +306,7 @@ describe Mongoid::Fields::Localized do
 
           context "when using fallbacks" do
 
-            before(:all) do
-              require "i18n/backend/fallbacks"
-              I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
-            end
+            with_i18n_fallbacks
 
             context "when fallbacks are defined" do
 
@@ -476,10 +504,7 @@ describe Mongoid::Fields::Localized do
 
         context "when fallbacks are defined" do
 
-          before(:all) do
-            require "i18n/backend/fallbacks"
-            I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
-          end
+          with_i18n_fallbacks
 
           context "when the lookup does not need to use fallbacks" do
 

data/spec/mongoid/shardable_models.rb

@@ -59,3 +59,17 @@ end
 class SmNotSharded
   include Mongoid::Document
 end
+
+class SmReviewAuthor
+  include Mongoid::Document
+  embedded_in :review, class_name: "SmReview", touch: false
+  field :name, type: String
+end
+
+class SmReview
+  include Mongoid::Document
+
+  embeds_one :author, class_name: "SmReviewAuthor"
+
+  shard_key "author.name" => 1
+end

data/spec/mongoid/shardable_spec.rb

@@ -27,11 +27,11 @@ describe Mongoid::Shardable do
     context 'when full syntax is used' do
       context 'with symbol value' do
         it 'sets shard key fields to symbol value' do
-          SmProducer.shard_key_fields.should == %i(age gender)
+          expect(SmProducer.shard_key_fields).to be == %i(age gender)
         end
 
         it 'sets shard config' do
-          SmProducer.shard_config.should == {
+          expect(SmProducer.shard_config).to be == {
             key: {age: 1, gender: 'hashed'},
             options: {
               unique: true,
@@ -41,37 +41,37 @@ describe Mongoid::Shardable do
         end
 
         it 'keeps hashed as string' do
-          SmProducer.shard_config[:key][:gender].should == 'hashed'
+          expect(SmProducer.shard_config[:key][:gender]).to be == 'hashed'
         end
       end
 
       context 'with string value' do
         it 'sets shard key fields to symbol value' do
-          SmActor.shard_key_fields.should == %i(age gender hello)
+          expect(SmActor.shard_key_fields).to be == %i(age gender hello)
         end
 
         it 'sets shard config' do
-          SmActor.shard_config.should == {
+          expect(SmActor.shard_config).to be == {
             key: {age: 1, gender: 'hashed', hello: 'hashed'},
             options: {},
           }
         end
 
         it 'sets hashed to string' do
-          SmActor.shard_config[:key][:gender].should == 'hashed'
+          expect(SmActor.shard_config[:key][:gender]).to be == 'hashed'
         end
       end
 
       context 'when passed association name' do
         it 'uses foreign key as shard key in shard config' do
-          SmDriver.shard_config.should == {
+          expect(SmDriver.shard_config).to be == {
             key: {age: 1, agency_id: 'hashed'},
             options: {},
           }
         end
 
         it 'uses foreign key as shard key in shard key fields' do
-          SmDriver.shard_key_fields.should == %i(age agency_id)
+          expect(SmDriver.shard_key_fields).to be == %i(age agency_id)
         end
       end
     end
@@ -79,26 +79,26 @@ describe Mongoid::Shardable do
     context 'when shorthand syntax is used' do
       context 'with symbol value' do
         it 'sets shard key fields to symbol value' do
-          SmMovie.shard_key_fields.should == %i(year)
+          expect(SmMovie.shard_key_fields).to be == %i(year)
         end
       end
 
       context 'with string value' do
         it 'sets shard key fields to symbol value' do
-          SmTrailer.shard_key_fields.should == %i(year)
+          expect(SmTrailer.shard_key_fields).to be == %i(year)
         end
       end
 
       context 'when passed association name' do
         it 'uses foreign key as shard key in shard config' do
-          SmDirector.shard_config.should == {
+          expect(SmDirector.shard_config).to be == {
             key: {agency_id: 1},
             options: {},
           }
         end
 
         it 'uses foreign key as shard key in shard key fields' do
-          SmDirector.shard_key_fields.should == %i(agency_id)
+          expect(SmDirector.shard_key_fields).to be == %i(agency_id)
         end
       end
     end
@@ -106,41 +106,80 @@ describe Mongoid::Shardable do
 
   describe '#shard_key_selector' do
     subject { instance.shard_key_selector }
-    let(:klass) { Band }
-    let(:value) { 'a-brand-name' }
+    
+    context 'when key is an immediate attribute' do
+      let(:klass) { Band }
+      let(:value) { 'a-brand-name' }
 
-    before { klass.shard_key(:name) }
+      before { klass.shard_key(:name) }
 
-    context 'when record is new' do
-      let(:instance) { klass.new(name: value) }
+      context 'when record is new' do
+        let(:instance) { klass.new(name: value) }
 
-      it { is_expected.to eq({ 'name' => value }) }
+        it { is_expected.to eq({ 'name' => value }) }
 
-      context 'changing shard key value' do
-        let(:new_value) { 'a-new-value' }
+        context 'changing shard key value' do
+          let(:new_value) { 'a-new-value' }
 
-        before do
-          instance.name = new_value
+          before do
+            instance.name = new_value
+          end
+
+          it { is_expected.to eq({ 'name' => new_value }) }
         end
+      end
+
+      context 'when record is persisted' do
+        let(:instance) { klass.create!(name: value) }
 
-        it { is_expected.to eq({ 'name' => new_value }) }
+        it { is_expected.to eq({ 'name' => value }) }
+
+        context 'changing shard key value' do
+          let(:new_value) { 'a-new-value' }
+
+          before do
+            instance.name = new_value
+          end
+
+          it { is_expected.to eq({ 'name' => new_value }) }
+        end
       end
     end
 
-    context 'when record is persisted' do
-      let(:instance) { klass.create!(name: value) }
+    context 'when key is an embedded attribute' do
+      let(:klass) { SmReview }
+      let(:value) { 'Arthur Conan Doyle' }
+      let(:key)   { 'author.name' }
 
-      it { is_expected.to eq({ 'name' => value }) }
+      context 'when record is new' do
+        let(:instance) { klass.new(author: { name: value }) }
 
-      context 'changing shard key value' do
-        let(:new_value) { 'a-new-value' }
+        it { is_expected.to eq({ key => value }) }
 
-        before do
-          instance.name = new_value
+        context 'changing shard key value' do
+          let(:new_value) { 'Jules Verne' }
+
+          before do
+            instance.author.name = new_value
+          end
+
+          it { is_expected.to eq({ key => new_value }) }
         end
+      end
+
+      context 'when record is persisted' do
+        let(:instance) { klass.create!(author: { name: value }) }
+
+        it { is_expected.to eq({ key => value }) }
+
+        context 'changing shard key value' do
+          let(:new_value) { 'Jules Verne' }
 
-        it 'uses the newly set shard key value' do
-          subject.should == { 'name' => new_value }
+          before do
+            instance.author.name = new_value
+          end
+
+          it { is_expected.to eq({ 'author.name' => new_value }) }
         end
       end
     end
@@ -148,56 +187,109 @@ describe Mongoid::Shardable do
 
   describe '#shard_key_selector_in_db' do
     subject { instance.shard_key_selector_in_db }
-    let(:klass) { Band }
-    let(:value) { 'a-brand-name' }
 
-    before { klass.shard_key(:name) }
+    context 'when key is an immediate attribute' do
+      let(:klass) { Band }
+      let(:value) { 'a-brand-name' }
 
-    context 'when record is new' do
-      let(:instance) { klass.new(name: value) }
+      before { klass.shard_key(:name) }
 
-      it { is_expected.to eq({ 'name' => value }) }
+      context 'when record is new' do
+        let(:instance) { klass.new(name: value) }
 
-      context 'changing shard key value' do
-        let(:new_value) { 'a-new-value' }
+        it { is_expected.to eq({ 'name' => value }) }
 
-        before do
-          instance.name = new_value
-        end
+        context 'changing shard key value' do
+          let(:new_value) { 'a-new-value' }
+
+          before do
+            instance.name = new_value
+          end
 
-        it 'uses the existing shard key value' do
-          subject.should == { 'name' => new_value }
+          it { is_expected.to eq({ 'name' => new_value }) }
         end
       end
-    end
 
-    context 'when record is persisted' do
-      let(:instance) { klass.create!(name: value) }
+      context 'when record is persisted' do
+        let(:instance) { klass.create!(name: value) }
+
+        it { is_expected.to eq({ 'name' => value }) }
+
+        context 'changing shard key value' do
+          let(:new_value) { 'a-new-value' }
 
-      it { is_expected.to eq({ 'name' => value }) }
+          before do
+            instance.name = new_value
+          end
 
-      context 'changing shard key value' do
-        let(:new_value) { 'a-new-value' }
+          it { is_expected.to eq({ 'name' => value }) }
+        end
+      end
+
+      context "when record is not found" do
+        let!(:instance) { klass.create!(name: value) }
 
         before do
-          instance.name = new_value
+          instance.destroy
         end
 
-        it { is_expected.to eq({ 'name' => value }) }
+        it "raises a DocumentNotFound error with the shard key in the description on reload" do
+          expect do
+            instance.reload
+          end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Band with id #{instance.id.to_s} and shard key name: a-brand-name./)
+        end
       end
     end
 
-    context "when record is not found" do
-      let!(:instance) { klass.create!(name: value) }
+    context 'when key is an embedded attribute' do
+      let(:klass) { SmReview }
+      let(:value) { 'Arthur Conan Doyle' }
+      let(:key)   { 'author.name' }
+
+      context 'when record is new' do
+        let(:instance) { klass.new(author: { name: value }) }
+
+        it { is_expected.to eq({ key => value }) }
 
-      before do
-        instance.destroy
+        context 'changing shard key value' do
+          let(:new_value) { 'Jules Verne' }
+
+          before do
+            instance.author.name = new_value
+          end
+
+          it { is_expected.to eq({ key => new_value }) }
+        end
       end
 
-      it "raises a DocumentNotFound error with the shard key in the description on reload" do
-        expect do
-          instance.reload
-        end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Band with id #{instance.id.to_s} and shard key name: a-brand-name./)
+      context 'when record is persisted' do
+        let(:instance) { klass.create!(author: { name: value }) }
+
+        it { is_expected.to eq({ key => value }) }
+
+        context 'changing shard key value' do
+          let(:new_value) { 'Jules Verne' }
+
+          before do
+            instance.author.name = new_value
+          end
+
+          it { is_expected.to eq({ key => value }) }
+        end
+
+        context "when record is not found" do
+          let!(:instance) { klass.create!(author: { name: value }) }
+  
+          before do
+            instance.destroy
+          end
+  
+          it "raises a DocumentNotFound error with the shard key in the description on reload" do
+            expect do
+              instance.reload
+            end.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class SmReview with id #{instance.id.to_s} and shard key author.name: Arthur Conan Doyle./)
+          end
+        end
       end
     end
   end

data/spec/mongoid/validatable/uniqueness_spec.rb

@@ -2476,7 +2476,6 @@ describe Mongoid::Validatable::UniquenessValidator do
   describe "i18n" do
 
     context 'when using a different locale' do
-
       around do |example|
         I18n.with_locale(:fr) { example.run }
       end