mongoid 7.6.2 → 8.0.1

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,36 +1,12 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative '../association/referenced/has_many_models'
+require_relative '../association/referenced/has_and_belongs_to_many_models'
+require_relative './nested_spec_models'
 
 describe Mongoid::Attributes::Nested do
 
-  # Expects the enclosing context to define `build_with_id`, taking an id
-  # value and returning the document built with it in nested attributes.
-  shared_examples 'rejects non-scalar ids' do |klass_name|
-    not_found = /not found for class #{klass_name}/
-
-    context 'when the id is an operator hash' do
-      it 'raises a document not found error' do
-        expect { build_with_id({ '$ne' => nil }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-
-    context 'when the id is an array' do
-      it 'raises a document not found error' do
-        expect { build_with_id([BSON::ObjectId.new]) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-
-    context 'when the id is a malformed object id hash' do
-      it 'raises a document not found error' do
-        expect { build_with_id({ '$oid' => 'junk' }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound, not_found)
-      end
-    end
-  end
-
   describe ".accepts_nested_attributes_for" do
 
     context "when the autosave option is not defined" do
@@ -202,30 +178,6 @@ describe Mongoid::Attributes::Nested do
       end
     end
 
-    context 'when the id in the attributes is not a scalar' do
-      let(:person) { Person.create! }
-
-      def build_with_id(id)
-        person.update!(posts_attributes: { '0' => { id: id, title: 'Crafted' } })
-      end
-
-      context 'when the association is empty' do
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-
-      context 'when the association is not empty' do
-        before { person.posts.create!(title: 'Existing') }
-
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-
-      context 'when allow_reparenting_via_nested_attributes is true' do
-        config_override :allow_reparenting_via_nested_attributes, true
-
-        include_examples 'rejects non-scalar ids', 'Post'
-      end
-    end
-
     context "when the relation is a references and referenced in many" do
 
       before do
@@ -249,100 +201,16 @@ describe Mongoid::Attributes::Nested do
           )
         end
 
-        context 'when allow_reparenting_via_nested_attributes is false' do
-          config_override :allow_reparenting_via_nested_attributes, false
-
-          it 'raises a document not found error' do
-            expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                             /Document\(s\) not found for class Preference/)
-          end
-        end
-
-        context 'when allow_reparenting_via_nested_attributes is true' do
-          config_override :allow_reparenting_via_nested_attributes, true
-
-          it 'sets the nested attributes' do
-            expect(person.preferences.map(&:name)).to eq([preference.name])
-          end
-
-          it 'updates attributes of existing document which is added to relation' do
-            preference_name = 'updated preference'
-            person = Person.new(
-              preferences_attributes: { 0 => { id: preference.id, name: preference_name } }
-            )
-            expect(person.preferences.map(&:name)).to eq([preference_name])
-          end
-
-          context 'when the id does not correspond to an existing document' do
-            let(:person) do
-              Person.new(
-                preferences_attributes: { 0 => { id: BSON::ObjectId.new, name: 'Ghost' } }
-              )
-            end
-
-            context 'when raise_not_found_error is true' do
-              config_override :raise_not_found_error, true
-
-              it 'raises a document not found error' do
-                expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                                 /Document\(s\) not found for class Preference/)
-              end
-            end
-
-            context 'when raise_not_found_error is false' do
-              config_override :raise_not_found_error, false
-
-              it 'raises a document not found error' do
-                expect { person }.to raise_error(Mongoid::Errors::DocumentNotFound,
-                                                 /Document\(s\) not found for class Preference/)
-              end
-            end
-          end
-        end
-
-        context 'when _destroy is true for a document not in the relation' do
-          before do
-            Person.send(:undef_method, :preferences_attributes=)
-            Person.accepts_nested_attributes_for :preferences, allow_destroy: true
-          end
-
-          let(:person) do
-            Person.new(
-              preferences_attributes: { 0 => { id: preference.id, _destroy: '1' } }
-            )
-          end
-
-          it 'does not raise UnknownAttribute' do
-            expect { person }.not_to raise_error
-          end
-
-          it 'does not add the document to the relation' do
-            expect(person.preferences).to be_empty
-          end
-        end
-      end
-
-      context 'when the id in the attributes is not a scalar' do
-        let(:target) { Person.create! }
-
-        def build_with_id(id)
-          target.update!(preferences_attributes: { 0 => { id: id, name: 'Crafted' } })
-        end
-
-        context 'when the association is empty' do
-          include_examples 'rejects non-scalar ids', 'Preference'
-        end
-
-        context 'when the association is not empty' do
-          before { target.preferences.create!(name: 'Existing') }
-
-          include_examples 'rejects non-scalar ids', 'Preference'
+        it "sets the nested attributes" do
+          expect(person.preferences.map(&:name)).to eq([preference.name])
         end
 
-        context 'when allow_reparenting_via_nested_attributes is true' do
-          config_override :allow_reparenting_via_nested_attributes, true
-
-          include_examples 'rejects non-scalar ids', 'Preference'
+        it "updates attributes of existing document which is added to relation" do
+          preference_name = 'updated preference'
+          person = Person.new(
+            preferences_attributes: { 0 => { id: preference.id, name: preference_name } }
+          )
+          expect(person.preferences.map(&:name)).to eq([preference_name])
         end
       end
     end
@@ -1488,7 +1356,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.addresses_attributes =
                     { "foo" => { "id" => "test", "street" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Address with id\(s\)/)
               end
             end
           end
@@ -3147,7 +3015,7 @@ describe Mongoid::Attributes::Nested do
                       { "0" =>
                         { "id" => BSON::ObjectId.new.to_s, "title" => "Rogue" }
                       }
-                  }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                  }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
                 end
               end
             end
@@ -3181,7 +3049,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.posts_attributes =
                     { "foo" => { "id" => "test", "title" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
               end
             end
           end
@@ -3898,7 +3766,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.preferences_attributes =
                     { "foo" => { "id" => "test", "name" => "Test" } }
-                }.to raise_error(Mongoid::Errors::DocumentNotFound)
+                }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
               end
             end
           end
@@ -4530,13 +4398,6 @@ describe Mongoid::Attributes::Nested do
 
     context "when nesting multiple levels and parent is timestamped" do
 
-      around do |example|
-        original_relations = Location.relations
-        Location.embedded_in :address, touch: true
-        example.run
-        Location.relations = original_relations
-      end
-
       after do
         Address.reset_callbacks(:save)
       end
@@ -5064,61 +4925,75 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  context 'when an id in nested attributes belongs to another parent' do
-    let(:victim) { Person.create! }
-    let(:attacker) { Person.create! }
+  context "when destroying has_many child using nested attributes" do
+    let(:school) do
+      School.create
+    end
 
-    context 'when the association is a has-many' do
-      before do
-        Person.send(:undef_method, :posts_attributes=)
-        Person.accepts_nested_attributes_for :posts
-      end
+    let!(:student) do
+      school.students.create
+    end
 
-      let!(:victim_post) { victim.posts.create!(title: 'Private') }
+    before do
+      school.attributes = {
+        '_id': school.id,
+        'students_attributes': [{
+          '_id': student.id,
+          '_destroy': 1
+          }]
+        }
+    end
 
-      it 'does not update the other parent\'s document' do
-        expect { attacker.update!(posts_attributes: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_post.reload.title).to eq('Private')
-      end
+    it "is able to access the parent in the after_destroy callback" do
+      expect(school.after_destroy_triggered).to eq(true)
+    end
+  end
 
-      it 'does not add the other parent\'s document to the association' do
-        expect { attacker.update!(posts_attributes: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(attacker.reload.posts).to be_empty
-      end
+  context "when destroying has_many child using nested attributes" do
+    let(:school) do
+      HabtmmSchool.create!(students: [student])
+    end
 
-      it 'does not update via a direct association assignment' do
-        expect { attacker.update!(posts: { '0' => { id: victim_post.id, title: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_post.reload.title).to eq('Private')
-      end
+    let(:student) do
+      HabtmmStudent.create!
     end
 
-    context 'when the association is a has-and-belongs-to-many' do
-      before do
-        Person.send(:undef_method, :preferences_attributes=)
-        Person.accepts_nested_attributes_for :preferences
-      end
+    before do
+      student.schools << school
+      school.attributes = {
+        '_id': school.id,
+        'students_attributes': [{
+          '_id': student.id,
+          '_destroy': 1
+          }]
+        }
+    end
+
+    it "is able to access the parent in the after_destroy callback" do
+      expect(school.reload.after_destroy_triggered).to eq(true)
+    end
+  end
 
-      let!(:victim_preference) { victim.preferences.create!(name: 'Private') }
+  context "when using a multi-leveled nested attribute on a referenced association" do
+    let(:author) { NestedAuthor.create }
+    let(:one_level_params) { { post_attributes: { title: 'test' } } }
+    let(:two_levels_params) { { post_attributes: { comments_attributes: [ { body: 'test' } ] } } }
 
-      it 'does not update the other parent\'s document' do
-        expect { attacker.update!(preferences_attributes: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_preference.reload.name).to eq('Private')
-      end
+    it "creates a 1st-depth child model" do
+      author.update_attributes(one_level_params)
+      expect(author.post.persisted?).to be true
+    end
 
-      it 'does not add the other parent\'s document to the association' do
-        expect { attacker.update!(preferences_attributes: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(attacker.reload.preferences).to be_empty
-      end
+    it "creates a 1st-depth child model, and a 2nd-depth child model" do
+      author.update_attributes(two_levels_params)
+      expect(author.post.comments.count).to eq 1
+    end
 
-      it 'does not update via a direct association assignment' do
-        expect { attacker.update!(preferences: { '0' => { id: victim_preference.id, name: 'Overwritten' } }) }
-          .to raise_error(Mongoid::Errors::DocumentNotFound)
-        expect(victim_preference.reload.name).to eq('Private')
+    context "the 1st-depth child model already exists" do
+      it "creates a 2nd-depth child model" do
+        author.create_post(title: 'test')
+        author.update_attributes(two_levels_params)
+        expect(author.post.comments.count).to eq 1
       end
     end
   end

data/spec/mongoid/attributes/nested_spec_models.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+class NestedAuthor
+  include Mongoid::Document
+
+  field :name, type: String
+  has_one :post, class_name: "NestedPost"
+  accepts_nested_attributes_for :post
+end
+
+class NestedComment
+  include Mongoid::Document
+
+  field :body, type: String
+  belongs_to :post, class_name: "NestedPost"
+end
+
+class NestedPost
+  include Mongoid::Document
+
+  field :title, type: String
+  belongs_to :author, class_name: "NestedAuthor"
+  has_many :comments, class_name: "NestedComment"
+  accepts_nested_attributes_for :comments
+end
+
+class NestedBook
+  include Mongoid::Document
+
+  embeds_one :cover, class_name: "NestedCover"
+  embeds_many :pages, class_name: "NestedPage"
+
+  accepts_nested_attributes_for :cover, :pages
+end
+
+class NestedCover
+  include Mongoid::Document
+
+  field :title, type: String
+  embedded_in :book, class_name: "NestedBook"
+end
+
+class NestedPage
+  include Mongoid::Document
+
+  field :number, type: Integer
+  embedded_in :book, class_name: "NestedBook"
+end

data/spec/mongoid/attributes/projector_spec.rb

@@ -5,11 +5,7 @@ require "spec_helper"
 describe Mongoid::Attributes::Projector do
   Dir[File.join(File.dirname(__FILE__), 'projector_data', '*.yml')].sort.each do |path|
     context File.basename(path) do
-      specs = if RUBY_VERSION.start_with?("2.5")
-                YAML.safe_load(File.read(path), [], [], true)
-              else
-                YAML.safe_load(File.read(path), aliases: true)
-              end
+      specs = YAML.safe_load(File.read(path), aliases: true)
 
       specs.each do |spec|
         context spec['name'] do