mongoid 7.5.4 → 8.1.7

data/spec/mongoid/findable_spec.rb

@@ -75,27 +75,17 @@ describe Mongoid::Findable do
       context "when the document is not found" do
 
         context "when raising a not found error" do
-
-          let!(:raise_option) { Mongoid.raise_not_found_error }
-
-          before { Mongoid.raise_not_found_error = true }
-
-          after { Mongoid.raise_not_found_error = raise_option }
+          config_override :raise_not_found_error, true
 
           it "raises an error" do
             expect {
               person.messages.find_by(body: 'bar')
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Message with attributes/)
           end
         end
 
         context "when raising no error" do
-
-          let!(:raise_option) { Mongoid.raise_not_found_error }
-
-          before { Mongoid.raise_not_found_error = false }
-
-          after { Mongoid.raise_not_found_error = raise_option }
+          config_override :raise_not_found_error, false
 
           it "returns nil" do
             expect(person.messages.find_by(body: 'bar')).to be_nil
@@ -134,27 +124,17 @@ describe Mongoid::Findable do
     context "when the document is not found" do
 
       context "when raising a not found error" do
-
-        let!(:raise_option) { Mongoid.raise_not_found_error }
-
-        before { Mongoid.raise_not_found_error = true }
-
-        after { Mongoid.raise_not_found_error = raise_option }
+        config_override :raise_not_found_error, true
 
         it "raises an error" do
           expect {
             Person.find_by(ssn: "333-22-1111")
-          }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Person with attributes/)
         end
       end
 
       context "when raising no error" do
-
-        let!(:raise_option) { Mongoid.raise_not_found_error }
-
-        before { Mongoid.raise_not_found_error = false }
-
-        after { Mongoid.raise_not_found_error = raise_option }
+        config_override :raise_not_found_error, false
 
         context "when no block is provided" do
 
@@ -213,7 +193,7 @@ describe Mongoid::Findable do
       it "raises an error" do
         expect {
           Person.find_by!(ssn: "333-22-1111")
-        }.to raise_error(Mongoid::Errors::DocumentNotFound)
+        }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document not found for class Person with attributes/)
       end
     end
   end
@@ -222,43 +202,411 @@ describe Mongoid::Findable do
 
     describe "##{method}" do
 
-      let!(:person) do
+      let!(:person1) do
         Person.create!
       end
 
-      it "returns the first matching document" do
-        expect(Person.send(method)).to eq(person)
+      let!(:person2) do
+        Person.create!
       end
 
-      it "doen't raise when passing options" do
-        expect do
-          Person.first(id_sort: :none)
-        end.to_not raise_error
+      it "returns the first matching document" do
+        expect(Person.send(method)).to eq(person1)
       end
 
       it "passes the limit through" do
-        Person.first(1).length.should == 1
+        expect(Person.send(method, 1)).to eq([ person1 ])
+      end
+
+      it "returns nil when no documents are found" do
+        expect(Band.send(method)).to be_nil
       end
     end
   end
 
-  describe "#last" do
-    let!(:person) do
+  describe "#first!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
       Person.create!
     end
 
     it "returns the first matching document" do
-      expect(Person.last).to eq(person)
+      expect(Person.first!).to eq(person1)
     end
 
-    it "doen't raise when passing options" do
+    it "raises an error when there are no documents" do
       expect do
-        Person.last(id_sort: :none)
-      end.to_not raise_error
+        Band.first!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#last" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the first matching document" do
+      expect(Person.last).to eq(person2)
     end
 
     it "passes the limit through" do
-      Person.last(1).length.should == 1
+      expect(Person.last(1)).to eq([ person2 ])
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.last).to be_nil
+    end
+  end
+
+  describe "#last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the last matching document" do
+      expect(Person.last!).to eq(person2)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#second" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the second matching document" do
+      expect(Person.second).to eq(person2)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.second).to be_nil
+    end
+  end
+
+  describe "#second!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    it "returns the second matching document" do
+      expect(Person.second!).to eq(person2)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.second!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#third" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    it "returns the third matching document" do
+      expect(Person.third).to eq(person3)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.third).to be_nil
+    end
+  end
+
+  describe "#third!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    it "returns the third matching document" do
+      expect(Person.third!).to eq(person3)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.third!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#fourth" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    it "returns the fourth matching document" do
+      expect(Person.fourth).to eq(person4)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.fourth).to be_nil
+    end
+  end
+
+  describe "#fourth!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    it "returns the fourth matching document" do
+      expect(Person.fourth!).to eq(person4)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.fourth!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#fifth" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the fifth matching document" do
+      expect(Person.fifth).to eq(person5)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.fifth).to be_nil
+    end
+  end
+
+  describe "#fifth!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the fifth matching document" do
+      expect(Person.fifth!).to eq(person5)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.fifth!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#second_to_last" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the second to last matching document" do
+      expect(Person.second_to_last).to eq(person4)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.second_to_last).to be_nil
+    end
+  end
+
+  describe "#second_to_last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the second to last matching document" do
+      expect(Person.second_to_last!).to eq(person4)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.second_to_last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
+    end
+  end
+
+  describe "#third_to_last" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the third to last matching document" do
+      expect(Person.third_to_last).to eq(person3)
+    end
+
+    it "returns nil when no documents are found" do
+      expect(Band.third_to_last).to be_nil
+    end
+  end
+
+  describe "#third_to_last!" do
+    let!(:person1) do
+      Person.create!
+    end
+
+    let!(:person2) do
+      Person.create!
+    end
+
+    let!(:person3) do
+      Person.create!
+    end
+
+    let!(:person4) do
+      Person.create!
+    end
+
+    let!(:person5) do
+      Person.create!
+    end
+
+    it "returns the third to last matching document" do
+      expect(Person.third_to_last!).to eq(person3)
+    end
+
+    it "raises an error when there are no documents" do
+      expect do
+        Band.third_to_last!
+      end.to raise_error(Mongoid::Errors::DocumentNotFound, /Could not find a document of class Band./)
     end
   end
 
@@ -502,7 +850,7 @@ describe Mongoid::Findable do
         Band.pluck(:follows)
       end
 
-      it "returns a array with nil values" do
+      it "returns an array with nil values" do
         expect(plucked).to eq([nil, nil, nil])
       end
     end
@@ -551,12 +899,9 @@ describe Mongoid::Findable do
   end
 
   context 'when Mongoid is configured to use activesupport time zone' do
-
-    before do
-      Mongoid.use_utc = false
-      Mongoid.use_activesupport_time_zone = true
-      Time.zone = "Asia/Kolkata"
-    end
+    config_override :use_utc, false
+    config_override :use_activesupport_time_zone, true
+    time_zone_override "Asia/Kolkata"
 
     let!(:time) do
       Time.zone.now.tap do |t|
@@ -564,8 +909,33 @@ describe Mongoid::Findable do
       end
     end
 
-    it 'uses activesupport time zone' do
-      expect(User.distinct(:last_login).first.to_s).to eql(time.in_time_zone('Asia/Kolkata').to_s)
+    context 'when distinct does not demongoize' do
+      config_override :legacy_pluck_distinct, true
+
+      let(:distinct) do
+        User.distinct(:last_login).first
+      end
+
+      it 'uses activesupport time zone' do
+        distinct.should be_a(ActiveSupport::TimeWithZone)
+        expect(distinct.to_s).to eql(time.in_time_zone('Asia/Kolkata').to_s)
+      end
+    end
+
+    context 'when distinct demongoizes' do
+      config_override :legacy_pluck_distinct, false
+
+      let(:distinct) do
+        User.distinct(:last_login).first
+      end
+
+      it 'uses activesupport time zone' do
+        distinct.should be_a(DateTime)
+        # Time and DateTime have different stringifications:
+        # 2022-03-16T21:12:32+00:00
+        # 2022-03-16 21:12:32 UTC
+        expect(distinct.to_s).to eql(time.in_time_zone('Asia/Kolkata').to_datetime.to_s)
+      end
     end
 
     it 'loads other fields accurately' do
@@ -574,11 +944,8 @@ describe Mongoid::Findable do
   end
 
   context 'when Mongoid is not configured to use activesupport time zone' do
-
-    before do
-      Mongoid.use_utc = true
-      Mongoid.use_activesupport_time_zone = false
-    end
+    config_override :use_utc, true
+    config_override :use_activesupport_time_zone, false
 
     let!(:time) do
       Time.now.tap do |t|
@@ -586,8 +953,33 @@ describe Mongoid::Findable do
       end
     end
 
-    it 'uses utc' do
-      expect(User.distinct(:last_login).first.to_s).to eql(time.utc.to_s)
+    context 'when distinct does not demongoize' do
+      config_override :legacy_pluck_distinct, true
+
+      let(:distinct) do
+        User.distinct(:last_login).first
+      end
+
+      it 'uses utc' do
+        distinct.should be_a(Time)
+        expect(distinct.to_s).to eql(time.utc.to_s)
+      end
+    end
+
+    context 'when distinct demongoizes' do
+      config_override :legacy_pluck_distinct, false
+
+      let(:distinct) do
+        User.distinct(:last_login).first
+      end
+
+      it 'uses utc' do
+        distinct.should be_a(DateTime)
+        # Time and DateTime have different stringifications:
+        # 2022-03-16T21:12:32+00:00
+        # 2022-03-16 21:12:32 UTC
+        expect(distinct.to_s).to eql(time.utc.to_datetime.to_s)
+      end
     end
 
     it 'loads other fields accurately' do

data/spec/mongoid/indexable/specification_spec.rb

@@ -85,7 +85,7 @@ describe Mongoid::Indexable::Specification do
         Band,
         { name: 1, title: 1, years: -1 },
         background: true,
-        drop_dups: true
+        unique: true
       )
     end
 
@@ -98,7 +98,7 @@ describe Mongoid::Indexable::Specification do
     end
 
     it "normalizes the options" do
-      expect(spec.options).to eq(background: true, drop_dups: true)
+      expect(spec.options).to eq(background: true, unique: true)
     end
   end