mongoid 7.5.4 → 8.1.6

data/spec/mongoid/tasks/database_rake_spec.rb

@@ -35,6 +35,22 @@ shared_context "rake task" do
       task.invoke
     end
   end
+
+  shared_examples_for "create_collections" do
+
+    it "receives create_collections" do
+      expect(Mongoid::Tasks::Database).to receive(:create_collections)
+      task.invoke
+    end
+  end
+
+  shared_examples_for "force create_collections" do
+
+    it "receives create_collections" do
+      expect(Mongoid::Tasks::Database).to receive(:create_collections).with(force: true)
+      task.invoke
+    end
+  end
 end
 
 shared_context "rails rake task" do
@@ -99,6 +115,10 @@ describe "db:setup" do
     expect(task.prerequisites).to include("mongoid:create_indexes")
   end
 
+  it "calls db:mongoid:create_collections" do
+    expect(task.prerequisites).to include("mongoid:create_collections")
+  end
+
   it "calls db:seed" do
     expect(task.prerequisites).to include("db:seed")
   end
@@ -113,6 +133,7 @@ describe "db:setup" do
 
   it "works" do
     expect(Mongoid::Tasks::Database).to receive(:create_indexes)
+    expect(Mongoid::Tasks::Database).to receive(:create_collections)
     expect(Rails).to receive(:root).and_return(".")
     expect(Rails).to receive(:application).and_return(application)
     task.invoke
@@ -169,9 +190,14 @@ describe "db:test:prepare" do
     expect(task.prerequisites).to include("mongoid:create_indexes")
   end
 
+  it "calls mongoid:create_collections" do
+    expect(task.prerequisites).to include("mongoid:create_collections")
+  end
+
   it "works" do
     expect(Rails).to receive(:application).and_return(application)
     expect(Mongoid::Tasks::Database).to receive(:create_indexes)
+    expect(Mongoid::Tasks::Database).to receive(:create_collections)
     task.invoke
   end
 end
@@ -200,6 +226,54 @@ describe "db:mongoid:create_indexes" do
   end
 end
 
+describe "db:mongoid:create_collections" do
+  include_context "rake task"
+
+  it_behaves_like "create_collections"
+
+  it "calls load_models" do
+    expect(task.prerequisites).to include("load_models")
+  end
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+
+    it_behaves_like "create_collections"
+  end
+end
+
+describe "db:mongoid:create_collections:force" do
+  include_context "rake task"
+
+  it_behaves_like "force create_collections"
+
+  it "calls load_models" do
+    expect(task.prerequisites).to include("load_models")
+  end
+
+  it "calls environment" do
+    expect(task.prerequisites).to include("environment")
+  end
+
+  context "when using rails task" do
+    include_context "rails rake task"
+
+    before do
+      expect(Rails).to receive(:application).and_return(application)
+    end
+
+    it_behaves_like "force create_collections"
+  end
+end
+
 describe "db:mongoid:remove_undefined_indexes" do
   include_context "rake task"
 

data/spec/mongoid/tasks/database_spec.rb

@@ -4,6 +4,59 @@ require "spec_helper"
 
 describe "Mongoid::Tasks::Database" do
 
+  before(:all) do
+    module DatabaseSpec
+      class Measurement
+        include Mongoid::Document
+
+        field :timestamp, type: Time
+        field :temperature, type: Integer
+
+        embeds_many :comments
+
+        store_in collection: "measurement",
+          collection_options: {
+            capped: true, size: 10000
+          }
+      end
+
+      class Comment
+        include Mongoid::Document
+
+        field :content, type: String
+
+        embedded_in :measurement
+
+        store_in collection_options: {
+            capped: true, size: 10000
+          }
+      end
+
+      class Note
+        include Mongoid::Document
+
+        field :text
+
+        recursively_embeds_one
+
+        store_in collection_options: {
+          capped: true, size: 10000
+        }
+      end
+    end
+  end
+
+  after(:all) do
+    Mongoid.deregister_model(DatabaseSpec::Measurement)
+    DatabaseSpec.send(:remove_const, :Measurement)
+    Mongoid.deregister_model(DatabaseSpec::Comment)
+    DatabaseSpec.send(:remove_const, :Comment)
+    Mongoid.deregister_model(DatabaseSpec::Note)
+    DatabaseSpec.send(:remove_const, :Note)
+    Object.send(:remove_const, :DatabaseSpec)
+  end
+
+
   let(:logger) do
     double("logger").tap do |log|
       allow(log).to receive(:info)
@@ -18,6 +71,80 @@ describe "Mongoid::Tasks::Database" do
     [ User, Account, Address, Draft ]
   end
 
+  describe '.create_collections' do
+    context 'collection_options are specified' do
+      let(:models) do
+        [DatabaseSpec::Measurement]
+      end
+
+      after do
+        DatabaseSpec::Measurement.collection.drop
+      end
+
+      [true, false].each do |force|
+        context "when force is #{force}" do
+          it 'creates the collection' do
+            expect(DatabaseSpec::Measurement).to receive(:create_collection).once.with(force: force)
+            Mongoid::Tasks::Database.create_collections(models, force: force)
+          end
+        end
+      end
+    end
+
+    context 'collection_options are not specified' do
+      let(:models) do
+        [Person]
+      end
+
+      [true, false].each do |force|
+        context "when force is #{force}" do
+          it 'creates the collection' do
+            expect(Person).to receive(:create_collection).once.with(force: force)
+            Mongoid::Tasks::Database.create_collections(models, force: force)
+          end
+        end
+      end
+
+      context "when collection options is defined on embedded model" do
+
+        let(:models) do
+          [DatabaseSpec::Comment]
+        end
+
+        let(:logger) do
+          double("logger").tap do |log|
+            expect(log).to receive(:info).once.with(/MONGOID: collection options ignored on: .*, please define in the root model/)
+          end
+        end
+
+        before do
+          allow(Mongoid::Tasks::Database).to receive(:logger).and_return(logger)
+        end
+
+        it "does nothing, but logging" do
+          expect(DatabaseSpec::Comment).to receive(:create_collection).never
+          Mongoid::Tasks::Database.create_collections(models)
+        end
+      end
+
+      context "when collection options is defined on cyclic model" do
+
+        let(:models) do
+          [DatabaseSpec::Note]
+        end
+
+        after do
+          DatabaseSpec::Note.collection.drop
+        end
+
+        it "creates the collection" do
+          expect(DatabaseSpec::Note).to receive(:create_collection).once
+          Mongoid::Tasks::Database.create_collections(models)
+        end
+      end
+    end
+  end
+
   describe ".create_indexes" do
 
     let!(:klass) do

data/spec/mongoid/timestamps_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative './timestamps_spec_models'
 
 describe Mongoid::Timestamps do
 
@@ -14,6 +15,10 @@ describe Mongoid::Timestamps do
       Dokument.fields
     end
 
+    let(:time_zone) { "Pacific Time (US & Canada)" }
+
+    time_zone_override "Pacific Time (US & Canada)"
+
     before do
       document.run_callbacks(:create)
       document.run_callbacks(:save)
@@ -35,6 +40,14 @@ describe Mongoid::Timestamps do
       expect(document.updated_at).to be_within(10).of(Time.now.utc)
     end
 
+    it "sets the created_at to the correct time zone" do
+      expect(document.created_at.time_zone.name).to eq(time_zone)
+    end
+
+    it "sets the updated_at to the correct time zone" do
+      expect(document.updated_at.time_zone.name).to eq(time_zone)
+    end
+
     it "ensures created_at equals updated_at on new records" do
       expect(document.updated_at).to eq(document.created_at)
     end
@@ -59,17 +72,20 @@ describe Mongoid::Timestamps do
   context "when the document has changed with updated_at specified" do
 
     let(:document) do
-      Dokument.new(created_at: Time.now.utc)
+      Dokument.create(created_at: Time.now.utc)
+    end
+
+    let(:expected_updated_at) do
+      DateTime.parse("2001-06-12")
     end
 
     before do
-      document.new_record = false
-      document.updated_at = DateTime.parse("2001-06-12")
+      document.updated_at = expected_updated_at
     end
 
     it "does not set updated at" do
-      expect(document).to receive(:updated_at=).never
       document.save!
+      expect(document.reload.updated_at).to be == expected_updated_at
     end
   end
 
@@ -107,4 +123,376 @@ describe Mongoid::Timestamps do
       expect(document.updated_at).to be_within(1).of(Time.now)
     end
   end
+
+  # This section of tests describes the behavior of the updated_at field for
+  # different updates on referenced associations, as outlined in PR #5219.
+  describe "updated_at attribute" do
+    let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+    let(:update_time) do
+      Timecop.freeze(Time.at(Time.now.to_i) + 2)
+    end
+
+    after do
+      Timecop.return
+    end
+
+    context "when touch: true" do
+      let(:user) { TimestampsSpec::Touch::User.create! }
+      let(:address) { TimestampsSpec::Touch::Address.create! }
+      let(:account) { TimestampsSpec::Touch::Account.create! }
+      let(:pet) { TimestampsSpec::Touch::Pet.create! }
+
+      before do
+        [user, address, account, pet]
+        update_time
+      end
+
+      context "when HABTM association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(addresses: [address])
+          end
+
+          it "updates the timestamps correctly" do
+            pending "MONGOID-4953"
+            user.updated_at.should == update_time
+            address.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            pending "MONGOID-4953"
+            user.reload.updated_at.should == update_time
+            address.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            user.update(address_ids: [address.id])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            address.updated_at.should == start_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            address.reload.updated_at.should == start_time
+          end
+        end
+      end
+
+      context "when has_many association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(accounts: [account])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            account.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            user.update(account_ids: [account.id])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            account.updated_at.should == start_time
+          end
+
+          # The Account object's updated_at is updated in the database but not
+          # locally, since, in this case, the Account object is not passed into
+          # the update function, so the Account object updated locally is not
+          # the same as the one that we have locally here.
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when belongs_to association; on has_many" do
+
+        context "when updating the association itself" do
+          before do
+            account.update(user: user)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            account.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            account.update(user_id: user.id)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            account.updated_at.should == update_time
+          end
+
+          # The User object's updated_at is updated in the database but not
+          # locally, since, in this case, the User object is not passed into
+          # the update function, so the User object updated locally is not
+          # the same as the one that we have locally here.
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when has_one association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(pet: pet)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when belongs_to association; on has_one" do
+
+        context "when updating the association itself" do
+          before do
+            pet.update(user: user)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            pet.update(user_id: pet.id)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+      end
+    end
+
+    context "when touch: false" do
+      let(:user) { TimestampsSpec::NoTouch::User.create! }
+      let(:address) { TimestampsSpec::NoTouch::Address.create! }
+      let(:account) { TimestampsSpec::NoTouch::Account.create! }
+      let(:pet) { TimestampsSpec::NoTouch::Pet.create! }
+
+      before do
+        [user, address, account, pet]
+        update_time
+      end
+
+      context "when HABTM association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(addresses: [address])
+          end
+
+          it "updates the timestamps correctly" do
+            pending "MONGOID-4953"
+            user.updated_at.should == update_time
+            address.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            pending "MONGOID-4953"
+            user.reload.updated_at.should == update_time
+            address.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            user.update(address_ids: [address.id])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == update_time
+            address.updated_at.should == start_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == update_time
+            address.reload.updated_at.should == start_time
+          end
+        end
+      end
+
+      context "when has_many association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(accounts: [account])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            account.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            user.update(account_ids: [account.id])
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            account.updated_at.should == start_time
+          end
+
+          # The Account object's updated_at is updated in the database but not
+          # locally, since, in this case, the Account object is not passed into
+          # the update function, so the Account object updated locally is not
+          # the same as the one that we have locally here.
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when belongs_to association; on has_many" do
+
+        context "when updating the association itself" do
+          before do
+            account.update(user: user)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            account.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            account.update(user_id: user.id)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            account.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            account.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when has_one association" do
+
+        context "when updating the association itself" do
+          before do
+            user.update(pet: pet)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+      end
+
+      context "when belongs_to association; on has_one" do
+
+        context "when updating the association itself" do
+          before do
+            pet.update(user: user)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+
+        context "when updating the association's foreign key" do
+          before do
+            pet.update(user_id: pet.id)
+          end
+
+          it "updates the timestamps correctly" do
+            user.updated_at.should == start_time
+            pet.updated_at.should == update_time
+          end
+
+          it "updates the timestamps in the db correctly" do
+            user.reload.updated_at.should == start_time
+            pet.reload.updated_at.should == update_time
+          end
+        end
+      end
+    end
+  end
 end