mongoid 7.4.3 → 8.0.7

data/spec/mongoid/association/referenced/has_many/buildable_spec.rb

@@ -138,5 +138,114 @@ describe Mongoid::Association::Referenced::HasMany::Buildable do
         end
       end
     end
+
+    context 'when the object is already associated with another object' do
+
+      context "when using <<" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs << drug
+          person2.drugs << drug
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using concat" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs.concat([drug])
+          person2.drugs.concat([drug])
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using =" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person2.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using = on the same document twice" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person1.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([drug])
+          expect(person1.drug_ids).to eq([drug._id])
+        end
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1237,7 +1237,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
+    context 'when including a limit' do
 
       let(:person) do
         Person.create!
@@ -1259,12 +1259,12 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         person.posts.create!(title: "Two")
       end
 
-      it 'does not use the sort on id' do
-        expect(enumerable.first(id_sort: :none)).to eq(first_post)
+      it 'returns the matching document' do
+        expect(enumerable.first(1)).to eq([first_post])
       end
     end
 
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!
@@ -1707,7 +1707,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
+    context 'when including a limit' do
 
       let(:person) do
         Person.create!
@@ -1729,12 +1729,12 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         person.posts.create!(title: "Two")
       end
 
-      it 'does not use the sort on id' do
-        expect(enumerable.last(id_sort: :none)).to eq(first_post)
+      it 'returns the matching document' do
+        expect(enumerable.last(1)).to eq([second_post])
       end
     end
 
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!

data/spec/mongoid/association/referenced/has_many/proxy_spec.rb

@@ -2,6 +2,26 @@
 
 require "spec_helper"
 
+module RefHasManySpec
+  module OverrideInitialize
+    class Parent
+      include Mongoid::Document
+      has_many :children, inverse_of: :parent
+    end
+
+    class Child
+      include Mongoid::Document
+      belongs_to :parent
+      field :name, type: String
+
+      def initialize(*args)
+        super
+        self.name ||= "default"
+      end
+    end
+  end
+end
+
 describe Mongoid::Association::Referenced::HasMany::Proxy do
 
   before :all do
@@ -877,6 +897,14 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
   [ :build, :new ].each do |method|
 
     describe "##{method}" do
+      context 'when model has #initialize' do
+        let(:parent) { RefHasManySpec::OverrideInitialize::Parent.create }
+        let(:child)  { parent.children.send(method) }
+
+        it 'should call #initialize' do
+          expect(child.name).to be == "default"
+        end
+      end
 
       context "when the association is not polymorphic" do
 
@@ -2077,154 +2105,114 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
     end
   end
 
-  describe "#delete" do
-
-    let!(:person) do
-      Person.create!(username: 'arthurnn')
-    end
+  %i[ delete delete_one ].each do |method|
+    describe "##{method}" do
+      let!(:person) { Person.create!(username: 'arthurnn') }
 
-    context "when the document is found" do
+      context 'when the document is found' do
+        context 'when no dependent option is set' do
+          context 'when we are assigning attributes' do
+            let!(:drug) { person.drugs.create! }
+            let(:deleted) { person.drugs.send(method, drug) }
 
-      context "when no dependent option is set" do
+            before do
+              Mongoid::Threaded.begin_execution(:assign)
+            end
 
-        context "when we are assigning attributes" do
+            after do
+              Mongoid::Threaded.exit_execution(:assign)
+            end
 
-          let!(:drug) do
-            person.drugs.create!
+            it 'does not cascade' do
+              expect(deleted.changes.keys).to eq([ 'person_id' ])
+            end
           end
 
-          before do
-            Mongoid::Threaded.begin_execution(:assign)
-          end
+          context 'when the document is loaded' do
+            let!(:drug) { person.drugs.create! }
+            let!(:deleted) { person.drugs.send(method, drug) }
 
-          after do
-            Mongoid::Threaded.exit_execution(:assign)
-          end
+            it 'returns the document' do
+              expect(deleted).to eq(drug)
+            end
 
-          let(:deleted) do
-            person.drugs.delete(drug)
-          end
+            it 'deletes the foreign key' do
+              expect(drug.person_id).to be_nil
+            end
 
-          it "does not cascade" do
-            expect(deleted.changes.keys).to eq([ "person_id" ])
+            it 'removes the document from the association' do
+              expect(person.drugs).not_to include(drug)
+            end
           end
-        end
 
-        context "when the document is loaded" do
+          context 'when the document is not loaded' do
+            let!(:drug) { Drug.create!(person_id: person.username) }
+            let!(:deleted) { person.drugs.send(method, drug) }
 
-          let!(:drug) do
-            person.drugs.create!
-          end
+            it 'returns the document' do
+              expect(deleted).to eq(drug)
+            end
 
-          let!(:deleted) do
-            person.drugs.delete(drug)
-          end
+            it 'deletes the foreign key' do
+              expect(drug.person_id).to be_nil
+            end
 
-          it "returns the document" do
-            expect(deleted).to eq(drug)
+            it 'removes the document from the association' do
+              expect(person.drugs).not_to include(drug)
+            end
           end
+        end
 
-          it "deletes the foreign key" do
-            expect(drug.person_id).to be_nil
-          end
+        context 'when dependent is delete' do
+          context 'when the document is loaded' do
+            let!(:post) { person.posts.create!(title: 'test') }
+            let!(:deleted) { person.posts.send(method, post) }
 
-          it "removes the document from the association" do
-            expect(person.drugs).to_not include(drug)
-          end
-        end
+            it 'returns the document' do
+              expect(deleted).to eq(post)
+            end
 
-        context "when the document is not loaded" do
+            it 'deletes the document' do
+              expect(post).to be_destroyed
+            end
 
-          let!(:drug) do
-            Drug.create!(person_id: person.username)
+            it 'removes the document from the association' do
+              expect(person.posts).not_to include(post)
+            end
           end
 
-          let!(:deleted) do
-            person.drugs.delete(drug)
-          end
+          context 'when the document is not loaded' do
+            let!(:post) { Post.create!(title: 'foo', person_id: person.id) }
+            let!(:deleted) { person.posts.send(method, post) }
 
-          it "returns the document" do
-            expect(deleted).to eq(drug)
-          end
+            it 'returns the document' do
+              expect(deleted).to eq(post)
+            end
 
-          it "deletes the foreign key" do
-            expect(drug.person_id).to be_nil
-          end
+            it 'deletes the document' do
+              expect(post).to be_destroyed
+            end
 
-          it "removes the document from the association" do
-            expect(person.drugs).to_not include(drug)
+            it 'removes the document from the association' do
+              expect(person.posts).not_to include(post)
+            end
           end
         end
       end
 
-      context "when dependent is delete" do
-
-        context "when the document is loaded" do
-
-          let!(:post) do
-            person.posts.create!(title: "test")
-          end
-
-          let!(:deleted) do
-            person.posts.delete(post)
-          end
+      context 'when the document is not found' do
+        let!(:post) { Post.create!(title: 'foo') }
+        let!(:deleted) { person.posts.send(method, post) }
 
-          it "returns the document" do
-            expect(deleted).to eq(post)
-          end
-
-          it "deletes the document" do
-            expect(post).to be_destroyed
-          end
-
-          it "removes the document from the association" do
-            expect(person.posts).to_not include(post)
-          end
+        it 'returns nil' do
+          expect(deleted).to be_nil
         end
 
-        context "when the document is not loaded" do
-
-          let!(:post) do
-            Post.create!(title: "foo", person_id: person.id)
-          end
-
-          let!(:deleted) do
-            person.posts.delete(post)
-          end
-
-          it "returns the document" do
-            expect(deleted).to eq(post)
-          end
-
-          it "deletes the document" do
-            expect(post).to be_destroyed
-          end
-
-          it "removes the document from the association" do
-            expect(person.posts).to_not include(post)
-          end
+        it 'does not delete the document' do
+          expect(post).to be_persisted
         end
       end
     end
-
-    context "when the document is not found" do
-
-      let!(:post) do
-        Post.create!(title: "foo")
-      end
-
-      let!(:deleted) do
-        person.posts.delete(post)
-      end
-
-      it "returns nil" do
-        expect(deleted).to be_nil
-      end
-
-      it "does not delete the document" do
-        expect(post).to be_persisted
-      end
-    end
   end
 
   [ :delete_all, :destroy_all ].each do |method|
@@ -2540,7 +2528,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
           it "raises an error" do
             expect {
               person.posts.find(post.id)
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
           end
         end
 
@@ -2555,7 +2543,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             it "raises an error" do
               expect {
                 person.posts.find(BSON::ObjectId.new)
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
             end
           end
 
@@ -2604,7 +2592,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             it "raises an error" do
               expect {
                 person.posts.find([ BSON::ObjectId.new ])
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Post with id\(s\)/)
             end
           end
 
@@ -2668,7 +2656,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             it "raises an error" do
               expect {
                 movie.ratings.find(BSON::ObjectId.new)
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Rating with id\(s\)/)
             end
           end
 
@@ -2725,7 +2713,7 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             it "raises an error" do
               expect {
                 movie.ratings.find([ BSON::ObjectId.new ])
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Rating with id\(s\)/)
             end
           end
 
@@ -4105,4 +4093,57 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
       expect(band.same_name).to eq([agent])
     end
   end
+
+  context "when removing a document with counter_cache on" do
+    let(:post) { Post.create! }
+    let(:person1) { Person.create! }
+    let(:person2) { Person.create! }
+
+    before do
+      post.update_attribute(:person, person1)
+      expect(person1.posts_count).to eq 1
+
+      person2
+      post.update_attribute(:person, person2)
+      person1.reload
+      expect(person1.posts_count).to eq 0
+      expect(person2.posts_count).to eq 1
+
+      post.update_attribute(:person, nil)
+      person1.reload
+      person2.reload
+    end
+
+    it "the count field is updated" do
+      expect(person2.posts_count).to eq 0
+    end
+  end
+
+  context "when there is a foreign key in the aliased associations" do
+    it "has the correct aliases" do
+      expect(Band.aliased_associations["artist_ids"]).to eq("artists")
+      expect(Artist.aliased_associations.key?("band_id")).to be false
+      expect(Artist.aliased_fields["band"]).to eq("band_id")
+    end
+  end
+
+  context "when executing concat on foreign key array from the db" do
+    config_override :legacy_attributes, false
+
+    before do
+      Agent.create!
+      Basic.create!
+    end
+
+    let!(:agent) { Agent.first }
+    let!(:basic) { Basic.first }
+
+    before do
+      agent.basic_ids.concat([basic.id])
+    end
+
+    it "works on the first attempt" do
+      expect(agent.basic_ids).to eq([basic.id])
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_many_models.rb

@@ -42,6 +42,7 @@ end
 
 class HmmSchool
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   has_many :students, class_name: 'HmmStudent'
 
@@ -51,8 +52,9 @@ end
 
 class HmmStudent
   include Mongoid::Document
+  include Mongoid::Timestamps
 
-  belongs_to :school, class_name: 'HmmSchool'
+  belongs_to :school, class_name: 'HmmSchool', touch: true
 
   field :name, type: String
   field :grade, type: Integer, default: 3

data/spec/mongoid/association/referenced/has_many_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative './has_many_models'
 
 describe Mongoid::Association::Referenced::HasMany do
 
@@ -1245,4 +1246,28 @@ describe Mongoid::Association::Referenced::HasMany do
       expect(association.create_relation(owner, target)).to be_a(Array)
     end
   end
+
+  context "when adding an object to the association" do
+    let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+    let(:update_time) do
+      Timecop.freeze(Time.at(Time.now.to_i) + 2)
+    end
+
+    after do
+      Timecop.return
+    end
+
+    let!(:school) { HmmSchool.create! }
+    let!(:student) { HmmStudent.create! }
+
+    before do
+      update_time
+      student.update(school: school)
+    end
+
+    it "updates the updated_at" do
+      expect(student.updated_at).to eq(update_time)
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -91,7 +91,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         expect(document).to eq(object)
       end
 
-      context 'when the object is already related to another object' do
+      context 'when the object is already associated with another object' do
 
         let(:original_person) do
           Person.new
@@ -105,7 +105,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
           association.build(Person.new, object)
         end
 
-        it 'clears the object of its previous relation' do
+        it 'clears the object of its previous association' do
           expect(original_person.account).to be_nil
         end