mongoid 7.4.3 → 7.5.0

data/spec/mongoid/association/embedded/embeds_many_models.rb

@@ -67,124 +67,3 @@ class EmmOuter
 
   field :level, :type => Integer
 end
-
-class EmmCustomerAddress
-  include Mongoid::Document
-
-  embedded_in :addressable, polymorphic: true, inverse_of: :work_address
-end
-
-class EmmFriend
-  include Mongoid::Document
-
-  embedded_in :befriendable, polymorphic: true
-end
-
-class EmmCustomer
-  include Mongoid::Document
-
-  embeds_one :home_address, class_name: 'EmmCustomerAddress', as: :addressable
-  embeds_one :work_address, class_name: 'EmmCustomerAddress', as: :addressable
-
-  embeds_many :close_friends, class_name: 'EmmFriend', as: :befriendable
-  embeds_many :acquaintances, class_name: 'EmmFriend', as: :befriendable
-end
-
-class EmmUser
-  include Mongoid::Document
-  include Mongoid::Timestamps
-
-  embeds_many :orders, class_name: 'EmmOrder'
-end
-
-class EmmOrder
-  include Mongoid::Document
-
-  field :amount, type: Integer
-
-  embedded_in :user, class_name: 'EmmUser'
-end
-
-module EmmSpec
-  # There is also a top-level Car class defined.
-  class Car
-    include Mongoid::Document
-
-    embeds_many :doors
-  end
-
-  class Door
-    include Mongoid::Document
-
-    embedded_in :car
-  end
-
-  class Tank
-    include Mongoid::Document
-
-    embeds_many :guns
-    embeds_many :emm_turrets
-    # This association references a model that is not in our module,
-    # and it does not define class_name hence Mongoid will not be able to
-    # figure out the inverse for this association.
-    embeds_many :emm_hatches
-
-    # class_name is intentionally unqualified, references a class in the
-    # same module. Rails permits class_name to be unqualified like this.
-    embeds_many :launchers, class_name: 'Launcher'
-  end
-
-  class Gun
-    include Mongoid::Document
-
-    embedded_in :tank
-  end
-
-  class Launcher
-    include Mongoid::Document
-
-    # class_name is intentionally unqualified.
-    embedded_in :tank, class_name: 'Tank'
-  end
-end
-
-# This is intentionally on top level.
-class EmmTurret
-  include Mongoid::Document
-
-  embedded_in :tank, class_name: 'EmmSpec::Tank'
-end
-
-# This is intentionally on top level.
-class EmmHatch
-  include Mongoid::Document
-
-  # No :class_name option on this association intentionally.
-  embedded_in :tank
-end
-
-class EmmPost
-  include Mongoid::Document
-
-  embeds_many :company_tags, class_name: "EmmCompanyTag"
-  embeds_many :user_tags, class_name: "EmmUserTag"
-end
-
-
-class EmmCompanyTag
-  include Mongoid::Document
-
-  field :title, type: String
-
-  embedded_in :post, class_name: "EmmPost"
-end
-
-
-class EmmUserTag
-  include Mongoid::Document
-
-  field :title, type: String
-
-  embedded_in :post, class_name: "EmmPost"
-end
-

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -2394,10 +2394,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "removes the ids from the foreign key" do
             expect(person.preference_ids).to eq([ preference_two.id ])
           end
-
-          it "sets the association locally" do
-            expect(person.preferences).to eq([preference_two])
-          end
         end
 
         context "when conditions are not provided" do
@@ -2424,10 +2420,6 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "returns the number of documents deleted" do
             expect(deleted).to eq(2)
           end
-
-          it "sets the association locally" do
-            expect(person.preferences).to eq([])
-          end
         end
       end
     end

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1264,6 +1264,33 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
+    context 'when including a limit' do
+
+      let(:person) do
+        Person.create!
+      end
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      let!(:first_post) do
+        person.posts.create!(title: "One")
+      end
+
+      let!(:second_post) do
+        person.posts.create!(title: "Two")
+      end
+
+      it 'returns the matching document' do
+        expect(enumerable.first(1)).to eq([first_post])
+      end
+    end
+
     context 'when the id_sort option is not provided' do
 
       let(:person) do
@@ -1707,6 +1734,33 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
+    context 'when including a limit' do
+
+      let(:person) do
+        Person.create!
+      end
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      let!(:first_post) do
+        person.posts.create!(title: "One")
+      end
+
+      let!(:second_post) do
+        person.posts.create!(title: "Two")
+      end
+
+      it 'returns the matching document' do
+        expect(enumerable.last(1)).to eq([second_post])
+      end
+    end
+
     context 'when the id_sort option is none' do
 
       let(:person) do

data/spec/mongoid/association/referenced/has_many/proxy_spec.rb

@@ -2239,8 +2239,10 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             Person.create!(username: 'durran')
           end
 
-          let!(:post1) { person.posts.create!(title: "Testing") }
-          let!(:post2) { person.posts.create!(title: "Test") }
+          before do
+            person.posts.create!(title: "Testing")
+            person.posts.create!(title: "Test")
+          end
 
           it "removes the correct posts" do
             person.posts.send(method, { title: "Testing" })
@@ -2256,11 +2258,6 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
           it "returns the number of documents deleted" do
             expect(person.posts.send(method, { title: "Testing" })).to eq(1)
           end
-
-          it "sets the association locally" do
-            person.posts.send(method, { title: "Testing" })
-            expect(person.posts).to eq([post2])
-          end
         end
 
         context "when conditions are not provided" do
@@ -2287,11 +2284,6 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
           it "returns the number of documents deleted" do
             expect(person.posts.send(method)).to eq(2)
           end
-
-          it "sets the association locally" do
-            person.posts.send(method)
-            expect(person.posts).to eq([])
-          end
         end
       end
 
@@ -2303,8 +2295,10 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
             Movie.create!(title: "Bladerunner")
           end
 
-          let!(:rating1) { movie.ratings.create!(value: 1) }
-          let!(:rating2) { movie.ratings.create!(value: 2) }
+          before do
+            movie.ratings.create!(value: 1)
+            movie.ratings.create!(value: 2)
+          end
 
           it "removes the correct ratings" do
             movie.ratings.send(method, { value: 1 })
@@ -2319,11 +2313,6 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
           it "returns the number of documents deleted" do
             expect(movie.ratings.send(method, { value: 1 })).to eq(1)
           end
-
-          it "sets the association locally" do
-            movie.ratings.send(method, { value: 1 })
-            expect(movie.ratings).to eq([rating2])
-          end
         end
 
         context "when conditions are not provided" do
@@ -2350,11 +2339,6 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
           it "returns the number of documents deleted" do
             expect(movie.ratings.send(method)).to eq(2)
           end
-
-          it "sets the association locally" do
-            movie.ratings.send(method)
-            expect(movie.ratings).to eq([])
-          end
         end
       end
     end

data/spec/mongoid/clients/options_spec.rb

@@ -413,6 +413,7 @@ describe Mongoid::Clients::Options, retry: 3 do
         end
 
         context 'when the options create a new cluster' do
+          retry_test
           # This test fails on sharded topologies in Evergreen but not locally
           require_topology :single, :replica_set
 

data/spec/mongoid/config_spec.rb

@@ -204,7 +204,7 @@ describe Mongoid::Config do
 
         Mongoid.configure { |config| config.load_configuration(configuration) }
 
-        expect(Mongoid::Config.discriminator_key).to be("_type")
+        expect(Mongoid::Config.discriminator_key).to eq("_type")
       end
     end
 
@@ -215,11 +215,11 @@ describe Mongoid::Config do
 
         Mongoid.configure { |config| config.load_configuration(configuration) }
 
-        expect(Mongoid::Config.discriminator_key).to be("test")
+        expect(Mongoid::Config.discriminator_key).to eq("test")
       end
 
       it 'is set globally' do
-        expect(Mongoid.discriminator_key).to be("test")
+        expect(Mongoid.discriminator_key).to eq("test")
       end
     end
   end
@@ -260,7 +260,7 @@ describe Mongoid::Config do
       let(:conf) { CONFIG }
 
       it "it is set to its default" do
-        expect(Mongoid.send(option)).to be(default)
+        expect(Mongoid.send(option)).to eq(default)
       end
     end
   end
@@ -328,6 +328,12 @@ describe Mongoid::Config do
     it_behaves_like "a config option"
   end
 
+  context 'when setting the overwrite_chained_operators option in the config' do
+    let(:option) { :overwrite_chained_operators }
+    let(:default) { true }
+
+    it_behaves_like "a config option"
+  end
 
   describe "#load!" do