mongoid 7.4.0 → 8.0.3

data/spec/mongoid/association/embedded/embeds_one_models.rb

@@ -52,3 +52,22 @@ class EomDnlChild
   embedded_in :parent, class_name: 'EomDnlParent'
   embedded_in :missing_parent, class_name: 'EomDnlMissingParent'
 end
+
+class EomAddress
+  include Mongoid::Document
+
+  field :city, type: String
+
+  embedded_in :addressable, polymorphic: true
+end
+
+# app/models/company.rb
+class EomCompany
+  include Mongoid::Document
+
+  embeds_one :address, class_name: 'EomAddress', as: :addressable
+  accepts_nested_attributes_for :address
+
+  embeds_one :delivery_address, class_name: 'EomAddress', as: :addressable
+  accepts_nested_attributes_for :delivery_address
+end

data/spec/mongoid/association/embedded/embeds_one_spec.rb

@@ -953,4 +953,32 @@ describe Mongoid::Association::Embedded::EmbedsOne do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
+
+  context "when multiple embeds_one associations reference the same class" do
+    let(:acme) { EomCompany.create(address: { city: 'Gotham' }, delivery_address: { city: 'Parcelville' }) }
+
+    context "when the first assignment is modified" do
+      before do
+        acme.update(address: EomAddress.new(city: 'Bigville'))
+        acme.reload
+      end
+
+      it "updates the correct association" do
+        expect(acme.address.city).to eq("Bigville")
+        expect(acme.delivery_address.city).to eq("Parcelville")
+      end
+    end
+
+    context "when the second assignment is modified" do
+      before do
+        acme.update(delivery_address: EomAddress.new(city: 'Bigville'))
+        acme.reload
+      end
+
+      it "updates the correct association" do
+        expect(acme.address.city).to eq("Gotham")
+        expect(acme.delivery_address.city).to eq("Bigville")
+      end
+    end
+  end
 end

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -83,7 +83,8 @@ describe Mongoid::Association::Referenced::BelongsTo::Binding do
         end
 
         it "does nothing" do
-          expect(game).to receive(:person=).never
+          expect(game).to receive(:person=).with(person).never
+          expect(game).to receive(:person=).with(nil).once
           binding.bind_one
         end
       end

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -235,4 +235,58 @@ describe Mongoid::Association::Referenced::BelongsTo::Buildable do
       end
     end
   end
+
+  context 'when the object is already associated with another object' do
+
+    context "when inverse is has_many" do
+
+      let(:drug1) do
+        Drug.create!
+      end
+
+      let(:drug2) do
+        Drug.create!
+      end
+
+      let(:person) do
+        Person.create!
+      end
+
+      before do
+        drug1.person = person
+        drug2.person = person
+      end
+
+      it 'does not clear the object of its previous association' do
+        expect(drug1.person).to eq(person)
+        expect(drug2.person).to eq(person)
+        expect(person.drugs).to eq([drug1, drug2])
+      end
+    end
+
+    context "when inverse is has_one" do
+
+      let(:account1) do
+        Account.create!(name: "1")
+      end
+
+      let(:account2) do
+        Account.create!(name: "2")
+      end
+
+      let(:person) do
+        Person.create!
+      end
+
+      before do
+        account1.person = person
+        account2.person = person
+      end
+
+      it 'clears the object of its previous association' do
+        expect(account1.person).to be_nil
+        expect(account2.person).to eq(person)
+      end
+    end
+  end
 end

data/spec/mongoid/association/referenced/belongs_to/proxy_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative '../belongs_to_models.rb'
 
 describe Mongoid::Association::Referenced::BelongsTo::Proxy do
 
@@ -1368,6 +1369,20 @@ describe Mongoid::Association::Referenced::BelongsTo::Proxy do
         game.person.set_personal_data(ssn: '123', age: 25)
       end.not_to raise_error
     end
+  end
+
+  # This is a very specific case, see MONGOID-5089 for more details.
+  context "when required is false, child is an orphan, and parent has explicit _id" do
+    let(:comment) { BTMComment.create! }
+    let(:article) do
+      BTMArticle.new(
+        comment_ids: [comment.id],
+        id: 1
+      )
+    end
 
+    it "uses the correct explicit id" do
+      expect(article.comments.first.article_id).to eq(1)
+    end
   end
 end

data/spec/mongoid/association/referenced/belongs_to_models.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class BTMArticle
+  include Mongoid::Document
+  has_many :comments, class_name: "BTMComment"
+end
+
+class BTMComment
+  include Mongoid::Document
+  belongs_to :article, class_name: "BTMArticle", required: false
+end

data/spec/mongoid/association/referenced/belongs_to_spec.rb

@@ -2019,8 +2019,8 @@ describe Mongoid::Association::Referenced::BelongsTo do
 
   describe '#foreign_key_check' do
 
-    it 'returns the foreign_key followed by "_changed?"' do
-      expect(association.foreign_key_check).to eq('owner_object_id_changed?')
+    it 'returns the foreign_key followed by "_previously_changed?"' do
+      expect(association.foreign_key_check).to eq('owner_object_id_previously_changed?')
     end
   end
 

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative "../has_and_belongs_to_many_models"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
 
@@ -2394,6 +2395,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "removes the ids from the foreign key" do
             expect(person.preference_ids).to eq([ preference_two.id ])
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([preference_two])
+          end
         end
 
         context "when conditions are not provided" do
@@ -2420,6 +2425,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "returns the number of documents deleted" do
             expect(deleted).to eq(2)
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([])
+          end
         end
       end
     end
@@ -2507,7 +2516,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "raises an error" do
             expect {
               preference
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
           end
         end
 
@@ -2522,7 +2531,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
             it "raises an error" do
               expect {
                 person.preferences.find(BSON::ObjectId.new)
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
             end
           end
 
@@ -2571,7 +2580,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "raises an error" do
             expect {
               preferences
-            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
           end
         end
 
@@ -2586,7 +2595,7 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
             it "raises an error" do
               expect {
                 person.preferences.find([ BSON::ObjectId.new ])
-              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+              }.to raise_error(Mongoid::Errors::DocumentNotFound, /Document\(s\) not found for class Preference with id\(s\)/)
             end
           end
 
@@ -3770,4 +3779,58 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       expect(p2.d_ids).to match_array([d2.id])
     end
   end
+
+  context "when accesing own _id from parent's foreign key in default" do
+    let!(:contract) { HabtmmContract.create! }
+    let!(:signature) { contract.signatures.create! }
+
+    it "is nil" do
+      expect(signature.favorite_signature).to be nil
+    end
+  end
+
+  context "when setting an association on a model that uses the class_name option" do
+    let!(:contract) { HabtmmContract.create! }
+    let!(:signature) { HabtmmSignature.create!(contracts: [contract]) }
+
+    it "populates the inverse foreign key" do
+      expect(signature.contracts.first.signature_ids).to eq([signature.id])
+    end
+  end
+
+  context "when there is a foreign key in the aliased associations" do
+    it "has the correct aliases" do
+      expect(Dog.aliased_associations["breed_ids"]).to eq("breeds")
+      expect(Breed.aliased_associations["dog_ids"]).to eq("dogs")
+    end
+  end
+
+  # This test is for MONGOID-5344 which tests that the initial call to
+  # signature_ids refers to the same array as subsequent calls to signature_ids.
+  # Prior to the change in that ticket, this test broke because the array
+  # returned from write_attribute (which is triggered the first time the
+  # foreign key array is referenced, to set the default), refers to a different
+  # array to the one stored in the attributes hash. This happened because,
+  # when retrieving a document from the database, the attributes hash is actually
+  # a BSON::Document, which applies a transformation to the array before
+  # storing it.
+  context "when executing concat on foreign key array from the db" do
+    config_override :legacy_attributes, false
+
+    before do
+      HabtmmContract.create!
+      HabtmmSignature.create!
+    end
+
+    let!(:contract) { HabtmmContract.first }
+    let!(:signature) { HabtmmSignature.first }
+
+    before do
+      contract.signature_ids.concat([signature.id])
+    end
+
+    it "works on the first attempt" do
+      expect(contract.signature_ids).to eq([signature.id])
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_and_belongs_to_many_models.rb

@@ -32,6 +32,8 @@ end
 class HabtmmSignature
   include Mongoid::Document
 
+  field :favorite_signature, default: ->{ contracts.first.signature_ids.first if contracts.first }
+
   has_and_belongs_to_many :contracts, class_name: 'HabtmmContract'
 
   field :name, type: String
@@ -65,3 +67,26 @@ class HabtmmAnimal
 
   has_and_belongs_to_many :trainers, inverse_of: :animals, class_name: 'HabtmmTrainer', scope: -> { where(name: 'Dave') }
 end
+
+class HabtmmSchool
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  has_and_belongs_to_many :students, class_name: 'HabtmmStudent'
+
+  field :after_destroy_triggered, default: false
+
+  accepts_nested_attributes_for :students, allow_destroy: true
+end
+
+class HabtmmStudent
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  has_and_belongs_to_many :schools, class_name: 'HabtmmSchool'
+
+  after_destroy do |doc|
+    schools.first.update_attributes!(after_destroy_triggered: true) unless schools.empty?
+  end
+end
+

data/spec/mongoid/association/referenced/has_and_belongs_to_many_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require_relative "./has_and_belongs_to_many_models"
 
 describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
@@ -1008,8 +1009,8 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
 
   describe '#foreign_key_check' do
 
-    it 'returns the foreign_key followed by "_changed?"' do
-      expect(association.foreign_key_check).to eq('has_many_right_object_ids_changed?')
+    it 'returns the foreign_key followed by "_previously_changed?"' do
+      expect(association.foreign_key_check).to eq('has_many_right_object_ids_previously_changed?')
     end
   end
 
@@ -1060,6 +1061,13 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
         expect(association.inverse_foreign_key).to eq('bar_ref')
       end
     end
+
+    context "when using a model that uses the class_name option" do
+      let(:inverse_foreign_key) { HabtmmSchool.relations[:students].inverse_foreign_key }
+      it "gets the correct inverse foreign key" do
+        expect(inverse_foreign_key).to eq("school_ids")
+      end
+    end
   end
 
   describe '#inverse_foreign_key_setter' do
@@ -1068,4 +1076,29 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany do
       expect(association.inverse_foreign_key_setter).to eq('has_many_left_object_ids=')
     end
   end
+
+  context "when adding an object to the association" do
+    let!(:start_time) { Timecop.freeze(Time.at(Time.now.to_i)) }
+
+    let(:update_time) do
+      Timecop.freeze(Time.at(Time.now.to_i) + 2)
+    end
+
+    after do
+      Timecop.return
+    end
+
+    let!(:school) { HabtmmSchool.create! }
+    let!(:student) { HabtmmStudent.create! }
+
+    before do
+      update_time
+      school.update(students: [student])
+    end
+
+    it "updates the updated at" do
+      pending "MONGOID-4953"
+      expect(school.updated_at).to eq(update_time)
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_many/buildable_spec.rb

@@ -138,5 +138,114 @@ describe Mongoid::Association::Referenced::HasMany::Buildable do
         end
       end
     end
+
+    context 'when the object is already associated with another object' do
+
+      context "when using <<" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs << drug
+          person2.drugs << drug
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using concat" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs.concat([drug])
+          person2.drugs.concat([drug])
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using =" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person2.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([])
+          expect(person1.drug_ids).to eq([])
+          expect(person2.drugs).to eq([drug])
+          expect(person2.drug_ids).to eq([drug._id])
+        end
+      end
+
+      context "when using = on the same document twice" do
+
+        let(:person1) do
+          Person.new
+        end
+
+        let(:person2) do
+          Person.new
+        end
+
+        let(:drug) do
+          Drug.new
+        end
+
+        before do
+          person1.drugs = [drug]
+          person1.drugs = [drug]
+        end
+
+        it 'clears the object of its previous association' do
+          expect(person1.drugs).to eq([drug])
+          expect(person1.drug_ids).to eq([drug._id])
+        end
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -1237,7 +1237,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
+    context 'when including a limit' do
 
       let(:person) do
         Person.create!
@@ -1259,12 +1259,12 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         person.posts.create!(title: "Two")
       end
 
-      it 'does not use the sort on id' do
-        expect(enumerable.first(id_sort: :none)).to eq(first_post)
+      it 'returns the matching document' do
+        expect(enumerable.first(1)).to eq([first_post])
       end
     end
 
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!
@@ -1707,7 +1707,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
     end
 
-    context 'when the id_sort option is none' do
+    context 'when including a limit' do
 
       let(:person) do
         Person.create!
@@ -1729,12 +1729,12 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         person.posts.create!(title: "Two")
       end
 
-      it 'does not use the sort on id' do
-        expect(enumerable.last(id_sort: :none)).to eq(first_post)
+      it 'returns the matching document' do
+        expect(enumerable.last(1)).to eq([second_post])
       end
     end
 
-    context 'when the id_sort option is not provided' do
+    context 'when no parameters are provided' do
 
       let(:person) do
         Person.create!