mongoid 7.3.2 → 7.3.5

data/spec/integration/contextual/empty_spec.rb

@@ -0,0 +1,142 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'Contextual classes when dealing with empty result set' do
+  shared_examples 'behave as expected' do
+    context '#exists?' do
+      it 'is false' do
+        context.exists?.should be false
+      end
+    end
+
+    context '#count' do
+      it 'is 0' do
+        context.count.should == 0
+      end
+    end
+
+    context '#length' do
+      it 'is 0' do
+        context.length.should == 0
+      end
+    end
+
+    # #estimated_count only exists for Mongo
+
+    context '#distinct' do
+      it 'is empty array' do
+        context.distinct(:foo).should == []
+      end
+    end
+
+    context '#each' do
+      context 'with block' do
+        it 'does not invoke the block' do
+          called = false
+          context.each do
+            called = true
+          end
+          called.should be false
+        end
+      end
+
+      context 'without block' do
+        it 'returns Enumerable' do
+          context.each.should be_a(Enumerable)
+        end
+
+        it 'returns empty Enumerable' do
+          context.each.to_a.should == []
+        end
+      end
+    end
+
+    context '#map' do
+      context 'with block' do
+        it 'does not invoke the block' do
+          called = false
+          context.map do
+            called = true
+          end
+          called.should be false
+        end
+      end
+
+      context 'without block' do
+        it 'returns empty array' do
+          skip 'MONGOID-5148'
+
+          context.map(:field).should == []
+        end
+      end
+    end
+
+    context '#first' do
+      it 'is nil' do
+        context.first.should be nil
+      end
+    end
+
+    context '#find_first' do
+      it 'is nil' do
+        context.find_first.should be nil
+      end
+    end
+
+    context '#one' do
+      it 'is nil' do
+        context.one.should be nil
+      end
+    end
+
+    context '#last' do
+      it 'is nil' do
+        context.last.should be nil
+      end
+    end
+  end
+
+  let(:context) do
+    context_cls.new(criteria)
+  end
+
+  before do
+    # Create an object of the same class used in the Criteria instance
+    # to verify we are using the Contextual classes.
+    Mop.create!
+  end
+
+  context 'Mongo' do
+    let(:context_cls) { Mongoid::Contextual::Mongo }
+
+    let(:criteria) do
+      Mop.and(Mop.where(a: 1), Mop.where(a: 2))
+    end
+
+    include_examples 'behave as expected'
+  end
+
+  context 'Memory' do
+    let(:context_cls) { Mongoid::Contextual::Memory }
+
+    let(:criteria) do
+      Mop.all.tap do |criteria|
+        criteria.documents = []
+      end
+    end
+
+    include_examples 'behave as expected'
+  end
+
+  context 'None' do
+    let(:context_cls) { Mongoid::Contextual::None }
+
+    let(:criteria) do
+      Mop.none
+    end
+
+    include_examples 'behave as expected'
+  end
+end

data/spec/integration/stringified_symbol_field_spec.rb

@@ -31,8 +31,8 @@ describe "StringifiedSymbol fields" do
     end
   end
 
-# Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
-let(:client) { Order.collection.client }
+  # Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
+  let(:client) { Order.collection.client }
 
   before do
     client.subscribe(Mongo::Monitoring::COMMAND, subscriber)

data/spec/lite_spec_helper.rb

@@ -19,7 +19,14 @@ autoload :Timecop, 'timecop'
 
 require 'support/spec_config'
 require 'mrss/lite_constraints'
-require "support/session_registry"
+
+if Gem::Version.new(Mongo::VERSION) < Gem::Version.new('2.18.0.alpha')
+  require "mrss/session_registry_legacy"
+else
+  require "mrss/session_registry"
+end
+
+Mrss.patch_mongo_for_session_registry
 
 unless SpecConfig.instance.ci?
   begin

data/spec/mongoid/association/embedded/embeds_many/proxy_spec.rb

@@ -2,6 +2,7 @@
 # encoding: utf-8
 
 require "spec_helper"
+require_relative '../embeds_many_models.rb'
 
 describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
 
@@ -4400,4 +4401,24 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
       end
     end
   end
+
+  context "when using assign_attributes with an already populated array" do
+    let(:post) { EmmPost.create! }
+
+    before do
+      post.assign_attributes(company_tags: [{id: BSON::ObjectId.new, title: 'a'}],
+        user_tags: [{id: BSON::ObjectId.new, title: 'b'}])
+      post.save!
+      post.reload
+      post.assign_attributes(company_tags: [{id: BSON::ObjectId.new, title: 'c'}],
+        user_tags: [])
+      post.save!
+      post.reload
+    end
+
+    it "has the correct embedded documents" do
+      expect(post.company_tags.length).to eq(1)
+      expect(post.company_tags.first.title).to eq("c")
+    end
+  end
 end

data/spec/mongoid/association/embedded/embeds_many_models.rb

@@ -52,3 +52,140 @@ class EmmProduct
 
   field :name, type: String
 end
+
+class EmmInner
+  include Mongoid::Document
+
+  embeds_many :friends, :class_name => self.name, :cyclic => true
+  embedded_in :parent, :class_name => self.name, :cyclic => true
+
+  field :level, :type => Integer
+end
+
+class EmmOuter
+  include Mongoid::Document
+  embeds_many :inners, class_name: 'EmmInner'
+
+  field :level, :type => Integer
+end
+
+class EmmCustomerAddress
+  include Mongoid::Document
+
+  embedded_in :addressable, polymorphic: true, inverse_of: :work_address
+end
+
+class EmmFriend
+  include Mongoid::Document
+
+  embedded_in :befriendable, polymorphic: true
+end
+
+class EmmCustomer
+  include Mongoid::Document
+
+  embeds_one :home_address, class_name: 'EmmCustomerAddress', as: :addressable
+  embeds_one :work_address, class_name: 'EmmCustomerAddress', as: :addressable
+
+  embeds_many :close_friends, class_name: 'EmmFriend', as: :befriendable
+  embeds_many :acquaintances, class_name: 'EmmFriend', as: :befriendable
+end
+
+class EmmUser
+  include Mongoid::Document
+  include Mongoid::Timestamps
+
+  embeds_many :orders, class_name: 'EmmOrder'
+end
+
+class EmmOrder
+  include Mongoid::Document
+
+  field :amount, type: Integer
+
+  embedded_in :user, class_name: 'EmmUser'
+end
+
+module EmmSpec
+  # There is also a top-level Car class defined.
+  class Car
+    include Mongoid::Document
+
+    embeds_many :doors
+  end
+
+  class Door
+    include Mongoid::Document
+
+    embedded_in :car
+  end
+
+  class Tank
+    include Mongoid::Document
+
+    embeds_many :guns
+    embeds_many :emm_turrets
+    # This association references a model that is not in our module,
+    # and it does not define class_name hence Mongoid will not be able to
+    # figure out the inverse for this association.
+    embeds_many :emm_hatches
+
+    # class_name is intentionally unqualified, references a class in the
+    # same module. Rails permits class_name to be unqualified like this.
+    embeds_many :launchers, class_name: 'Launcher'
+  end
+
+  class Gun
+    include Mongoid::Document
+
+    embedded_in :tank
+  end
+
+  class Launcher
+    include Mongoid::Document
+
+    # class_name is intentionally unqualified.
+    embedded_in :tank, class_name: 'Tank'
+  end
+end
+
+# This is intentionally on top level.
+class EmmTurret
+  include Mongoid::Document
+
+  embedded_in :tank, class_name: 'EmmSpec::Tank'
+end
+
+# This is intentionally on top level.
+class EmmHatch
+  include Mongoid::Document
+
+  # No :class_name option on this association intentionally.
+  embedded_in :tank
+end
+
+class EmmPost
+  include Mongoid::Document
+
+  embeds_many :company_tags, class_name: "EmmCompanyTag"
+  embeds_many :user_tags, class_name: "EmmUserTag"
+end
+
+
+class EmmCompanyTag
+  include Mongoid::Document
+
+  field :title, type: String
+
+  embedded_in :post, class_name: "EmmPost"
+end
+
+
+class EmmUserTag
+  include Mongoid::Document
+
+  field :title, type: String
+
+  embedded_in :post, class_name: "EmmPost"
+end
+

data/spec/mongoid/association/referenced/belongs_to_query_spec.rb

@@ -35,4 +35,24 @@ describe Mongoid::Association::Referenced::BelongsTo do
       expect(school.team).to eq('Bulldogs')
     end
   end
+
+  context 'when projecting with #only while having similar inverse_of candidates' do
+    before do
+      alice = HmmOwner.create!(name: 'Alice')
+      bob = HmmOwner.create!(name: 'Bob')
+
+      HmmPet.create!(name: 'Rex', current_owner: bob, previous_owner: alice)
+    end
+
+    let(:pet) { HmmPet.where(name: 'Rex').only(:name, :previous_owner_id, 'previous_owner.name').first }
+
+    it 'populates specified fields' do
+      expect(pet.name).to eq('Rex')
+      expect(pet.previous_owner.name).to eq('Alice')
+    end
+
+    it 'does not try to load the inverse for an association that explicitly prevents it' do
+      expect { pet.previous_owner.name }.not_to raise_error
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -2395,6 +2395,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "removes the ids from the foreign key" do
             expect(person.preference_ids).to eq([ preference_two.id ])
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([preference_two])
+          end
         end
 
         context "when conditions are not provided" do
@@ -2421,6 +2425,10 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
           it "returns the number of documents deleted" do
             expect(deleted).to eq(2)
           end
+
+          it "sets the association locally" do
+            expect(person.preferences).to eq([])
+          end
         end
       end
     end