mongoid 7.3.2 → 7.3.3

data/spec/integration/stringified_symbol_field_spec.rb

@@ -31,8 +31,8 @@ describe "StringifiedSymbol fields" do
     end
   end
 
-# Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
-let(:client) { Order.collection.client }
+  # Using command monitoring to test that StringifiedSymbol sends a string and returns a symbol
+  let(:client) { Order.collection.client }
 
   before do
     client.subscribe(Mongo::Monitoring::COMMAND, subscriber)

data/spec/mongoid/association/referenced/belongs_to_query_spec.rb

@@ -35,4 +35,24 @@ describe Mongoid::Association::Referenced::BelongsTo do
       expect(school.team).to eq('Bulldogs')
     end
   end
+
+  context 'when projecting with #only while having similar inverse_of candidates' do
+    before do
+      alice = HmmOwner.create!(name: 'Alice')
+      bob = HmmOwner.create!(name: 'Bob')
+
+      HmmPet.create!(name: 'Rex', current_owner: bob, previous_owner: alice)
+    end
+
+    let(:pet) { HmmPet.where(name: 'Rex').only(:name, :previous_owner_id, 'previous_owner.name').first }
+
+    it 'populates specified fields' do
+      expect(pet.name).to eq('Rex')
+      expect(pet.previous_owner.name).to eq('Alice')
+    end
+
+    it 'does not try to load the inverse for an association that explicitly prevents it' do
+      expect { pet.previous_owner.name }.not_to raise_error
+    end
+  end
 end

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -10,11 +10,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when comparing with an enumerable" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       context "when only a criteria target exists" do
@@ -88,7 +88,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
           context "when the loaded has no docs and added is persisted" do
 
             before do
-              post.save
+              post.save!
               enumerable._added[post.id] = post
             end
 
@@ -168,18 +168,18 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#<<" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let!(:enumerable) do
       described_class.new([])
     end
 
-    context "when the relation is empty" do
+    context "when the association is empty" do
 
       let!(:added) do
         enumerable << post
@@ -201,18 +201,18 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     end
   end
 
-  describe "#any?" do
+  describe "#empty?" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post_one) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let!(:post_two) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     context "when only a criteria target exists" do
@@ -225,28 +225,139 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         described_class.new(criteria)
       end
 
-      let!(:any) do
-        enumerable.any?
+      let(:empty) do
+        enumerable.empty?
       end
 
-      it "returns true" do
-        expect(any).to be true
+      it "returns false" do
+        expect(empty).to be false
       end
 
-      it "retains the correct length" do
-        expect(enumerable.length).to eq(2)
+      context 'when #empty? is called' do
+
+        before { empty }
+
+        it "retains the correct length" do
+          expect(enumerable.length).to eq(2)
+        end
+
+        it "retains the correct length when calling to_a" do
+          expect(enumerable.to_a.length).to eq(2)
+        end
+
+        context "when iterating over the association a second time" do
+
+          before do
+            enumerable.each { |post| post }
+          end
+
+          it "retains the correct length" do
+            expect(enumerable.length).to eq(2)
+          end
+
+          it "retains the correct length when calling to_a" do
+            expect(enumerable.to_a.length).to eq(2)
+          end
+        end
       end
+    end
 
-      it "retains the correct length when calling to_a" do
-        expect(enumerable.to_a.length).to eq(2)
+    context "when the documents have been loaded" do
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let!(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      before do
+        enumerable.load_all!
+      end
+
+      it "is _loaded" do
+        expect(enumerable._loaded?).to be true
+      end
+
+      it "it does not call #exists? on the unloaded scope" do
+        expect(enumerable._unloaded).to_not receive(:exists?)
+        expect(enumerable.empty?).to be false
+      end
+    end
+
+    context "when the documents are not loaded" do
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let!(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      it "is not _loaded" do
+        expect(enumerable._loaded?).to be false
+      end
+
+      it "it calls #exists? on the unloaded scope" do
+        expect(enumerable._unloaded).to receive(:exists?)
+        expect(enumerable.empty?).to be true
       end
 
-      context "when iterating over the relation a second time" do
+      context "when documents are added" do
 
         before do
-          enumerable.each { |post| post }
+          enumerable << post_one
+        end
+
+        it "is not _loaded" do
+          expect(enumerable._loaded?).to be false
         end
 
+        it "it does not call #exists? on the unloaded scope" do
+          expect(enumerable._unloaded).to_not receive(:exists?)
+          expect(enumerable.empty?).to be false
+        end
+      end
+    end
+  end
+
+  describe "#any?" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    let!(:post_one) do
+      Post.create!(person_id: person.id)
+    end
+
+    let!(:post_two) do
+      Post.create!(person_id: person.id)
+    end
+
+    context "when only a criteria target exists" do
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let!(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      let(:any) do
+        enumerable.any?
+      end
+
+      it "returns true" do
+        expect(any).to be true
+      end
+
+      context 'when #any? is called' do
+
+        before { any }
+
         it "retains the correct length" do
           expect(enumerable.length).to eq(2)
         end
@@ -254,6 +365,21 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         it "retains the correct length when calling to_a" do
           expect(enumerable.to_a.length).to eq(2)
         end
+
+        context "when iterating over the association a second time" do
+
+          before do
+            enumerable.each { |post| post }
+          end
+
+          it "retains the correct length" do
+            expect(enumerable.length).to eq(2)
+          end
+
+          it "retains the correct length when calling to_a" do
+            expect(enumerable.to_a.length).to eq(2)
+          end
+        end
       end
     end
 
@@ -274,6 +400,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         expect(enumerable._loaded?).to be true
       end
 
+      it "it does not call #exists? on the unloaded scope" do
+        expect(enumerable._unloaded).to_not receive(:exists?)
+        expect(enumerable.any?).to be true
+      end
+
       context "when a block is given" do
         it "returns true when the predicate is true" do
           expect(
@@ -325,6 +456,27 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         expect(enumerable._loaded?).to be false
       end
 
+      it "it calls #exists? on the unloaded scope" do
+        expect(enumerable._unloaded).to receive(:exists?)
+        expect(enumerable.any?).to be false
+      end
+
+      context "when documents are added" do
+
+        before do
+          enumerable << post_one
+        end
+
+        it "is not _loaded" do
+          expect(enumerable._loaded?).to be false
+        end
+
+        it "it does not call #exists? on the unloaded scope" do
+          expect(enumerable._unloaded).to_not receive(:exists?)
+          expect(enumerable.any?).to be true
+        end
+      end
+
       context "when a block is given" do
         it "returns true when the predicate is true" do
           expect(
@@ -366,15 +518,15 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#clear" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let!(:post_two) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let(:criteria) do
@@ -412,15 +564,15 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#clone" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(title: "one", person_id: person.id)
+      Post.create!(title: "one", person_id: person.id)
     end
 
     let!(:post_two) do
-      Post.create(title: "two", person_id: person.id)
+      Post.create!(title: "two", person_id: person.id)
     end
 
     let(:criteria) do
@@ -452,13 +604,13 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#delete" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the document is loaded" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let!(:enumerable) do
@@ -512,7 +664,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when the document is unloaded" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let(:criteria) do
@@ -539,7 +691,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when the document is not found" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let(:criteria) do
@@ -565,13 +717,13 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#delete_if" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the document is loaded" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let!(:enumerable) do
@@ -625,7 +777,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when the document is unloaded" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let(:criteria) do
@@ -652,7 +804,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when the block doesn't match" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       let(:criteria) do
@@ -676,11 +828,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#detect" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person: person, title: "test")
+      Post.create!(person: person, title: "test")
     end
 
     let(:criteria) do
@@ -706,11 +858,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#each" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     context "when only a criteria target exists" do
@@ -737,18 +889,18 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         expect(enumerable).to be__loaded
       end
 
-      context 'when the base relation is accessed from each document' do
+      context 'when the base association is accessed from each document' do
 
         let(:persons) do
           described_class.new(criteria).collect(&:person)
         end
 
         before do
-          Post.create(person_id: person.id)
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
-        it 'sets the base relation from the criteria' do
+        it 'sets the base association from the criteria' do
           expect(persons.uniq.size).to eq(1)
         end
       end
@@ -856,7 +1008,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#entries" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:criteria) do
@@ -870,7 +1022,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context "when the added contains a persisted document" do
 
       let!(:post) do
-        Post.create(person_id: person.id)
+        Post.create!(person_id: person.id)
       end
 
       before do
@@ -890,7 +1042,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#first" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the enumerable is not loaded" do
@@ -908,7 +1060,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         context "when added is empty" do
 
           let!(:post) do
-            Post.create(person_id: person.id)
+            Post.create!(person_id: person.id)
           end
 
           let(:first) do
@@ -932,7 +1084,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         context "when added is not empty" do
 
           let!(:post) do
-            Post.create(person_id: person.id)
+            Post.create!(person_id: person.id)
           end
 
           let(:post_two) do
@@ -1004,7 +1156,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when loaded is not empty" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         let(:enumerable) do
@@ -1023,7 +1175,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when loaded is empty" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         let(:enumerable) do
@@ -1062,7 +1214,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context 'when the id_sort option is none' do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:criteria) do
@@ -1074,11 +1226,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
 
       let!(:first_post) do
-        person.posts.create(title: "One")
+        person.posts.create!(title: "One")
       end
 
       let!(:second_post) do
-        person.posts.create(title: "Two")
+        person.posts.create!(title: "Two")
       end
 
       it 'does not use the sort on id' do
@@ -1089,7 +1241,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context 'when the id_sort option is not provided' do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:criteria) do
@@ -1101,11 +1253,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
 
       let!(:first_post) do
-        person.posts.create(title: "One")
+        person.posts.create!(title: "One")
       end
 
       let!(:second_post) do
-        person.posts.create(title: "Two")
+        person.posts.create!(title: "Two")
       end
 
       it 'uses the sort on id' do
@@ -1117,15 +1269,15 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#include?" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post_one) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let!(:post_two) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     context "when no criteria exists" do
@@ -1187,7 +1339,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         described_class.new(criteria)
       end
 
-      let!(:included) do
+      let(:included) do
         enumerable.include?(post_two)
       end
 
@@ -1203,7 +1355,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
         expect(enumerable.to_a.length).to eq(2)
       end
 
-      context "when iterating over the relation a second time" do
+      context "when iterating over the association a second time" do
 
         before do
           enumerable.each { |post| post }
@@ -1371,7 +1523,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#last" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context "when the enumerable is not loaded" do
@@ -1387,7 +1539,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when unloaded is not empty" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         let(:last) do
@@ -1449,11 +1601,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when added is not empty" do
 
         let!(:post_one) do
-          person.posts.create
+          person.posts.create!
         end
 
         let!(:post_two) do
-          person.posts.create
+          person.posts.create!
         end
 
         let(:last) do
@@ -1474,7 +1626,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when loaded is not empty" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         let(:enumerable) do
@@ -1493,7 +1645,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when loaded is empty" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         let(:enumerable) do
@@ -1532,7 +1684,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context 'when the id_sort option is none' do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:criteria) do
@@ -1544,11 +1696,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
 
       let!(:first_post) do
-        person.posts.create(title: "One")
+        person.posts.create!(title: "One")
       end
 
       let!(:second_post) do
-        person.posts.create(title: "Two")
+        person.posts.create!(title: "Two")
       end
 
       it 'does not use the sort on id' do
@@ -1559,7 +1711,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
     context 'when the id_sort option is not provided' do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let(:criteria) do
@@ -1571,11 +1723,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       end
 
       let!(:first_post) do
-        person.posts.create(title: "One")
+        person.posts.create!(title: "One")
       end
 
       let!(:second_post) do
-        person.posts.create(title: "Two")
+        person.posts.create!(title: "Two")
       end
 
       it 'uses the sort on id' do
@@ -1608,11 +1760,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#load_all!" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let(:criteria) do
@@ -1643,15 +1795,15 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#reset" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let(:post_two) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let(:enumerable) do
@@ -1699,11 +1851,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#size" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     context "when the base is new" do
@@ -1715,7 +1867,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when the added contains a persisted document" do
 
         let!(:post) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         context "when the enumerable is not loaded" do
@@ -1786,7 +1938,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
       context "when the added contains persisted documents" do
 
         let(:post_two) do
-          Post.create(person_id: person.id)
+          Post.create!(person_id: person.id)
         end
 
         before do
@@ -1807,11 +1959,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#to_json" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(title: "test", person_id: person.id)
+      Post.create!(title: "test", person_id: person.id)
     end
 
     let(:criteria) do
@@ -1838,11 +1990,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#to_json(parameters)" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(title: "test", person_id: person.id)
+      Post.create!(title: "test", person_id: person.id)
     end
 
     let(:criteria) do
@@ -1861,11 +2013,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#as_json" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(title: "test", person_id: person.id)
+      Post.create!(title: "test", person_id: person.id)
     end
 
     let(:criteria) do
@@ -1893,11 +2045,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#as_json(parameters)" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(title: "test", person_id: person.id)
+      Post.create!(title: "test", person_id: person.id)
     end
 
     let(:criteria) do
@@ -1920,11 +2072,11 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe "#uniq" do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     let!(:post) do
-      Post.create(person_id: person.id)
+      Post.create!(person_id: person.id)
     end
 
     let(:criteria) do
@@ -1956,7 +2108,7 @@ describe Mongoid::Association::Referenced::HasMany::Enumerable do
   describe 'setting the same parent object on enumerated children objects' do
 
     let(:person) do
-      Person.create
+      Person.create!
     end
 
     context 'when a single child is fetched' do