mongoid 7.2.1 → 7.2.5

data/spec/mongoid/clients/options_spec.rb

@@ -141,6 +141,8 @@ describe Mongoid::Clients::Options, retry: 3 do
           end
 
           it 'does not disconnect the original cluster' do
+            skip 'https://jira.mongodb.org/browse/MONGOID-5130'
+
             expect(connections_after).to eq(connections_before)
             expect(cluster_before).to be(cluster_after)
           end

data/spec/mongoid/contextual/atomic_spec.rb

@@ -753,12 +753,25 @@ describe Mongoid::Contextual::Atomic do
       context.set(name: "Recoil")
     end
 
-    it "sets existing fields" do
-      expect(depeche_mode.reload.name).to eq("Recoil")
+    shared_examples 'writes as expected' do
+      it "sets existing fields" do
+        expect(depeche_mode.reload.name).to eq("Recoil")
+      end
+
+      it "sets non existent fields" do
+        expect(smiths.reload.name).to eq("Recoil")
+      end
     end
 
-    it "sets non existent fields" do
-      expect(smiths.reload.name).to eq("Recoil")
+    include_examples 'writes as expected'
+
+    context 'when fields being set have been projected out' do
+
+      let(:criteria) do
+        Band.only(:genres)
+      end
+
+      include_examples 'writes as expected'
     end
   end
 

data/spec/mongoid/criteria_spec.rb

@@ -3769,10 +3769,14 @@ describe Mongoid::Criteria do
 
       before do
         expect(Person).to receive(:minor).and_call_original
+        expect(Person).to receive(:older_than).and_call_original
       end
 
       it "calls the method on the class" do
         expect(criteria.minor).to be_empty
+        expect do
+          criteria.older_than(age: 25)
+        end.not_to raise_error
       end
     end
 

data/spec/mongoid/document_fields_spec.rb

@@ -85,4 +85,30 @@ describe Mongoid::Document do
       end
     end
   end
+
+  context 'Regexp field' do
+    shared_examples "persists strings as regexp" do |type|
+      it 'persists strings as regexp' do
+        mop = Mop.create!(regexp_field: 'foo')
+        expect(mop.regexp_field).to be_a Regexp
+        expect(Mop.find(mop.id).regexp_field).to be_a BSON::Regexp::Raw
+        expect(
+          Mop.collection.find(
+            "_id" => mop.id,
+            "regexp_field" => { "$type" => type }
+          ).count
+        ).to be == 1
+      end
+    end
+
+    context "< 3.2" do
+      max_server_version("3.1")
+      include_examples "persists strings as regexp", 11
+    end
+
+    context ">= 3.2" do
+      min_server_version("3.2")
+      it_behaves_like "persists strings as regexp", "regex"
+    end
+  end
 end

data/spec/mongoid/document_query_spec.rb

@@ -36,4 +36,55 @@ describe Mongoid::Document do
       expect(_person.age).to be 42
     end
   end
+
+  context 'when projecting with #without' do
+    before do
+      duck = Pet.new(name: 'Duck')
+      Person.create!(username: 'Dev', title: 'CEO', pet: duck)
+    end
+
+    let(:person) { Person.where(username: 'Dev').without(:title).first }
+
+      it 'allows access to attribute of embedded document' do
+      expect(person.pet.name).to eq 'Duck'
+    end
+
+    context 'when exclusion starts with association name but is not the association' do
+
+      let(:person) { Person.where(username: 'Dev').without(:pet_).first }
+
+      it 'allows access to attribute of embedded document' do
+        expect(person.pet.name).to eq 'Duck'
+      end
+    end
+
+    context 'when exclusion starts with prefix of association name' do
+
+      let(:person) { Person.where(username: 'Dev').without(:pe).first }
+
+      it 'allows access to attribute of embedded document' do
+        expect(person.pet.name).to eq 'Duck'
+      end
+    end
+
+    context 'when another attribute of the association is excluded' do
+
+      let(:person) { Person.where(username: 'Dev').without('pet.weight').first }
+
+      it 'allows access to non-excluded attribute of embedded document' do
+        expect(person.pet.name).to eq 'Duck'
+      end
+    end
+
+    context 'when the excluded attribute of the association is retrieved' do
+
+      let(:person) { Person.where(username: 'Dev').without('pet.name').first }
+
+      it 'prohibits the retrieval' do
+        lambda do
+          person.pet.name
+        end.should raise_error(ActiveModel::MissingAttributeError)
+      end
+    end
+  end
 end

data/spec/mongoid/errors/mongoid_error_spec.rb

@@ -10,14 +10,26 @@ describe Mongoid::Errors::MongoidError do
   let(:options) { {} }
 
   before do
-    {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
-      expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", {}).and_return(name)
-    end
-
-    ["message", "summary", "resolution"].each do |name|
-      expect(::I18n).to receive(:translate).
-        with("mongoid.errors.messages.#{key}.#{name}", {}).
-      and_return(name)
+    if RUBY_VERSION.start_with?('3.', '2.7')
+      {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
+        expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", **{}).and_return(name)
+      end
+
+      ["message", "summary", "resolution"].each do |name|
+        expect(::I18n).to receive(:translate).
+          with("mongoid.errors.messages.#{key}.#{name}", **{}).
+          and_return(name)
+      end
+    else
+      {"message_title" => "message", "summary_title" => "summary", "resolution_title" => "resolution"}.each do |key, name|
+        expect(::I18n).to receive(:translate).with("mongoid.errors.messages.#{key}", {}).and_return(name)
+      end
+
+      ["message", "summary", "resolution"].each do |name|
+        expect(::I18n).to receive(:translate).
+          with("mongoid.errors.messages.#{key}.#{name}", {}).
+          and_return(name)
+      end
     end
 
     error.compose_message(key, options)

data/spec/mongoid/matcher/extract_attribute_data/numeric_keys.yml

@@ -0,0 +1,104 @@
+- name: string key - matches
+  document:
+    # Document field names in MongoDB are always strings.
+    '42': foo
+  # The paths are also always strings.
+  key: '42'
+  
+  result:
+    - foo
+
+- name: string key - does not match
+  document:
+    # Document field names in MongoDB are always strings.
+    '42': foo
+  # The paths are also always strings.
+  key: '4'
+  
+  result: []
+
+- name: array value - matches
+  document:
+    '42':
+      - foo
+  key: '42'
+  
+  result:
+    - ['foo']
+
+- name: subfield of numeric key - matches
+  document:
+    '42':
+      foo: bar
+  key: 42.foo
+  
+  result: 
+    - bar
+
+- name: numeric key under array
+  document:
+    a:
+      -
+        '42': bar
+
+  key: a.42
+
+  result: 
+    - bar
+
+- name: multiple values under numeric key under array
+  document: &numeric-key-under-array
+    a:
+      -
+        '42': bar
+      -
+        '42': foo
+
+  key: a.42
+
+  result: 
+    - bar
+    - foo
+
+- name: array indexing with values under numeric key under array
+  document: *numeric-key-under-array
+
+  key: a.1
+
+  result: 
+    - 
+      '42': foo
+
+- name: multiple values under array under numeric key
+  document:
+    a:
+      '42':
+        -
+          foo: bar
+        -       
+          foo: baq
+
+  key: a.42.foo
+
+  result: 
+    - bar
+    - baq
+
+- name: path component interpretable as both array index and hash key
+  document: 
+    a:
+      -
+        '1': bar
+      -
+        '1': foo
+
+  key: a.1
+
+  result: 
+    # The order of these results isn't guaranteed:
+    # 1 interpreted as the array index:
+    -
+      '1': foo
+    # 1 interpreted as hash key:
+    - bar
+    - foo

data/spec/mongoid/matcher/extract_attribute_data/traversal.yml

@@ -3,9 +3,8 @@
     name: foo
   key: name
   
-  exists: true
-  value: foo
-  expanded: false
+  result: 
+    - foo
 
 - name: scalar leaf
   document: &foo-bar-foo-bar-2
@@ -16,20 +15,26 @@
             2
   key: foo.bar.foo.bar
   
-  exists: true
-  value: 2
-  expanded: false
+  result:
+    - 2
 
 - name: scalar non-leaf
   document: *foo-bar-foo-bar-2
   key: foo.bar
   
-  exists: true
-  value:
-    foo:
-      bar:
-        2
-  expanded: false
+  result:
+    -
+      foo:
+        bar:
+          2
+
+- name: null leaf
+  document:
+    name:
+  key: name
+  
+  result: 
+    - ~
 
 - name: array leaf
   document: &foo-bar-foo-bar-array-2
@@ -40,21 +45,18 @@
             - 2
   key: foo.bar.foo.bar
   
-  exists: true
-  value:
-    - 2
-  expanded: false
+  result:
+    - [2]
 
 - name: scalar non-leaf
   document: *foo-bar-foo-bar-array-2
   key: foo.bar
   
-  exists: true
-  value:
-    foo:
-      bar:
-        - 2
-  expanded: false
+  result:
+    -
+      foo:
+        bar:
+          - 2
 
 - name: array non-leaf
   document: &foo-bar-array-foo-bar-2
@@ -66,30 +68,24 @@
               2
   key: foo.bar.foo.bar
   
-  exists: true
-  value:
+  result:
     - 2
-  expanded: true
 
 - name: array non-leaf with non-leaf query
   document: *foo-bar-array-foo-bar-2
   key: foo.bar
   
-  exists: true
-  value:
+  result:
     -
       foo:
         bar:
           2
-  expanded: true
 
 - name: array non-leaf with query for missing non-leaf key
   document: *foo-bar-array-foo-bar-2
   key: foo.missing
   
-  exists: false
-  value: []
-  expanded: true
+  result: []
 
 - name: path past end of document
   document: &foo-hello-world
@@ -97,17 +93,23 @@
       hello: world
   key: foo.bar.foo.bar
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
 
 - name: query for missing leaf key
   document: *foo-hello-world
   key: foo.bar
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
+
+- name: numeric path component when traversing hash
+  document:
+    foo:
+      "10":
+        42
+  key: "foo.10"
+
+  result: 
+    - 42
 
 - name: array index - hash leaf
   document: &foo-one-two
@@ -117,42 +119,35 @@
     bar: [3, 4]
   key: foo.1.two
   
-  exists: true
-  value: 2
-  expanded: false
+  result: 
+    - 2
 
 - name: array index - hash non-leaf
   document: *foo-one-two
   key: foo.1
   
-  exists: true
-  value:
-    two: 2
-  expanded: false
+  result:
+    -
+      two: 2
 
 - name: array index - scalar leaf
   document: *foo-one-two
   key: bar.1
   
-  exists: true
-  value: 4
-  expanded: false
+  result: 
+    - 4
 
 - name: array index - scalar leaf - missing
   document: *foo-one-two
   key: bar.2
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
 
 - name: array index - scalar leaf - missing with further hash subscription
   document: *foo-one-two
   key: bar.2.any
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
 
 - name: non-sequential nested arrays - hash leaf - one value
   document: &books-authors
@@ -166,30 +161,27 @@
           - name: Pasha
   key: books.0.authors.name
   
-  exists: true
-  value: [Steve]
-  expanded: true
+  result:
+    - Steve
 
 - name: non-sequential nested arrays - hash non-leaf - one value
   document: *books-authors
   key: books.0
   
-  exists: true
-  value:
-    authors:
-      - name: Steve
-  expanded: false
+  result:
+    -
+      authors:
+        - name: Steve
 
 - name: non-sequential nested arrays - hash non-leaf - multiple values
   document: *books-authors
   key: books.1
   
-  exists: true
-  value:
-    authors:
-      - name: Boris
-      - name: Pasha
-  expanded: false
+  result:
+    -
+      authors:
+        - name: Boris
+        - name: Pasha
 
 - name: sequential nested arrays - numerically indexed leaf
   document: &groups
@@ -197,41 +189,32 @@
       - [1]
   key: groups.0.0
   
-  exists: true
-  value: 1
-  expanded: false
+  result: 
+    - 1
 
 - name: sequential nested arrays - numerically indexed leaf - missing
   document: *groups
   key: groups.0.1
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
 
 - name: sequential nested arrays - missing hash path through non-leaf
   document: *groups
   key: groups.missing
   
-  exists: false
-  value: []
-  expanded: true
+  result: []
 
 - name: sequential nested arrays - missing hash path through leaf
   document: *groups
   key: groups.0.missing
   
-  exists: false
-  value: []
-  expanded: true
+  result: []
 
 - name: sequential nested arrays - missing hash path past leaf
   document: *groups
   key: groups.0.0.missing
   
-  exists: false
-  value: ~
-  expanded: false
+  result: []
 
 - name: mix of arrays and hashes in an array
   document:
@@ -242,9 +225,8 @@
       - bar: 2
   key: foo.bar
   
-  exists: true
-  value: [2]
-  expanded: true
+  result: 
+    - 2
 
 - name: numeric index through a primitive value not supporting subscription operator
   document:
@@ -254,6 +236,4 @@
   key:
     occupants.0.age.0
     
-  exists: false
-  value: ~
-  expanded: false
+  result: []