mongoid 7.2.0 → 7.2.4

data/spec/integration/callbacks_models.rb

@@ -0,0 +1,49 @@
+class Galaxy
+  include Mongoid::Document
+
+  field :age, type: Integer
+
+  before_validation :set_age
+
+  embeds_many :stars
+
+  private
+
+  def set_age
+    self.age ||= 100_000
+  end
+end
+
+class Star
+  include Mongoid::Document
+
+  embedded_in :galaxy
+
+  field :age, type: Integer
+
+  before_validation :set_age
+
+  embeds_many :planets
+
+  private
+
+  def set_age
+    self.age ||= 42_000
+  end
+end
+
+class Planet
+  include Mongoid::Document
+
+  embedded_in :star
+
+  field :age, type: Integer
+
+  before_validation :set_age
+
+  private
+
+  def set_age
+    self.age ||= 2_000
+  end
+end

data/spec/integration/callbacks_spec.rb

@@ -0,0 +1,216 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require 'spec_helper'
+require_relative './callbacks_models'
+
+describe 'callbacks integration tests' do
+  context 'when modifying attributes in a callback' do
+
+    context 'when creating top-level document' do
+      context 'top level document' do
+        let(:instance) do
+          Galaxy.create!
+        end
+
+        it 'writes the attribute value into the model' do
+          instance.age.should == 100_000
+        end
+
+        it 'persists the attribute value' do
+          Galaxy.find(instance.id).age.should == 100_000
+        end
+      end
+
+      context 'embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.age.should == 42_000
+          end
+
+          it 'persists the attribute value' do
+            Galaxy.find(instance.id).stars.first.age.should == 42_000
+          end
+        end
+
+        context 'set as a document instance' do
+          let(:instance) do
+            Galaxy.create!(stars: [Star.new])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          let(:instance) do
+            Galaxy.create!(stars: [{}])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+
+      context 'nested embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.planets.first.age.should == 2_000
+          end
+
+          it 'persists the attribute value' do
+            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+          end
+        end
+
+        context 'set as a document instance' do
+          let(:instance) do
+            Galaxy.create!(stars: [Star.new(
+              planets: [Planet.new],
+            )])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          let(:instance) do
+            Galaxy.create!(stars: [
+              planets: [{}],
+            ])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+    end
+
+    context 'when updating top-level document via #save' do
+      let!(:instance) do
+        Galaxy.create!
+      end
+
+      context 'embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.age.should == 42_000
+          end
+
+          it 'persists the attribute value' do
+            Galaxy.find(instance.id).stars.first.age.should == 42_000
+          end
+        end
+
+        context 'set as a document instance' do
+          before do
+            instance.stars = [Star.new]
+            instance.save!
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          before do
+            instance.stars = [{}]
+            instance.save!
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+
+      context 'nested embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.planets.first.age.should == 2_000
+          end
+
+          it 'persists the attribute value' do
+            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+          end
+        end
+
+        context 'set as a document instance' do
+          before do
+            instance.stars = [Star.new(planets: [Planet.new])]
+            instance.save!
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          before do
+            instance.stars = [planets: [{}]]
+            instance.save!
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+    end
+
+    context 'when updating top-level document via #update_attributes' do
+      let!(:instance) do
+        Galaxy.create!
+      end
+
+      context 'embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.age.should == 42_000
+          end
+
+          it 'persists the attribute value' do
+            Galaxy.find(instance.id).stars.first.age.should == 42_000
+          end
+        end
+
+        context 'set as a document instance' do
+          before do
+            instance.update_attributes(stars: [Star.new])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          before do
+            instance.update_attributes(stars: [{}])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+
+      context 'nested embedded document' do
+        shared_examples 'persists the attribute value' do
+          it 'writes the attribute value into the model' do
+            instance.stars.first.planets.first.age.should == 2_000
+          end
+
+          it 'persists the attribute value' do
+            pending 'MONGOID-4476'
+
+            Galaxy.find(instance.id).stars.first.planets.first.age.should == 2_000
+          end
+        end
+
+        context 'set as a document instance' do
+          before do
+            instance.update_attributes(stars: [Star.new(planets: [Planet.new])])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+
+        context 'set as attributes on parent' do
+          before do
+            instance.update_attributes(stars: [planets: [{}]])
+          end
+
+          include_examples 'persists the attribute value'
+        end
+      end
+    end
+  end
+end

data/spec/integration/document_spec.rb

@@ -19,4 +19,25 @@ describe Mongoid::Document do
       DelegatingPatient.default_client.should be Mongoid.default_client
     end
   end
+
+  describe '#reload' do
+    context 'when changing shard key value' do
+      require_topology :sharded
+
+      let(:profile) do
+        # Profile shard_key :name
+        Profile.create!(name: "Alice")
+      end
+
+      it "successfully reloads the document after saving an update to the sharded field" do
+        expect(profile.name).to eq("Alice")
+        profile.name = "Bob"
+        profile.save!
+
+        profile.reload
+
+        expect(profile.name).to eq("Bob")
+      end
+    end
+  end
 end

data/spec/integration/matcher_operator_data/elem_match.yml

@@ -361,3 +361,49 @@
   # https://jira.mongodb.org/browse/MONGOID-4908
   matches: false
   error: [matcher, driver]
+
+- name: $elemMatch given as symbol
+  document:
+    tags:
+      - intelligent
+  query:
+    tags:
+      :$elemMatch:
+        $eq: intelligent
+  matches: true
+
+- name: $elemMatch given as symbol - document does not contain the matched field
+  document:
+  query:
+    tags:
+      :$elemMatch:
+        $eq: intelligent
+  matches: false
+
+- name: $elemMatch argument operator given as symbol - matches
+  document:
+    tags:
+      - intelligent
+  query:
+    tags:
+      $elemMatch:
+        :$eq: intelligent
+  matches: true
+
+- name: $elemMatch argument operator given as symbol - does not match
+  document:
+    tags:
+      - intelligent
+  query:
+    tags:
+      $elemMatch:
+        :$eq: intelli
+  matches: false
+
+- name: $elemMatch argument operator given as symbol - document does not contain the matched field
+  document:
+  query:
+    tags:
+      $elemMatch:
+        :$eq: intelli
+  matches: false

data/spec/integration/matcher_operator_data/gt_types.yml

@@ -0,0 +1,63 @@
+- name: Date field - matches
+  document:
+    date_field: 2020-12-22
+  query:
+    date_field:
+      $gt: 2020-12-21
+  matches: true
+
+- name: Date field - does not match
+  document:
+    date_field: 2020-12-21
+  query:
+    date_field:
+      $gt: 2020-12-21
+  matches: false
+
+- name: Date value in generic field - matches
+  document:
+    field: 2020-12-22
+  query:
+    field:
+      $gt: 2020-12-21
+  matches: true
+
+- name: Date field - does not match
+  document:
+    field: 2020-12-21
+  query:
+    field:
+      $gt: 2020-12-21
+  matches: false
+
+- name: Time value in generic field queried by date - matches
+  document:
+    field: 2020-12-22 00:00:00
+  query:
+    field:
+      $gt: 2020-12-21
+  matches: true
+
+- name: Time value in generic field queried by date - does not match
+  document:
+    field: 2020-12-21 00:00:00
+  query:
+    field:
+      $gt: 2020-12-21
+  matches: false
+
+- name: Time value in generic field - matches
+  document:
+    field: 2020-12-22 00:00:00
+  query:
+    field:
+      $gt: 2020-12-21 00:00:00
+  matches: true
+
+- name: Time value in generic field - does not match
+  document:
+    field: 2020-12-21 00:00:00
+  query:
+    field:
+      $gt: 2020-12-21 00:00:00
+  matches: false

data/spec/integration/matcher_operator_data/gte_types.yml

@@ -0,0 +1,15 @@
+- name: Date field - matches
+  document:
+    date_field: 2020-12-22
+  query:
+    date_field:
+      $gte: 2020-12-21
+  matches: true
+
+- name: Date field - does not match
+  document:
+    date_field: 2020-12-20
+  query:
+    date_field:
+      $gte: 2020-12-21
+  matches: false

data/spec/integration/matcher_operator_data/implicit_traversal.yml

@@ -14,3 +14,99 @@
   query:
     foo.bar: 2
   matches: true
+
+- name: numeric key - matches
+  document: &numeric-key
+    foo:
+      '42':
+        bar: 1
+  query:
+    foo.42.bar: 1
+  matches: true
+
+- name: numeric key - does not match
+  document: *numeric-key
+  query:
+    foo.142.bar: 1
+  matches: false
+
+- name: array under numeric key - matches
+  document: &numeric-key-array
+    foo:
+      '42':
+        -
+          bar: 1
+  query:
+    foo.42.bar: 1
+  matches: true
+
+- name: array under numeric key - does not match
+  document: *numeric-key-array
+  query:
+    foo.142.bar: 1
+  matches: false
+
+- name: numeric key under array - matches
+  document: &array-numeric-key
+    foo:
+      -
+        '42':
+          bar: 1
+  query:
+    foo.42.bar: 1
+  matches: true
+
+- name: numeric key under array - does not match
+  document: *array-numeric-key
+  query:
+    foo.142.bar: 1
+  matches: false
+
+- name: numeric key eligible as both array index and hash key - matches array index
+  document: &numeric-key-mixed
+    foo:
+      -
+        '1':
+          bar: 1
+      -
+        '1':
+          bar: 2
+  query:
+    foo.1:
+      '1':
+        bar: 2
+  matches: true
+
+- name: numeric key eligible as both array index and hash key - does not match array index
+  document: *numeric-key-mixed
+  query:
+    foo.1:
+      # The second array item has bar: 2, bar: 1 is not matched
+      '1':
+        bar: 1
+  matches: false
+
+- name: numeric key eligible as both array index and hash key - matches hash key
+  document: *numeric-key-mixed
+  query:
+    foo.1:
+      # Both bar: 1 and bar: 2 are ok, 1 in query matches the key under each
+      # array element
+      bar: 2
+  matches: true
+
+- name: numeric key eligible as both array index and hash key - matches hash key again
+  document: *numeric-key-mixed
+  query:
+    foo.1:
+      # Both bar: 1 and bar: 2 are ok, 1 in query matches the key under each
+      # array element
+      bar: 1
+  matches: true
+
+- name: numeric key eligible as both array index and hash key - does not match hash key
+  document: *numeric-key-mixed
+  query:
+    foo.0:
+      bar: 2
+  matches: false