mongoid 7.0.5 → 8.1.5

data/spec/mongoid/extensions/hash_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Hash do
@@ -176,7 +178,7 @@ describe Mongoid::Extensions::Hash do
 
         it "moves the non hash values under the provided key" do
           expect(consolidated).to eq({
-            "$set" => { name: "Tool", likes: 10 }, "$inc" => { plays: 1 }
+            "$set" => { 'name' => "Tool", likes: 10 }, "$inc" => { 'plays' => 1 }
           })
         end
       end
@@ -193,7 +195,7 @@ describe Mongoid::Extensions::Hash do
 
         it "moves the non hash values under the provided key" do
           expect(consolidated).to eq({
-            "$set" => { likes: 10, name: "Tool" }, "$inc" => { plays: 1 }
+            "$set" => { likes: 10, 'name' => "Tool" }, "$inc" => { 'plays' => 1 }
           })
         end
       end
@@ -211,7 +213,7 @@ describe Mongoid::Extensions::Hash do
 
       it "moves the non hash values under the provided key" do
         expect(consolidated).to eq({
-          "$set" => { likes: 10, name: "Tool" }, "$inc" => { plays: 1 }
+          "$set" => { likes: 10, name: "Tool" }, "$inc" => { 'plays' => 1 }
         })
       end
     end
@@ -288,6 +290,26 @@ describe Mongoid::Extensions::Hash do
     it "returns the hash" do
       expect(Hash.demongoize(hash)).to eq(hash)
     end
+
+    context "when object is nil" do
+      let(:demongoized) do
+        Hash.demongoize(nil)
+      end
+
+      it "returns nil" do
+        expect(demongoized).to be_nil
+      end
+    end
+
+    context "when the object is uncastable" do
+      let(:demongoized) do
+        Hash.demongoize(1)
+      end
+
+      it "returns the object" do
+        expect(demongoized).to eq(1)
+      end
+    end
   end
 
   describe ".mongoize" do
@@ -324,6 +346,16 @@ describe Mongoid::Extensions::Hash do
         expect(mongoized).to be_nil
       end
     end
+
+    context "when the object is uncastable" do
+      let(:mongoized) do
+        Hash.mongoize(1)
+      end
+
+      it "returns nil" do
+        expect(mongoized).to be_nil
+      end
+    end
   end
 
   describe "#mongoize" do
@@ -362,4 +394,107 @@ describe Mongoid::Extensions::Hash do
       expect(Hash).to be_resizable
     end
   end
+
+  shared_examples_for 'unsatisfiable criteria method' do
+
+    context "when the hash has only an empty _id criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria and another criteria" do
+
+      let(:hash) do
+        { "_id" => { "$in" => [] }, 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria at top level" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}], 'foo' => 'bar'}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }}, {'foo' => 'bar'}]}
+      end
+
+      it "is true" do
+        expect(hash.send(meth)).to be true
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $and and another criteria in $and value" do
+
+      let(:hash) do
+        {'$and' => [{ "_id" => { "$in" => [] }, 'foo' => 'bar'}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $or" do
+
+      let(:hash) do
+        {'$or' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+
+    context "when the hash has an empty _id criteria via $nor" do
+
+      let(:hash) do
+        {'$nor' => [{ "_id" => { "$in" => [] }}]}
+      end
+
+      it "is false" do
+        expect(hash.send(meth)).to be false
+      end
+    end
+  end
+
+  describe "#blank_criteria?" do
+    let(:meth) { :blank_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
+
+  describe "#_mongoid_unsatisfiable_criteria?" do
+    let(:meth) { :_mongoid_unsatisfiable_criteria? }
+
+    it_behaves_like 'unsatisfiable criteria method'
+  end
 end

data/spec/mongoid/extensions/integer_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Integer do
@@ -16,112 +18,108 @@ describe Mongoid::Extensions::Integer do
       integer.__mongoize_time__
     end
 
-    it "returns the float as a time" do
-      expect(mongoized).to eq(Time.at(integer))
-    end
-  end
-
-  describe ".demongoize" do
+    let(:expected_time) { Time.at(integer).in_time_zone }
 
-    context "when the value is an integer" do
+    context "when using active support's time zone" do
+      include_context 'using AS time zone'
 
-      it "returns a integer" do
-        expect(Integer.demongoize(number)).to eq(number)
-      end
+      it_behaves_like 'mongoizes to AS::TimeWithZone'
     end
 
-    context "when the value is nil" do
+    context "when not using active support's time zone" do
+      include_context 'not using AS time zone'
 
-      it "returns nil" do
-        expect(Integer.demongoize(nil)).to be_nil
-      end
+      it_behaves_like 'mongoizes to Time'
     end
+  end
 
-    context "when the value is not an integer" do
+  [ :mongoize, :demongoize ].each do |method|
 
-      it "converts the value to an integer" do
-        expect(Integer.demongoize("1.0")).to eq(1)
-      end
-    end
-  end
+    describe ".#{method}" do
 
-  describe ".mongoize" do
+      context "when the value is a number" do
 
-    context "when the value is a number" do
+        context "when the value is an integer" do
 
-      context "when the value is an integer" do
+          context "when the value is small" do
+
+            it "it returns the integer" do
+              expect(Integer.send(method, 3)).to eq(3)
+            end
+          end
 
-        context "when the value is small" do
+          context "when the value is large" do
 
-          it "it returns the integer" do
-            expect(Integer.mongoize(3)).to eq(3)
+            it "returns the integer" do
+              expect(Integer.send(method, 1024**2).to_s).to eq("1048576")
+            end
           end
         end
 
-        context "when the value is large" do
+        context "when the value is a decimal" do
 
-          it "returns the integer" do
-            expect(Integer.mongoize(1024**2).to_s).to eq("1048576")
+          it "casts to integer" do
+            expect(Integer.send(method, 2.5)).to eq(2)
           end
         end
-      end
 
-      context "when the value is a decimal" do
+        context "when the value is floating point zero" do
 
-        it "casts to integer" do
-          expect(Integer.mongoize(2.5)).to eq(2)
+          it "returns the integer zero" do
+            expect(Integer.send(method, 0.00000)).to eq(0)
+          end
         end
-      end
 
-      context "when the value is floating point zero" do
+        context "when the value is a floating point integer" do
 
-        it "returns the integer zero" do
-          expect(Integer.mongoize(0.00000)).to eq(0)
+          it "returns the integer number" do
+            expect(Integer.send(method, 4.00000)).to eq(4)
+          end
         end
-      end
 
-      context "when the value is a floating point integer" do
+        context "when the value has leading zeros" do
 
-        it "returns the integer number" do
-          expect(Integer.mongoize(4.00000)).to eq(4)
+          it "returns the stripped integer" do
+            expect(Integer.send(method, "000011")).to eq(11)
+          end
         end
       end
 
-      context "when the value has leading zeros" do
+      context "when the string is not a number" do
 
-        it "returns the stripped integer" do
-          expect(Integer.mongoize("000011")).to eq(11)
-        end
-      end
-    end
+        context "when the string is non numerical" do
 
-    context "when the string is not a number" do
+          it "returns nil" do
+            expect(Integer.send(method, "foo")).to be_nil
+          end
+        end
 
-      context "when the string is non numerical" do
+        context "when the string starts with a number" do
 
-        it "returns 0" do
-          expect(Integer.mongoize("foo")).to eq(0)
+          it "returns nil" do
+            expect(Integer.send(method, "42bogus")).to be_nil
+          end
         end
-      end
 
-      context "when the string is numerical" do
+        context "when the string is empty" do
 
-        it "returns the integer value for the string" do
-          expect(Integer.mongoize("3")).to eq(3)
+          it "returns nil" do
+            expect(Integer.send(method, "")).to be_nil
+          end
         end
-      end
 
-      context "when the string is empty" do
+        context "when the string is nil" do
 
-        it "returns nil" do
-          expect(Integer.mongoize("")).to be_nil
+          it "returns nil" do
+            expect(Integer.send(method, nil)).to be_nil
+          end
         end
-      end
 
-      context "when the string is nil" do
+        context "when giving an object that is castable to an Integer" do
 
-        it "returns nil" do
-          expect(Integer.mongoize(nil)).to be_nil
+          it "returns the integer value" do
+            expect(Integer.send(method, 2.hours)).to eq(7200)
+          end
         end
       end
     end

data/spec/mongoid/extensions/module_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Module do

data/spec/mongoid/extensions/nil_class_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::NilClass do

data/spec/mongoid/extensions/object_id_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::ObjectId do

data/spec/mongoid/extensions/object_spec.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Extensions::Object do
 
-  describe "#__evolve_object_id__" do
+  let(:object) do
+    Object.new
+  end
 
-    let(:object) do
-      Object.new
-    end
+  describe "#__evolve_object_id__" do
 
     it "returns self" do
       expect(object.__evolve_object_id__).to eq(object)
@@ -15,10 +17,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__find_args__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__find_args__).to eq(object)
     end
@@ -26,10 +24,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_object_id__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_object_id__).to eq(object)
     end
@@ -128,10 +122,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__mongoize_time__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__mongoize_time__).to eq(object)
     end
@@ -139,10 +129,6 @@ describe Mongoid::Extensions::Object do
 
   describe "#__sortable__" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns self" do
       expect(object.__sortable__).to eq(object)
     end
@@ -288,12 +274,15 @@ describe Mongoid::Extensions::Object do
 
   describe "#numeric?" do
 
-    let(:object) do
-      Object.new
-    end
-
     it "returns false" do
       expect(object.numeric?).to eq(false)
     end
   end
+
+  describe "#blank_criteria?" do
+
+    it "is false" do
+      expect(object.blank_criteria?).to be false
+    end
+  end
 end