mongoid 7.0.5 → 7.0.6

data/spec/lite_spec_helper.rb

@@ -4,7 +4,6 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
 require "mongoid"
-require "rspec"
 
 # MRI 2.5 and JRuby 9.2 change visibility of Object#pp when 'pp' is required,
 # which happens when RSpec reports anything. This creates an issue for tests
@@ -36,6 +35,10 @@ else
 end
 
 RSpec.configure do |config|
+  config.expect_with(:rspec) do |c|
+    c.syntax = [:should, :expect]
+  end
+
   if SpecConfig.instance.ci?
     config.add_formatter(RSpec::Core::Formatters::JsonFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
   end

data/spec/mongoid/attributes/dynamic_spec.rb

@@ -0,0 +1,153 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Attributes::Dynamic do
+  shared_examples_for 'dynamic field' do
+    let(:raw_attributes) do
+      {attr_name => 'foo bar'}
+    end
+
+    context 'when reading attributes' do
+      context 'an unsaved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'saved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'when attribute is not set' do
+        it 'cannot be read' do
+          bar = Bar.new
+          expect do
+            bar.send(attr_name)
+          end.to raise_error(NoMethodError)
+        end
+
+        context 'reading via read_attribute' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar.read_attribute(:foo)).to be nil
+          end
+        end
+
+        context 'reading via []' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar[:foo]).to be nil
+          end
+        end
+      end
+    end
+
+    context 'when writing attributes via constructor' do
+      it 'can be written' do
+        bar = Bar.new(raw_attributes)
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via attributes=' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.attributes = raw_attributes
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via write_attribute' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.write_attribute(attr_name, 'foo bar')
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via []=' do
+      context 'string key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_s] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'symbol key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_sym] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+    end
+
+    context 'when writing attributes via #{attribute}=' do
+      context 'when attribute is not already set' do
+        let(:bar) { Bar.new }
+
+        it 'cannot be written' do
+          expect do
+            bar.send("#{attr_name}=", 'foo bar')
+            bar.save!
+          end.to raise_error(NoMethodError)
+        end
+      end
+
+      context 'when attribute is already set' do
+        let(:bar) { Bar.new(attr_name => 'foo bar') }
+
+        it 'can be written' do
+          bar.send("#{attr_name}=", 'new foo bar')
+          bar.save!
+
+          _bar = Bar.find(bar.id)
+          expect(_bar.send(attr_name)).to eq('new foo bar')
+        end
+      end
+    end
+  end
+
+  context 'when attribute name is alphanumeric' do
+    let(:attr_name) { 'foo' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains spaces' do
+    let(:attr_name) { 'hello world' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains special characters' do
+    let(:attr_name) { 'hello%world' }
+
+    it_behaves_like 'dynamic field'
+  end
+end

data/spec/mongoid/attributes_spec.rb

@@ -1346,10 +1346,16 @@ describe Mongoid::Attributes do
     context "when attribute is a Hash" do
       let(:person) { Person.new map: { somekey: "somevalue" } }
 
-      it "raises an error when try to set an invalid value" do
-        expect {
+      it "raises an error when trying to set a value of invalid type - array" do
+        expect do
           person.map = []
-        }.to raise_error(Mongoid::Errors::InvalidValue)
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Array cannot be written to a field of type Hash/)
+      end
+
+      it "raises an error when trying to set a value of invalid type - boolean" do
+        expect do
+          person.map = false
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Hash/)
       end
 
       it "can set a Hash value" do
@@ -1364,10 +1370,16 @@ describe Mongoid::Attributes do
         expect(person.aliases).to eq([ :alias_1 ])
       end
 
-      it "raises an error when try to set an invalid value" do
-        expect {
+      it "raises an error when trying to set a value of invalid type - hash" do
+        expect do
           person.aliases = {}
-        }.to raise_error(Mongoid::Errors::InvalidValue)
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type Hash cannot be written to a field of type Array/)
+      end
+
+      it "raises an error when trying to set a value of invalid type - boolean" do
+        expect do
+          person.aliases = false
+        end.to raise_error(Mongoid::Errors::InvalidValue, /Value of type FalseClass cannot be written to a field of type Array/)
       end
     end
 
@@ -1422,7 +1434,7 @@ describe Mongoid::Attributes do
   end
 
   describe "#typed_attributes"  do
-    
+
     let(:date_time) do
       DateTime.current
     end

data/spec/mongoid/criteria/queryable/selectable_logical_spec.rb

@@ -0,0 +1,762 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Criteria::Queryable::Selectable do
+
+  let(:query) do
+    Mongoid::Query.new("id" => "_id")
+  end
+
+  describe "#and" do
+
+    context "when provided no criterion" do
+
+      let(:selection) do
+        query.and
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided nil" do
+
+      let(:selection) do
+        query.and(nil)
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided a single criterion" do
+
+      let(:selection) do
+        query.and(field: [ 1, 2 ])
+      end
+
+      it "adds the $and selector" do
+        expect(selection.selector).to eq({
+          "$and" => [{ "field" => [ 1, 2 ] }]
+        })
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided a nested criterion" do
+
+      let(:selection) do
+        query.and(:test.elem_match => { :field.in => [ 1, 2 ] })
+      end
+
+      it "adds the $and selector" do
+        expect(selection.selector).to eq({
+          "$and" => [{ "test" => { "$elemMatch" => { "field" => { "$in" => [ 1, 2 ] }}}}]
+        })
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided multiple criterion" do
+
+      context "when the criterion is already included" do
+
+        let(:selection) do
+          query.and({ first: [ 1, 2 ] }).and({ first: [ 1, 2 ] })
+        end
+
+        it "does not duplicate the $and selector" do
+          expect(selection.selector).to eq({
+            "$and" => [
+              { "first" => [ 1, 2 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.and({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+        end
+
+        it "adds the $and selector" do
+          expect(selection.selector).to eq({
+            "$and" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.and({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+        end
+
+        it "appends both $and expressions" do
+          expect(selection.selector).to eq({
+            "$and" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+
+    context "when chaining the criterion" do
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.and(first: [ 1, 2 ]).and(second: [ 3, 4 ])
+        end
+
+        it "adds the $and selectors" do
+          expect(selection.selector).to eq({
+            "$and" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.and(first: [ 1, 2 ]).and(first: [ 3, 4 ])
+        end
+
+        it "appends both $and expressions" do
+          expect(selection.selector).to eq({
+            "$and" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+  end
+
+  describe "#or" do
+
+    context "when provided no criterion" do
+
+      let(:selection) do
+        query.or
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided nil" do
+
+      let(:selection) do
+        query.or(nil)
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided a single criterion" do
+
+      let(:selection) do
+        query.or(field: [ 1, 2 ])
+      end
+
+      it "adds the $or selector" do
+        expect(selection.selector).to eq({
+          "$or" => [{ "field" => [ 1, 2 ] }]
+        })
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided multiple criterion" do
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.or({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+        end
+
+        it "adds the $or selector" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when a criterion has a selectable key" do
+
+        let(:selection) do
+          query.or({ first: [ 1, 2 ] }, { :second.gt => 3 })
+        end
+
+        it "adds the $or selector" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => { "$gt" => 3 }}
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion has an aliased field" do
+
+        let(:selection) do
+          query.or({ id: 1 })
+        end
+
+        it "adds the $or selector and aliases the field" do
+          expect(selection.selector).to eq({
+            "$or" => [ { "_id" => 1 } ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when a criterion is wrapped in an array" do
+
+        let(:selection) do
+          query.or([{ first: [ 1, 2 ] }, { :second.gt => 3 }])
+        end
+
+        it "adds the $or selector" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => { "$gt" => 3 }}
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.or({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+        end
+
+        it "appends both $or expressions" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+
+    context "when chaining the criterion" do
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.or(first: [ 1, 2 ]).or(second: [ 3, 4 ])
+        end
+
+        it "adds the $or selectors" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.or(first: [ 1, 2 ]).or(first: [ 3, 4 ])
+        end
+
+        it "appends both $or expressions" do
+          expect(selection.selector).to eq({
+            "$or" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+  end
+
+  describe "#nor" do
+
+    context "when provided no criterion" do
+
+      let(:selection) do
+        query.nor
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided nil" do
+
+      let(:selection) do
+        query.nor(nil)
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided a single criterion" do
+
+      let(:selection) do
+        query.nor(field: [ 1, 2 ])
+      end
+
+      it "adds the $nor selector" do
+        expect(selection.selector).to eq({
+          "$nor" => [{"field" => [ 1, 2 ] }]
+        })
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided multiple criterion" do
+
+      context "when the criterion are fnor different fields" do
+
+        let(:selection) do
+          query.nor({ first: [ 1, 2 ] }, { second: [ 3, 4 ] })
+        end
+
+        it "adds the $nor selector" do
+          expect(selection.selector).to eq({
+            "$nor" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.nor({ first: [ 1, 2 ] }, { first: [ 3, 4 ] })
+        end
+
+        it "appends both $nor expressions" do
+          expect(selection.selector).to eq({
+            "$nor" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+
+    context "when chaining the criterion" do
+
+      context "when the criterion are fnor different fields" do
+
+        let(:selection) do
+          query.nor(first: [ 1, 2 ]).nor(second: [ 3, 4 ])
+        end
+
+        it "adds the $nor selectors" do
+          expect(selection.selector).to eq({
+            "$nor" => [
+              { "first" => [ 1, 2 ] },
+              { "second" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.nor(first: [ 1, 2 ]).nor(first: [ 3, 4 ])
+        end
+
+        it "appends both $nor expressions" do
+          expect(selection.selector).to eq({
+            "$nor" => [
+              { "first" => [ 1, 2 ] },
+              { "first" => [ 3, 4 ] }
+            ]
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+  end
+
+  describe "#not" do
+
+    context "when provided no criterion" do
+
+      let(:selection) do
+        query.not
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).not_to equal(query)
+      end
+
+      it 'does not mutate receiver' do
+        expect(query.negating).to be nil
+
+        selection
+        expect(query.negating).to be nil
+      end
+
+      context "when the following criteria is a query method" do
+
+        let(:selection) do
+          query.not.all(field: [ 1, 2 ])
+        end
+
+        it "negates the all selection" do
+          expect(selection.selector).to eq(
+            { "field" => { "$not" => { "$all" => [ 1, 2 ] }}}
+          )
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+      end
+
+      context "when the following criteria is a gt method" do
+
+        let(:selection) do
+          query.not.gt(age: 50)
+        end
+
+        it "negates the gt selection" do
+          expect(selection.selector).to eq(
+            { "age" => { "$not" => { "$gt" => 50 }}}
+          )
+        end
+
+        it "returns a coned query" do
+          expect(selection).to_not eq(query)
+        end
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+      end
+
+      context "when the following criteria is a where" do
+
+        let(:selection) do
+          query.not.where(field: 1, :other.in => [ 1, 2 ])
+        end
+
+        it "negates the selection with an operator" do
+          expect(selection.selector).to eq(
+            { "field" => { "$ne" => 1 }, "other" => { "$not" => { "$in" => [ 1, 2 ] }}}
+          )
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+      end
+
+      context "when the following criteria is a where with a regexp" do
+
+        let(:selection) do
+          query.not.where(field: 1, other: /test/)
+        end
+
+        it "negates the selection with an operator" do
+          expect(selection.selector).to eq(
+            { "field" => { "$ne" => 1 }, "other" => { "$not" => /test/ } }
+          )
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+
+        it "removes the negation on the clone" do
+          expect(selection).to_not be_negating
+        end
+
+      end
+    end
+
+    context "when provided nil" do
+
+      let(:selection) do
+        query.not(nil)
+      end
+
+      it "does not add any criterion" do
+        expect(selection.selector).to eq({})
+      end
+
+      it "returns the query" do
+        expect(selection).to eq(query)
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided a single criterion" do
+
+      let(:selection) do
+        query.not(field: /test/)
+      end
+
+      it "adds the $not selector" do
+        expect(selection.selector).to eq({
+          "field" => { "$not" => /test/ }
+        })
+      end
+
+      it "returns a cloned query" do
+        expect(selection).to_not equal(query)
+      end
+    end
+
+    context "when provided multiple criterion" do
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.not(first: /1/, second: /2/)
+        end
+
+        it "adds the $not selectors" do
+          expect(selection.selector).to eq({
+            "first" => { "$not" => /1/ },
+            "second" => { "$not" => /2/ }
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+
+    context "when chaining the criterion" do
+
+      context "when the criterion are for different fields" do
+
+        let(:selection) do
+          query.not(first: /1/).not(second: /2/)
+        end
+
+        it "adds the $not selectors" do
+          expect(selection.selector).to eq({
+            "first" => { "$not" => /1/ },
+            "second" => { "$not" => /2/ }
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are on the same field" do
+
+        let(:selection) do
+          query.not(first: /1/).not(first: /2/)
+        end
+
+        it "overwrites the first $not selector" do
+          expect(selection.selector).to eq({
+            "first" =>  { "$not" => /2/ }
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+
+      context "when the criterion are a double negative" do
+
+        let(:selection) do
+          query.not.where(:first.not => /1/)
+        end
+
+        it "does not double the $not selector" do
+          expect(selection.selector).to eq({
+            "first" =>  { "$not" => /1/ }
+          })
+        end
+
+        it "returns a cloned query" do
+          expect(selection).to_not equal(query)
+        end
+      end
+    end
+  end
+end