mongoid 7.0.4 → 7.0.10

data/spec/lite_spec_helper.rb

@@ -4,7 +4,6 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
 require "mongoid"
-require "rspec"
 
 # MRI 2.5 and JRuby 9.2 change visibility of Object#pp when 'pp' is required,
 # which happens when RSpec reports anything. This creates an issue for tests
@@ -36,16 +35,27 @@ else
 end
 
 RSpec.configure do |config|
+  config.expect_with(:rspec) do |c|
+    c.syntax = [:should, :expect]
+  end
+
   if SpecConfig.instance.ci?
     config.add_formatter(RSpec::Core::Formatters::JsonFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
   end
 
   if SpecConfig.instance.ci?
-    # Allow a max of 30 seconds per test.
-    # Tests should take under 10 seconds ideally but it seems
-    # we have some that run for more than 10 seconds in CI.
+    timeout = if SpecConfig.instance.app_tests?
+      # Allow 5 minutes per test for the app tests, since they install
+      # gems for Rails applications which can take a long time.
+      300
+    else
+      # Allow a max of 30 seconds per test.
+      # Tests should take under 10 seconds ideally but it seems
+      # we have some that run for more than 10 seconds in CI.
+      30
+    end
     config.around(:each) do |example|
-      TimeoutInterrupt.timeout(30) do
+      TimeoutInterrupt.timeout(timeout) do
         example.run
       end
     end

data/spec/mongoid/association/embedded/embeds_many_models.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+class EmmCongress
+  include Mongoid::Document
+
+  embeds_many :legislators, class_name: 'EmmLegislator'
+
+  field :name, type: String
+end
+
+class EmmLegislator
+  include Mongoid::Document
+
+  embedded_in :congress, class_name: 'EmmCongress'
+
+  field :a, type: Integer, default: 0
+  field :b, type: Integer, default: 0
+end
+
+# Models with associations with :class_name as a :: prefixed string
+
+class EmmCcCongress
+  include Mongoid::Document
+
+  embeds_many :legislators, class_name: '::EmmCcLegislator'
+
+  field :name, type: String
+end
+
+class EmmCcLegislator
+  include Mongoid::Document
+
+  embedded_in :congress, class_name: '::EmmCcCongress'
+
+  field :a, type: Integer, default: 0
+  field :b, type: Integer, default: 0
+end
+
+class EmmManufactory
+  include Mongoid::Document
+
+  embeds_many :products, order: :id.desc, class_name: 'EmmProduct'
+end
+
+
+class EmmProduct
+  include Mongoid::Document
+
+  embedded_in :manufactory, class_name: 'EmmManufactory'
+
+  field :name, type: String
+end

data/spec/mongoid/association/embedded/embeds_many_spec.rb

@@ -646,6 +646,16 @@ describe Mongoid::Association::Embedded::EmbedsMany do
       it 'returns the class name option' do
         expect(association.klass).to eq(_class)
       end
+
+      context 'when the class name is prefixed with ::' do
+        let(:options) do
+          { class_name: '::OtherEmbeddedObject' }
+        end
+
+        it 'returns the class name option' do
+          expect(association.klass).to eq(_class)
+        end
+      end
     end
 
     context 'when the class_name option is not specified' do

data/spec/mongoid/association/embedded/embeds_one_spec.rb

@@ -453,8 +453,6 @@ describe Mongoid::Association::Embedded::EmbedsOne do
             end
 
             it 'returns the inverse in an array' do
-              pending 'MONGOID-4751'
-
               inverses = association.inverses
               expect(inverses).to eq([:parent])
             end

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_spec.rb

@@ -1754,6 +1754,43 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
       end
     end
 
+    describe "#any?" do
+
+      let(:person) do
+        Person.create
+      end
+
+      context "when nothing exists on the relation" do
+
+        context "when no document is added" do
+
+          let!(:sandwich) do
+            Sandwich.create!
+          end
+
+          it "returns false" do
+            expect(sandwich.meats.any?).to be false
+          end
+        end
+
+        context "when the document is destroyed" do
+
+          before do
+            Meat.create!
+          end
+
+          let!(:sandwich) do
+            Sandwich.create!
+          end
+
+          it "returns false" do
+            sandwich.destroy
+            expect(sandwich.meats.any?).to be false
+          end
+        end
+      end
+    end
+
     context "when documents have been persisted" do
 
       let!(:preference) do
@@ -1843,6 +1880,107 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
     end
   end
 
+  describe "#any?" do
+
+    let(:sandwich) do
+      Sandwich.create
+    end
+
+    context "when nothing exists on the relation" do
+
+      context "when no document is added" do
+
+        let!(:sandwich) do
+          Sandwich.create!
+        end
+
+        it "returns false" do
+          expect(sandwich.meats.any?).to be false
+        end
+      end
+
+      context "when the document is destroyed" do
+
+        before do
+          Meat.create!
+        end
+
+        let!(:sandwich) do
+          Sandwich.create!
+        end
+
+        it "returns false" do
+          sandwich.destroy
+          expect(sandwich.meats.any?).to be false
+        end
+      end
+    end
+
+    context "when appending to a relation and _loaded/_unloaded are empty" do
+
+      let!(:sandwich) do
+        Sandwich.create!
+      end
+
+      before do
+        sandwich.meats << Meat.new
+      end
+
+      it "returns true" do
+        expect(sandwich.meats.any?).to be true
+      end
+    end
+
+    context "when appending to a relation in a transaction" do
+      require_transaction_support
+
+      let!(:sandwich) do
+        Sandwich.create!
+      end
+
+      it "returns true" do
+        sandwich.with_session do |session|
+          session.with_transaction do
+            expect{ sandwich.meats << Meat.new }.to_not raise_error
+            expect(sandwich.meats.any?).to be true
+          end
+        end
+      end
+    end
+
+    context "when documents have been persisted" do
+
+      let!(:meat) do
+        sandwich.meats.create
+      end
+
+      it "returns true" do
+        expect(sandwich.meats.any?).to be true
+      end
+    end
+
+    context "when documents have not been persisted" do
+
+      let!(:meat) do
+        sandwich.meats.build
+      end
+
+      it "returns false" do
+        expect(sandwich.meats.any?).to be true
+      end
+    end
+
+    context "when new documents exist in the database" do
+      before do
+        Meat.create(sandwiches: [sandwich])
+      end
+
+      it "returns true" do
+        expect(sandwich.meats.any?).to be true
+      end
+    end
+  end
+
   [ :create, :create! ].each do |method|
 
     describe "##{method}" do
@@ -2686,7 +2824,8 @@ describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
         expect(preferences).to eq([ preference_one ])
       end
 
-      context 'when providing a collation', if: collation_supported? do
+      context 'when providing a collation' do
+        min_server_version '3.4'
 
         let(:preferences) do
           person.preferences.where(name: "FIRST").collation(locale: 'en_US', strength: 2).to_a

data/spec/mongoid/association/referenced/has_many/enumerable_spec.rb

@@ -253,6 +253,111 @@ describe Mongoid::Association::Referenced::HasMany::Targets::Enumerable do
         end
       end
     end
+
+    context "when the documents have been loaded" do
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let!(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      before do
+        enumerable.load_all!
+      end
+
+      it "is _loaded" do
+        expect(enumerable._loaded?).to be true
+      end
+
+      context "when a block is given" do
+        it "returns true when the predicate is true" do
+          expect(
+            enumerable.any? { |doc| true }
+          ).to be true
+        end
+
+        it "returns false when the predicate is false" do
+          expect(
+            enumerable.any? { |doc| false }
+          ).to be false
+        end
+      end
+
+      context "when an argument is given" do
+        ruby_version_gte '2.5'
+
+        it "returns true when the argument is true" do
+          expect(enumerable.any?(Post)).to be true
+        end
+
+        it "returns false when the argument is false" do
+          expect(enumerable.any?(Sandwich)).to be false
+        end
+      end
+
+      context "when both an argument and a block are given" do
+        ruby_version_gte '2.5'
+
+        it "gives precedence to the pattern" do
+          expect(
+            enumerable.any?(Post) { |doc| false }
+          ).to be true
+        end
+      end
+    end
+
+    context "when the documents are not loaded" do
+
+      let(:criteria) do
+        Post.where(person_id: person.id)
+      end
+
+      let!(:enumerable) do
+        described_class.new(criteria)
+      end
+
+      it "is not _loaded" do
+        expect(enumerable._loaded?).to be false
+      end
+
+      context "when a block is given" do
+        it "returns true when the predicate is true" do
+          expect(
+            enumerable.any? { |doc| true }
+          ).to be true
+        end
+
+        it "returns false when the predicate is false" do
+          expect(
+            enumerable.any? { |doc| false }
+          ).to be false
+        end
+      end
+
+      context "when an argument is given" do
+        ruby_version_gte '2.5'
+
+        it "returns true when the argument is true" do
+          expect(enumerable.any?(Post)).to be true
+        end
+
+        it "returns false when the argument is false" do
+          expect(enumerable.any?(Sandwich)).to be false
+        end
+      end
+
+      context "when both an argument and a block are given" do
+        ruby_version_gte '2.5'
+
+        it "gives precedence to the pattern" do
+          expect(
+            enumerable.any?(Post) { |doc| false }
+          ).to be true
+        end
+      end
+    end
   end
 
   describe "#clear" do

data/spec/mongoid/association/referenced/has_many/proxy_spec.rb

@@ -2904,7 +2904,8 @@ describe Mongoid::Association::Referenced::HasMany::Proxy do
         expect(posts).to eq([ post_one ])
       end
 
-      context 'when providing a collation', if: collation_supported? do
+      context 'when providing a collation' do
+        min_server_version '3.4'
 
         let(:posts) do
           person.posts.where(title: "FIRST").collation(locale: 'en_US', strength: 2)

data/spec/mongoid/attributes/dynamic_spec.rb

@@ -0,0 +1,153 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Attributes::Dynamic do
+  shared_examples_for 'dynamic field' do
+    let(:raw_attributes) do
+      {attr_name => 'foo bar'}
+    end
+
+    context 'when reading attributes' do
+      context 'an unsaved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'saved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'when attribute is not set' do
+        it 'cannot be read' do
+          bar = Bar.new
+          expect do
+            bar.send(attr_name)
+          end.to raise_error(NoMethodError)
+        end
+
+        context 'reading via read_attribute' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar.read_attribute(:foo)).to be nil
+          end
+        end
+
+        context 'reading via []' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar[:foo]).to be nil
+          end
+        end
+      end
+    end
+
+    context 'when writing attributes via constructor' do
+      it 'can be written' do
+        bar = Bar.new(raw_attributes)
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via attributes=' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.attributes = raw_attributes
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via write_attribute' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.write_attribute(attr_name, 'foo bar')
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via []=' do
+      context 'string key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_s] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'symbol key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_sym] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+    end
+
+    context 'when writing attributes via #{attribute}=' do
+      context 'when attribute is not already set' do
+        let(:bar) { Bar.new }
+
+        it 'cannot be written' do
+          expect do
+            bar.send("#{attr_name}=", 'foo bar')
+            bar.save!
+          end.to raise_error(NoMethodError)
+        end
+      end
+
+      context 'when attribute is already set' do
+        let(:bar) { Bar.new(attr_name => 'foo bar') }
+
+        it 'can be written' do
+          bar.send("#{attr_name}=", 'new foo bar')
+          bar.save!
+
+          _bar = Bar.find(bar.id)
+          expect(_bar.send(attr_name)).to eq('new foo bar')
+        end
+      end
+    end
+  end
+
+  context 'when attribute name is alphanumeric' do
+    let(:attr_name) { 'foo' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains spaces' do
+    let(:attr_name) { 'hello world' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains special characters' do
+    let(:attr_name) { 'hello%world' }
+
+    it_behaves_like 'dynamic field'
+  end
+end