mongoid 7.0.12 → 7.3.3

data/spec/mongoid/association/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::EagerLoadable do

data/spec/mongoid/association/embedded/cyclic_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::Cyclic do

data/spec/mongoid/association/embedded/dirty_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require 'spec_helper'
 
 describe "when initialize a model with an embedded model" do

data/spec/mongoid/association/embedded/embedded_in/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Binding do

data/spec/mongoid/association/embedded/embedded_in/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do

data/spec/mongoid/association/embedded/embedded_in/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Proxy do

data/spec/mongoid/association/embedded/embedded_in_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './embeds_one_models'
 
@@ -898,4 +901,4 @@ describe Mongoid::Association::Embedded::EmbeddedIn do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
-end
+end

data/spec/mongoid/association/embedded/embeds_many/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany::Binding do

data/spec/mongoid/association/embedded/embeds_many/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany::Buildable do

data/spec/mongoid/association/embedded/embeds_many/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
@@ -1399,6 +1402,39 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
   end
 
+  describe "#any?" do
+
+    let(:person) do
+      Person.create
+    end
+
+    context "when documents are persisted" do
+      before do
+        person.addresses.create(street: "Upper")
+      end
+
+      it "returns true" do
+        expect(person.addresses.any?).to be true
+      end
+    end
+    
+    context "when documents are not persisted" do
+      before do
+        person.addresses.build(street: "Bond")
+      end
+      
+      it "returns true" do
+        expect(person.addresses.any?).to be true
+      end
+    end
+
+    context "when documents are not created" do
+      it "returns false" do
+        expect(person.addresses.any?).to be false
+      end
+    end
+  end
+
   describe "#create" do
 
     context "when providing multiple attributes" do
@@ -2413,13 +2449,26 @@ describe Mongoid::Association::Embedded::EmbedsMany::Proxy do
     end
 
     context "when providing a criteria class method" do
+      context "without keyword arguments" do
 
-      let(:addresses) do
-        person.addresses.california
+        let(:addresses) do
+          person.addresses.california
+        end
+
+        it "applies the criteria to the documents" do
+          expect(addresses).to eq([ address_one ])
+        end
       end
 
-      it "applies the criteria to the documents" do
-        expect(addresses).to eq([ address_one ])
+      context "with keyword arguments" do
+
+        let(:addresses) do
+          person.addresses.city_and_state(city: "Sacramento", state: "CA")
+        end
+
+        it "applies the criteria to the documents" do
+          expect(addresses).to eq([])
+        end
       end
     end
 

data/spec/mongoid/association/embedded/embeds_many_models.rb

@@ -3,6 +3,7 @@
 
 class EmmCongress
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   embeds_many :legislators, class_name: 'EmmLegislator'
 

data/spec/mongoid/association/embedded/embeds_many_query_spec.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './embeds_many_models'
+
+describe Mongoid::Association::Embedded::EmbedsMany do
+
+  context 'when projecting with #only' do
+    before do
+      congress = EmmCongress.new(name: 'foo')
+      congress.legislators << EmmLegislator.new(a: 1, b: 2)
+      congress.save!
+    end
+
+    let(:congress) do
+      EmmCongress.where(name: 'foo').only(:name, 'legislators._id', 'legislators.a').first
+    end
+
+    let(:legislator) { congress.legislators.first }
+
+    it 'populates specified fields only' do
+      expect(legislator.a).to eq(1)
+      # has a default value specified in the model
+      expect do
+        legislator.b
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(legislator.attributes.keys).to eq(['_id', 'a'])
+    end
+
+    context 'when using only with $' do
+      before do
+        Patient.destroy_all
+        Patient.create!(
+          title: 'Steve',
+          addresses: [
+            Address.new(number: '123'),
+            Address.new(number: '456'),
+          ],
+        )
+      end
+
+      let(:patient) do
+        Patient.where('addresses.number' => {'$gt' => 100}).only('addresses.$').first
+      end
+
+      it 'loads embedded association' do
+        expect(patient.addresses.first.number).to eq(123)
+      end
+    end
+  end
+end

data/spec/mongoid/association/embedded/embeds_many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsMany do
@@ -859,4 +862,4 @@ describe Mongoid::Association::Embedded::EmbedsMany do
       expect(association.path(double( :_parent => true))).to be_a(Mongoid::Atomic::Paths::Embedded::Many)
     end
   end
-end
+end

data/spec/mongoid/association/embedded/embeds_one/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Binding do

data/spec/mongoid/association/embedded/embeds_one/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Buildable do

data/spec/mongoid/association/embedded/embeds_one/proxy_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Embedded::EmbedsOne::Proxy do

data/spec/mongoid/association/embedded/embeds_one_dnl_models.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 # This file is added as an autoload target, but should never be actually
 # processed.
 

data/spec/mongoid/association/embedded/embeds_one_models.rb

@@ -1,5 +1,9 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 class EomParent
   include Mongoid::Document
+  include Mongoid::Timestamps
 
   embeds_one :child, class_name: 'EomChild'
 

data/spec/mongoid/association/embedded/embeds_one_query_spec.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+require_relative './embeds_one_models'
+
+describe Mongoid::Association::Embedded::EmbedsOne do
+
+  context 'when projecting with #only' do
+    before do
+      parent = EomParent.new(name: 'foo')
+      parent.child = EomChild.new(a: 1, b: 2)
+      parent.save!
+    end
+
+    let(:parent) do
+      EomParent.where(name: 'foo').only(:name, 'child._id', 'child.a').first
+    end
+
+    it 'populates specified fields only' do
+      expect(parent.child.a).to eq(1)
+      # has a default value specified in the model
+      expect do
+        parent.child.b
+      end.to raise_error(ActiveModel::MissingAttributeError)
+      expect(parent.child.attributes.keys).to eq(['_id', 'a'])
+    end
+  end
+end

data/spec/mongoid/association/embedded/embeds_one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative './embeds_one_models'
 
@@ -951,4 +954,4 @@ describe Mongoid::Association::Embedded::EmbedsOne do
       expect(association.create_relation(owner, target)).to be_a(EmbeddedObject)
     end
   end
-end
+end

data/spec/mongoid/association/macros_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Macros do

data/spec/mongoid/association/nested/many_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::Many do

data/spec/mongoid/association/nested/one_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Nested::One do
@@ -134,20 +137,24 @@ describe Mongoid::Association::Nested::One do
         { allow_destroy: true }
       end
 
-      let(:builder) do
-        described_class.new(association, {
-          id: name.id,
-          last_name: "Lang",
-          _destroy: true
-        }, options)
-      end
+      %i(id _id).each do |id_field|
+        context "#{id_field}" do
+          let(:builder) do
+            described_class.new(association, {
+              id_field => name.id,
+              last_name: "Lang",
+              _destroy: true
+            }, options)
+          end
 
-      before do
-        builder.build(person)
-      end
+          before do
+            builder.build(person)
+          end
 
-      it "deletes the relation" do
-        expect(person.name).to be_nil
+          it "deletes the relation" do
+            expect(person.name).to be_nil
+          end
+        end
       end
     end
   end

data/spec/mongoid/association/options_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Options do

data/spec/mongoid/association/polymorphic_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe "Polymorphic Associations" do

data/spec/mongoid/association/referenced/belongs_to/binding_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Binding do

data/spec/mongoid/association/referenced/belongs_to/buildable_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 
 describe Mongoid::Association::Referenced::BelongsTo::Buildable do

data/spec/mongoid/association/referenced/belongs_to/eager_spec.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
 require "spec_helper"
 require_relative '../has_many_models'
 
@@ -75,6 +78,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when including the belongs_to association" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       it "queries twice" do
 
@@ -87,6 +93,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when the association is not polymorphic" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       let(:eager) do
         Post.includes(:person).last
@@ -105,13 +114,13 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
         end
 
         it "does not query when touching the association" do
-          expect_query(0) do
+          expect_no_queries do
             expect(eager.person).to eq(person)
           end
         end
 
         it "does not query when updating the association" do
-          expect_query(0) do
+          expect_no_queries do
             eager.person.username = "arthurnn"
           end
         end
@@ -137,18 +146,201 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
 
     context "when the association is polymorphic" do
 
-      let!(:movie) do
-        Movie.create(name: "Bladerunner")
+      context "without namespaces" do
+
+        let!(:stand_alone_rating) do
+          Rating.create(value: 7)
+        end
+
+        let!(:bar) do
+          Bar.create(name: "FooBar")
+        end
+
+        let(:bar_rating) do
+          bar.create_rating(value: 5)
+        end
+
+        let!(:movie) do
+          Movie.create(name: "Bladerunner")
+        end
+
+        let(:movie_rating) do
+          movie.ratings.create(value: 10)
+        end
+
+        let(:eager) do
+          Rating.includes(:ratable).entries
+        end
+
+        context "when the eager load has returned documents" do
+
+          before do
+            bar_rating
+            movie_rating
+            eager
+          end
+
+          it "puts the documents in the parent document" do
+            expect(eager.map { |e| e.ivar(:ratable) }).to eq([nil, bar, movie])
+          end
+
+          it "does not query when touching the association" do
+            expect_no_queries do
+              expect(eager.map(&:ratable)).to eq([nil, bar, movie])
+            end
+          end
+
+          it "does not query when updating the association" do
+            expect_no_queries do
+              eager.last.ratable.name = "Easy rider"
+            end
+          end
+        end
+
+        context "when the eager load has not returned documents" do
+
+          before { eager }
+
+          it "does not set anything on the parent" do
+            expect(eager.map { |e| e.ivar(:ratable) }).to all(be nil)
+          end
+
+          it "has a nil association" do
+            expect(eager.map(&:ratable)).to all(be nil)
+          end
+        end
       end
 
-      let!(:rating) do
-        movie.ratings.create(value: 10)
+      context "with namespaces" do
+
+        let!(:stand_alone_review) do
+          Publication::Review.create(summary: "awful")
+        end
+
+        let!(:encyclopedia) do
+          Publication::Encyclopedia.create(title: "Encyclopedia Britannica")
+        end
+
+        let(:encyclopedia_review) do
+          encyclopedia.reviews.create(summary: "inspiring")
+        end
+
+        let!(:pull_request) do
+          Coding::PullRequest.create(title: "Add eager loading for polymorphic belongs_to associations")
+        end
+
+        let(:pull_request_review) do
+          pull_request.reviews.create(summary: "Looks good to me")
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable).entries
+        end
+
+        context "when the eager load has returned documents" do
+
+          before do
+            encyclopedia_review
+            pull_request_review
+            eager
+          end
+
+          it "puts the documents in the parent document" do
+            expect(eager.map { |e| e.ivar(:reviewable) }).to eq([nil, encyclopedia, pull_request])
+          end
+
+          it "does not query when touching the association" do
+            expect_no_queries do
+              expect(eager.map(&:reviewable)).to eq([nil, encyclopedia, pull_request])
+            end
+          end
+
+          it "does not query when updating the association" do
+            expect_no_queries do
+              eager.last.reviewable.title = "Load stuff eagerly"
+            end
+          end
+        end
+
+        context "when the eager load has not returned documents" do
+
+          before { eager }
+
+          it "does not set anything on the parent" do
+            expect(eager.map { |e| e.ivar(:reviewable) }).to all(be nil)
+          end
+
+          it "has a nil association" do
+            expect(eager.map(&:reviewable)).to all(be nil)
+          end
+        end
+      end
+
+      context 'when eager loading multiple associations' do
+        let(:reviewable) do
+          Publication::Encyclopedia.create!(title: "Encyclopedia Britannica")
+        end
+
+        let!(:reviewable_review) do
+          Publication::Review.create!(summary: "awful",
+            reviewable: reviewable)
+        end
+
+        let(:reviewer) do
+          Dog.create!
+        end
+
+        let!(:reviewer_review) do
+          Publication::Review.create(summary: "okay",
+            reviewer: reviewer)
+        end
+
+        let(:template) do
+          Template.create!
+        end
+
+        let!(:template_review) do
+          Publication::Review.create(summary: "Looks good to me",
+            template: template)
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable, :reviewer, :template).entries
+        end
+
+        it 'loads all associations eagerly' do
+          loaded = expect_query(4) do
+            eager
+          end
+
+          expect_no_queries do
+            eager.map(&:reviewable).compact.should == [reviewable]
+          end
+
+          expect_no_queries do
+            eager.map(&:reviewer).compact.should == [reviewer]
+          end
+
+          expect_no_queries do
+            eager.map(&:template).compact.should == [template]
+          end
+        end
       end
 
-      it "raises an error" do
-        expect {
-          Rating.includes(:ratable).last
-        }.to raise_error(Mongoid::Errors::EagerLoad)
+      context 'when eager loading an association that has type but not value set' do
+
+        let!(:reviewer_review) do
+          Publication::Review.create(summary: "okay",
+            reviewer_type: 'Dog')
+        end
+
+        let(:eager) do
+          Publication::Review.includes(:reviewable, :reviewer, :template).entries
+        end
+
+        it 'does not error' do
+          eager.map(&:reviewer).should == [nil]
+        end
       end
     end
 
@@ -162,6 +354,9 @@ describe Mongoid::Association::Referenced::BelongsTo::Eager do
     end
 
     context "when all the values for the belongs_to association are nil" do
+      # Query count assertions require that all queries are sent using the
+      # same connection object.
+      require_no_multi_shard
 
       before do
         2.times { |i| HmmTicket.create!(person: nil) }