mongoid 7.0.12 → 7.0.13

data/spec/integration/associations/embedded_spec.rb

@@ -59,4 +59,118 @@ describe 'embedded associations' do
       end
     end
   end
+
+  context 'without default order' do
+    let(:congress) do
+      EmmCongress.create!
+    end
+
+    let(:legislator) do
+      EmmLegislator.create!(congress: congress, a: 1)
+    end
+
+    shared_examples_for 'an embedded association' do
+      it 'adds child documents to parent association object' do
+        legislator
+        congress.legislators._target.should == [legislator]
+      end
+
+      it 'adds child documents to parent association object criteria' do
+        legislator
+        congress.legislators.criteria.documents.should == [legislator]
+      end
+
+      it 'populates documents on parent association object' do
+        congress.legislators.documents.should == [legislator]
+      end
+
+      it 'returns created child when referencing embedded association' do
+        congress.legislators.should == [legislator]
+      end
+
+      it 'returns created child when referencing Criteria created from embedded association' do
+        congress.legislators.all.should be_a(Mongoid::Criteria)
+        congress.legislators.all.to_a.should == [legislator]
+      end
+    end
+
+    context 'when association was not previously referenced' do
+      before do
+        legislator
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+
+    context 'when association was previously referenced' do
+      before do
+        # This query must be before the product is created
+        congress.legislators.where(a: 1).first
+
+        legislator
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+  end
+
+  context 'with default order' do
+    let(:manufactory) do
+      EmmManufactory.create!
+    end
+
+    let(:product) do
+      EmmProduct.create!(manufactory: manufactory, name: 'Car')
+    end
+
+    shared_examples_for 'adds child documents to parent association' do
+      it 'adds child documents to parent association' do
+        manufactory.products._target.should == [product]
+      end
+    end
+
+    shared_examples_for 'an embedded association' do
+      it 'adds child documents to parent association object' do
+        product
+        manufactory.products._target.should == [product]
+      end
+
+      it 'adds child documents to parent association object criteria' do
+        product
+        manufactory.products.criteria.documents.should == [product]
+      end
+
+      it 'populates documents on parent association object' do
+        manufactory.products.documents.should == [product]
+      end
+
+      it 'returns created child when referencing embedded association' do
+        manufactory.products.should == [product]
+      end
+
+      it 'returns created child when referencing Criteria created from embedded association' do
+        manufactory.products.all.should be_a(Mongoid::Criteria)
+        manufactory.products.all.to_a.should == [product]
+      end
+    end
+
+    context 'when association is not loaded' do
+      before do
+        product
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+
+    context 'when association is loaded' do
+      before do
+        # This query must be before the product is created
+        manufactory.products.where(name: "Car").first
+
+        product
+      end
+
+      it_behaves_like 'an embedded association'
+    end
+  end
 end

data/spec/lite_spec_helper.rb

@@ -2,6 +2,7 @@
 
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "shared", "lib"))
 
 require "mongoid"
 
@@ -12,6 +13,7 @@ require "mongoid"
 require 'pp'
 
 require 'support/spec_config'
+require 'mrss/lite_constraints'
 require "support/session_registry"
 
 unless SpecConfig.instance.ci?
@@ -44,7 +46,7 @@ RSpec.configure do |config|
     config.add_formatter(RSpec::Core::Formatters::JsonFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
   end
 
-  if SpecConfig.instance.ci?
+  if SpecConfig.instance.ci? && !%w(1 true yes).include?(ENV['INTERACTIVE']&.downcase)
     timeout = if SpecConfig.instance.app_tests?
       # Allow 5 minutes per test for the app tests, since they install
       # gems for Rails applications which can take a long time.
@@ -61,6 +63,8 @@ RSpec.configure do |config|
       end
     end
   end
+
+  config.extend(Mrss::LiteConstraints)
 end
 
 # require all shared examples

data/spec/mongoid/attributes_spec.rb

@@ -242,6 +242,97 @@ describe Mongoid::Attributes do
         end
       end
 
+      context "when the field was not explicitly defined" do
+
+        context "when excluding with only and the field was not excluded" do
+
+          let(:from_db) do
+            Person.only(:_id).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:undefined_field]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was not excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "returns nil" do
+            from_db[:undefined_field].should be nil
+          end
+        end
+      end
+
+      context 'when projecting with #only' do
+        let!(:person) do
+          Person.create(title: 'sir', name: { first_name: 'Jose', language: { name: 'es' } })
+        end
+
+        context 'when projecting an embedded association' do
+          let(:from_db) do
+            Person.only(:name).first
+          end
+
+          context 'when retrieving a field of the association using the dot notation' do
+
+            it 'retrieves the field' do
+              pending 'MONGOID-5032, fixed in 7.3'
+
+              expect(from_db['name.first_name']).to eq 'Jose'
+            end
+          end
+
+          context 'when retrieving a field of a nested association using the dot notation' do
+            it 'retrieves the field' do
+              pending 'MONGOID-5032, fixed in 7.3'
+
+              expect(from_db['name.language.name']).to eq 'es'
+            end
+          end
+        end
+
+        context 'when projecting a sub-association of an embedded association' do
+          let(:from_db) do
+            Person.only('name.language').first
+          end
+
+          context 'when retrieving a field under the projected sub-association' do
+            it 'retrieves the field' do
+              pending 'MONGOID-5032, fixed in 7.3'
+
+              expect(from_db['name.language.name']).to eq 'es'
+            end
+          end
+
+          context 'when retrieving a non-projected field' do
+            it 'raises MissingAttributeError' do
+              expect do
+                from_db['name.first_name']
+              end.to raise_error(ActiveModel::MissingAttributeError)
+            end
+          end
+        end
+      end
+
       context "when the attribute does not exist" do
 
         before do
@@ -326,6 +417,67 @@ describe Mongoid::Attributes do
         expect(terms).to eq(true)
       end
     end
+
+    context 'when the field is not explicitly defined' do
+      let(:bar) { Bar.new }
+
+      before do
+        bar['missing_field'] = 42
+      end
+
+      it 'writes the value into attributes' do
+        bar.attributes.should == {'_id' => bar.id, 'missing_field' => 42}
+      end
+
+      it 'makes the attribute accessible via []' do
+        bar['missing_field'].should == 42
+      end
+
+      context 'when writing fields on a document with projection' do
+
+        let!(:person) do
+          Person.create(title: "sir")
+        end
+
+        context "when excluding with only and the field was not excluded" do
+
+          let(:from_db) do
+            Person.only(:_id).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:undefined_field] = 'x'
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title] = 'x'
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without and the field was not excluded" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "writes the value" do
+            from_db[:undefined_field] = 'x'
+            from_db[:undefined_field].should == 'x'
+          end
+        end
+      end
+    end
   end
 
   describe "#_id" do
@@ -890,6 +1042,50 @@ describe Mongoid::Attributes do
         expect(person.age_before_type_cast).to eq("old")
       end
     end
+
+    context 'when reading fields on a document with projection' do
+
+      let!(:person) do
+        Person.create(title: "sir")
+      end
+
+      context "when excluding with only and the field was not excluded" do
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.read_attribute(:undefined_field)
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.read_attribute(:title)
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was not excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "returns nil" do
+          from_db.read_attribute(:undefined_field).should be nil
+        end
+      end
+    end
   end
 
   describe "#attribute_present?" do
@@ -1395,6 +1591,51 @@ describe Mongoid::Attributes do
         expect(dictionary.description).to eq('foo')
       end
     end
+
+    context 'when writing fields on a document with projection' do
+
+      let!(:person) do
+        Person.create(title: "sir")
+      end
+
+      context "when excluding with only and the field was not excluded" do
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.write_attribute(:undefined_field, 'x')
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.write_attribute(:title, 'x')
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without and the field was not excluded" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "writes the value" do
+          from_db.write_attribute(:undefined_field, 'x')
+          from_db.read_attribute(:undefined_field).should == 'x'
+        end
+      end
+    end
   end
 
   describe "#typed_value_for" do

data/spec/mongoid/contextual/atomic_spec.rb

@@ -653,12 +653,25 @@ describe Mongoid::Contextual::Atomic do
       context.set(name: "Recoil")
     end
 
-    it "sets existing fields" do
-      expect(depeche_mode.reload.name).to eq("Recoil")
+    shared_examples 'writes as expected' do
+      it "sets existing fields" do
+        expect(depeche_mode.reload.name).to eq("Recoil")
+      end
+
+      it "sets non existent fields" do
+        expect(smiths.reload.name).to eq("Recoil")
+      end
     end
 
-    it "sets non existent fields" do
-      expect(smiths.reload.name).to eq("Recoil")
+    include_examples 'writes as expected'
+
+    context 'when fields being set have been projected out' do
+
+      let(:criteria) do
+        Band.only(:genres)
+      end
+
+      include_examples 'writes as expected'
     end
   end