mongoid 6.4.2 → 7.0.3

data/spec/mongoid/{relations → association}/polymorphic_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Polymorphic do
+describe "Polymorphic Associations" do
 
   describe "#polymorph" do
 
@@ -12,16 +12,8 @@ describe Mongoid::Relations::Polymorphic do
 
       context "when the relation stores a foreign key" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            name: :ratable,
-            polymorphic: true,
-            relation: Mongoid::Relations::Referenced::In
-          )
-        end
-
-        let!(:polymorphed) do
-          klass.polymorph(metadata)
+        let!(:association) do
+          klass.belongs_to :ratable, polymorphic: true
         end
 
         it "sets polymorphic to true" do
@@ -31,24 +23,12 @@ describe Mongoid::Relations::Polymorphic do
         it "adds the foreign key type field" do
           expect(klass.fields["ratable_type"]).to_not be_nil
         end
-
-        it "returns self" do
-          expect(polymorphed).to eq(klass)
-        end
       end
 
       context "when the relation does not store a foreign key" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            name: :ratings,
-            as: :ratable,
-            relation: Mongoid::Relations::Referenced::Many
-          )
-        end
-
-        before do
-          klass.polymorph(metadata)
+        let!(:association) do
+          klass.has_many :ratings, as: :ratable
         end
 
         it "sets polymorphic to true" do
@@ -67,15 +47,8 @@ describe Mongoid::Relations::Polymorphic do
 
     context "when the relation is not polymorphic" do
 
-      let(:metadata) do
-        Mongoid::Relations::Metadata.new(
-          name: :ratings,
-          relation: Mongoid::Relations::Referenced::Many
-        )
-      end
-
-      before do
-        klass.polymorph(metadata)
+      let!(:association) do
+        klass.has_many :ratings
       end
 
       it "sets polymorphic to false" do
@@ -125,4 +98,63 @@ describe Mongoid::Relations::Polymorphic do
       end
     end
   end
+
+  context 'when the relation is touchable' do
+
+    context 'when the relation is embedded' do
+
+      let(:define_classes) do
+
+        class FirstOwner
+          include Mongoid::Document
+
+          embeds_one :owned, class_name: 'Owned', as: :embedded_relation_polymorphic_touch_owner
+        end
+
+        class SecondOwner
+          include Mongoid::Document
+
+          embeds_one :owned, class_name: 'Owned', as: :embedded_relation_polymorphic_touch_owner
+        end
+
+        class Owned
+          include Mongoid::Document
+
+          embedded_in :embedded_relation_polymorphic_touch_owner, polymorphic: true, touch: true
+        end
+      end
+
+      it 'successfully defines the touch method' do
+       expect { define_classes }.not_to raise_error
+      end
+    end
+
+    context 'when the relation is not embedded' do
+
+      let(:define_classes) do
+
+        class FirstOwner
+          include Mongoid::Document
+
+          has_one :owned, class_name: 'Owned', as: :belongs_relation_polymorphic_touch_owner
+        end
+
+        class SecondOwner
+          include Mongoid::Document
+
+          has_one :owned, class_name: 'Owned', as: :belongs_relation_polymorphic_touch_owner
+        end
+
+        class Owned
+          include Mongoid::Document
+
+          belongs_to :belongs_relation_polymorphic_touch_owner, polymorphic: true, touch: true
+        end
+      end
+
+      it 'successfully defines the touch method' do
+       expect { define_classes }.not_to raise_error
+      end
+    end
+  end
 end

data/spec/mongoid/{relations/bindings/referenced/in_spec.rb → association/referenced/belongs_to/binding_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Bindings::Referenced::In do
+describe Mongoid::Association::Referenced::BelongsTo::Binding do
 
   let(:person) do
     Person.new
@@ -14,11 +14,11 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     Post.new
   end
 
-  let(:game_metadata) do
+  let(:game_association) do
     Game.relations["person"]
   end
 
-  let(:post_metadata) do
+  let(:post_association) do
     Post.relations["person"]
   end
 
@@ -27,7 +27,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references one" do
 
       let(:binding) do
-        described_class.new(game, person, game_metadata)
+        described_class.new(game, person, game_association)
       end
 
       context "when the document is bindable with default pk" do
@@ -90,7 +90,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references many" do
 
       let(:binding) do
-        described_class.new(post, person, post_metadata)
+        described_class.new(post, person, post_association)
       end
 
       context "when the document is bindable" do
@@ -129,7 +129,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references one" do
 
       let(:binding) do
-        described_class.new(game, person, game_metadata)
+        described_class.new(game, person, game_association)
       end
 
       context "when the document is unbindable" do
@@ -162,7 +162,7 @@ describe Mongoid::Relations::Bindings::Referenced::In do
     context "when the child of an references many" do
 
       let(:binding) do
-        described_class.new(post, person, post_metadata)
+        described_class.new(post, person, post_association)
       end
 
       context "when the document is unbindable" do

data/spec/mongoid/{relations/builders/referenced/in_spec.rb → association/referenced/belongs_to/buildable_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Builders::Referenced::In do
+describe Mongoid::Association::Referenced::BelongsTo::Buildable do
 
   let(:base) do
     double
@@ -8,45 +8,28 @@ describe Mongoid::Relations::Builders::Referenced::In do
 
   describe "#build" do
 
-    let(:criteria) do
-      Person.where(_id: object_id)
+    let(:document) do
+      association.build(base, object)
     end
 
-    let(:metadata) do
-      double(
-        klass: Person,
-        name: :person,
-        foreign_key: "person_id",
-        criteria: criteria
-      )
-    end
-
-    let(:builder) do
-      described_class.new(base, metadata, object)
+    let(:association) do
+      Post.relations['person']
     end
 
     context "when provided an id" do
 
       context "when the object is an object id" do
 
-        let(:object_id) do
-          BSON::ObjectId.new
+        let!(:person) do
+          Person.create(_id: object)
         end
 
         let(:object) do
-          object_id
-        end
-
-        let(:person) do
-          double
+          BSON::ObjectId.new
         end
 
         before do
-          expect(criteria).to receive(:first).and_return(person)
-        end
-
-        let!(:document) do
-          builder.build
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -54,40 +37,52 @@ describe Mongoid::Relations::Builders::Referenced::In do
         end
       end
 
-      context "when the object is an integer" do
+      context 'when the id is nil' do
+
+        let(:object) do
+          nil
+        end
 
         before do
-          Person.field :_id, overwrite: true, type: Integer
+          expect(Person).not_to receive(:where)
         end
 
-        after do
-          Person.field(
-            :_id,
-            overwrite: true,
-            type: BSON::ObjectId,
-            pre_processed: true,
-            default: ->{ BSON::ObjectId.new }
-          )
+        it 'returns nil' do
+          expect(document).to be_nil
         end
+      end
 
-        let(:object_id) do
-          666
+      context "when the id does not correspond to a document in the database" do
+
+        let!(:person) do
+          Person.create
         end
 
         let(:object) do
-          object_id
+          BSON::ObjectId.new
         end
 
-        let(:person) do
-          double
+        before do
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
-        before do
-          expect(criteria).to receive(:first).and_return(person)
+        it 'returns nil' do
+          expect(document).to be_nil
+        end
+      end
+
+      context "when the object is an integer" do
+
+        let!(:person) do
+          Person.create(_id: object)
+        end
+
+        let(:object) do
+          666
         end
 
-        let!(:document) do
-          builder.build
+        before do
+          expect(Person).to receive(:where).with(association.primary_key => object).and_call_original
         end
 
         it "sets the document" do
@@ -98,50 +93,22 @@ describe Mongoid::Relations::Builders::Referenced::In do
 
     context "when provided a object" do
 
-      let(:object) do
-        Person.new
+      let!(:person) do
+        Person.create
       end
 
-      let(:builder) do
-        described_class.new(base, nil, object)
+      let(:object) do
+        Person.new
       end
 
-      let(:document) do
-        builder.build
+      before do
+        expect(Person).not_to receive(:where)
       end
 
       it "returns the object" do
         expect(document).to eq(object)
       end
     end
-  end
-
-  describe "#build" do
-
-    let(:game) do
-      Game.new
-    end
-
-    context "when no document found in the database" do
-
-      context "when the id is nil" do
-
-        it "returns nil" do
-          expect(game.person).to be_nil
-        end
-      end
-
-      context "when the id is incorrect" do
-
-        before do
-          game.person_id = BSON::ObjectId.new
-        end
-
-        it "returns nil" do
-          expect(game.person).to be_nil
-        end
-      end
-    end
 
     context "when the document is persisted" do
 

data/spec/mongoid/{relations/eager/belongs_to_spec.rb → association/referenced/belongs_to/eager_spec.rb}

@@ -1,6 +1,7 @@
 require "spec_helper"
+require_relative '../has_many_models'
 
-describe Mongoid::Relations::Eager::BelongsTo do
+describe Mongoid::Association::Referenced::BelongsTo::Eager do
 
   describe ".grouped_docs" do
 
@@ -12,13 +13,13 @@ describe Mongoid::Relations::Eager::BelongsTo do
       Person.create!
     end
 
-    let(:metadata) do
+    let(:association) do
       Post.reflect_on_association(:person)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -27,7 +28,7 @@ describe Mongoid::Relations::Eager::BelongsTo do
     end
 
     it "aggregates by the parent id" do
-      expect(eager.grouped_docs.keys).to eq([person.id])
+      expect(eager.send(:grouped_docs).keys).to eq([person.id])
     end
   end
 
@@ -41,13 +42,13 @@ describe Mongoid::Relations::Eager::BelongsTo do
       Person.create!
     end
 
-    let(:metadata) do
+    let(:association) do
       Post.reflect_on_association(:person)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
@@ -55,11 +56,11 @@ describe Mongoid::Relations::Eager::BelongsTo do
       Post.create!(person: person)
     end
 
-    it "sets the relation into the parent" do
+    it "sets the association into the parent" do
       docs.each do |doc|
         expect(doc).to receive(:set_relation).with(:person, :foo)
       end
-      eager.set_on_parent(person.id, :foo)
+      eager.send(:set_on_parent, person.id, :foo)
     end
   end
 
@@ -73,7 +74,7 @@ describe Mongoid::Relations::Eager::BelongsTo do
       3.times { |i| Account.create!(person: person, name: "savings#{i}") }
     end
 
-    context "when including the belongs_to relation" do
+    context "when including the belongs_to association" do
 
       it "queries twice" do
 
@@ -85,7 +86,7 @@ describe Mongoid::Relations::Eager::BelongsTo do
       end
     end
 
-    context "when the relation is not polymorphic" do
+    context "when the association is not polymorphic" do
 
       let(:eager) do
         Post.includes(:person).last
@@ -128,13 +129,13 @@ describe Mongoid::Relations::Eager::BelongsTo do
           expect(eager.ivar(:person)).to be nil
         end
 
-        it "has a nil relation" do
+        it "has a nil association" do
           expect(eager.person).to be nil
         end
       end
     end
 
-    context "when the relation is polymorphic" do
+    context "when the association is polymorphic" do
 
       let!(:movie) do
         Movie.create(name: "Bladerunner")
@@ -159,5 +160,23 @@ describe Mongoid::Relations::Eager::BelongsTo do
         expect(game.person_id).to eql(id)
       end
     end
+
+    context "when all the values for the belongs_to association are nil" do
+
+      before do
+        2.times { |i| HmmTicket.create!(person: nil) }
+      end
+
+      it "only queries once for the parent documents" do
+        found_ticket = false
+        expect_query(1) do
+          HmmTicket.all.includes(:person).each do |ticket|
+            expect(ticket.person).to eq nil
+            found_ticket = true
+          end
+        end
+        expect(found_ticket).to be true
+      end
+    end
   end
 end