mongoid 6.0.3 → 6.1.0.rc0

data/spec/mongoid/contextual/map_reduce_spec.rb

@@ -32,15 +32,15 @@ describe Mongoid::Contextual::MapReduce do
     Band.collection
   end
 
-  describe "#command" do
+  let(:criteria) do
+    Band.all
+  end
 
-    let(:criteria) do
-      Band.all
-    end
+  let(:map_reduce) do
+    described_class.new(collection, criteria, map, reduce)
+  end
 
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
+  describe "#command" do
 
     let(:base_command) do
       {
@@ -51,27 +51,25 @@ describe Mongoid::Contextual::MapReduce do
       }
     end
 
-    it "returns the db command" do
-      expect(map_reduce.command).to eq(base_command)
-    end
-
     context "with sort" do
+
       let(:criteria) do
         Band.order_by(name: -1)
       end
 
-      it "returns the db command with a sort option" do
-        expect(map_reduce.command).to eq(base_command.merge(sort: {'name' => -1}))
+      it "includes a sort option in the map reduce command" do
+        expect(map_reduce.command[:sort]).to eq('name' => -1)
       end
     end
 
     context "with limit" do
+
       let(:criteria) do
         Band.limit(10)
       end
 
       it "returns the db command with a limit option" do
-        expect(map_reduce.command).to eq(base_command.merge(limit: 10))
+        expect(map_reduce.command[:limit]).to eq(10)
       end
     end
   end
@@ -82,10 +80,6 @@ describe Mongoid::Contextual::MapReduce do
       Band.all
     end
 
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:counts) do
       map_reduce.out(inline: 1).counts
     end
@@ -102,14 +96,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#each" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     context "when the map/reduce is inline" do
 
       let(:results) do
@@ -130,20 +116,40 @@ describe Mongoid::Contextual::MapReduce do
         map_reduce.out(replace: "mr-output")
       end
 
-      it "iterates over the results" do
-        expect(results.entries).to eq([
+      let(:expected_results) do
+        [
           { "_id" => "Depeche Mode", "value" => { "likes" => 200 }},
           { "_id" => "Tool", "value" => { "likes" => 100 }}
-        ])
+        ]
+      end
+
+      it "iterates over the results" do
+        expect(results.entries).to eq(expected_results)
+      end
+
+      it 'outputs to the collection' do
+        expect(results.entries).to eq(map_reduce.criteria.view.database["mr-output"].find.to_a)
       end
     end
 
     context "when no output is provided" do
 
-      it "raises an error" do
-        expect {
-          map_reduce.entries
-        }.to raise_error(Mongoid::Errors::NoMapReduceOutput)
+      context "when the results are iterated" do
+
+        it "raises an error" do
+          expect {
+            map_reduce.entries
+          }.to raise_error(Mongoid::Errors::NoMapReduceOutput)
+        end
+      end
+
+      context "when the statstics are requested" do
+
+        it "raises an error" do
+          expect {
+            map_reduce.counts
+          }.to raise_error(Mongoid::Errors::NoMapReduceOutput)
+        end
       end
     end
 
@@ -161,17 +167,46 @@ describe Mongoid::Contextual::MapReduce do
         expect(results.entries).to be_empty
       end
     end
-  end
 
-  describe "#emitted" do
+    context "when there is a collation on the criteria" do
 
-    let(:criteria) do
-      Band.all
-    end
+      let(:map) do
+        %Q{
+         function() {
+           emit(this.name, 1);
+        }}
+      end
 
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
+      let(:reduce) do
+        %Q{
+         function(key, values) {
+           return Array.sum(values);
+        }}
+      end
+
+      let(:criteria) do
+        Band.where(name: 'DEPECHE MODE').collation(locale: 'en_US', strength: 2)
+      end
+
+      context 'when the server supports collations', if: collation_supported? do
+
+        it 'applies the collation' do
+          expect(map_reduce.out(inline: 1).count).to eq(1)
+        end
+      end
+
+      context 'when the server does not support collations', unless: collation_supported? do
+
+        it 'raises an exception' do
+          expect {
+            map_reduce.out(inline: 1).to_a
+          }.to raise_exception(Mongo::Error::UnsupportedCollation)
+        end
+      end
     end
+  end
+
+  describe "#emitted" do
 
     let(:emitted) do
       map_reduce.out(inline: 1).emitted
@@ -184,16 +219,8 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#empty?" do
 
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     context "when the map/reduce has results" do
 
-      let(:criteria) do
-        Band.all
-      end
-
       let(:results) do
         map_reduce.out(inline: 1)
       end
@@ -221,14 +248,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#finalize" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:finalized) do
       map_reduce.finalize("testing")
     end
@@ -240,14 +259,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#input" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:input) do
       map_reduce.out(inline: 1).input
     end
@@ -259,14 +270,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#js_mode" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:results) do
       map_reduce.out(inline: 1).js_mode
     end
@@ -278,14 +281,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#out" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     context "when providing inline" do
 
       let(:out) do
@@ -293,7 +288,7 @@ describe Mongoid::Contextual::MapReduce do
       end
 
       it "sets the out command" do
-        expect(out.command[:out]).to eq(inline: 1)
+        expect(out.command[:out][:inline]).to eq(1)
       end
     end
 
@@ -306,7 +301,7 @@ describe Mongoid::Contextual::MapReduce do
         end
 
         it "sets the out command value to a string" do
-          expect(out.command[:out]).to eq(replace: "test")
+          expect(out.command[:out][:replace]).to eq('test')
         end
       end
     end
@@ -314,14 +309,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#output" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:output) do
       map_reduce.out(inline: 1).output
     end
@@ -332,40 +319,44 @@ describe Mongoid::Contextual::MapReduce do
   end
 
   describe "#raw" do
-    let(:criteria) { Band.all }
-    let(:client) { collection.database.client }
-    let(:map_reduce) { described_class.new(collection, criteria, map, reduce) }
 
-    subject { map_reduce.raw }
+    let(:client) do
+      collection.database.client
+    end
 
-    it { expect{subject}.to raise_error(Mongoid::Errors::NoMapReduceOutput) }
+    context "when not specifying an out" do
 
-    context "when providing inline" do
-      let!(:out) { map_reduce.out(inline: 1) }
+      it "raises a NoMapReduceOutput error" do
+        expect {
+          map_reduce.raw
+        }.to raise_error(Mongoid::Errors::NoMapReduceOutput)
+      end
+    end
 
-      before { allow(client).to receive(:command).and_return(['result', 'from', 'client.command']) }
+    context "when providing replace" do
 
-      it "passes the command to the client, using the client options" do
-        expect(client).to receive(:command).with(out.command, client.options)
-        subject
+      let(:replace_map_reduce) do
+        map_reduce.out(replace: 'output-collection')
       end
 
-      it "returns the first element from the result array of client.command" do
-        expect(subject).to eq('result')
+      context 'when a read preference is defined' do
+
+        let(:criteria) do
+          Band.all.read(mode: :secondary)
+        end
+
+        it "uses the read preference", if: testing_replica_set? do
+
+          expect {
+            replace_map_reduce.raw
+          }.to raise_exception(Mongo::Error::OperationFailure)
+        end
       end
     end
   end
 
   describe "#reduced" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:reduced) do
       map_reduce.out(inline: 1).reduced
     end
@@ -377,14 +368,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#scope" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:finalize) do
       %Q{
       function(key, value) {
@@ -404,14 +387,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#time" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:time) do
       map_reduce.out(inline: 1).time
     end
@@ -423,14 +398,6 @@ describe Mongoid::Contextual::MapReduce do
 
   describe "#execute" do
 
-    let(:criteria) do
-      Band.all
-    end
-
-    let(:map_reduce) do
-      described_class.new(collection, criteria, map, reduce)
-    end
-
     let(:execution_results) do
       map_reduce.out(inline: 1).execute
     end

data/spec/mongoid/contextual/memory_spec.rb

@@ -47,6 +47,21 @@ describe Mongoid::Contextual::Memory do
           expect(context.send(method)).to be true
         end
       end
+
+      context 'when there is a collation on the criteria' do
+
+        let(:criteria) do
+          Address.where(street: "hobrecht").tap do |crit|
+            crit.documents = [ hobrecht, friedel ]
+          end.collation(locale: 'en_US', strength: 2)
+        end
+
+        it "raises an exception" do
+          expect {
+            context.send(method)
+          }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+        end
+      end
     end
   end
 
@@ -77,6 +92,21 @@ describe Mongoid::Contextual::Memory do
       end
     end
 
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.where(street: "hobrecht").tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.count
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
+
     context "when provided a document" do
 
       context "when the document matches" do
@@ -245,6 +275,21 @@ describe Mongoid::Contextual::Memory do
           expect(deleted).to eq(1)
         end
       end
+
+      context 'when there is a collation on the criteria' do
+
+        let(:criteria) do
+          Address.any_in(street: [ "hobrecht", "friedel" ]).tap do |crit|
+            crit.documents = [ hobrecht, friedel, pfluger ]
+          end.collation(locale: 'en_US', strength: 2)
+        end
+
+        it "raises an exception" do
+          expect {
+            context.send(method)
+          }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+        end
+      end
     end
   end
 
@@ -278,36 +323,54 @@ describe Mongoid::Contextual::Memory do
 
     describe "##{method}" do
 
-      let!(:destroyed) do
-        context.send(method)
-      end
+      context 'when there is no collation on the criteria' do
 
-      it "deletes the first matching document" do
-        expect(hobrecht).to be_destroyed
-      end
+        let!(:destroyed) do
+          context.send(method)
+        end
 
-      it "deletes the last matching document" do
-        expect(friedel).to be_destroyed
-      end
+        it "deletes the first matching document" do
+          expect(hobrecht).to be_destroyed
+        end
 
-      it "does not delete non matching docs" do
-        expect(pfluger).to_not be_destroyed
-      end
+        it "deletes the last matching document" do
+          expect(friedel).to be_destroyed
+        end
 
-      it "removes the docs from the relation" do
-        expect(person.addresses).to eq([ pfluger ])
-      end
+        it "does not delete non matching docs" do
+          expect(pfluger).to_not be_destroyed
+        end
 
-      it "removes the docs from the context" do
-        expect(context.entries).to be_empty
-      end
+        it "removes the docs from the relation" do
+          expect(person.addresses).to eq([ pfluger ])
+        end
+
+        it "removes the docs from the context" do
+          expect(context.entries).to be_empty
+        end
 
-      it "persists the changes to the database" do
-        expect(person.reload.addresses).to eq([ pfluger ])
+        it "persists the changes to the database" do
+          expect(person.reload.addresses).to eq([ pfluger ])
+        end
+
+        it "returns the number of destroyed documents" do
+          expect(destroyed).to eq(2)
+        end
       end
 
-      it "returns the number of destroyed documents" do
-        expect(destroyed).to eq(2)
+      context 'when there is a collation on the criteria' do
+
+        let(:criteria) do
+          Address.any_in(street: [ "hobrecht", "friedel" ]).tap do |crit|
+            crit.documents = [ hobrecht, friedel, pfluger ]
+          end.collation(locale: 'en_US', strength: 2)
+        end
+
+        it "raises an exception" do
+          expect {
+            context.send(method)
+          }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+        end
       end
     end
   end
@@ -355,6 +418,21 @@ describe Mongoid::Contextual::Memory do
         expect(context.distinct(:street)).to eq([ "hobrecht", "friedel" ])
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.where(street: "hobrecht").tap do |crit|
+          crit.documents = [ hobrecht, hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.distinct(:street)
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#each" do
@@ -441,6 +519,21 @@ describe Mongoid::Contextual::Memory do
         end
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.where(street: "hobrecht").tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.each
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#exists?" do
@@ -486,6 +579,21 @@ describe Mongoid::Contextual::Memory do
         expect(context).to_not be_exists
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.where(street: "pfluger").tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   [ :first, :one ].each do |method|
@@ -513,6 +621,21 @@ describe Mongoid::Contextual::Memory do
       it "returns the first matching document" do
         expect(context.send(method)).to eq(hobrecht)
       end
+
+      context 'when there is a collation on the criteria' do
+
+        let(:criteria) do
+          Address.where(:street.in => [ "hobrecht", "friedel" ]).tap do |crit|
+            crit.documents = [ hobrecht, friedel ]
+          end.collation(locale: 'en_US', strength: 2)
+        end
+
+        it "raises an exception" do
+          expect {
+            context.send(method)
+          }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+        end
+      end
     end
   end
 
@@ -600,6 +723,21 @@ describe Mongoid::Contextual::Memory do
         expect(context).to eq([ hobrecht ])
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.limit(1).tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#last" do
@@ -625,6 +763,21 @@ describe Mongoid::Contextual::Memory do
     it "returns the last matching document" do
       expect(context.last).to eq(friedel)
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.where(:street.in => [ "hobrecht", "friedel" ]).tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.last
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   [ :length, :size ].each do |method|
@@ -672,6 +825,21 @@ describe Mongoid::Contextual::Memory do
           expect(context.send(method)).to eq(0)
         end
       end
+
+      context 'when there is a collation on the criteria' do
+
+        let(:criteria) do
+          Address.where(street: "hobrecht").tap do |crit|
+            crit.documents = [ hobrecht, friedel ]
+          end.collation(locale: 'en_US', strength: 2)
+        end
+
+        it "raises an exception" do
+          expect {
+            context.send(method)
+          }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+        end
+      end
     end
   end
 
@@ -699,34 +867,52 @@ describe Mongoid::Contextual::Memory do
       described_class.new(criteria)
     end
 
-    let!(:limit) do
-      context.limit(2)
-    end
+    context 'when there is no collation on the criteria' do
 
-    it "returns the context" do
-      expect(limit).to eq(context)
-    end
+      let!(:limit) do
+        context.limit(2)
+      end
 
-    context "when asking for all documents" do
+      it "returns the context" do
+        expect(limit).to eq(context)
+      end
+
+      context "when asking for all documents" do
 
-      context "when only a limit exists" do
+        context "when only a limit exists" do
 
-        it "only returns the limited documents" do
-          expect(context.entries).to eq([ hobrecht, friedel ])
+          it "only returns the limited documents" do
+            expect(context.entries).to eq([ hobrecht, friedel ])
+          end
         end
-      end
 
-      context "when a skip and limit exist" do
+        context "when a skip and limit exist" do
 
-        before do
-          limit.skip(1)
-        end
+          before do
+            limit.skip(1)
+          end
 
-        it "applies the skip before the limit" do
-          expect(context.entries).to eq([ friedel, pfluger ])
+          it "applies the skip before the limit" do
+            expect(context.entries).to eq([ friedel, pfluger ])
+          end
         end
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.tap do |crit|
+          crit.documents = [ hobrecht, friedel, pfluger ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.limit(2)
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#pluck" do
@@ -784,6 +970,21 @@ describe Mongoid::Contextual::Memory do
         end
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.tap do |crit|
+          crit.documents = [ hobrecht, friedel ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.pluck(:foo, :bar)
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#skip" do
@@ -810,34 +1011,52 @@ describe Mongoid::Contextual::Memory do
       described_class.new(criteria)
     end
 
-    let!(:skip) do
-      context.skip(1)
-    end
+    context 'when there is no collation on the criteria' do
 
-    it "returns the context" do
-      expect(skip).to eq(context)
-    end
+      let!(:skip) do
+        context.skip(1)
+      end
+
+      it "returns the context" do
+        expect(skip).to eq(context)
+      end
 
-    context "when asking for all documents" do
+      context "when asking for all documents" do
 
-      context "when only a skip exists" do
+        context "when only a skip exists" do
 
-        it "skips the correct number" do
-          expect(context.entries).to eq([ friedel, pfluger ])
+          it "skips the correct number" do
+            expect(context.entries).to eq([ friedel, pfluger ])
+          end
         end
-      end
 
-      context "when a skip and limit exist" do
+        context "when a skip and limit exist" do
 
-        before do
-          skip.limit(1)
-        end
+          before do
+            skip.limit(1)
+          end
 
-        it "applies the skip before the limit" do
-          expect(context.entries).to eq([ friedel ])
+          it "applies the skip before the limit" do
+            expect(context.entries).to eq([ friedel ])
+          end
         end
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.tap do |crit|
+          crit.documents = [ hobrecht, friedel, pfluger ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.skip(1)
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#sort" do
@@ -991,6 +1210,21 @@ describe Mongoid::Contextual::Memory do
         expect(context.entries).to eq([ friedel, hobrecht, pfluger ])
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.tap do |crit|
+          crit.documents = [ hobrecht, friedel, pfluger ]
+        end.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.sort(state: 1)
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#update" do
@@ -1118,6 +1352,19 @@ describe Mongoid::Contextual::Memory do
         end
       end
     end
+
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.update
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
   end
 
   describe "#update_all" do
@@ -1138,6 +1385,19 @@ describe Mongoid::Contextual::Memory do
       person.addresses.create(street: "pfluger")
     end
 
+    context 'when there is a collation on the criteria' do
+
+      let(:criteria) do
+        Address.all.collation(locale: 'en_US', strength: 2)
+      end
+
+      it "raises an exception" do
+        expect {
+          context.update_all({})
+        }.to raise_exception(Mongoid::Errors::InMemoryCollationNotSupported)
+      end
+    end
+
     context "when the documents are empty" do
 
       let(:person_two) do