mongoid 5.4.0 → 6.4.8

data/spec/mongoid/matchable/elem_match_spec.rb

@@ -0,0 +1,86 @@
+require "spec_helper"
+
+describe Mongoid::Matchable::ElemMatch do
+
+  let(:attribute) {[{"a" => 1, "b" => 2}, {"a" => 2, "b" => 2}, {"a" => 3, "b" => 1}]}
+  let(:matcher) do
+    described_class.new(attribute)
+  end
+
+  describe "#_matches?" do
+
+    context "when the attribute is not an array" do
+
+      let(:attribute) {"string"}
+
+      it "returns false" do
+        expect(matcher._matches?("$elemMatch" => {"a" => 1})).to be false
+      end
+    end
+
+    context "when the $elemMatch is not a hash" do
+
+      let(:attribute) {"string"}
+
+      it "returns false" do
+        expect(matcher._matches?("$elemMatch" => [])).to be false
+      end
+    end
+
+    context "when there is a sub document that matches the criteria" do
+
+      it "returns true" do
+        expect(matcher._matches?("$elemMatch" => {"a" => 1})).to be true
+      end
+
+      context "when evaluating multiple fields of the subdocument" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => 1, "b" => 2})).to be true
+        end
+
+        context "when the $elemMatch document keys are out of order" do
+
+          it "returns true" do
+            expect(matcher._matches?("$elemMatch" => {"b" => 2, "a" => 1})).to be true
+          end
+        end
+      end
+
+      context "when using other operators that match" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 1}})).to be true
+        end
+      end
+    end
+
+    context "when there is not a sub document that matches the criteria" do
+
+      it "returns false" do
+        expect(matcher._matches?("$elemMatch" => {"a" => 10})).to be false
+      end
+
+      context "when evaluating multiple fields of the subdocument" do
+
+        it "returns false" do
+          expect(matcher._matches?("$elemMatch" => {"a" => 1, "b" => 3})).to be false
+        end
+      end
+
+      context "when using other operators that do not match" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 10}})).to be false
+        end
+      end
+    end
+
+    context "when using a criteria that matches partially but not a single sub document" do
+
+      it "returns false" do
+        expect(matcher._matches?("$elemMatch" => {"a" => 3, "b" => 2})).to be false
+      end
+    end
+  end
+end

data/spec/mongoid/matchable/exists_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Exists do
 
-  describe "#matches?" do
+  describe "#_matches?" do
 
     context "when checking for existence" do
 
@@ -13,7 +13,7 @@ describe Mongoid::Matchable::Exists do
         end
 
         it "returns true" do
-          expect(matcher.matches?("$exists" => true)).to be true
+          expect(matcher._matches?("$exists" => true)).to be true
         end
       end
 
@@ -24,7 +24,7 @@ describe Mongoid::Matchable::Exists do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$exists" => true)).to be false
+          expect(matcher._matches?("$exists" => true)).to be false
         end
       end
     end
@@ -38,7 +38,7 @@ describe Mongoid::Matchable::Exists do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$exists" => false)).to be false
+          expect(matcher._matches?("$exists" => false)).to be false
         end
       end
 
@@ -49,7 +49,7 @@ describe Mongoid::Matchable::Exists do
         end
 
         it "returns true" do
-          expect(matcher.matches?("$exists" => false)).to be true
+          expect(matcher._matches?("$exists" => false)).to be true
         end
       end
     end

data/spec/mongoid/matchable/gt_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Gt do
 
-  describe "#matches?" do
+  describe "#_matches?" do
 
     context "when the value is larger" do
 
@@ -11,7 +11,7 @@ describe Mongoid::Matchable::Gt do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$gt" => 3)).to be true
+        expect(matcher._matches?("$gt" => 3)).to be true
       end
     end
 
@@ -22,7 +22,7 @@ describe Mongoid::Matchable::Gt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$gt" => 3)).to be false
+        expect(matcher._matches?("$gt" => 3)).to be false
       end
     end
 
@@ -33,7 +33,7 @@ describe Mongoid::Matchable::Gt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$gt" => 10)).to be false
+        expect(matcher._matches?("$gt" => 10)).to be false
       end
     end
 
@@ -44,7 +44,7 @@ describe Mongoid::Matchable::Gt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$gt" => 5)).to be false
+        expect(matcher._matches?("$gt" => 5)).to be false
       end
     end
 
@@ -56,7 +56,7 @@ describe Mongoid::Matchable::Gt do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$gt" => 5)).to be true
+          expect(matcher._matches?("$gt" => 5)).to be true
         end
       end
 
@@ -67,9 +67,20 @@ describe Mongoid::Matchable::Gt do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$gt" => 5)).to be false
+          expect(matcher._matches?("$gt" => 5)).to be false
         end
       end
     end
+
+    context "when the value is not numeric" do
+
+      let(:matcher) do
+        described_class.new(5)
+      end
+
+      it "returns false" do
+        expect(matcher._matches?("$gt" => '4.9')).to be false
+      end
+    end
   end
 end

data/spec/mongoid/matchable/gte_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Gte do
 
-  describe "#matches?" do
+  describe "#_matches?" do
 
     context "when the value is larger" do
 
@@ -11,7 +11,7 @@ describe Mongoid::Matchable::Gte do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$gte" => 3)).to be true
+        expect(matcher._matches?("$gte" => 3)).to be true
       end
     end
 
@@ -22,7 +22,7 @@ describe Mongoid::Matchable::Gte do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$gte" => 10)).to be false
+        expect(matcher._matches?("$gte" => 10)).to be false
       end
     end
 
@@ -33,7 +33,7 @@ describe Mongoid::Matchable::Gte do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$gte" => 5)).to be true
+        expect(matcher._matches?("$gte" => 5)).to be true
       end
     end
 
@@ -44,7 +44,7 @@ describe Mongoid::Matchable::Gte do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$gte" => 5)).to be false
+        expect(matcher._matches?("$gte" => 5)).to be false
       end
     end
 
@@ -55,7 +55,7 @@ describe Mongoid::Matchable::Gte do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$gte" => 5)).to be true
+          expect(matcher._matches?("$gte" => 5)).to be true
         end
       end
 
@@ -65,9 +65,19 @@ describe Mongoid::Matchable::Gte do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$gte" => 5)).to be false
+          expect(matcher._matches?("$gte" => 5)).to be false
         end
+      end
+    end
+
+    context "when the value is not numeric" do
+
+      let(:matcher) do
+        described_class.new(5)
+      end
 
+      it "returns false" do
+        expect(matcher._matches?("$gte" => '4.9')).to be false
       end
     end
   end

data/spec/mongoid/matchable/in_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::In do
 
-  describe "#matches?" do
+  describe "#_matches\?" do
 
     context 'when the attribute is not nil' do
 
@@ -13,14 +13,14 @@ describe Mongoid::Matchable::In do
       context "when the values include the attribute" do
 
         it "returns true" do
-          expect(matcher.matches?("$in" => [/\Afir.*\z/, "second"])).to be true
+          expect(matcher._matches?("$in" => [/\Afir.*\z/, "second"])).to be true
         end
       end
 
       context "when the values don't include the attribute" do
 
         it "returns false" do
-          expect(matcher.matches?("$in" => ["third"])).to be false
+          expect(matcher._matches?("$in" => ["third"])).to be false
         end
       end
     end
@@ -34,14 +34,14 @@ describe Mongoid::Matchable::In do
       context "when the values include the attribute" do
 
         it "returns true" do
-          expect(matcher.matches?("$in" => [/\Afir.*\z/, nil])).to be true
+          expect(matcher._matches?("$in" => [/\Afir.*\z/, nil])).to be true
         end
       end
 
       context "when the values don't include the attribute" do
 
         it "returns false" do
-          expect(matcher.matches?("$in" => ["third"])).to be false
+          expect(matcher._matches?("$in" => ["third"])).to be false
         end
       end
     end

data/spec/mongoid/matchable/lt_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Lt do
 
-  describe "#matches?" do
+  describe "#_matches\?" do
 
     context "when the value is larger" do
 
@@ -11,7 +11,7 @@ describe Mongoid::Matchable::Lt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$lt" => 3)).to be false
+        expect(matcher._matches?("$lt" => 3)).to be false
       end
     end
 
@@ -22,7 +22,7 @@ describe Mongoid::Matchable::Lt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$lt" => 3)).to be false
+        expect(matcher._matches?("$lt" => 3)).to be false
       end
     end
 
@@ -33,7 +33,7 @@ describe Mongoid::Matchable::Lt do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$lt" => 10)).to be true
+        expect(matcher._matches?("$lt" => 10)).to be true
       end
     end
 
@@ -44,7 +44,7 @@ describe Mongoid::Matchable::Lt do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$lt" => 5)).to be false
+        expect(matcher._matches?("$lt" => 5)).to be false
       end
     end
 
@@ -55,7 +55,7 @@ describe Mongoid::Matchable::Lt do
         end
 
         it "returns true" do
-          expect(matcher.matches?("$lt" => 5)).to be true
+          expect(matcher._matches?("$lt" => 5)).to be true
         end
       end
 
@@ -65,10 +65,21 @@ describe Mongoid::Matchable::Lt do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$lt" => 5)).to be false
+          expect(matcher._matches?("$lt" => 5)).to be false
         end
 
       end
     end
+
+    context "when the value is not numeric" do
+
+      let(:matcher) do
+        described_class.new(5)
+      end
+
+      it "returns false" do
+        expect(matcher._matches?("$lt" => '5.1')).to be false
+      end
+    end
   end
 end

data/spec/mongoid/matchable/lte_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Lte do
 
-  describe "#matches?" do
+  describe "#_matches\?" do
 
     context "when the value is larger" do
 
@@ -11,7 +11,7 @@ describe Mongoid::Matchable::Lte do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$lte" => 3)).to be false
+        expect(matcher._matches?("$lte" => 3)).to be false
       end
     end
 
@@ -22,7 +22,7 @@ describe Mongoid::Matchable::Lte do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$lte" => 10)).to be true
+        expect(matcher._matches?("$lte" => 10)).to be true
       end
     end
 
@@ -33,7 +33,7 @@ describe Mongoid::Matchable::Lte do
       end
 
       it "returns true" do
-        expect(matcher.matches?("$lte" => 5)).to be true
+        expect(matcher._matches?("$lte" => 5)).to be true
       end
     end
 
@@ -44,18 +44,19 @@ describe Mongoid::Matchable::Lte do
       end
 
       it "returns false" do
-        expect(matcher.matches?("$lte" => 5)).to be false
+        expect(matcher._matches?("$lte" => 5)).to be false
       end
     end
 
     context "when the value is an array" do
+
       context "there are value valid" do
         let(:matcher) do
           described_class.new([3, 4])
         end
 
         it "returns true" do
-          expect(matcher.matches?("$lte" => 5)).to be true
+          expect(matcher._matches?("$lte" => 5)).to be true
         end
       end
 
@@ -65,9 +66,19 @@ describe Mongoid::Matchable::Lte do
         end
 
         it "returns false" do
-          expect(matcher.matches?("$lte" => 5)).to be false
+          expect(matcher._matches?("$lte" => 5)).to be false
         end
+      end
+    end
 
+    context "when the value is not numeric" do
+
+      let(:matcher) do
+        described_class.new(5)
+      end
+
+      it "returns false" do
+        expect(matcher._matches?("$lte" => '5.1')).to be false
       end
     end
   end

data/spec/mongoid/matchable/ne_spec.rb

@@ -6,19 +6,19 @@ describe Mongoid::Matchable::Ne do
     described_class.new("first")
   end
 
-  describe "#matches?" do
+  describe "#_matches?" do
 
     context "when the values are not equal" do
 
       it "returns true" do
-        expect(matcher.matches?("$ne" => "second")).to be true
+        expect(matcher._matches?("$ne" => "second")).to be true
       end
     end
 
     context "when the values are equal" do
 
       it "returns false" do
-        expect(matcher.matches?("$ne" => "first")).to be false
+        expect(matcher._matches?("$ne" => "first")).to be false
       end
     end
 
@@ -31,14 +31,14 @@ describe Mongoid::Matchable::Ne do
       context "when the value is in the array" do
 
         it "returns false" do
-          expect(array_matcher.matches?("$ne" => "first")).to be false
+          expect(array_matcher._matches?("$ne" => "first")).to be false
         end
       end
 
       context "when the value is not in the array" do
 
         it "returns true" do
-          expect(array_matcher.matches?("$ne" => "second")).to be true
+          expect(array_matcher._matches?("$ne" => "second")).to be true
         end
       end
     end

data/spec/mongoid/matchable/nin_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Mongoid::Matchable::Nin do
 
-  describe "#matches?" do
+  describe "#_matches?" do
 
     context 'when the attribute is not nil' do
 
@@ -13,14 +13,14 @@ describe Mongoid::Matchable::Nin do
       context "when the values do not contain the attribute" do
 
         it "returns true" do
-          expect(matcher.matches?("$nin" => ["second", "third"])).to be true
+          expect(matcher._matches?("$nin" => ["second", "third"])).to be true
         end
       end
 
       context "when the values contain the attribute" do
 
         it "returns false" do
-          expect(matcher.matches?("$nin" => ["first"])).to be false
+          expect(matcher._matches?("$nin" => ["first"])).to be false
         end
       end
     end
@@ -33,14 +33,14 @@ describe Mongoid::Matchable::Nin do
       context "when the values do not contain the attribute" do
 
         it "returns true" do
-          expect(matcher.matches?("$nin" => ["third"])).to be true
+          expect(matcher._matches?("$nin" => ["third"])).to be true
         end
       end
 
       context "when the values contain the attribute" do
 
         it "returns false" do
-          expect(matcher.matches?("$nin" => [/\Afir.*\z/, nil])).to be false
+          expect(matcher._matches?("$nin" => [/\Afir.*\z/, nil])).to be false
         end
       end
     end