mongoid 5.2.1 → 5.4.0

data/lib/mongoid/relations/embedded/many.rb

@@ -19,7 +19,8 @@ module Mongoid
         # @example Push a document.
         #   person.addresses.push(address)
         #
-        # @param [ Document, Array<Document> ] *args Any number of documents.
+        # @param [ Document, Array<Document> ] args Any number of documents.
+        #
         def <<(*args)
           docs = args.flatten
           return concat(docs) if docs.size > 1
@@ -59,7 +60,7 @@ module Mongoid
         #
         # @since 2.4.0
         def concat(docs)
-          batch_insert(docs) unless docs.empty?
+          batch_push(docs) unless docs.empty?
           self
         end
 
@@ -337,8 +338,6 @@ module Mongoid
         # @example Create the binding.
         #   relation.binding([ address ])
         #
-        # @param [ Array<Document> ] new_target The new documents to bind with.
-        #
         # @return [ Binding ] The many binding.
         #
         # @since 2.0.0.rc.1
@@ -461,7 +460,7 @@ module Mongoid
         #   relation.remove_all({ :num => 1 }, true)
         #
         # @param [ Hash ] conditions Conditions to filter by.
-        # @param [ true, false ] destroy If true then destroy, else delete.
+        # @param [ true, false ] method
         #
         # @return [ Integer ] The number of documents removed.
         def remove_all(conditions = {}, method = :delete)

data/lib/mongoid/relations/embedded/one.rb

@@ -31,7 +31,7 @@ module Mongoid
         # @example Substitute the new document.
         #   person.name.substitute(new_name)
         #
-        # @param [ Document ] other A document to replace the target.
+        # @param [ Document ] replacement A document to replace the target.
         #
         # @return [ Document, nil ] The relation or nil.
         #
@@ -61,8 +61,6 @@ module Mongoid
         # @example Get the binding.
         #   relation.binding([ address ])
         #
-        # @param [ Document ] new_target The new document to bind with.
-        #
         # @return [ Binding ] The relation's binding.
         #
         # @since 2.0.0.rc.1

data/lib/mongoid/relations/macros.rb

@@ -326,7 +326,8 @@ module Mongoid
         #   Model.reference_one_to_one(:name, meta)
         #
         # @param [ Symbol ] name The name of the relation.
-        # @param [ Metadata ] meta The relation metadata.
+        # @param [ Symbol ] options The association options.
+        # @param [ Metadata ] relation The relation.
         #
         # @return [ Class ] The model class.
         #

data/lib/mongoid/relations/metadata.rb

@@ -920,7 +920,7 @@ module Mongoid
       # @example Find the module from the parts.
       #   metadata.find_from_parts([ "Namespace", "Module" ])
       #
-      # @param [ Array<String> ] The modules.
+      # @param [ Array<String> ] modules The modules.
       #
       # @return [ String ] The matching module.
       #
@@ -1127,7 +1127,7 @@ module Mongoid
       # @example Find the inverses.
       #   metadata.lookup_inverses(other)
       #
-      # @param [ Document ] : The inverse document.
+      # @param [ Document ] other The inverse document.
       #
       # @return [ Array<String> ] The inverse names.
       def lookup_inverses(other)
@@ -1150,7 +1150,7 @@ module Mongoid
       # @example Find the inverse.
       #   metadata.lookup_inverse(other)
       #
-      # @param [ Document ] : The inverse document.
+      # @param [ Document ] other The inverse document.
       #
       # @return [ String ] The inverse name.
       #

data/lib/mongoid/relations/nested_builder.rb

@@ -25,7 +25,7 @@ module Mongoid
       # @example Is there a reject proc?
       #   builder.reject?
       #
-      # @param The parent document of the relation
+      # @param [ Document ] document The parent document of the relation
       # @param [ Hash ] attrs The attributes to check for rejection.
       #
       # @return [ true, false ] True and call proc or method if rejectable, false if not.

data/lib/mongoid/relations/proxy.rb

@@ -145,7 +145,8 @@ module Mongoid
       # to the target of the proxy. This can be overridden in special cases.
       #
       # @param [ String, Symbol ] name The name of the method.
-      # @param [ Array ] *args The arguments passed to the method.
+      # @param [ Array ] args The arguments passed to the method.
+      #
       def method_missing(name, *args, &block)
         target.send(name, *args, &block)
       end
@@ -183,7 +184,7 @@ module Mongoid
       # @example returns the before_add callback method name
       #   callback_method(:before_add)
       #
-      # @param [ Symbol ] which callback
+      # @param [ Symbol ] callback_name Which callback
       #
       # @return [ Array ] with callback methods to be executed, the array may have symbols and Procs
       #

data/lib/mongoid/relations/referenced/in.rb

@@ -44,8 +44,7 @@ module Mongoid
         # @example Substitute the relation.
         #   name.substitute(new_name)
         #
-        # @param [ Document, Array<Document> ] new_target The replacement.
-        # @param [ true, false ] building Are we in build mode?
+        # @param [ Document, Array<Document> ] replacement The replacement.
         #
         # @return [ In, nil ] The relation or nil.
         #
@@ -65,8 +64,6 @@ module Mongoid
         # @example Get the binding object.
         #   binding([ address ])
         #
-        # @param [ Document, Array<Document> ] new_target The replacement.
-        #
         # @return [ Binding ] The binding object.
         #
         # @since 2.0.0.rc.1

data/lib/mongoid/relations/referenced/many.rb

@@ -22,7 +22,7 @@ module Mongoid
         # @example Concat with other documents.
         #   person.posts.concat([ post_one, post_two ])
         #
-        # @param [ Document, Array<Document> ] *args Any number of documents.
+        # @param [ Document, Array<Document> ] args Any number of documents.
         #
         # @return [ Array<Document> ] The loaded docs.
         #
@@ -190,7 +190,7 @@ module Mongoid
         # @note This will keep matching documents in memory for iteration
         #   later.
         #
-        # @param [ BSON::ObjectId, Array<BSON::ObjectId> ] arg The ids.
+        # @param [ BSON::ObjectId, Array<BSON::ObjectId> ] args The ids.
         #
         # @return [ Document, Criteria ] The matching document(s).
         #
@@ -368,8 +368,6 @@ module Mongoid
         # @example Get the binding.
         #   relation.binding([ address ])
         #
-        # @param [ Array<Document> ] new_target The new documents to bind with.
-        #
         # @return [ Binding ] The binding.
         #
         # @since 2.0.0.rc.1
@@ -493,7 +491,7 @@ module Mongoid
         #   person.posts.delete_all({ :title => "Testing" })
         #
         # @param [ Hash ] conditions Optional conditions to delete with.
-        # @param [ Symbol ] The deletion method to call.
+        # @param [ Symbol ] method The deletion method to call.
         #
         # @return [ Integer ] The number of documents deleted.
         #

data/lib/mongoid/relations/referenced/many_to_many.rb

@@ -19,7 +19,7 @@ module Mongoid
         # @example Concat with other documents.
         #   person.posts.concat([ post_one, post_two ])
         #
-        # @param [ Document, Array<Document> ] *args Any number of documents.
+        # @param [ Document, Array<Document> ] args Any number of documents.
         #
         # @return [ Array<Document> ] The loaded docs.
         #

data/lib/mongoid/relations/referenced/one.rb

@@ -69,8 +69,6 @@ module Mongoid
         # @example Get the binding.
         #   relation.binding([ address ])
         #
-        # @param [ Document ] new_target The new target of the relation.
-        #
         # @return [ Binding ] The binding object.
         def binding
           Bindings::Referenced::One.new(base, target, __metadata)

data/lib/mongoid/relations/reflections.rb

@@ -24,7 +24,7 @@ module Mongoid
       # @example Find multiple relation metadata by macro.
       #   person.reflect_on_all_associations(:embeds_many)
       #
-      # @param [ Array<Symbol> ] *macros The relation macros.
+      # @param [ Array<Symbol> ] macros The relation macros.
       #
       # @return [ Array<Metadata> ] The matching relation metadata.
       def reflect_on_all_associations(*macros)
@@ -50,7 +50,7 @@ module Mongoid
         # @example Find multiple relation metadata by macro.
         #   Person.reflect_on_all_associations(:embeds_many)
         #
-        # @param [ Array<Symbol> ] *macros The relation macros.
+        # @param [ Array<Symbol> ] macros The relation macros.
         #
         # @return [ Array<Metadata> ] The matching relation metadata.
         def reflect_on_all_associations(*macros)

data/lib/mongoid/scopable.rb

@@ -80,7 +80,7 @@ module Mongoid
       #     default_scope ->{ where(active: true) }
       #   end
       #
-      # @param [ Proc, Criteria ] scope The default scope.
+      # @param [ Proc, Criteria ] value The default scope.
       #
       # @raise [ Errors::InvalidScope ] If the scope is not a proc or criteria.
       #
@@ -136,7 +136,7 @@ module Mongoid
       #   end
       #
       # @param [ Symbol ] name The name of the scope.
-      # @param [ Proc ] conditions The conditions of the scope.
+      # @param [ Proc ] value The conditions of the scope.
       #
       # @raise [ Errors::InvalidScope ] If the scope is not a proc.
       # @raise [ Errors::ScopeOverwrite ] If the scope name already exists.

data/lib/mongoid/serializable.rb

@@ -138,7 +138,7 @@ module Mongoid
     # @example Get the relation names.
     #   document.relation_names(:include => [ :addresses ])
     #
-    # @param [ Hash, Symbol, Array<Symbol ] inclusions The inclusions.
+    # @param [ Hash, Symbol, Array<Symbol> ] inclusions The inclusions.
     #
     # @return [ Array<Symbol> ] The names of the included relations.
     #
@@ -153,7 +153,8 @@ module Mongoid
     # @example Get the relation options.
     #   document.relation_names(:include => [ :addresses ])
     #
-    # @param [ Hash, Symbol, Array<Symbol ] inclusions The inclusions.
+    # @param [ Hash, Symbol, Array<Symbol> ] inclusions The inclusions.
+    # @param [ Hash ] options The options.
     # @param [ Symbol ] name The name of the relation.
     #
     # @return [ Hash ] The options for the relation.

data/lib/mongoid/tasks/database.rb

@@ -36,7 +36,8 @@ module Mongoid
       # @example Return the list of unused indexes.
       #   Mongoid::Tasks::Database.undefined_indexes
       #
-      # @return Hash{Class => Array(Hash)} The list of undefined indexes by model.
+      # @return [ Array<Hash> ] The list of undefined indexes by model.
+      #
       def undefined_indexes(models = ::Mongoid.models)
         undefined_by_model = {}
 

data/lib/mongoid/threaded.rb

@@ -64,7 +64,7 @@ module Mongoid
     # @example Set the global database override.
     #   Threaded.database_override = :testing
     #
-    # @param [ String, Symbol ] The global override name.
+    # @param [ String, Symbol ] name The global override name.
     #
     # @return [ String, Symbol ] The override.
     #
@@ -180,7 +180,7 @@ module Mongoid
     # @example Set the global client override.
     #   Threaded.client_override = :testing
     #
-    # @param [ String, Symbol ] The global override name.
+    # @param [ String, Symbol ] name The global override name.
     #
     # @return [ String, Symbol ] The override.
     #
@@ -304,7 +304,7 @@ module Mongoid
     # @example Get all autosaves.
     #   Threaded.autosaves_for(Person)
     #
-    # @param [ Class ] The class to check.
+    # @param [ Class ] klass The class to check.
     #
     # @return [ Array ] The current autosaves.
     #
@@ -317,7 +317,7 @@ module Mongoid
     # @example Get all validations.
     #   Threaded.validations_for(Person)
     #
-    # @param [ Class ] The class to check.
+    # @param [ Class ] klass The class to check.
     #
     # @return [ Array ] The current validations.
     #

data/lib/mongoid/validatable.rb

@@ -144,7 +144,7 @@ module Mongoid
       # @example Validate with a specific validator.
       #   validates_with MyValidator, on: :create
       #
-      # @param [ Class<Array>, Hash ] *args The validator classes and options.
+      # @param [ Class<Array>, Hash ] args The validator classes and options.
       #
       # @note See ActiveModel::Validations::With for full options. This is
       #   overridden to add autosave functionality when presence validation is

data/lib/mongoid/validatable/macros.rb

@@ -17,7 +17,8 @@ module Mongoid
       #     validates_associated :name, :addresses
       #   end
       #
-      # @param [ Array ] *args The arguments to pass to the validator.
+      # @param [ Array ] args The arguments to pass to the validator.
+      #
       def validates_associated(*args)
         validates_with(AssociatedValidator, _merge_attributes(args))
       end
@@ -34,7 +35,8 @@ module Mongoid
       #     validates_uniqueness_of :title
       #   end
       #
-      # @param [ Array ] *args The arguments to pass to the validator.
+      # @param [ Array ] args The arguments to pass to the validator.
+      #
       def validates_uniqueness_of(*args)
         validates_with(UniquenessValidator, _merge_attributes(args))
       end

data/lib/mongoid/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Mongoid
-  VERSION = "5.2.1"
+  VERSION = "5.4.0"
 end

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -211,10 +211,10 @@ describe Mongoid::Atomic::Modifiers do
 
         it "adds the push all modifiers" do
           expect(modifiers).to eq(
-            { "$pushAll" =>
-              { "addresses" => [
+            { "$push" =>
+              { "addresses" => { '$each' => [
                   { "street" => "Oxford St" }
-                ]
+                ] }
               }
             }
           )
@@ -238,11 +238,11 @@ describe Mongoid::Atomic::Modifiers do
 
         it "adds the push all modifiers" do
           expect(modifiers).to eq(
-            { "$pushAll" =>
-              { "addresses" => [
+            { "$push" =>
+              { "addresses" => { '$each' => [
                   { "street" => "Hobrechtstr." },
                   { "street" => "Pflugerstr." }
-                ]
+                ] }
               }
             }
           )
@@ -270,10 +270,10 @@ describe Mongoid::Atomic::Modifiers do
         it "adds the push all modifiers to the conflicts hash" do
           expect(modifiers).to eq(
             { "$set" => { "addresses.0.street" => "Bond" },
-              conflicts: { "$pushAll" =>
-                { "addresses" => [
+              conflicts: { "$push" =>
+                { "addresses" => { '$each' => [
                     { "street" => "Oxford St" }
-                  ]
+                  ] }
                 }
               }
             }
@@ -300,10 +300,10 @@ describe Mongoid::Atomic::Modifiers do
           expect(modifiers).to eq(
             { "$pullAll" => {
               "addresses" => { "street" => "Bond St" }},
-              conflicts: { "$pushAll" =>
-                { "addresses" => [
+              conflicts: { "$push" => 
+                { "addresses" => { '$each' => [
                     { "street" => "Oxford St" }
-                  ]
+                  ] }
                 }
               }
             }
@@ -328,12 +328,12 @@ describe Mongoid::Atomic::Modifiers do
 
         it "adds the push all modifiers to the conflicts hash" do
           expect(modifiers).to eq(
-            { "$pushAll" => {
-              "addresses.0.locations" => [{ "street" => "Bond St" }]},
-              conflicts: { "$pushAll" =>
-                { "addresses" => [
+            { "$push" => {
+              "addresses.0.locations" => {'$each' => [{ "street" => "Bond St" }]}},
+              conflicts: { "$push" =>
+                { "addresses" => { '$each' => [
                     { "street" => "Oxford St" }
-                  ]
+                  ] }
                 }
               }
             }

data/spec/mongoid/atomic_spec.rb

@@ -76,13 +76,13 @@ describe Mongoid::Atomic do
             person.addresses.build(street: "Oxford St")
           end
 
-          it "returns a $set and $pushAll for modifications" do
+          it "returns a $set and $push and $each for modifications" do
             expect(person.atomic_updates).to eq(
               {
                 "$set" => { "title" => "Sir" },
-                "$pushAll" => { "addresses" => [
+                "$push" => { "addresses" => {'$each' => [
                     { "_id" => "oxford-st", "street" => "Oxford St" }
-                  ]}
+                  ] } }
               }
             )
           end
@@ -197,8 +197,8 @@ describe Mongoid::Atomic do
                       "addresses.0.street" => "Bond St"
                     },
                     conflicts: {
-                      "$pushAll" => {
-                        "addresses.0.locations" => [{ "_id" => location.id, "name" => "Home" }]
+                      "$push" => {
+                        "addresses.0.locations" => { '$each' => [{ "_id" => location.id, "name" => "Home" }] }
                       }
                     }
                   }
@@ -215,8 +215,8 @@ describe Mongoid::Atomic do
                       "addresses.0.street" => "Bond St"
                     },
                     conflicts: {
-                      "$pushAll" => {
-                        "addresses.0.locations" => [{ "_id" => location.id, "name" => "Home" }]
+                      "$push" => {
+                        "addresses.0.locations" => { '$each' => [{ "_id" => location.id, "name" => "Home" }] }
                       }
                     }
                   }
@@ -263,15 +263,15 @@ describe Mongoid::Atomic do
                       "addresses.0.street" => "Bond St"
                     },
                     conflicts: {
-                      "$pushAll" => {
-                        "addresses" => [{
+                      "$push" => {
+                        "addresses" => { '$each' => [{
                           "_id" => new_address.id,
                           "street" => "Another",
                           "locations" => [
                             "_id" => location.id,
                             "name" => "Home"
                           ]
-                        }]
+                        }] }
                       }
                     }
                   }
@@ -310,15 +310,15 @@ describe Mongoid::Atomic do
                   "$set" => {
                     "title" => "Sir"
                   },
-                  "$pushAll" => {
-                    "addresses" => [{
+                  "$push" => {
+                    "addresses" => { '$each' => [{
                       "_id" => new_address.id,
                       "street" => "Ipanema",
                       "locations" => [
                         "_id" => location.id,
                         "name" => "Home"
                       ]
-                    }]
+                    }] }
                   },
                   conflicts: {
                     "$set" => { "addresses.0.street"=>"Bond St" }
@@ -339,21 +339,21 @@ describe Mongoid::Atomic do
             address.locations.build(name: "Home")
           end
 
-          it "returns the proper $sets and $pushAlls for all levels" do
+          it "returns the proper $sets and $pushs and $eaches for all levels" do
             expect(person.atomic_updates).to eq(
               {
                 "$set" => {
                   "title" => "Sir",
                 },
-                "$pushAll" => {
-                  "addresses" => [{
+                "$push" => {
+                  "addresses" => { "$each" => [{
                     "_id" => address.id,
                     "street" => "Another",
                     "locations" => [
                       "_id" => location.id,
                       "name" => "Home"
                     ]
-                  }]
+                  }] }
                 }
               }
             )