mongoid 5.0.1 → 5.0.2

data/lib/mongoid/tasks/database.rb

@@ -47,7 +47,7 @@ module Mongoid
                 # ignore default index
                 unless index['name'] == '_id_'
                   key = index['key'].symbolize_keys
-                  spec = model.index_specification(key)
+                  spec = model.index_specification(key, index['name'])
                   unless spec
                     # index not specified
                     undefined_by_model[model] ||= []

data/lib/mongoid/threaded.rb

@@ -31,7 +31,6 @@ module Mongoid
       hash[key] = "[mongoid]:#{key}-stack"
     end
 
-    extend Gem::Deprecate
     extend self
 
     # Begin entry into a named thread local stack.
@@ -175,8 +174,6 @@ module Mongoid
     def client_override
       Thread.current[CLIENT_OVERRIDE_KEY]
     end
-    alias :session_override :client_override
-    deprecate :session_override, :client_override, 2015, 12
 
     # Set the global client override.
     #
@@ -191,8 +188,6 @@ module Mongoid
     def client_override=(name)
       Thread.current[CLIENT_OVERRIDE_KEY] = name
     end
-    alias :session_override= :client_override=
-    deprecate :session_override=, :client_override=, 2015, 12
 
     # Get the current Mongoid scope.
     #

data/lib/mongoid/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Mongoid
-  VERSION = "5.0.1"
+  VERSION = "5.0.2"
 end

data/spec/app/models/bomb.rb

@@ -0,0 +1,4 @@
+class Bomb
+  include Mongoid::Document
+  has_one :explosion, dependent: :delete, autobuild: true
+end

data/spec/app/models/building.rb

@@ -1,5 +1,6 @@
 class Building
   include Mongoid::Document
-  embeds_one :building_address
+
+  embeds_one :building_address, validate: false
   embeds_many :contractors
 end

data/spec/app/models/building_address.rb

@@ -1,5 +1,7 @@
 class BuildingAddress
   include Mongoid::Document
-  embedded_in :building
   field :city, type: String
+
+  embedded_in :building
+  validates_presence_of :city
 end

data/spec/app/models/courier_job.rb

@@ -0,0 +1,4 @@
+class CourierJob
+  include Mongoid::Document
+  embeds_one :drop_address, as: :addressable, autobuild: true, class_name: "ShipmentAddress"
+end

data/spec/app/models/explosion.rb

@@ -0,0 +1,4 @@
+class Explosion
+  include Mongoid::Document
+  belongs_to :bomb
+end

data/spec/app/models/message.rb

@@ -2,7 +2,10 @@ class Message
   include Mongoid::Document
 
   field :body, type: String
+  field :priority, type: Integer
 
   embedded_in :person
   has_and_belongs_to_many :receviers, class_name: "Person", inverse_of: nil
+
+  has_one :post, as: :posteable
 end

data/spec/app/models/name.rb

@@ -14,6 +14,7 @@ class Name
   embeds_many :translations, validate: false
   embeds_one :language, as: :translatable, validate: false
   embedded_in :namable, polymorphic: true
+  embedded_in :person
 
   accepts_nested_attributes_for :language
 

data/spec/app/models/post.rb

@@ -15,6 +15,9 @@ class Post
   has_many :videos, validate: false
   has_many :roles, validate: false
 
+  belongs_to :posteable, polymorphic: true
+  accepts_nested_attributes_for :posteable, autosave: true
+
   scope :recent, ->{ where(created_at: { "$lt" => Time.now, "$gt" => 30.days.ago }) }
   scope :posting, ->{ where(:content.in => [ "Posting" ]) }
   scope :open, ->{ where(title: "open") }

data/spec/app/models/sandwich.rb

@@ -1,4 +1,9 @@
 class Sandwich
   include Mongoid::Document
   has_and_belongs_to_many :meats
+
+  field :name, type: String
+
+  belongs_to :posteable, polymorphic: true
+  accepts_nested_attributes_for :posteable, autosave: true
 end

data/spec/app/models/shipment_address.rb

@@ -0,0 +1,2 @@
+class ShipmentAddress < Address
+end

data/spec/mongoid/attributes/nested_spec.rb

@@ -102,6 +102,19 @@ describe Mongoid::Attributes::Nested do
       end
     end
 
+    context "when the association is referenced in and polymorphic" do
+
+      it "infers the class name of the polymorphic with the inverse type" do
+        expect {
+          Post.create!(
+            title: "Some title",
+            posteable_type: "Sandwich",
+            posteable_attributes: { name: 'Grilled Cheese' }
+          )
+        }.not_to raise_error
+      end
+    end
+
     context "when the relation is an embedded in" do
 
       before do
@@ -4788,38 +4801,84 @@ describe Mongoid::Attributes::Nested do
         league.divisions.create(name: "Old Name")
       end
 
-      let(:params) do
-        { divisions_attributes:
-          { "0" => { id: division.id.to_s, name: "New Name" }}
-        }
-      end
+      context "when additional validation is set" do
 
-      before do
-        league.update_attributes(params)
-      end
+        before do
+          League.validates_presence_of(:divisions)
+        end
 
-      it "sets the nested attributes" do
-        expect(league.reload.divisions.first.name).to eq("New Name")
-      end
+        after do
+          League.reset_callbacks(:validate)
+        end
 
-      context "with corrupted data" do
+        context "when validation fails" do
 
-        before do
-          league[:league] = params
+          let(:division) do
+            Division.new
+          end
+
+          let(:league) do
+            League.create!(divisions: [division])
+          end
+
+          let(:error_raising_update) do
+            league.update!(:divisions => nil)
+          end
+
+          before do
+            league.update(:divisions => nil)
+            league.reload
+          end
+
+          it "the update raises an error" do
+            expect{ error_raising_update }.to raise_error
+          end
+
+          it "the update does not occur" do
+            expect(league.divisions.first).to eq(division)
+          end
+
+          it "the document is inaccurately marked destroyed (you fixed the bug if you broke this!)" do
+            expect(division).to be_destroyed
+          end
         end
+      end
 
-        let(:new_params) do
+      context "when no additional validation is set" do
+
+        let(:params) do
           { divisions_attributes:
-            { "0" => { id: division.id.to_s, name: "Name" }}
+            { "0" => { id: division.id.to_s, name: "New Name" }}
           }
         end
 
         before do
-          league.update_attributes(new_params)
+          league.update_attributes(params)
         end
 
         it "sets the nested attributes" do
-          expect(league.reload.divisions.first.name).to eq("Name")
+          expect(league.reload.divisions.first.name).to eq("New Name")
+        end
+
+        context "with corrupted data" do
+
+          before do
+            league[:league] = params
+          end
+
+          let(:new_params) do
+            { divisions_attributes:
+              { "0" => { id: division.id.to_s, name: "Name" }}
+            }
+          end
+
+          before do
+            league.update_attributes(new_params)
+          end
+
+          it "sets the nested attributes" do
+            expect(league.reload.divisions.first.name).to eq("Name")
+          end
         end
       end
     end

data/spec/mongoid/attributes_spec.rb

@@ -1207,6 +1207,19 @@ describe Mongoid::Attributes do
         }.to raise_error(Mongoid::Errors::InvalidValue)
       end
     end
+
+    context "when attribute is localized and #attributes is a BSON::Document" do
+      let(:dictionary) { Dictionary.new }
+
+      before do
+        allow(dictionary).to receive(:attributes).and_return(BSON::Document.new)
+      end
+
+      it "sets the value for the current locale" do
+        dictionary.write_attribute(:description, 'foo')
+        expect(dictionary.description).to eq('foo')
+      end
+    end
   end
 
   describe "#typed_value_for" do

data/spec/mongoid/criteria_spec.rb

@@ -3254,6 +3254,25 @@ describe Mongoid::Criteria do
           expect(criteria.selector).to eq({ "agent_ids" => [ id_one, id_two ]})
         end
       end
+
+      context "when querying on a big decimal" do
+
+        let(:sales) do
+          BigDecimal.new('0.1')
+        end
+
+        let!(:band) do
+          Band.create(name: "Boards of Canada", sales: sales)
+        end
+
+        let(:from_db) do
+          Band.where(sales: sales).first
+        end
+
+        it "finds the document by the big decimal value" do
+          expect(from_db).to eq(band)
+        end
+      end
     end
   end
 
@@ -3468,4 +3487,37 @@ describe Mongoid::Criteria do
       end
     end
   end
+
+  describe "#type_selection" do
+
+    context "when only one subclass exists" do
+
+      let(:criteria) do
+        described_class.new(Firefox)
+      end
+
+      let(:selection) do
+        criteria.send(:type_selection)
+      end
+
+      it "does not use an $in query" do
+        expect(selection).to eq({ _type: "Firefox" })
+      end
+    end
+
+    context "when more than one subclass exists" do
+
+      let(:criteria) do
+        described_class.new(Browser)
+      end
+
+      let(:selection) do
+        criteria.send(:type_selection)
+      end
+
+      it "does not use an $in query" do
+        expect(selection).to eq({ _type: { "$in" => [ "Firefox", "Browser" ]}})
+      end
+    end
+  end
 end

data/spec/mongoid/document_spec.rb

@@ -613,25 +613,49 @@ describe Mongoid::Document do
       Person.new
     end
 
-    context "when not frozen" do
+    context "when freezing the model" do
 
-      it "freezes attributes" do
-        expect(person.freeze).to eq(person)
-        expect { person.title = "something" }.to raise_error
+      context "when not frozen" do
+
+        it "freezes attributes" do
+          expect(person.freeze).to eq(person)
+          expect { person.title = "something" }.to raise_error
+        end
       end
-    end
 
-    context "when frozen" do
+      context "when frozen" do
 
-      before do
-        person.raw_attributes.freeze
+        before do
+          person.raw_attributes.freeze
+        end
+
+        it "keeps things frozen" do
+          person.freeze
+          expect {
+            person.title = "something"
+          }.to raise_error
+        end
       end
+    end
 
-      it "keeps things frozen" do
-        person.freeze
-        expect {
-          person.title = "something"
-        }.to raise_error
+    context "when freezing attributes of the model" do
+
+      context "when assigning a frozen value" do
+
+        context "when the frozen value is a hash" do
+
+          let(:hash) do
+            {"foo" => {"bar" => {"baz" => [1,2,3]}}}
+          end
+
+          let(:assign_hash) do
+            person.map = hash.freeze
+          end
+
+          it "no mutation occurs during assignment" do
+            expect{ assign_hash }.not_to raise_error
+          end
+        end
       end
     end
   end

data/spec/mongoid/indexable/specification_spec.rb

@@ -99,4 +99,29 @@ describe Mongoid::Indexable::Specification do
       expect(spec.options).to eq(background: true, drop_dups: true)
     end
   end
+
+  describe '#name' do
+
+    context 'when there is only one field' do
+
+      let(:spec) do
+        described_class.new(Band, { name: 1 })
+      end
+
+      it 'returns the key and direction separated by an underscore' do
+        expect(spec.name).to eq('name_1')
+      end
+    end
+
+    context 'when there are two fields' do
+
+      let(:spec) do
+        described_class.new(Band, { name: 1, title: -1 })
+      end
+
+      it 'returns the keys and directions separated by underscores' do
+        expect(spec.name).to eq('name_1_title_-1')
+      end
+    end
+  end
 end

data/spec/mongoid/persistable_spec.rb

@@ -203,4 +203,21 @@ describe Mongoid::Persistable do
       }.to raise_error(Mongoid::Errors::Callback)
     end
   end
+
+  example "able use set value using dot notation" do
+    class Customer
+      include Mongoid::Document
+
+      field :address, type: Hash, default: -> {{}}
+    end
+
+    customer = Customer.new 
+    customer.save
+    customer.set 'address.country' => 'India'
+    expect(customer.address).to eql({ 'country' => 'India' })
+    customer.set 'address.country.state' => 'MH'
+    expect(customer.address).to eql({'country' => { 'state' => 'MH' }})
+    customer.set 'address' => { 'country' => 'India'}
+    expect(customer.address).to eql({ 'country' => 'India' })
+  end
 end