mongoid 4.0.2 → 5.0.0

data/spec/mongoid/errors/{no_session_database_spec.rb → no_client_database_spec.rb}

@@ -1,22 +1,22 @@
 require "spec_helper"
 
-describe Mongoid::Errors::NoSessionDatabase do
+describe Mongoid::Errors::NoClientDatabase do
 
   describe "#message" do
 
     let(:error) do
-      described_class.new(:secondary, { hosts: [ "localhost:27017" ] })
+      described_class.new(:secondary, { hosts: [ "127.0.0.1:27017" ] })
     end
 
     it "contains the problem in the message" do
       expect(error.message).to include(
-        "No database provided for session configuration: :secondary."
+        "No database provided for client configuration: :secondary."
       )
     end
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-        "Each session configuration must provide a database so Mongoid"
+        "Each client configuration must provide a database so Mongoid"
       )
     end
 

data/spec/mongoid/errors/{no_session_hosts_spec.rb → no_client_hosts_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Errors::NoSessionHosts do
+describe Mongoid::Errors::NoClientHosts do
 
   describe "#message" do
 
@@ -10,13 +10,13 @@ describe Mongoid::Errors::NoSessionHosts do
 
     it "contains the problem in the message" do
       expect(error.message).to include(
-        "No hosts provided for session configuration: :secondary."
+        "No hosts provided for client configuration: :secondary."
       )
     end
 
     it "contains the summary in the message" do
       expect(error.message).to include(
-        "Each session configuration must provide hosts so Mongoid"
+        "Each client configuration must provide hosts so Mongoid"
       )
     end
 

data/spec/mongoid/errors/{no_sessions_config_spec.rb → no_clients_config_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Errors::NoSessionsConfig do
+describe Mongoid::Errors::NoClientsConfig do
 
   describe "#message" do
 
@@ -10,7 +10,7 @@ describe Mongoid::Errors::NoSessionsConfig do
 
     it "contains the problem in the message" do
       expect(error.message).to include(
-        "No sessions configuration provided."
+        "No clients configuration provided."
       )
     end
 

data/spec/mongoid/fields/localized_spec.rb

@@ -81,6 +81,7 @@ describe Mongoid::Fields::Localized do
       context "when a locale is provided" do
 
         before do
+          I18n.enforce_available_locales = false
           ::I18n.locale = :de
         end
 

data/spec/mongoid/fields_spec.rb

@@ -18,6 +18,7 @@ describe Mongoid::Fields do
 
         before do
           product.description = "test"
+          I18n.enforce_available_locales = false
           ::I18n.locale = :de
           product.description = "The best"
         end

data/spec/mongoid/findable_spec.rb

@@ -40,14 +40,14 @@ describe Mongoid::Findable do
     end
   end
 
-  describe ".find_and_modify" do
+  describe ".find_one_and_update" do
 
     let!(:person) do
       Person.create(title: "Senior")
     end
 
     it "returns the document" do
-      expect(Person.find_and_modify(title: "Junior")).to eq(person)
+      expect(Person.find_one_and_update(title: "Junior")).to eq(person)
     end
   end
 
@@ -485,25 +485,4 @@ describe Mongoid::Findable do
       end
     end
   end
-
-  describe "#text_search" do
-
-    before do
-      Word.with(database: "admin").mongo_session.command(setParameter: 1, textSearchEnabled: true)
-      Word.create_indexes
-      Word.create!(name: "phase", origin: "latin")
-    end
-
-    after(:all) do
-      Word.remove_indexes
-    end
-
-    let(:search) do
-      Word.text_search("phase")
-    end
-
-    it "returns all fields" do
-      expect(search.first.origin).to eq("latin")
-    end
-  end
 end

data/spec/mongoid/indexable_spec.rb

@@ -41,13 +41,13 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when database specific options exist" do
+    context "when database specific options exist", if: non_legacy_server? do
 
       let(:klass) do
         Class.new do
           include Mongoid::Document
           store_in collection: "test_db_remove"
-          index({ test: 1 }, { database: "mia_2" })
+          index({ test: 1 }, { database: "mongoid_optional" })
           index({ name: 1 }, { background: true })
         end
       end
@@ -58,7 +58,7 @@ describe Mongoid::Indexable do
       end
 
       let(:indexes) do
-        klass.with(database: "mia_2").collection.indexes
+        klass.with(database: "mongoid_optional").collection.indexes
       end
 
       it "creates the indexes" do
@@ -84,17 +84,17 @@ describe Mongoid::Indexable do
       end
 
       it "creates the indexes" do
-        expect(klass.collection.indexes[_type: 1]).to_not be_nil
+        expect(klass.collection.indexes.get(_type: 1)).to_not be_nil
       end
     end
 
-    context "when database options are specified" do
+    context "when database options are specified", if: non_legacy_server? do
 
       let(:klass) do
         Class.new do
           include Mongoid::Document
           store_in collection: "test_db_indexes"
-          index({ _type: 1 }, { database: "mia_1" })
+          index({ _type: 1 }, { database: "mongoid_optional" })
         end
       end
 
@@ -102,12 +102,16 @@ describe Mongoid::Indexable do
         klass.create_indexes
       end
 
+      after do
+        klass.remove_indexes
+      end
+
       let(:indexes) do
-        klass.with(database: "mia_1").collection.indexes
+        klass.with(database: "mongoid_optional").collection.indexes
       end
 
       it "creates the indexes" do
-        expect(indexes[_type: 1]).to_not be_nil
+        expect(indexes.get(_type: 1)).to_not be_nil
       end
     end
   end

data/spec/mongoid/interceptable_spec.rb

@@ -929,6 +929,21 @@ describe Mongoid::Interceptable do
             expect(band.reload.records.first.before_save_called).to be true
           end
         end
+
+        context "when the child is created" do
+
+          let!(:band) do
+            Band.create
+          end
+
+          let!(:label) do
+            band.create_label(name: 'Label')
+          end
+
+          it "only executes callback once" do
+            expect(label.before_save_count).to be 1
+          end
+        end
       end
 
       describe "#before_update" do

data/spec/mongoid/persistable/settable_spec.rb

@@ -159,4 +159,20 @@ describe Mongoid::Persistable::Settable do
       expect(person.reload.somethingnew).to eq "somethingnew"
     end
   end
+
+  context "with an attribute with private setter" do
+    let(:agent) do
+      Agent.create
+    end
+
+    let(:title) do
+      "Double-Oh Seven"
+    end
+
+    it "updates the attribute" do
+      agent.singleton_class.send :private, :title=
+      agent.set(title: title)
+      expect(agent.reload.title).to eq title
+    end
+  end
 end

data/spec/mongoid/persistable/updatable_spec.rb

@@ -217,6 +217,7 @@ describe Mongoid::Persistable::Updatable do
       end
 
       before do
+        I18n.enforce_available_locales = false
         ::I18n.locale = :de
         product.update_attribute(:description, "Die Bombe")
       end
@@ -283,7 +284,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             person.update_attributes(map: { "bad.key" => "value" })
-          }.to raise_error(Moped::Errors::OperationFailure)
+          }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
 
@@ -319,7 +320,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             person.send(method, map: { "bad.key" => "value" })
-          }.to raise_error(Moped::Errors::OperationFailure)
+          }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
 

data/spec/mongoid/persistable_spec.rb

@@ -61,7 +61,7 @@ describe Mongoid::Persistable do
         end
 
         before do
-          expect_any_instance_of(Moped::Query).to receive(:update).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -88,7 +88,7 @@ describe Mongoid::Persistable do
         end
 
         before do
-          expect_any_instance_of(Moped::Query).to receive(:update).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -116,7 +116,7 @@ describe Mongoid::Persistable do
         end
 
         before do
-          expect_any_instance_of(Moped::Query).to receive(:update).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do
@@ -153,7 +153,7 @@ describe Mongoid::Persistable do
         end
 
         before do
-          expect_any_instance_of(Moped::Query).to receive(:update).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
         end
 
         let!(:update) do

data/spec/mongoid/query_cache_spec.rb

@@ -15,7 +15,7 @@ describe Mongoid::QueryCache do
         Band.all.send(method)
       end
 
-      context "when query cache disable" do
+      context "when query cache is disabled" do
 
         before do
           Mongoid::QueryCache.enabled = false
@@ -54,7 +54,7 @@ describe Mongoid::QueryCache do
       Band.all.to_a
     end
 
-    context "when query cache disable" do
+    context "when query cache is disabled" do
 
       before do
         Mongoid::QueryCache.enabled = false
@@ -76,20 +76,24 @@ describe Mongoid::QueryCache do
       end
 
       context "when querying only the first" do
-        let(:game) { Game.create!(name: "2048") }
+
+        let(:game) do
+          Game.create!(name: "2048")
+        end
 
         before do
           game.ratings.where(:value.gt => 5).asc(:id).all.to_a
         end
 
-        it "queries again" do
-          expect_query(1) do
+        it "does not query again" do
+          expect_no_queries do
             game.ratings.where(:value.gt => 5).asc(:id).first
           end
         end
       end
 
-      context "limiting the result" do
+      context "when limiting the result" do
+
         it "queries again" do
           expect_query(1) do
             Band.limit(2).all.to_a
@@ -97,7 +101,8 @@ describe Mongoid::QueryCache do
         end
       end
 
-      context "specifying a different skip value" do
+      context "when specifying a different skip value" do
+
         before do
           Band.limit(2).skip(1).all.to_a
         end
@@ -213,7 +218,7 @@ describe Mongoid::QueryCache do
 
     it "does not cache the query" do
       expect(Mongoid::QueryCache).to receive(:cache_table).never
-      Band.collection.indexes.create(name: 1)
+      Band.collection.indexes.create_one(name: 1)
     end
   end
 end

data/spec/mongoid/relations/auto_save_spec.rb

@@ -150,7 +150,7 @@ describe Mongoid::Relations::AutoSave do
           end
         end
 
-        context "when updating the child" do
+        pending "when updating the child" do
 
           before do
             person.account = account

data/spec/mongoid/relations/counter_cache_spec.rb

@@ -287,4 +287,38 @@ describe Mongoid::Relations::CounterCache do
       end
     end
   end
+
+  describe "#add_counter_cache_callbacks" do
+
+    let(:person) do
+      Person.create
+    end
+
+    let!(:drug) do
+      person.drugs.create
+    end
+
+    context "when parent is not frozen" do
+
+      before do
+        drug.destroy
+      end
+
+      it "before_destroy updates counter cache" do
+        expect(person.drugs_count).to eq(0)
+      end
+    end
+
+    context "when parent is frozen" do
+
+      before do
+        person.destroy
+        drug.destroy
+      end
+
+      it "before_destroy doesn't update counter cache" do
+        expect(person.drugs_count).to eq(1)
+      end
+    end
+  end
 end

data/spec/mongoid/relations/eager/belongs_to_spec.rb

@@ -150,5 +150,14 @@ describe Mongoid::Relations::Eager::BelongsTo do
         }.to raise_error(Mongoid::Errors::EagerLoad)
       end
     end
+
+    context "when setting the foreign key id directly" do
+
+      it "works" do
+        id = BSON::ObjectId.new
+        game = Game.new(:person_id => id)
+        expect(game.person_id).to eql(id)
+      end
+    end
   end
 end

data/spec/mongoid/relations/eager/has_and_belongs_to_many_spec.rb

@@ -45,7 +45,7 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
 
       it "queries twice" do
         expect_query(2) do
-          Person.all.includes(:houses).each do |person|
+          Person.asc(:_id).includes(:houses).each do |person|
             expect(person.houses).to_not be_nil
 
             expect(person.houses.length).to be(3)
@@ -54,7 +54,7 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
       end
 
       it "has all items" do
-        Person.all.includes(:houses).each do |person|
+        Person.asc(:_id).includes(:houses).each do |person|
           expect(person.ivar(:houses).length).to be(3)
         end
       end
@@ -63,7 +63,7 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
     context "when the relation is not polymorphic" do
 
       let(:eager) do
-        Person.includes(:preferences).last
+        Person.asc(:_id).includes(:preferences).last
       end
 
       context "when the eager load has returned documents" do

data/spec/mongoid/relations/embedded/many_spec.rb

@@ -3873,7 +3873,7 @@ describe Mongoid::Relations::Embedded::Many do
     before do
       band.collection.
         find(_id: band.id).
-        update("$set" => { records: [{ name: "Moderat" }]})
+        update_one("$set" => { records: [{ name: "Moderat" }]})
     end
 
     context "when loading the documents" do
@@ -3933,4 +3933,126 @@ describe Mongoid::Relations::Embedded::Many do
       expect(loaded.extension).to eq("Testing")
     end
   end
+
+  context "deleting embedded documents" do
+
+    it "able to delete embedded documents upon condition" do
+      company = Company.new
+      4.times { |i| company.staffs << Staff.new(age: 50 + i)}
+      2.times { |i| company.staffs << Staff.new(age: 40)}
+      company.save
+      company.staffs.delete_if {|x| x.age >= 50}
+      expect(company.staffs.count).to eq(2)
+    end
+  end
+
+  context "when substituting polymorphic documents" do
+
+    before(:all) do
+      class DNS; end
+
+      class DNS::Zone
+        include Mongoid::Document
+        embeds_many :rrsets, class_name: 'DNS::RRSet',  inverse_of: :zone
+        embeds_one  :soa,    class_name: 'DNS::Record', as: :container
+      end
+
+      class DNS::RRSet
+        include Mongoid::Document
+        embedded_in :zone, class_name: 'DNS::Zone',   inverse_of: :rrsets
+        embeds_many :records, class_name: 'DNS::Record', as: :container
+      end
+
+      class DNS::Record
+        include Mongoid::Document
+        embedded_in :container, polymorphic: true
+      end
+    end
+
+    after(:all) do
+      Object.send(:remove_const, :DNS)
+    end
+
+    context "when the parent is new" do
+
+      let(:zone) do
+        DNS::Zone.new
+      end
+
+      let(:soa_1) do
+        DNS::Record.new
+      end
+
+      context "when replacing the set document" do
+
+        let(:soa_2) do
+          DNS::Record.new
+        end
+
+        before do
+          zone.soa = soa_1
+        end
+
+        it "properly sets the metadata" do
+          expect(zone.soa = soa_2).to eq(soa_2)
+        end
+      end
+
+      context "when deleting the set document" do
+
+        let(:soa_2) do
+          DNS::Record.new
+        end
+
+        before do
+          zone.soa = soa_1
+        end
+
+        it "properly sets the metadata" do
+          expect(zone.soa.delete).to be true
+        end
+      end
+    end
+
+    context "when the parent is persisted" do
+
+      let(:zone) do
+        DNS::Zone.create
+      end
+
+      let(:soa_1) do
+        DNS::Record.new
+      end
+
+      context "when replacing the set document" do
+
+        let(:soa_2) do
+          DNS::Record.new
+        end
+
+        before do
+          zone.soa = soa_1
+        end
+
+        it "properly sets the metadata" do
+          expect(zone.soa = soa_2).to eq(soa_2)
+        end
+      end
+
+      context "when deleting the set document" do
+
+        let(:soa_2) do
+          DNS::Record.new
+        end
+
+        before do
+          zone.soa = soa_1
+        end
+
+        it "properly sets the metadata" do
+          expect(zone.soa.delete).to be true
+        end
+      end
+    end
+  end
 end

data/spec/mongoid/relations/embedded/one_spec.rb

@@ -947,7 +947,7 @@ describe Mongoid::Relations::Embedded::One do
     context "when a parent was removed outside of mongoid" do
 
       before do
-        person.collection.where(_id: person.id).update(
+        person.collection.find(_id: person.id).update_one(
           "$pull" => { "addresses" => { _id: address_one.id }}
         )
       end
@@ -963,7 +963,7 @@ describe Mongoid::Relations::Embedded::One do
         end
 
         before do
-          address_two.code = code
+          person.reload.addresses.first.code = code
         end
 
         it "reloads the correct number" do
@@ -982,7 +982,7 @@ describe Mongoid::Relations::Embedded::One do
     before do
       band.collection.
         find(_id: band.id).
-        update("$set" => { label: { name: "Mute" }})
+        update_one("$set" => { label: { name: "Mute" }})
     end
 
     context "when loading the documents" do

data/spec/mongoid/relations/proxy_spec.rb

@@ -2,6 +2,34 @@ require "spec_helper"
 
 describe Mongoid::Relations::Proxy do
 
+  describe "#find" do
+    let(:person) do
+      Person.create
+    end
+
+    let(:messages) do
+      person.messages
+    end
+
+    let(:msg1) do
+      messages.create(body: 'msg1')
+    end
+
+    it "returns nil with no arguments" do
+      expect(messages.find).to be_nil
+      expect(messages.send(:find)).to be_nil
+      expect(messages.__send__(:find)).to be_nil
+      expect(messages.public_send(:find)).to be_nil
+    end
+
+    it "returns the object corresponding to the id" do
+      expect(messages.find(msg1.id)).to eq(msg1)
+      expect(messages.send(:find, msg1.id)).to eq(msg1)
+      expect(messages.__send__(:find, msg1.id)).to eq(msg1)
+      expect(messages.public_send(:find, msg1.id)).to eq(msg1)
+    end
+  end
+
   describe "#extend" do
 
     before(:all) do

data/spec/mongoid/relations/referenced/in_spec.rb

@@ -1240,7 +1240,7 @@ describe Mongoid::Relations::Referenced::In do
 
       before do
         Person.collection.find({ _id: person_one.id }).
-          update({ "$set" => { title: "Madam" }})
+          update_one({ "$set" => { title: "Madam" }})
       end
 
       let(:reloaded) do