mongoid 4.0.2 → 5.0.0.beta

data/spec/mongoid/contextual/none_spec.rb

@@ -65,6 +65,21 @@ describe Mongoid::Contextual::None do
     end
   end
 
+  describe "#pluck" do
+
+    let!(:band) do
+      Band.create(name: "Depeche Mode")
+    end
+
+    let(:context) do
+      described_class.new(Band.where(name: "Depeche Mode"))
+    end
+
+    it "returns an empty array" do
+      expect(context.pluck(:id)).to eq([])
+    end
+  end
+
   describe "#first" do
 
     let!(:band) do

data/spec/mongoid/copyable_spec.rb

@@ -42,7 +42,7 @@ describe Mongoid::Copyable do
         end
 
         before do
-          Band.collection.find(_id: band.id).update("$set" => { "id" => 1234 })
+          Band.collection.find(_id: band.id).update_one("$set" => { "id" => 1234 })
         end
 
         let!(:cloned) do
@@ -54,9 +54,43 @@ describe Mongoid::Copyable do
         end
       end
 
+      context "when a document has old renamed fields" do
+
+        let!(:actor) do
+          Actor.create(name: "test")
+        end
+
+        before do
+          Actor.collection.find(_id: actor.id).update_one("$set" => { "this_is_not_a_field" => 1 })
+        end
+
+        let(:cloned) do
+          actor.reload.send(method)
+        end
+
+        it "copies the document without error" do
+          expect(cloned.this_is_not_a_field).to eq(1)
+        end
+      end
+
+      context "when using store_as" do
+
+        context "and dynamic attributes are not set" do
+
+          it "clones" do
+            t = StoreAsDupTest1.new(:name => "hi")
+            t.build_store_as_dup_test2(:name => "there")
+            t.save
+            copy = t.send(method)
+            expect(copy.store_as_dup_test2.name).to eq(t.store_as_dup_test2.name)
+          end
+        end
+      end
+
       context "when cloning a document with multiple languages field" do
 
         before do
+          I18n.enforce_available_locales = false
           I18n.locale = 'pt_BR'
           person.desc = "descrição"
           person.save

data/spec/mongoid/criteria/findable_spec.rb

@@ -239,6 +239,203 @@ describe Mongoid::Criteria::Findable do
           end
         end
       end
+
+      context "when providing a single id as extended json" do
+
+        context "when the id matches" do
+
+          let(:found) do
+            Band.find(band.id.as_json)
+          end
+
+          it "returns the matching document" do
+            expect(found).to eq(band)
+          end
+        end
+
+        context "when the id does not match" do
+
+          context "when raising a not found error" do
+
+            before do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find(BSON::ObjectId.new.as_json)
+            end
+
+            it "raises an error" do
+              expect {
+                found
+              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            end
+          end
+
+          context "when raising no error" do
+
+            before do
+              Mongoid.raise_not_found_error = false
+            end
+
+            after do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find(BSON::ObjectId.new.as_json)
+            end
+
+            it "returns nil" do
+              expect(found).to be_nil
+            end
+          end
+        end
+      end
+
+      context "when providing a splat of extended json ids" do
+
+        let!(:band_two) do
+          Band.create(name: "Tool")
+        end
+
+        context "when all ids match" do
+
+          let(:found) do
+            Band.find(band.id.as_json, band_two.id.as_json)
+          end
+
+          it "contains the first match" do
+            expect(found).to include(band)
+          end
+
+          it "contains the second match" do
+            expect(found).to include(band_two)
+          end
+
+          context "when ids are duplicates" do
+
+            let(:found) do
+              Band.find(band.id, band.id)
+            end
+
+            it "contains only the first match" do
+              expect(found).to eq([band])
+            end
+          end
+        end
+
+        context "when any id does not match" do
+
+          context "when raising a not found error" do
+
+            before do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find(band.id.as_json, BSON::ObjectId.new.as_json)
+            end
+
+            it "raises an error" do
+              expect {
+                found
+              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            end
+          end
+
+          context "when raising no error" do
+
+            before do
+              Mongoid.raise_not_found_error = false
+            end
+
+            after do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find(band.id.as_json, BSON::ObjectId.new.as_json)
+            end
+
+            it "returns only the matching documents" do
+              expect(found).to eq([ band ])
+            end
+          end
+        end
+      end
+
+      context "when providing an array of extended json ids" do
+
+        let!(:band_two) do
+          Band.create(name: "Tool")
+        end
+
+        context "when all ids match" do
+
+          let(:found) do
+            Band.find([ band.id.as_json, band_two.id.as_json ])
+          end
+
+          it "contains the first match" do
+            expect(found).to include(band)
+          end
+
+          it "contains the second match" do
+            expect(found).to include(band_two)
+          end
+
+          context "when ids are duplicates" do
+
+            let(:found) do
+              Band.find([ band.id, band.id ])
+            end
+
+            it "contains only the first match" do
+              expect(found).to eq([band])
+            end
+          end
+        end
+
+        context "when any id does not match" do
+
+          context "when raising a not found error" do
+
+            before do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find([ band.id.as_json, BSON::ObjectId.new.as_json ])
+            end
+
+            it "raises an error" do
+              expect {
+                found
+              }.to raise_error(Mongoid::Errors::DocumentNotFound)
+            end
+          end
+
+          context "when raising no error" do
+
+            before do
+              Mongoid.raise_not_found_error = false
+            end
+
+            after do
+              Mongoid.raise_not_found_error = true
+            end
+
+            let(:found) do
+              Band.find([ band.id.as_json, BSON::ObjectId.new.as_json ])
+            end
+
+            it "returns only the matching documents" do
+              expect(found).to eq([ band ])
+            end
+          end
+        end
+      end
     end
 
     context "when using string ids" do

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -954,7 +954,7 @@ describe Mongoid::Criteria::Modifiable do
           end
 
           it "does not update the last document" do
-            expect(from_db.posts.last.title).to eq("Second")
+            expect(from_db.posts[1].title).to eq("Second")
           end
         end
 
@@ -999,11 +999,11 @@ describe Mongoid::Criteria::Modifiable do
           end
 
           it "updates the first document" do
-            expect(from_db.preferences.first.name).to eq("London")
+            expect(from_db.preferences[0].name).to eq("London")
           end
 
           it "does not update the last document" do
-            expect(from_db.preferences.last.name).to eq("Second")
+            expect(from_db.preferences[1].name).to eq("Second")
           end
         end
 
@@ -1014,11 +1014,11 @@ describe Mongoid::Criteria::Modifiable do
           end
 
           it "updates the matching documents" do
-            expect(from_db.preferences.first.name).to eq("Berlin")
+            expect(from_db.preferences[0].name).to eq("Berlin")
           end
 
           it "does not update non matching documents" do
-            expect(from_db.preferences.last.name).to eq("Second")
+            expect(from_db.preferences[1].name).to eq("Second")
           end
         end
       end
@@ -1217,36 +1217,14 @@ describe Mongoid::Criteria::Modifiable do
           end
 
           it "updates the matching documents" do
-            expect(from_db.preferences.first.name).to eq("Berlin")
+            expect(from_db.preferences[0].name).to eq("Berlin")
           end
 
           it "does not update non matching documents" do
-            expect(from_db.preferences.last.name).to eq("Second")
+            expect(from_db.preferences[1].name).to eq("Second")
           end
         end
       end
     end
-
-    context "when update document structure" do
-
-      before do
-        person = Person.new(username: "user_title", score: 25)
-        person.save
-      end
-
-      let(:from_db) do
-        Person.last
-      end
-
-      it "rename document string field" do
-        Person.where(username: "user_title").update_all("$rename" => { username: "title" })
-        expect(from_db.title).to eq("user_title")
-      end
-
-      it "rename document integer field" do
-        Person.where(score: 25).update_all("$rename" => { score: "age" })
-        expect(from_db.age).to eq( 25 )
-      end
-    end
   end
 end

data/spec/mongoid/criteria_spec.rb

@@ -148,6 +148,21 @@ describe Mongoid::Criteria do
     end
   end
 
+  describe "#read" do
+
+    let(:person) do
+      Person.create
+    end
+
+    let(:criteria) do
+      Person.read(mode: :secondary)
+    end
+
+    it "adds the read option" do
+      expect(criteria.options[:read]).to eq(mode: :secondary)
+    end
+  end
+
   describe "#aggregates" do
 
     context "when provided a single field" do
@@ -362,7 +377,7 @@ describe Mongoid::Criteria do
       end
 
       it "does not hit the database after first iteration" do
-        expect(criteria.context.query).to receive(:each).never
+        expect(criteria.context.view).to receive(:each).never
         criteria.each do |doc|
           expect(doc).to eq(person)
         end
@@ -380,7 +395,7 @@ describe Mongoid::Criteria do
       end
 
       it "does not hit the database after first iteration" do
-        expect(criteria.context.query).to receive(:each).never
+        expect(criteria.context.view).to receive(:each).never
         criteria.each do |doc|
           expect(doc).to eq(person)
         end
@@ -709,7 +724,7 @@ describe Mongoid::Criteria do
     end
 
     it "returns the criteria explain path" do
-      expect(criteria.explain["cursor"]).to eq("BasicCursor")
+      expect(criteria.explain).to_not be_empty
     end
   end
 
@@ -752,12 +767,12 @@ describe Mongoid::Criteria do
       Band.only(:name)
     end
 
-    it "returns the fields minus type" do
-      expect(criteria.field_list).to eq([ "name" ])
+    it "returns the fields with required _id minus type" do
+      expect(criteria.field_list).to eq([ "_id", "name" ])
     end
   end
 
-  describe "#find_and_modify" do
+  describe "#find_one_and_update" do
 
     let!(:depeche) do
       Band.create(name: "Depeche Mode")
@@ -778,7 +793,7 @@ describe Mongoid::Criteria do
           end
 
           let(:result) do
-            criteria.find_and_modify({ "$inc" => { likes: 1 }}, new: true)
+            criteria.find_one_and_update({ "$inc" => { likes: 1 }}, return_document: :after)
           end
 
           it "returns the first matching document" do
@@ -793,7 +808,7 @@ describe Mongoid::Criteria do
           end
 
           let!(:result) do
-            criteria.find_and_modify("$inc" => { likes: 1 })
+            criteria.find_one_and_update("$inc" => { likes: 1 })
           end
 
           before do
@@ -813,7 +828,7 @@ describe Mongoid::Criteria do
         end
 
         let!(:result) do
-          criteria.find_and_modify("$inc" => { likes: 1 })
+          criteria.find_one_and_update("$inc" => { likes: 1 })
         end
 
         it "returns the first matching document" do
@@ -832,7 +847,7 @@ describe Mongoid::Criteria do
         end
 
         let!(:result) do
-          criteria.find_and_modify("$inc" => { likes: 1 })
+          criteria.find_one_and_update("$inc" => { likes: 1 })
         end
 
         it "returns the first matching document" do
@@ -851,7 +866,7 @@ describe Mongoid::Criteria do
         end
 
         let!(:result) do
-          criteria.find_and_modify("$inc" => { likes: 1 })
+          criteria.find_one_and_update("$inc" => { likes: 1 })
         end
 
         it "returns the first matching document" do
@@ -874,7 +889,7 @@ describe Mongoid::Criteria do
         end
 
         let!(:result) do
-          criteria.find_and_modify({ "$inc" => { likes: 1 }}, new: true)
+          criteria.find_one_and_update({ "$inc" => { likes: 1 }}, return_document: :after)
         end
 
         it "returns the first matching document" do
@@ -893,7 +908,7 @@ describe Mongoid::Criteria do
         end
 
         let!(:result) do
-          criteria.find_and_modify({}, remove: true)
+          criteria.find_one_and_delete
         end
 
         it "returns the first matching document" do
@@ -915,11 +930,18 @@ describe Mongoid::Criteria do
       end
 
       let(:result) do
-        criteria.find_and_modify("$inc" => { likes: 1 })
+        criteria.find_one_and_update("$inc" => { likes: 1 })
       end
 
-      it "returns nil" do
-        expect(result).to be_nil
+      context "without upsert" do
+
+        let(:result) do
+          criteria.find_one_and_update("$inc" => { likes: 1 })
+        end
+
+        it "returns nil" do
+          expect(result).to be_nil
+        end
       end
     end
   end
@@ -1401,13 +1423,6 @@ describe Mongoid::Criteria do
             end
           end
 
-          it "does not eager load the last document" do
-            doc = criteria.last
-            expect_query(1) do
-              expect(doc.person).to eq(person_two)
-            end
-          end
-
           it "returns the first document" do
             expect(document).to eq(post_one)
           end
@@ -1416,7 +1431,7 @@ describe Mongoid::Criteria do
         context "when calling last" do
 
           let!(:criteria) do
-            Post.includes(:person)
+            Post.asc(:_id).includes(:person)
           end
 
           let!(:document) do
@@ -2226,17 +2241,6 @@ describe Mongoid::Criteria do
         ])
       end
     end
-
-    context "when timeout options are provided" do
-
-      let(:map_reduce) do
-        Band.limit(2).no_timeout.map_reduce(map, reduce).out(replace: "test_bands")
-      end
-
-      it "sets the timeout option on the query" do
-        expect(map_reduce.send(:documents).operation.flags).to eq([ :no_cursor_timeout ])
-      end
-    end
   end
 
   describe "#max" do
@@ -2621,6 +2625,19 @@ describe Mongoid::Criteria do
         end
       end
 
+      context "when not including id" do
+
+        let(:criteria) do
+          Band.only(:name)
+        end
+
+        it "responds to id anyway" do
+          expect {
+            criteria.first.id
+          }.to_not raise_error
+        end
+      end
+
       context "when passing an array" do
 
         let(:criteria) do
@@ -2704,7 +2721,7 @@ describe Mongoid::Criteria do
         end
 
         it "properly uses the database field name" do
-          expect(criteria.options).to eq(fields: { "mobile_phones" => 1 })
+          expect(criteria.options).to eq(fields: { "_id" => 1, "mobile_phones" => 1 })
         end
       end
     end
@@ -3042,36 +3059,6 @@ describe Mongoid::Criteria do
     end
   end
 
-  describe "#extras with a hint" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:criteria) do
-      Band.where(name: "Depeche Mode").extras(:hint => {:bad_hint => 1})
-    end
-
-    it "executes the criteria while properly giving the hint to Mongo" do
-      expect { criteria.to_ary }.to raise_error(Moped::Errors::QueryFailure)
-    end
-  end
-
-  describe "#hint" do
-
-    let!(:band) do
-      Band.create(name: "Depeche Mode")
-    end
-
-    let(:criteria) do
-      Band.where(name: "Depeche Mode").hint(bad_hint: 1)
-    end
-
-    it "executes the criteria while properly giving the hint to Mongo" do
-      expect { criteria.to_ary }.to raise_error(Moped::Errors::QueryFailure)
-    end
-  end
-
   describe "#max_scan" do
     let!(:band) do
       Band.create(name: "Depeche Mode")
@@ -3090,31 +3077,6 @@ describe Mongoid::Criteria do
     end
   end
 
-  describe "#text_search" do
-
-    let(:criteria) do
-      Word.all
-    end
-
-    before do
-      Word.with(database: "admin").mongo_session.command(setParameter: 1, textSearchEnabled: true)
-      Word.create_indexes
-      Word.create!(name: "phase", origin: "latin")
-    end
-
-    after(:all) do
-      Word.remove_indexes
-    end
-
-    let(:search) do
-      criteria.text_search("phase")
-    end
-
-    it "returns all fields" do
-      expect(search.first.origin).to eq("latin")
-    end
-  end
-
   describe "#to_criteria" do
 
     let(:criteria) do
@@ -3417,6 +3379,10 @@ describe Mongoid::Criteria do
 
   describe "#without" do
 
+    let!(:person) do
+      Person.create!(username: "davinci", age: 50, pets: false)
+    end
+
     context "when omitting to embedded documents" do
 
       context "when the embedded documents are aliased" do
@@ -3430,5 +3396,22 @@ describe Mongoid::Criteria do
         end
       end
     end
+
+    context "when excluding id" do
+
+      let(:criteria) do
+        Person.without(:_id, :id, "_id", "id")
+      end
+
+      it "does not raise error" do
+        expect {
+          criteria.first.id
+        }.to_not raise_error
+      end
+
+      it "returns id anyway" do
+        expect(criteria.first.id).to_not be_nil
+      end
+    end
   end
 end