mongoid 4.0.1 → 4.0.2

data/spec/mongoid/contextual/memory_spec.rb

@@ -926,8 +926,13 @@ describe Mongoid::Contextual::Memory do
         Address.new(street: "lenau", number: 5, name: "lenau")
       end
 
+      let(:kampuchea_krom) do
+        Address.new(street: "kampuchea krom", number: 5, name: "kampuchea krom")
+      end
+
       before do
         criteria.documents.unshift(lenau)
+        criteria.documents.unshift(kampuchea_krom)
       end
 
       context "when the sort is ascending" do
@@ -937,7 +942,7 @@ describe Mongoid::Contextual::Memory do
         end
 
         it "sorts the documents" do
-          expect(context.entries).to eq([ friedel, lenau, pfluger, hobrecht ])
+          expect(context.entries).to eq([ friedel, kampuchea_krom, lenau, pfluger, hobrecht ])
         end
 
         it "returns the context" do
@@ -952,7 +957,7 @@ describe Mongoid::Contextual::Memory do
         end
 
         it "sorts the documents" do
-          expect(context.entries).to eq([ hobrecht, pfluger, lenau, friedel ])
+          expect(context.entries).to eq([ hobrecht, pfluger, lenau, kampuchea_krom, friedel ])
         end
 
         it "returns the context" do

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -934,12 +934,9 @@ describe Mongoid::Criteria::Modifiable do
 
       context "when the relation is a references many" do
 
-        let!(:post_one) do
-          person.posts.create(title: "First")
-        end
-
-        let!(:post_two) do
-          person.posts.create(title: "Second")
+        before do
+          person.posts.create!(title: "First")
+          person.posts.create!(title: "Second")
         end
 
         context "when updating the relation directly" do
@@ -948,12 +945,12 @@ describe Mongoid::Criteria::Modifiable do
             person.posts.update(title: "London")
           end
 
-          let!(:from_db) do
+          let(:from_db) do
             Person.first
           end
 
           it "updates the first document" do
-            expect(from_db.posts.first.title).to eq("London")
+            expect(from_db.posts.map(&:title)).to eq(["London", "Second"])
           end
 
           it "does not update the last document" do

data/spec/mongoid/document_spec.rb

@@ -529,11 +529,15 @@ describe Mongoid::Document do
     context "when the document is not new" do
 
       let(:person) do
-        Person.instantiate("_id" => BSON::ObjectId.new)
+        Person.create!
       end
 
       it "returns the id in an array" do
-        expect(person.to_key).to eq([ person.id ])
+        expect(person.to_key).to eq([ person.id.to_s ])
+      end
+
+      it "can query using the key" do
+        expect(person.id).to eq Person.find(person.to_key).first.id
       end
     end
 
@@ -546,7 +550,7 @@ describe Mongoid::Document do
       end
 
       it "returns the id in an array" do
-        expect(person.to_key).to eq([ person.id ])
+        expect(person.to_key).to eq([ person.id.to_s ])
       end
     end
   end

data/spec/mongoid/extensions_spec.rb

@@ -13,3 +13,17 @@ describe BSON::ObjectId do
     end
   end
 end
+
+describe BSON::Document do
+
+  describe "#symbolize_keys" do
+
+    let(:doc) do
+      described_class.new("foo" => "bar")
+    end
+
+    it "returns key as symbol" do
+      expect(doc.symbolize_keys.keys).to eq [:foo]
+    end
+  end
+end

data/spec/mongoid/findable_spec.rb

@@ -53,6 +53,55 @@ describe Mongoid::Findable do
 
   describe ".find_by" do
 
+    context "when collection is a embeds_many" do
+
+      let(:person) do
+        Person.create(title: "sir")
+      end
+
+      let!(:message) do
+        person.messages.create!(body: 'foo')
+      end
+
+      context "when the document is found" do
+
+        it "returns the document" do
+          expect(person.messages.find_by(body: 'foo')).to eq(message)
+        end
+      end
+
+      context "when the document is not found" do
+
+        context "when raising a not found error" do
+
+          let!(:raise_option) { Mongoid.raise_not_found_error }
+
+          before { Mongoid.raise_not_found_error = true }
+
+          after { Mongoid.raise_not_found_error = raise_option }
+
+          it "raises an error" do
+            expect {
+              person.messages.find_by(body: 'bar')
+            }.to raise_error(Mongoid::Errors::DocumentNotFound)
+          end
+        end
+
+        context "when raising no error" do
+
+          let!(:raise_option) { Mongoid.raise_not_found_error }
+
+          before { Mongoid.raise_not_found_error = false }
+
+          after { Mongoid.raise_not_found_error = raise_option }
+
+          it "returns nil" do
+            expect(person.messages.find_by(body: 'bar')).to be_nil
+          end
+        end
+      end
+    end
+
     context "when the document is found" do
 
       let!(:person) do
@@ -84,9 +133,11 @@ describe Mongoid::Findable do
 
       context "when raising a not found error" do
 
-        before do
-          Mongoid.raise_not_found_error = true
-        end
+        let!(:raise_option) { Mongoid.raise_not_found_error }
+
+        before { Mongoid.raise_not_found_error = true }
+
+        after { Mongoid.raise_not_found_error = raise_option }
 
         it "raises an error" do
           expect {
@@ -97,13 +148,11 @@ describe Mongoid::Findable do
 
       context "when raising no error" do
 
-        before do
-          Mongoid.raise_not_found_error = false
-        end
+        let!(:raise_option) { Mongoid.raise_not_found_error }
 
-        after do
-          Mongoid.raise_not_found_error = true
-        end
+        before { Mongoid.raise_not_found_error = false }
+
+        after { Mongoid.raise_not_found_error = raise_option }
 
         context "when no block is provided" do
 
@@ -128,6 +177,45 @@ describe Mongoid::Findable do
     end
   end
 
+  describe "find_by!" do
+
+    context "when the document is found" do
+
+      let!(:person) do
+        Person.create(title: "sir")
+      end
+
+      context "when no block is provided" do
+
+        it "returns the document" do
+          expect(Person.find_by!(title: "sir")).to eq(person)
+        end
+      end
+
+      context "when a block is provided" do
+
+        let(:result) do
+          Person.find_by!(title: "sir") do |peep|
+            peep.age = 50
+          end
+        end
+
+        it "yields the returned document" do
+          expect(result.age).to eq(50)
+        end
+      end
+    end
+
+    context "when the document is not found" do
+
+      it "raises an error" do
+        expect {
+          Person.find_by!(ssn: "333-22-1111")
+        }.to raise_error(Mongoid::Errors::DocumentNotFound)
+      end
+    end
+  end
+
   [ :first, :one ].each do |method|
 
     describe "##{method}" do

data/spec/mongoid/persistable/creatable_spec.rb

@@ -394,6 +394,47 @@ describe Mongoid::Persistable::Creatable do
           end
         end
       end
+
+      context "#find_or_create_by!" do
+
+        before do
+          container.vehicles.find_or_create_by!({ driver_id: driver.id }, Car)
+        end
+
+        it "creates the given type document" do
+          expect(container.vehicles.map(&:class)).to eq([ Car ])
+        end
+
+        it "creates with the given attributes" do
+          expect(container.vehicles.map(&:driver)).to eq([ driver ])
+        end
+
+        it "creates the correct number of documents" do
+          expect(container.vehicles.size).to eq(1)
+        end
+
+        context "when executing with a found document" do
+
+          before do
+            container.vehicles.find_or_create_by!({ driver_id: driver.id }, Car)
+          end
+
+          it "does not create an additional document" do
+            expect(container.vehicles.size).to eq(1)
+          end
+        end
+
+        context "when executing with an additional new document" do
+
+          before do
+            container.vehicles.find_or_create_by!({ driver_id: driver.id }, Truck)
+          end
+
+          it "creates the new additional document" do
+            expect(container.vehicles.size).to eq(2)
+          end
+        end
+      end
     end
   end
 

data/spec/mongoid/persistable/savable_spec.rb

@@ -8,6 +8,14 @@ describe Mongoid::Persistable::Savable do
       Person.create
     end
 
+    let(:contextable_item) do
+      ContextableItem.new
+    end
+
+    let(:persisted_contextable_item) do
+      ContextableItem.create(title: 'sir')
+    end
+
     context "when skipping validation" do
 
       context "when no relations are involved" do
@@ -285,6 +293,35 @@ describe Mongoid::Persistable::Savable do
         }.to raise_error(Mongoid::Errors::ReadonlyDocument)
       end
     end
+
+    context "when validation context isn't assigned" do
+      it "returns true" do
+        expect(contextable_item.save).to be true
+      end
+    end
+
+    context "when validation context exists" do
+      context "on new document" do
+        it "returns true" do
+          contextable_item.title = "sir"
+          expect(contextable_item.save(context: :in_context)).to be true
+        end
+        it "returns false" do
+          expect(contextable_item.save(context: :in_context)).to be false
+        end
+      end
+
+      context "on persisted document" do
+        it "returns true" do
+          persisted_contextable_item.title = "lady"
+          expect(persisted_contextable_item.save(context: :in_context)).to be true
+        end
+        it "returns false" do
+          persisted_contextable_item.title = nil
+          expect(persisted_contextable_item.save(context: :in_context)).to be false
+        end
+      end
+    end
   end
 
   describe "save!" do

data/spec/mongoid/persistable/settable_spec.rb

@@ -136,4 +136,27 @@ describe Mongoid::Persistable::Settable do
       end
     end
   end
+
+  context "when dynamic attributes are not enabled" do
+    let(:account) do
+      Account.create
+    end
+
+    it "raises exception for an unknown attribute " do
+      expect {
+        account.set(somethingnew: "somethingnew")
+      }.to raise_error(Mongoid::Errors::UnknownAttribute)
+    end
+  end
+
+  context "when dynamic attributes enabled" do
+    let(:person) do
+      Person.create
+    end
+
+    it "updates non existing attribute" do
+      person.set(somethingnew: "somethingnew")
+      expect(person.reload.somethingnew).to eq "somethingnew"
+    end
+  end
 end

data/spec/mongoid/relations/embedded/many_spec.rb

@@ -2120,6 +2120,80 @@ describe Mongoid::Relations::Embedded::Many do
     end
   end
 
+  describe "#find_or_create_by!" do
+
+    let(:person) do
+      Person.create
+    end
+
+    let!(:address) do
+      person.addresses.build(street: "Bourke", city: "Melbourne")
+    end
+
+    context "when the document exists" do
+
+      let(:found) do
+        person.addresses.find_or_create_by!(street: "Bourke")
+      end
+
+      it "returns the document" do
+        expect(found).to eq(address)
+      end
+    end
+
+    context "when the document does not exist" do
+
+      let(:found) do
+        person.addresses.find_or_create_by!(street: "King") do |address|
+          address.state = "CA"
+        end
+      end
+
+      it "sets the new document attributes" do
+        expect(found.street).to eq("King")
+      end
+
+      it "returns a newly persisted document" do
+        expect(found).to be_persisted
+      end
+
+      it "calls the passed block" do
+        expect(found.state).to eq("CA")
+      end
+
+      context "when validation fails" do
+
+        it "raises an error" do
+          expect {
+            person.addresses.find_or_create_by!(street: "1")
+          }.to raise_error(Mongoid::Errors::Validations)
+        end
+      end
+    end
+
+    context "when the child belongs to another document" do
+
+      let(:product) do
+        Product.create
+      end
+
+      let(:purchase) do
+        Purchase.create
+      end
+
+      let(:line_item) do
+        purchase.line_items.find_or_create_by(
+            product_id: product.id,
+            product_type: product.class.name
+        )
+      end
+
+      it "properly creates the document" do
+        expect(line_item.product).to eq(product)
+      end
+    end
+  end
+
   describe "#find_or_initialize_by" do
 
     let(:person) do