mongoid 4.0.0 → 4.0.2

data/spec/mongoid/positional_spec.rb

@@ -15,8 +15,7 @@ describe Mongoid::Positional do
         "$set" => {
           "field" => "value",
           "children.0.field" => "value",
-          "children.0.children.1.children.3.field" => "value",
-          "children.0.children.1.children.3.field" => "value",
+          "children.0.children.1.children.3.field" => "value"
         },
         "$pushAll" => {
           "children.0.children.1.children.3.fields" => [ "value", "value" ]
@@ -113,8 +112,7 @@ describe Mongoid::Positional do
             "$set" => {
               "field" => "value",
               "children.$.field" => "value",
-              "children.$.children.1.children.3.field" => "value",
-              "children.$.children.1.children.3.field" => "value",
+              "children.$.children.1.children.3.field" => "value"
             },
             "$pushAll" => {
               "children.$.children.1.children.3.fields" => [ "value", "value" ]
@@ -142,8 +140,7 @@ describe Mongoid::Positional do
             "$set" => {
               "field" => "value",
               "children.0.field" => "value",
-              "children.0.children.1.children.3.field" => "value",
-              "children.0.children.1.children.3.field" => "value",
+              "children.0.children.1.children.3.field" => "value"
             },
             "$pushAll" => {
               "children.0.children.1.children.3.fields" => [ "value", "value" ]
@@ -172,8 +169,7 @@ describe Mongoid::Positional do
           "$set" => {
             "field" => "value",
             "children.$.field" => "value",
-            "children.0.children.$.children.3.field" => "value",
-            "children.0.children.$.children.3.field" => "value",
+            "children.0.children.$.children.3.field" => "value"
           },
           "$pushAll" => {
             "children.0.children.$.children.3.fields" => [ "value", "value" ]
@@ -206,8 +202,7 @@ describe Mongoid::Positional do
           "$set" => {
             "field" => "value",
             "children.$.field" => "value",
-            "children.0.children.1.children.$.field" => "value",
-            "children.0.children.1.children.$.field" => "value",
+            "children.0.children.1.children.$.field" => "value"
           },
           "$pushAll" => {
             "children.0.children.1.children.$.fields" => [ "value", "value" ]

data/spec/mongoid/query_cache_spec.rb

@@ -177,6 +177,38 @@ describe Mongoid::QueryCache do
     end
   end
 
+  context "when querying a very large collection" do
+
+    before do
+      123.times { Band.create! }
+    end
+
+    it "returns the right number of records" do
+      expect(Band.all.to_a.length).to eq(123)
+    end
+
+    it "#pluck returns the same count of objects" do
+      expect(Band.pluck(:name).length).to eq(123)
+    end
+
+    context "when loading all the documents" do
+
+      before do
+        Band.all.to_a
+      end
+
+      it "caches the complete result of the query" do
+        expect_no_queries do
+          expect(Band.all.to_a.length).to eq(123)
+        end
+      end
+
+      it "returns the same count of objects when using #pluck" do
+        expect(Band.pluck(:name).length).to eq(123)
+      end
+    end
+  end
+
   context "when inserting an index" do
 
     it "does not cache the query" do

data/spec/mongoid/relations/embedded/many_spec.rb

@@ -2120,6 +2120,80 @@ describe Mongoid::Relations::Embedded::Many do
     end
   end
 
+  describe "#find_or_create_by!" do
+
+    let(:person) do
+      Person.create
+    end
+
+    let!(:address) do
+      person.addresses.build(street: "Bourke", city: "Melbourne")
+    end
+
+    context "when the document exists" do
+
+      let(:found) do
+        person.addresses.find_or_create_by!(street: "Bourke")
+      end
+
+      it "returns the document" do
+        expect(found).to eq(address)
+      end
+    end
+
+    context "when the document does not exist" do
+
+      let(:found) do
+        person.addresses.find_or_create_by!(street: "King") do |address|
+          address.state = "CA"
+        end
+      end
+
+      it "sets the new document attributes" do
+        expect(found.street).to eq("King")
+      end
+
+      it "returns a newly persisted document" do
+        expect(found).to be_persisted
+      end
+
+      it "calls the passed block" do
+        expect(found.state).to eq("CA")
+      end
+
+      context "when validation fails" do
+
+        it "raises an error" do
+          expect {
+            person.addresses.find_or_create_by!(street: "1")
+          }.to raise_error(Mongoid::Errors::Validations)
+        end
+      end
+    end
+
+    context "when the child belongs to another document" do
+
+      let(:product) do
+        Product.create
+      end
+
+      let(:purchase) do
+        Purchase.create
+      end
+
+      let(:line_item) do
+        purchase.line_items.find_or_create_by(
+            product_id: product.id,
+            product_type: product.class.name
+        )
+      end
+
+      it "properly creates the document" do
+        expect(line_item.product).to eq(product)
+      end
+    end
+  end
+
   describe "#find_or_initialize_by" do
 
     let(:person) do

data/spec/mongoid/relations/referenced/many_spec.rb

@@ -2560,6 +2560,136 @@ describe Mongoid::Relations::Referenced::Many do
     end
   end
 
+  describe "#find_or_create_by!" do
+
+    context "when the relation is not polymorphic" do
+
+      let(:person) do
+        Person.create
+      end
+
+      let!(:post) do
+        person.posts.create(title: "Testing")
+      end
+
+      context "when the document exists" do
+
+        let(:found) do
+          person.posts.find_or_create_by!(title: "Testing")
+        end
+
+        it "returns the document" do
+          expect(found).to eq(post)
+        end
+
+        it "keeps the document in the relation" do
+          expect(found.person).to eq(person)
+        end
+      end
+
+      context "when the document does not exist" do
+
+        context "when there is no criteria attached" do
+
+          let(:found) do
+            person.posts.find_or_create_by!(title: "Test") do |post|
+              post.content = "The Content"
+            end
+          end
+
+          it "sets the new document attributes" do
+            expect(found.title).to eq("Test")
+          end
+
+          it "returns a newly persisted document" do
+            expect(found).to be_persisted
+          end
+
+          it "calls the passed block" do
+            expect(found.content).to eq("The Content")
+          end
+
+          it "keeps the document in the relation" do
+            expect(found.person).to eq(person)
+          end
+        end
+
+        context "when a criteria is attached" do
+
+          let(:found) do
+            person.posts.recent.find_or_create_by!(title: "Test")
+          end
+
+          it "sets the new document attributes" do
+            expect(found.title).to eq("Test")
+          end
+
+          it "returns a newly persisted document" do
+            expect(found).to be_persisted
+          end
+
+          it "keeps the document in the relation" do
+            expect(found.person).to eq(person)
+          end
+        end
+      end
+    end
+
+    context "when the relation is polymorphic" do
+
+      let(:movie) do
+        Movie.create
+      end
+
+      let!(:rating) do
+        movie.ratings.create(value: 1)
+      end
+
+      context "when the document exists" do
+
+        let(:found) do
+          movie.ratings.find_or_create_by!(value: 1)
+        end
+
+        it "returns the document" do
+          expect(found).to eq(rating)
+        end
+
+        it "keeps the document in the relation" do
+          expect(found.ratable).to eq(movie)
+        end
+      end
+
+      context "when the document does not exist" do
+
+        let(:found) do
+          movie.ratings.find_or_create_by!(value: 3)
+        end
+
+        it "sets the new document attributes" do
+          expect(found.value).to eq(3)
+        end
+
+        it "returns a newly persisted document" do
+          expect(found).to be_persisted
+        end
+
+        it "keeps the document in the relation" do
+          expect(found.ratable).to eq(movie)
+        end
+
+        context "when validation fails" do
+
+          it "raises an error" do
+            expect {
+              movie.comments.find_or_create_by!(title: "")
+            }.to raise_error(Mongoid::Errors::Validations)
+          end
+        end
+      end
+    end
+  end
+
   describe "#find_or_initialize_by" do
 
     context "when the relation is not polymorphic" do
@@ -3555,4 +3685,27 @@ describe Mongoid::Relations::Referenced::Many do
       expect(person.posts.open).to eq([ post ])
     end
   end
+
+  context "when accessing a relation named parent" do
+    let!(:parent) do
+      Odd.create(name: "odd parent")
+    end
+
+    let(:child) do
+      Even.create(parent_id: parent.id, name: "original even child")
+    end
+
+    it "updates the child after accessing the parent" do
+      # Access parent relation on the child to make sure it is loaded
+      child.parent
+
+      new_child_name = "updated even child"
+
+      child.name = new_child_name
+      child.save!
+
+      reloaded = Even.find(child.id)
+      expect(reloaded.name).to eq(new_child_name)
+    end
+  end
 end

data/spec/mongoid/relations/referenced/many_to_many_spec.rb

@@ -2466,6 +2466,55 @@ describe Mongoid::Relations::Referenced::ManyToMany do
     end
   end
 
+  describe "#find_or_create_by!" do
+
+    context "when the relation is not polymorphic" do
+
+      let(:person) do
+        Person.create
+      end
+
+      let!(:preference) do
+        person.preferences.create(name: "Testing")
+      end
+
+      context "when the document exists" do
+
+        let(:found) do
+          person.preferences.find_or_create_by!(name: "Testing")
+        end
+
+        it "returns the document" do
+          expect(found).to eq(preference)
+        end
+      end
+
+      context "when the document does not exist" do
+
+        let(:found) do
+          person.preferences.find_or_create_by!(name: "Test")
+        end
+
+        it "sets the new document attributes" do
+          expect(found.name).to eq("Test")
+        end
+
+        it "returns a newly persisted document" do
+          expect(found).to be_persisted
+        end
+
+        context "when validation fails" do
+
+          it "raises an error" do
+            expect {
+              person.preferences.find_or_create_by!(name: "A")
+            }.to raise_error(Mongoid::Errors::Validations)
+          end
+        end
+      end
+    end
+  end
+
   describe "#find_or_initialize_by" do
 
     context "when the relation is not polymorphic" do

data/spec/mongoid/reloadable_spec.rb

@@ -261,5 +261,28 @@ describe Mongoid::Reloadable do
         end
       end
     end
+
+    context "when overriding #id alias" do
+
+      let!(:object) do
+        IdKey.create(key: 'foo')
+      end
+
+      let!(:from_db) do
+        IdKey.find(object._id).tap do |object|
+          object.key = 'bar'
+          object.save
+        end
+      end
+
+      it "reloads the object attributes from the db" do
+        object.reload
+        expect(object.key).to eq('bar')
+      end
+
+      it "reload should return self" do
+        expect(object.reload).to eq(from_db)
+      end
+    end
   end
 end

data/spec/mongoid/sessions/options_spec.rb

@@ -65,7 +65,8 @@ describe Mongoid::Sessions::Options do
     end
 
     it "passes down the options to collection" do
-      expect_any_instance_of(Moped::Session).to receive(:with).with(options).and_return({})
+      session = Band.mongo_session
+      expect_any_instance_of(Moped::Session).to receive(:with).with(options).and_return(session)
       instance.collection
     end
   end

data/spec/mongoid/sessions_spec.rb

@@ -409,6 +409,36 @@ describe Mongoid::Sessions do
       end
     end
 
+    context "when overridden the database with store_in" do
+
+      before do
+        Band.store_in(database: database_id_alt)
+      end
+
+      context "on instance level" do
+
+        let(:band) do
+          Band.new.with({:read=>:primary})
+        end
+
+        it "uses the new database" do
+          expect(band.mongo_session.send(:current_database).name).to eq database_id_alt
+        end
+
+        context "when using another database before" do
+
+          before do
+            band
+            User.create!
+          end
+
+          it "uses the new database" do
+            expect(band.mongo_session.send(:current_database).name).to eq database_id_alt
+          end
+        end
+      end
+    end
+
     context "when overriding to a monghq single server", config: :mongohq do
 
       shared_examples_for "an overridden session to a mongohq single server" do

data/spec/spec_helper.rb

@@ -93,6 +93,8 @@ ActiveSupport::Inflector.inflections do |inflect|
   inflect.singular("address_components", "address_component")
 end
 
+I18n.config.enforce_available_locales = false
+
 RSpec.configure do |config|
   config.include Mongoid::SpecHelpers
   config.raise_errors_for_deprecations!

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: mongoid
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.2
 platform: ruby
 authors:
 - Durran Jordan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-23 00:00:00.000000000 Z
+date: 2015-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -115,6 +115,7 @@ files:
 - lib/mongoid/contextual/text_search.rb
 - lib/mongoid/copyable.rb
 - lib/mongoid/criteria.rb
+- lib/mongoid/criteria/#findable.rb#
 - lib/mongoid/criteria/findable.rb
 - lib/mongoid/criteria/inspectable.rb
 - lib/mongoid/criteria/marshalable.rb
@@ -389,6 +390,7 @@ files:
 - spec/app/models/circus.rb
 - spec/app/models/code.rb
 - spec/app/models/comment.rb
+- spec/app/models/contextable_item.rb
 - spec/app/models/contractor.rb
 - spec/app/models/cookie.rb
 - spec/app/models/country_code.rb
@@ -429,6 +431,7 @@ files:
 - spec/app/models/home.rb
 - spec/app/models/house.rb
 - spec/app/models/html_writer.rb
+- spec/app/models/id_key.rb
 - spec/app/models/image.rb
 - spec/app/models/implant.rb
 - spec/app/models/item.rb
@@ -537,6 +540,7 @@ files:
 - spec/app/models/writer.rb
 - spec/config/mongoid.yml
 - spec/helpers.rb
+- spec/mongoid/#atomic_spec.rb#
 - spec/mongoid/atomic/modifiers_spec.rb
 - spec/mongoid/atomic/paths/embedded/many_spec.rb
 - spec/mongoid/atomic/paths/embedded/one_spec.rb
@@ -780,7 +784,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: mongoid
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Elegant Persistance in Ruby for MongoDB.
@@ -831,6 +835,7 @@ test_files:
 - spec/app/models/circus.rb
 - spec/app/models/code.rb
 - spec/app/models/comment.rb
+- spec/app/models/contextable_item.rb
 - spec/app/models/contractor.rb
 - spec/app/models/cookie.rb
 - spec/app/models/country_code.rb
@@ -871,6 +876,7 @@ test_files:
 - spec/app/models/home.rb
 - spec/app/models/house.rb
 - spec/app/models/html_writer.rb
+- spec/app/models/id_key.rb
 - spec/app/models/image.rb
 - spec/app/models/implant.rb
 - spec/app/models/item.rb
@@ -979,6 +985,7 @@ test_files:
 - spec/app/models/writer.rb
 - spec/config/mongoid.yml
 - spec/helpers.rb
+- spec/mongoid/#atomic_spec.rb#
 - spec/mongoid/atomic/modifiers_spec.rb
 - spec/mongoid/atomic/paths/embedded/many_spec.rb
 - spec/mongoid/atomic/paths/embedded/one_spec.rb