mongoid 4.0.0 → 4.0.1

data/spec/mongoid/attributes_spec.rb

@@ -248,6 +248,17 @@ describe Mongoid::Attributes do
     it "delegates to #id" do
       expect(person._id).to eq(person.id)
     end
+
+    context "when #id alias is overridden" do
+
+      let(:object) do
+        IdKey.new(key: 'foo')
+      end
+
+      it "delegates to another method" do
+        expect(object.id).to eq(object.key)
+      end
+    end
   end
 
   describe "#_id=" do
@@ -314,6 +325,19 @@ describe Mongoid::Attributes do
           expect(person.id).to eq(2)
         end
       end
+
+      context "when #id= alias is overridden" do
+
+        let(:object) do
+          IdKey.new(key: 'foo')
+        end
+
+        it "delegates to another method" do
+          object.id = 'bar'
+          expect(object.id).to eq('bar')
+        end
+      end
+
     end
 
     context "when using string ids" do
@@ -853,6 +877,18 @@ describe Mongoid::Attributes do
         expect(person.attribute_present?(:title)).to be false
       end
     end
+
+    context "when the attribute is not on only list" do
+
+      before { Person.create }
+      let(:person) do
+        Person.only(:id).first
+      end
+
+      it "return false" do
+        expect(person.attribute_present?(:foobar)).to be false
+      end
+    end
   end
 
   describe "#has_attribute?" do

data/spec/mongoid/contextual/atomic_spec.rb

@@ -103,10 +103,8 @@ describe Mongoid::Contextual::Atomic do
         expect(depeche_mode.reload.likes).to eq(12)
       end
 
-      if mongodb_version > "2.5"
-        it "does not error on non initialized fields" do
-          expect(smiths.reload.likes).to eq(0)
-        end
+      it "does not error on non initialized fields" do
+        expect(smiths.reload.likes).to eq(0)
       end
     end
 
@@ -120,10 +118,8 @@ describe Mongoid::Contextual::Atomic do
         expect(depeche_mode.reload.likes).to eq(61)
       end
 
-      if mongodb_version > "2.5"
-        it "does not error on non initialized fields" do
-          expect(smiths.reload.likes).to eq(13)
-        end
+      it "does not error on non initialized fields" do
+        expect(smiths.reload.likes).to eq(13)
       end
     end
 
@@ -137,13 +133,11 @@ describe Mongoid::Contextual::Atomic do
         expect(depeche_mode.reload.likes).to eq(14)
       end
 
-      if mongodb_version > "2.5"
-        it "does not error on non initialized fields" do
-          expect(smiths.reload.likes).to eq(10)
-        end
+      it "does not error on non initialized fields" do
+        expect(smiths.reload.likes).to eq(10)
       end
     end
-  end
+  end if mongodb_version > "2.5"
 
   describe "#inc" do
 

data/spec/mongoid/criteria_spec.rb

@@ -1371,6 +1371,77 @@ describe Mongoid::Criteria do
 
     context "when including a belongs to relation" do
 
+      context "when the criteria is from the root" do
+
+        let!(:person_two) do
+          Person.create(age: 2)
+        end
+
+        let!(:post_one) do
+          person.posts.create(title: "one")
+        end
+
+        let!(:post_two) do
+          person_two.posts.create(title: "two")
+        end
+
+        context "when calling first" do
+
+          let(:criteria) do
+            Post.includes(:person)
+          end
+
+          let!(:document) do
+            criteria.first
+          end
+
+          it "eager loads the first document" do
+            expect_query(0) do
+              expect(document.person).to eq(person)
+            end
+          end
+
+          it "does not eager load the last document" do
+            doc = criteria.last
+            expect_query(1) do
+              expect(doc.person).to eq(person_two)
+            end
+          end
+
+          it "returns the first document" do
+            expect(document).to eq(post_one)
+          end
+        end
+
+        context "when calling last" do
+
+          let!(:criteria) do
+            Post.includes(:person)
+          end
+
+          let!(:document) do
+            criteria.last
+          end
+
+          it "eager loads the last document" do
+            expect_query(0) do
+              expect(document.person).to eq(person_two)
+            end
+          end
+
+          it "does not eager load the first document" do
+            doc = criteria.first
+            expect_query(1) do
+              expect(doc.person).to eq(person)
+            end
+          end
+
+          it "returns the last document" do
+            expect(document).to eq(post_two)
+          end
+        end
+      end
+
       context "when the criteria is from an embedded relation" do
 
         let(:peep) do
@@ -1495,77 +1566,6 @@ describe Mongoid::Criteria do
           end
         end
       end
-
-      context "when the criteria is from the root" do
-
-        let!(:person_two) do
-          Person.create(age: 2)
-        end
-
-        let!(:post_one) do
-          person.posts.create(title: "one")
-        end
-
-        let!(:post_two) do
-          person_two.posts.create(title: "two")
-        end
-
-        context "when calling first" do
-
-          let(:criteria) do
-            Post.includes(:person)
-          end
-
-          let!(:document) do
-            criteria.first
-          end
-
-          it "eager loads the first document" do
-            expect_query(0) do
-              expect(document.person).to eq(person)
-            end
-          end
-
-          it "does not eager load the last document" do
-            doc = criteria.last
-            expect_query(1) do
-              expect(doc.person).to eq(person_two)
-            end
-          end
-
-          it "returns the first document" do
-            expect(document).to eq(post_one)
-          end
-        end
-
-        context "when calling last" do
-
-          let!(:criteria) do
-            Post.includes(:person)
-          end
-
-          let!(:document) do
-            criteria.last
-          end
-
-          it "eager loads the last document" do
-            expect_query(0) do
-              expect(document.person).to eq(person_two)
-            end
-          end
-
-          it "does not eager load the first document" do
-            doc = criteria.first
-            expect_query(1) do
-              expect(doc.person).to eq(person)
-            end
-          end
-
-          it "returns the last document" do
-            expect(document).to eq(post_two)
-          end
-        end
-      end
     end
 
     context "when providing inclusions to the default scope" do
@@ -2851,6 +2851,17 @@ describe Mongoid::Criteria do
       end
     end
 
+    context "when plucking existent and non-existent fields" do
+
+      let(:plucked) do
+        Band.all.pluck(:id, :fooz)
+      end
+
+      it "returns nil for the field that doesnt exist" do
+        expect(plucked).to eq([[depeche.id, nil], [tool.id, nil], [photek.id, nil] ])
+      end
+    end
+
     context "when plucking a field that doesnt exist" do
 
       context "when pluck one field" do
@@ -2859,8 +2870,8 @@ describe Mongoid::Criteria do
           Band.all.pluck(:foo)
         end
 
-        it "returns a empty array" do
-          expect(plucked).to eq([])
+        it "returns a array with nil values" do
+          expect(plucked).to eq([nil, nil, nil])
         end
       end
 
@@ -2870,8 +2881,8 @@ describe Mongoid::Criteria do
           Band.all.pluck(:foo, :bar)
         end
 
-        it "returns a empty array" do
-          expect(plucked).to eq([[], [], []])
+        it "returns a nil arrays" do
+          expect(plucked).to eq([[nil, nil], [nil, nil], [nil, nil]])
         end
       end
     end

data/spec/mongoid/document_spec.rb

@@ -144,7 +144,7 @@ describe Mongoid::Document do
       context "with updated_at" do
 
         let!(:updated_at) do
-          document.updated_at.utc.to_s(:number)
+          document.updated_at.utc.to_s(:nsec)
         end
 
         it "has the id and updated_at key name" do
@@ -182,7 +182,7 @@ describe Mongoid::Document do
       end
 
       let!(:updated_at) do
-        agent.updated_at.utc.to_s(:number)
+        agent.updated_at.utc.to_s(:nsec)
       end
 
       it "has the id and updated_at key name" do

data/spec/mongoid/findable_spec.rb

@@ -382,8 +382,8 @@ describe Mongoid::Findable do
         Band.pluck(:follows)
       end
 
-      it "returns an empty array" do
-        expect(plucked).to be_empty
+      it "returns a array with nil values" do
+        expect(plucked).to eq([nil, nil, nil])
       end
     end
   end

data/spec/mongoid/positional_spec.rb

@@ -15,8 +15,7 @@ describe Mongoid::Positional do
         "$set" => {
           "field" => "value",
           "children.0.field" => "value",
-          "children.0.children.1.children.3.field" => "value",
-          "children.0.children.1.children.3.field" => "value",
+          "children.0.children.1.children.3.field" => "value"
         },
         "$pushAll" => {
           "children.0.children.1.children.3.fields" => [ "value", "value" ]
@@ -113,8 +112,7 @@ describe Mongoid::Positional do
             "$set" => {
               "field" => "value",
               "children.$.field" => "value",
-              "children.$.children.1.children.3.field" => "value",
-              "children.$.children.1.children.3.field" => "value",
+              "children.$.children.1.children.3.field" => "value"
             },
             "$pushAll" => {
               "children.$.children.1.children.3.fields" => [ "value", "value" ]
@@ -142,8 +140,7 @@ describe Mongoid::Positional do
             "$set" => {
               "field" => "value",
               "children.0.field" => "value",
-              "children.0.children.1.children.3.field" => "value",
-              "children.0.children.1.children.3.field" => "value",
+              "children.0.children.1.children.3.field" => "value"
             },
             "$pushAll" => {
               "children.0.children.1.children.3.fields" => [ "value", "value" ]
@@ -172,8 +169,7 @@ describe Mongoid::Positional do
           "$set" => {
             "field" => "value",
             "children.$.field" => "value",
-            "children.0.children.$.children.3.field" => "value",
-            "children.0.children.$.children.3.field" => "value",
+            "children.0.children.$.children.3.field" => "value"
           },
           "$pushAll" => {
             "children.0.children.$.children.3.fields" => [ "value", "value" ]
@@ -206,8 +202,7 @@ describe Mongoid::Positional do
           "$set" => {
             "field" => "value",
             "children.$.field" => "value",
-            "children.0.children.1.children.$.field" => "value",
-            "children.0.children.1.children.$.field" => "value",
+            "children.0.children.1.children.$.field" => "value"
           },
           "$pushAll" => {
             "children.0.children.1.children.$.fields" => [ "value", "value" ]

data/spec/mongoid/query_cache_spec.rb

@@ -177,6 +177,38 @@ describe Mongoid::QueryCache do
     end
   end
 
+  context "when querying a very large collection" do
+
+    before do
+      123.times { Band.create! }
+    end
+
+    it "returns the right number of records" do
+      expect(Band.all.to_a.length).to eq(123)
+    end
+
+    it "#pluck returns the same count of objects" do
+      expect(Band.pluck(:name).length).to eq(123)
+    end
+
+    context "when loading all the documents" do
+
+      before do
+        Band.all.to_a
+      end
+
+      it "caches the complete result of the query" do
+        expect_no_queries do
+          expect(Band.all.to_a.length).to eq(123)
+        end
+      end
+
+      it "returns the same count of objects when using #pluck" do
+        expect(Band.pluck(:name).length).to eq(123)
+      end
+    end
+  end
+
   context "when inserting an index" do
 
     it "does not cache the query" do

data/spec/mongoid/relations/referenced/many_spec.rb

@@ -3555,4 +3555,27 @@ describe Mongoid::Relations::Referenced::Many do
       expect(person.posts.open).to eq([ post ])
     end
   end
+
+  context "when accessing a relation named parent" do
+    let!(:parent) do
+      Odd.create(name: "odd parent")
+    end
+
+    let(:child) do
+      Even.create(parent_id: parent.id, name: "original even child")
+    end
+
+    it "updates the child after accessing the parent" do
+      # Access parent relation on the child to make sure it is loaded
+      child.parent
+
+      new_child_name = "updated even child"
+
+      child.name = new_child_name
+      child.save!
+
+      reloaded = Even.find(child.id)
+      expect(reloaded.name).to eq(new_child_name)
+    end
+  end
 end

data/spec/mongoid/reloadable_spec.rb

@@ -261,5 +261,28 @@ describe Mongoid::Reloadable do
         end
       end
     end
+
+    context "when overriding #id alias" do
+
+      let!(:object) do
+        IdKey.create(key: 'foo')
+      end
+
+      let!(:from_db) do
+        IdKey.find(object._id).tap do |object|
+          object.key = 'bar'
+          object.save
+        end
+      end
+
+      it "reloads the object attributes from the db" do
+        object.reload
+        expect(object.key).to eq('bar')
+      end
+
+      it "reload should return self" do
+        expect(object.reload).to eq(from_db)
+      end
+    end
   end
 end