mongoid 4.0.0.alpha2 → 4.0.0.beta1

data/spec/mongoid/attributes_spec.rb

@@ -14,6 +14,39 @@ describe Mongoid::Attributes do
         expect(account.overridden).to eq("not recommended")
       end
     end
+
+    context "when the attribute was excluded in a criteria" do
+
+      let!(:person) do
+        Person.create(title: "sir")
+      end
+
+      context "when excluding with only" do
+
+        let(:from_db) do
+          Person.only(:_id).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.title
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+
+      context "when excluding with without" do
+
+        let(:from_db) do
+          Person.without(:title).first
+        end
+
+        it "raises an error" do
+          expect {
+            from_db.title
+          }.to raise_error(ActiveModel::MissingAttributeError)
+        end
+      end
+    end
   end
 
   describe "#[]" do
@@ -70,6 +103,35 @@ describe Mongoid::Attributes do
         Person.create(title: "sir")
       end
 
+      context "when the attribute was excluded in a criteria" do
+
+        context "when excluding with only" do
+
+          let(:from_db) do
+            Person.only(:_id).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+
+        context "when excluding with without" do
+
+          let(:from_db) do
+            Person.without(:title).first
+          end
+
+          it "raises an error" do
+            expect {
+              from_db[:title]
+            }.to raise_error(ActiveModel::MissingAttributeError)
+          end
+        end
+      end
+
       context "when the attribute does not exist" do
 
         before do
@@ -547,6 +609,19 @@ describe Mongoid::Attributes do
         expect(person.map).to eq({})
       end
     end
+
+    context "when providing tainted parameters" do
+
+      let(:params) do
+        ActionController::Parameters.new(title: "sir")
+      end
+
+      it "raises an error" do
+        expect {
+          Person.new(params)
+        }.to raise_error(ActiveModel::ForbiddenAttributesError)
+      end
+    end
   end
 
   context "updating when attributes already exist" do
@@ -637,6 +712,7 @@ describe Mongoid::Attributes do
   end
 
   describe "#read_attribute_before_type_cast" do
+
     let(:person) do
       Person.create
     end
@@ -657,7 +733,6 @@ describe Mongoid::Attributes do
     end
   end
 
-
   describe "#attribute_present?" do
 
     context "when document is a new record" do

data/spec/mongoid/changeable_spec.rb

@@ -1424,8 +1424,10 @@ describe Mongoid::Changeable do
       end
 
       after do
-        Acolyte._save_callbacks.reject! do |callback|
+        Acolyte._save_callbacks.select do |callback|
           callback.kind == :after
+        end.each do |callback|
+          Acolyte._save_callbacks.delete(callback)
         end
       end
 
@@ -1448,8 +1450,10 @@ describe Mongoid::Changeable do
       end
 
       after do
-        Acolyte._save_callbacks.reject! do |callback|
+        Acolyte._save_callbacks.select do |callback|
           callback.kind == :after
+        end.each do |callback|
+          Acolyte._save_callbacks.delete(callback)
         end
       end
 

data/spec/mongoid/contextual/mongo_spec.rb

@@ -1548,7 +1548,9 @@ describe Mongoid::Contextual::Mongo do
       end
 
       it "limits the fields to the projection" do
-        expect(documents.first.origin).to be_nil
+        expect {
+          documents.first.origin
+        }.to raise_error(ActiveModel::MissingAttributeError)
       end
     end
 

data/spec/mongoid/contextual/text_search_spec.rb

@@ -37,7 +37,9 @@ describe Mongoid::Contextual::TextSearch do
       end
 
       it "limits the fields to the projection" do
-        expect(documents.first.origin).to be_nil
+        expect {
+          documents.first.origin
+        }.to raise_error(ActiveModel::MissingAttributeError)
       end
     end
 

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -298,6 +298,157 @@ describe Mongoid::Criteria::Modifiable do
     end
   end
 
+  describe ".find_or_create_by!" do
+
+    context "when the document is found" do
+
+      context "when providing an attribute" do
+
+        let!(:person) do
+          Person.create(title: "Senior")
+        end
+
+        it "returns the document" do
+          expect(Person.find_or_create_by!(title: "Senior")).to eq(person)
+        end
+      end
+
+      context "when providing a document" do
+
+        context "with an owner with a BSON identity type" do
+
+          let!(:person) do
+            Person.create
+          end
+
+          let!(:game) do
+            Game.create(person: person)
+          end
+
+          context "when providing the object directly" do
+
+            let(:from_db) do
+              Game.find_or_create_by!(person: person)
+            end
+
+            it "returns the document" do
+              expect(from_db).to eq(game)
+            end
+          end
+
+          context "when providing the proxy relation" do
+
+            let(:from_db) do
+              Game.find_or_create_by!(person: game.person)
+            end
+
+            it "returns the document" do
+              expect(from_db).to eq(game)
+            end
+          end
+        end
+
+        context "with an owner with an Integer identity type" do
+
+          let!(:jar) do
+            Jar.create
+          end
+
+          let!(:cookie) do
+            Cookie.create(jar: jar)
+          end
+
+          let(:from_db) do
+            Cookie.find_or_create_by!(jar: jar)
+          end
+
+          it "returns the document" do
+            expect(from_db).to eq(cookie)
+          end
+        end
+      end
+    end
+
+    context "when the document is not found" do
+
+      context "when providing a document" do
+
+        let!(:person) do
+          Person.create
+        end
+
+        let!(:game) do
+          Game.create
+        end
+
+        let(:from_db) do
+          Game.find_or_create_by!(person: person)
+        end
+
+        it "returns the new document" do
+          expect(from_db.person).to eq(person)
+        end
+
+        it "does not return an existing false document" do
+          expect(from_db).to_not eq(game)
+        end
+      end
+
+      context "when not providing a block" do
+
+        let!(:person) do
+          Person.find_or_create_by!(title: "Senorita")
+        end
+
+        it "creates a persisted document" do
+          expect(person).to be_persisted
+        end
+
+        it "sets the attributes" do
+          expect(person.title).to eq("Senorita")
+        end
+      end
+
+      context "when validation fails" do
+
+        before do
+          Person.validates_presence_of(:title)
+        end
+
+        after do
+          Person.reset_callbacks(:validate)
+        end
+
+        it "raises an exception" do
+          expect {
+            Person.find_or_create_by!(ssn: "test")
+          }.to raise_error(Mongoid::Errors::Validations)
+        end
+      end
+
+      context "when providing a block" do
+
+        let!(:person) do
+          Person.find_or_create_by!(title: "Senorita") do |person|
+            person.pets = true
+          end
+        end
+
+        it "creates a persisted document" do
+          expect(person).to be_persisted
+        end
+
+        it "sets the attributes" do
+          expect(person.title).to eq("Senorita")
+        end
+
+        it "calls the block" do
+          expect(person.pets).to be true
+        end
+      end
+    end
+  end
+
   describe ".find_or_initialize_by" do
 
     context "when the document is found" do
@@ -404,6 +555,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
 
+      context "when the criteria is on an embedded relation" do
+
+        let!(:band) do
+          Band.create(name: "Placebo")
+        end
+
+        let(:document) do
+          band.notes.permanent.first_or_create(text: "test")
+        end
+
+        it "returns a new document" do
+          expect(document.text).to eq("test")
+        end
+
+        it "returns a persisted document" do
+          expect(document).to be_persisted
+        end
+      end
+
       context "when a block is provided" do
 
         let(:document) do
@@ -1059,5 +1229,27 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context "when update document structure" do
+
+      before do
+        person = Person.new(username: "user_title", score: 25)
+        person.save
+      end
+
+      let(:from_db) do
+        Person.last
+      end
+
+      it "rename document string field" do
+        Person.where(username: "user_title").update_all("$rename" => { username: "title" })
+        expect(from_db.title).to eq("user_title")
+      end
+
+      it "rename document integer field" do
+        Person.where(score: 25).update_all("$rename" => { score: "age" })
+        expect(from_db.age).to eq( 25 )
+      end
+    end
   end
 end

data/spec/mongoid/criteria_spec.rb

@@ -2611,7 +2611,9 @@ describe Mongoid::Criteria do
         end
 
         it "limits the returned fields" do
-          expect(criteria.first.name).to be_nil
+          expect {
+            criteria.first.name
+          }.to raise_error(ActiveModel::MissingAttributeError)
         end
 
         it "does not add _type to the fields" do
@@ -2630,7 +2632,9 @@ describe Mongoid::Criteria do
         end
 
         it "excludes the non included fields" do
-          expect(criteria.first.active).to be_nil
+          expect {
+            criteria.first.active
+          }.to raise_error(ActiveModel::MissingAttributeError)
         end
 
         it "does not add _type to the fields" do

data/spec/mongoid/errors/document_not_destroyed_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe Mongoid::Errors::DocumentNotDestroyed do
+
+  describe "#message" do
+
+    let(:post) do
+      Post.new
+    end
+
+    let(:error) do
+      described_class.new(post.id, Post)
+    end
+
+    it "contains the problem in the message" do
+      expect(error.message).to include(
+        "Post with id #{post.id.inspect} was not destroyed"
+      )
+    end
+
+    it "contains the summary in the message" do
+      expect(error.message).to include(
+        "When calling Post#destroy! and a callback halts the destroy callback"
+      )
+    end
+
+    it "contains the resolution in the message" do
+      expect(error.message).to include(
+        "Check the before/after destroy callbacks to ensure"
+      )
+    end
+  end
+end

data/spec/mongoid/errors/readonly_document_spec.rb

@@ -0,0 +1,29 @@
+require "spec_helper"
+
+describe Mongoid::Errors::ReadonlyDocument do
+
+  describe "#message" do
+
+    let(:error) do
+      described_class.new(Band)
+    end
+
+    it "contains the problem in the message" do
+      expect(error.message).to include(
+        "Attempted to persist the readonly document 'Band'."
+      )
+    end
+
+    it "contains the summary in the message" do
+      expect(error.message).to include(
+        "Documents loaded from the database using #only"
+      )
+    end
+
+    it "contains the resolution in the message" do
+      expect(error.message).to include(
+        "Don't attempt to persist documents that are flagged as readonly."
+      )
+    end
+  end
+end