mongoid 4.0.0.alpha1 → 4.0.0.alpha2

data/spec/mongoid/relations/bindings/referenced/many_to_many_spec.rb

@@ -39,7 +39,7 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
       end
 
       it "passes the binding options through to the inverse" do
-        person.should_receive(:save).never
+        expect(person).to receive(:save).never
       end
 
       it "syncs the base" do
@@ -60,7 +60,7 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
       end
 
       it "does not save the parent on bind" do
-        person.should_receive(:save).never
+        expect(person).to receive(:save).never
         binding.bind_one(preference_two)
       end
     end
@@ -68,7 +68,7 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
     context "when the document is not bindable" do
 
       it "does nothing" do
-        person.preferences.should_receive(:<<).never
+        expect(person.preferences).to receive(:<<).never
         binding.bind_one(preference)
       end
     end
@@ -84,8 +84,8 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
 
       before do
         binding.bind_one(target.first)
-        person.should_receive(:delete).never
-        preference.should_receive(:delete).never
+        expect(person).to receive(:delete).never
+        expect(preference).to receive(:delete).never
         binding.unbind_one(target.first)
       end
 
@@ -113,10 +113,10 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
       end
 
       it "never performs a persistance operation" do
-        person.should_receive(:delete).never
-        person.should_receive(:save).never
-        preference.should_receive(:delete).never
-        preference.should_receive(:save).never
+        expect(person).to receive(:delete).never
+        expect(person).to receive(:save).never
+        expect(preference).to receive(:delete).never
+        expect(preference).to receive(:save).never
         binding.unbind_one(target.first)
       end
     end
@@ -124,7 +124,7 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
     context "when the documents are not unbindable" do
 
       it "does nothing" do
-        person.should_receive(:preferences=).never
+        expect(person).to receive(:preferences=).never
         binding.unbind_one(target.first)
       end
     end

data/spec/mongoid/relations/bindings/referenced/one_spec.rb

@@ -23,8 +23,8 @@ describe Mongoid::Relations::Bindings::Referenced::One do
     context "when the document is bindable" do
 
       before do
-        person.should_receive(:save).never
-        game.should_receive(:save).never
+        expect(person).to receive(:save).never
+        expect(game).to receive(:save).never
         binding.bind_one
       end
 
@@ -44,7 +44,7 @@ describe Mongoid::Relations::Bindings::Referenced::One do
       end
 
       it "does nothing" do
-        person.should_receive(:game=).never
+        expect(person).to receive(:game=).never
         binding.bind_one
       end
     end
@@ -60,8 +60,8 @@ describe Mongoid::Relations::Bindings::Referenced::One do
 
       before do
         binding.bind_one
-        person.should_receive(:delete).never
-        game.should_receive(:delete).never
+        expect(person).to receive(:delete).never
+        expect(game).to receive(:delete).never
         binding.unbind_one
       end
 
@@ -77,7 +77,7 @@ describe Mongoid::Relations::Bindings::Referenced::One do
     context "when the document is not unbindable" do
 
       it "does nothing" do
-        person.should_receive(:game=).never
+        expect(person).to receive(:game=).never
         binding.unbind_one
       end
     end

data/spec/mongoid/relations/builders/referenced/in_spec.rb

@@ -42,7 +42,7 @@ describe Mongoid::Relations::Builders::Referenced::In do
         end
 
         before do
-          criteria.should_receive(:first).and_return(person)
+          expect(criteria).to receive(:first).and_return(person)
         end
 
         let!(:document) do
@@ -83,7 +83,7 @@ describe Mongoid::Relations::Builders::Referenced::In do
         end
 
         before do
-          criteria.should_receive(:first).and_return(person)
+          expect(criteria).to receive(:first).and_return(person)
         end
 
         let!(:document) do

data/spec/mongoid/relations/builders/referenced/one_spec.rb

@@ -41,7 +41,7 @@ describe Mongoid::Relations::Builders::Referenced::One do
       end
 
       before do
-        criteria.should_receive(:first).and_return(post)
+        expect(criteria).to receive(:first).and_return(post)
       end
 
       let!(:documents) do

data/spec/mongoid/relations/cascading/delete_spec.rb

@@ -59,8 +59,8 @@ describe Mongoid::Relations::Cascading::Delete do
       context "when the documents are in memory" do
 
         before do
-          post_one.should_receive(:delete).never
-          post_two.should_receive(:delete).never
+          expect(post_one).to receive(:delete).never
+          expect(post_two).to receive(:delete).never
           person.delete
         end
 

data/spec/mongoid/relations/cascading/destroy_spec.rb

@@ -23,11 +23,11 @@ describe Mongoid::Relations::Cascading::Destroy do
     context "when the documents exist" do
 
       before do
-        person.should_receive(:posts).and_return([ post ])
+        expect(person).to receive(:posts).and_return([ post ])
       end
 
       it "destroys all documents in the relation" do
-        post.should_receive(:destroy)
+        expect(post).to receive(:destroy)
         strategy.cascade
       end
     end
@@ -35,11 +35,11 @@ describe Mongoid::Relations::Cascading::Destroy do
     context "when no documents exist" do
 
       before do
-        person.should_receive(:posts).and_return([])
+        expect(person).to receive(:posts).and_return([])
       end
 
       it "does not destroy anything" do
-        post.should_receive(:destroy).never
+        expect(post).to receive(:destroy).never
         strategy.cascade
       end
     end

data/spec/mongoid/relations/cascading/nullify_spec.rb

@@ -21,11 +21,11 @@ describe Mongoid::Relations::Cascading::Nullify do
     end
 
     before do
-      person.should_receive(:posts).and_return(relation)
+      expect(person).to receive(:posts).and_return(relation)
     end
 
     it "nullifies the relation" do
-      relation.should_receive(:nullify)
+      expect(relation).to receive(:nullify)
       strategy.cascade
     end
   end

data/spec/mongoid/relations/cascading/restrict_spec.rb

@@ -34,7 +34,7 @@ describe Mongoid::Relations::Cascading::Restrict do
       context "when person has no drugs" do
 
         before do
-          person.should_receive(:drugs).and_return([ ])
+          expect(person).to receive(:drugs).and_return([ ])
         end
 
         it "deletes the person" do
@@ -45,7 +45,7 @@ describe Mongoid::Relations::Cascading::Restrict do
       context "when person has drugs" do
 
         before do
-          person.should_receive(:drugs).and_return([ drug ])
+          expect(person).to receive(:drugs).and_return([ drug ])
         end
 
         it "it raises an error" do
@@ -56,11 +56,11 @@ describe Mongoid::Relations::Cascading::Restrict do
 
     context "when no document exists" do
       before do
-        person.should_receive(:drugs).and_return([])
+        expect(person).to receive(:drugs).and_return([])
       end
 
       it "doesn't delete anything" do
-        drug.should_receive(:delete).never
+        expect(drug).to receive(:delete).never
         strategy.cascade
       end
     end

data/spec/mongoid/relations/eager_spec.rb

@@ -33,7 +33,7 @@ describe Mongoid::Relations::Eager do
       let(:includes) { [:person] }
 
       it "groups by foreign_key" do
-        doc.should_receive(:person_id).once
+        expect(doc).to receive(:person_id).once
         context.preload(inclusions, [doc])
       end
 
@@ -127,7 +127,7 @@ describe Mongoid::Relations::Eager do
       end
 
       it "runs the has_many preload" do
-        Mongoid::Relations::Eager::HasMany.should_receive(:new).with([posts_metadata], docs).once.and_call_original
+        expect(Mongoid::Relations::Eager::HasMany).to receive(:new).with([posts_metadata], docs).once.and_call_original
 
         context.eager_load(docs)
       end
@@ -156,18 +156,18 @@ describe Mongoid::Relations::Eager do
       end
 
       it "runs the has_many preload" do
-        Mongoid::Relations::Eager::HasMany.should_receive(:new).with([posts_metadata], docs).once.and_call_original
+        expect(Mongoid::Relations::Eager::HasMany).to receive(:new).with([posts_metadata], docs).once.and_call_original
 
         context.eager_load(docs)
       end
 
       it "runs the has_one preload" do
-        Mongoid::Relations::Eager::HasOne.should_receive(:new).with([cat_metadata], docs).once.and_call_original
+        expect(Mongoid::Relations::Eager::HasOne).to receive(:new).with([cat_metadata], docs).once.and_call_original
         context.eager_load(docs)
       end
 
       it "runs the has_and_belongs_to_many preload" do
-        Mongoid::Relations::Eager::HasAndBelongsToMany.should_receive(:new).with([houses_metadata], docs).once.and_call_original
+        expect(Mongoid::Relations::Eager::HasAndBelongsToMany).to receive(:new).with([houses_metadata], docs).once.and_call_original
         context.eager_load(docs)
       end
     end
@@ -191,7 +191,7 @@ describe Mongoid::Relations::Eager do
       end
 
       it "runs the has_one preload" do
-        Mongoid::Relations::Eager::HasOne.should_receive(:new).with([book_metadata, cat_metadata], docs).once.and_call_original
+        expect(Mongoid::Relations::Eager::HasOne).to receive(:new).with([book_metadata, cat_metadata], docs).once.and_call_original
         context.eager_load(docs)
       end
     end

data/spec/mongoid/relations/embedded/many_spec.rb

@@ -208,6 +208,37 @@ describe Mongoid::Relations::Embedded::Many do
           end
         end
       end
+
+      context "when the child has one sided many to many relation" do
+        let(:person) do
+          Person.create
+        end
+
+        let(:message) do
+          Message.new
+        end
+
+        context "assign parent first" do
+          before do
+            message.person = person
+            message.receviers.send(method, person)
+          end
+
+          it "appends to the relation array" do
+            expect(message.receviers).to include(person)
+          end
+        end
+
+        context "not assign parent" do
+          before do
+            message.receviers.send(method, person)
+          end
+
+          it "appends to the relation array" do
+            expect(message.receviers).to include(person)
+          end
+        end
+      end
     end
   end
 
@@ -1216,7 +1247,7 @@ describe Mongoid::Relations::Embedded::Many do
       end
 
       before do
-        person.addresses.should_not_receive(:batch_insert)
+        expect(person.addresses).to_not receive(:batch_insert)
         person.addresses.concat([])
       end
 
@@ -3547,7 +3578,7 @@ describe Mongoid::Relations::Embedded::Many do
     context "with errors" do
 
       before do
-        artist.should_receive(:before_add_song).and_raise
+        expect(artist).to receive(:before_add_song).and_raise
       end
 
       it "does not add the document to the relation" do
@@ -3577,7 +3608,7 @@ describe Mongoid::Relations::Embedded::Many do
     context "when errors are raised" do
 
       before do
-        artist.should_receive(:after_add_label).and_raise
+        expect(artist).to receive(:after_add_label).and_raise
       end
 
       it "adds the document to the relation" do
@@ -3638,7 +3669,7 @@ describe Mongoid::Relations::Embedded::Many do
       context "when errors are raised" do
 
         before do
-          artist.should_receive(:before_remove_song).and_raise
+          expect(artist).to receive(:before_remove_song).and_raise
         end
 
         describe "#delete" do
@@ -3706,7 +3737,7 @@ describe Mongoid::Relations::Embedded::Many do
     context "when errors are raised" do
 
       before do
-        artist.should_receive(:after_remove_label).and_raise
+        expect(artist).to receive(:after_remove_label).and_raise
       end
 
       describe "#delete" do

data/spec/mongoid/relations/metadata_spec.rb

@@ -82,7 +82,7 @@ describe Mongoid::Relations::Metadata do
       end
 
       before do
-        metadata.should_receive(:inverse).and_return(:wheels)
+        expect(metadata).to receive(:inverse).and_return(:wheels)
       end
 
       it "returns inverse name + _count" do
@@ -315,11 +315,11 @@ describe Mongoid::Relations::Metadata do
     end
 
     before do
-      Mongoid::Relations::Options.should_receive(:validate!).at_least(:once)
+      expect(Mongoid::Relations::Options).to receive(:validate!).at_least(:once)
     end
 
     it "concatenates the result from #find_module and name.classify" do
-      metadata.should_receive(:find_module).once.and_return("Fruit")
+      expect(metadata).to receive(:find_module).once.and_return("Fruit")
       expect(classified).to eq("Fruit::Name")
     end
   end
@@ -339,7 +339,7 @@ describe Mongoid::Relations::Metadata do
     end
 
     before do
-      Mongoid::Relations::Options.should_receive(:validate!).at_least(:once)
+      expect(Mongoid::Relations::Options).to receive(:validate!).at_least(:once)
     end
 
     context "when inverse_class_name is nil" do
@@ -390,7 +390,7 @@ describe Mongoid::Relations::Metadata do
           end
 
           it "returns root namespace" do
-            expect(mod).to be_empty
+            expect(mod).to be_nil
           end
         end
 
@@ -1812,19 +1812,38 @@ describe Mongoid::Relations::Metadata do
 
     context "when multiple matches" do
 
-      before do
-        class_name.constantize.has_many(:evil_drugs, class_name: "Drug")
-      end
+      context "when the inverse_of is not nil" do
+
+        before do
+          class_name.constantize.has_many(:evil_drugs, class_name: "Drug")
+        end
+
+        after do
+          class_name.constantize.relations.delete("evil_drugs")
+          Person.reset_callbacks(:validate)
+        end
 
-      after do
-        class_name.constantize.relations.delete("evil_drugs")
-        Person.reset_callbacks(:validate)
+        it "raises AmbiguousRelationship" do
+          expect {
+            inverse_relation
+          }.to raise_error(Mongoid::Errors::AmbiguousRelationship)
+        end
       end
 
-      it "raises AmbiguousRelationship" do
-        expect {
-          inverse_relation
-        }.to raise_error(Mongoid::Errors::AmbiguousRelationship)
+      context "when the inverse_of is nil" do
+
+        before do
+          class_name.constantize.has_many(:evil_drugs, class_name: "Drug", inverse_of: nil)
+        end
+
+        after do
+          class_name.constantize.relations.delete("evil_drugs")
+          Person.reset_callbacks(:validate)
+        end
+
+        it "returns the non-nil inverses" do
+          expect(inverse_relation).to eq(:drugs)
+        end
       end
     end
   end

data/spec/mongoid/relations/referenced/many_spec.rb

@@ -3286,7 +3286,7 @@ describe Mongoid::Relations::Referenced::Many do
     context "when execution raises errors" do
 
       before do
-        artist.should_receive(:before_add_album).and_raise
+        expect(artist).to receive(:before_add_album).and_raise
       end
 
       it "does not add the document to the relation" do
@@ -3316,7 +3316,7 @@ describe Mongoid::Relations::Referenced::Many do
     context "when execution raises errors" do
 
       before do
-        artist.should_receive(:after_add_album).and_raise
+        expect(artist).to receive(:after_add_album).and_raise
       end
 
       it "adds the document to the relation" do
@@ -3377,7 +3377,7 @@ describe Mongoid::Relations::Referenced::Many do
       context "when execution raises errors" do
 
         before do
-          artist.should_receive(:before_remove_album).and_raise
+          expect(artist).to receive(:before_remove_album).and_raise
         end
 
         describe "#delete" do
@@ -3452,7 +3452,7 @@ describe Mongoid::Relations::Referenced::Many do
     context "when errors are raised" do
 
       before do
-        artist.should_receive(:after_remove_album).and_raise
+        expect(artist).to receive(:after_remove_album).and_raise
       end
 
       describe "#delete" do
@@ -3505,4 +3505,19 @@ describe Mongoid::Relations::Referenced::Many do
       expect(criteria).to eq([ post_two, post_one ])
     end
   end
+
+  context "when accessing a scope named open" do
+
+    let(:person) do
+      Person.create
+    end
+
+    let!(:post) do
+      person.posts.create(title: "open")
+    end
+
+    it "returns the appropriate documents" do
+      expect(person.posts.open).to eq([ post ])
+    end
+  end
 end