mongoid 3.1.6 → 4.0.0

data/spec/mongoid/relations/cascading_spec.rb

@@ -21,7 +21,7 @@ describe Mongoid::Relations::Cascading do
         end
 
         it "ignores the cascade" do
-          band.cascade!.should eq([ "records" ])
+          expect(band.cascade!).to eq([ "records" ])
         end
       end
     end
@@ -61,11 +61,11 @@ describe Mongoid::Relations::Cascading do
       end
 
       it "adds the action to the cascades" do
-        klass.cascades.should include("posts")
+        expect(klass.cascades).to include("posts")
       end
 
       it "returns self" do
-        cascaded.should eq(klass)
+        expect(cascaded).to eq(klass)
       end
     end
 
@@ -83,11 +83,11 @@ describe Mongoid::Relations::Cascading do
       end
 
       it "does not add an action to the cascades" do
-        klass.cascades.should_not include("posts")
+        expect(klass.cascades).to_not include("posts")
       end
 
       it "returns self" do
-        cascaded.should eq(klass)
+        expect(cascaded).to eq(klass)
       end
     end
   end
@@ -161,7 +161,7 @@ describe Mongoid::Relations::Cascading do
             end
 
             it "removes the references to the removed document" do
-              from_db.ratable_id.should be_nil
+              expect(from_db.ratable_id).to be_nil
             end
           end
 
@@ -186,7 +186,7 @@ describe Mongoid::Relations::Cascading do
               end
 
               it "removes the references to the removed document" do
-                from_db.ratable_id.should be_nil
+                expect(from_db.ratable_id).to be_nil
               end
             end
 
@@ -197,7 +197,7 @@ describe Mongoid::Relations::Cascading do
               end
 
               it "returns nil" do
-                book.send(method).should be_true
+                expect(book.send(method)).to be true
               end
             end
           end
@@ -221,11 +221,11 @@ describe Mongoid::Relations::Cascading do
             end
 
             it "removes the references from the removed document" do
-              person.preference_ids.should_not include(preference.id)
+              expect(person.preference_ids).to_not include(preference.id)
             end
 
             it "removes the references to the removed document" do
-              from_db.person_ids.should_not include(person.id)
+              expect(from_db.person_ids).to_not include(person.id)
             end
           end
         end
@@ -250,12 +250,12 @@ describe Mongoid::Relations::Cascading do
               end
 
               it "raises no error" do
-                expect{ person.send(method) }.to_not raise_error(Mongoid::Errors::DeleteRestriction)
+                expect{ person.send(method) }.to_not raise_error
               end
 
               it "deletes the parent" do
                 person.send(method)
-                person.should be_destroyed
+                expect(person).to be_destroyed
               end
             end
 
@@ -289,12 +289,12 @@ describe Mongoid::Relations::Cascading do
               end
 
               it "raises no error" do
-                expect{ person.send(method) }.to_not raise_error(Mongoid::Errors::DeleteRestriction)
+                expect{ person.send(method) }.to_not raise_error
               end
 
               it "deletes the parent" do
                 person.send(method)
-                person.should be_destroyed
+                expect(person).to be_destroyed
               end
             end
 
@@ -328,12 +328,12 @@ describe Mongoid::Relations::Cascading do
               end
 
               it "raises no error" do
-                expect{ person.send(method) }.to_not raise_error(Mongoid::Errors::DeleteRestriction)
+                expect{ person.send(method) }.to_not raise_error
               end
 
               it "deletes the parent" do
                 person.send(method)
-                person.should be_destroyed
+                expect(person).to be_destroyed
               end
             end
 

data/spec/mongoid/relations/constraint_spec.rb

@@ -9,9 +9,10 @@ describe Mongoid::Relations::Constraint do
       before(:all) do
         Person.field(
           :_id,
-          type: Moped::BSON::ObjectId,
+          type: BSON::ObjectId,
           pre_processed: true,
-          default: ->{ Moped::BSON::ObjectId.new }
+          default: ->{ BSON::ObjectId.new },
+          overwrite: true
         )
       end
 
@@ -31,22 +32,22 @@ describe Mongoid::Relations::Constraint do
       context "when provided an object id" do
 
         let(:object) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         it "returns the object id" do
-          constraint.convert(object).should eq(object)
+          expect(constraint.convert(object)).to eq(object)
         end
       end
 
       context "when provided a string" do
 
         let(:object) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         it "returns an object id from the string" do
-          constraint.convert(object.to_s).should eq(object)
+          expect(constraint.convert(object.to_s)).to eq(object)
         end
       end
     end
@@ -67,7 +68,7 @@ describe Mongoid::Relations::Constraint do
       end
 
       it "returns the object" do
-        constraint.convert("testing").should eq("testing")
+        expect(constraint.convert("testing")).to eq("testing")
       end
     end
   end

data/spec/mongoid/relations/conversions_spec.rb

@@ -11,7 +11,7 @@ describe Mongoid::Relations::Conversions do
       end
 
       let(:object) do
-        Moped::BSON::ObjectId.new
+        BSON::ObjectId.new
       end
 
       let(:flagged) do
@@ -19,7 +19,7 @@ describe Mongoid::Relations::Conversions do
       end
 
       it "returns the object" do
-        flagged.should eq(object)
+        expect(flagged).to eq(object)
       end
     end
 
@@ -30,16 +30,18 @@ describe Mongoid::Relations::Conversions do
           :_id,
           type: String,
           pre_processed: true,
-          default: ->{ Moped::BSON::ObjectId.new.to_s }
+          overwrite: true,
+          default: ->{ BSON::ObjectId.new.to_s }
         )
       end
 
       after do
         Person.field(
           :_id,
-          type: Moped::BSON::ObjectId,
+          type: BSON::ObjectId,
           pre_processed: true,
-          default: ->{ Moped::BSON::ObjectId.new }
+          overwrite: true,
+          default: ->{ BSON::ObjectId.new }
         )
       end
 
@@ -50,7 +52,7 @@ describe Mongoid::Relations::Conversions do
       context "when provided an object id" do
 
         let(:object) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         let(:flagged) do
@@ -58,14 +60,14 @@ describe Mongoid::Relations::Conversions do
         end
 
         it "returns the object id" do
-          flagged.should eq(object)
+          expect(flagged).to eq(object)
         end
       end
 
       context "when provided a string" do
 
         let(:object) do
-          Moped::BSON::ObjectId.new.to_s
+          BSON::ObjectId.new.to_s
         end
 
         let(:flagged) do
@@ -73,11 +75,11 @@ describe Mongoid::Relations::Conversions do
         end
 
         it "returns the string" do
-          flagged.should eq(object)
+          expect(flagged).to eq(object)
         end
 
         it "marks the string as unconvertable" do
-          flagged.should be_unconvertable_to_bson
+          expect(flagged).to be_unconvertable_to_bson
         end
       end
     end
@@ -91,7 +93,7 @@ describe Mongoid::Relations::Conversions do
       context "when provided an object id" do
 
         let(:object) do
-          Moped::BSON::ObjectId.new
+          BSON::ObjectId.new
         end
 
         let(:flagged) do
@@ -99,7 +101,7 @@ describe Mongoid::Relations::Conversions do
         end
 
         it "returns the object id" do
-          flagged.should eq(object)
+          expect(flagged).to eq(object)
         end
       end
 
@@ -114,11 +116,11 @@ describe Mongoid::Relations::Conversions do
         end
 
         it "returns the integer" do
-          flagged.should eq(15)
+          expect(flagged).to eq(15)
         end
 
         it "marks the integer as unconvertable" do
-          flagged.should be_unconvertable_to_bson
+          expect(flagged).to be_unconvertable_to_bson
         end
       end
     end

data/spec/mongoid/relations/counter_cache_spec.rb

@@ -4,6 +4,91 @@ describe Mongoid::Relations::CounterCache do
 
   describe "#reset_counters" do
 
+    context "when counter is reset" do
+
+      let(:person) do
+        Person.create do |person|
+          person[:drugs_count] = 3
+        end
+      end
+
+      before do
+        person.reset_counters(:drugs)
+      end
+
+      it "sets the counter to zero" do
+        expect(person.drugs_count).to eq(0)
+      end
+
+      it "persists the changes" do
+        expect(person.reload.drugs_count).to eq(0)
+      end
+    end
+
+    context "when reset with invalid name" do
+
+      let(:person) do
+        Person.create
+      end
+
+      it "expect to raise an error" do
+        expect {
+          person.reset_counters(:not_exist)
+        }.to raise_error
+      end
+    end
+
+    context "when counter gets messy" do
+
+      let(:person) do
+        Person.create
+      end
+
+      let!(:post) do
+        person.posts.create(title: "my first post")
+      end
+
+      before do
+        Person.update_counters(person.id, :posts_count => 10)
+        person.reload
+        person.reset_counters(:posts)
+      end
+
+      it "resets to the right value" do
+        expect(person.posts_count).to eq(1)
+      end
+
+      it "persists the change" do
+        expect(person.reload.posts_count).to eq(1)
+      end
+    end
+
+    context "when the counter is on a subclass" do
+
+      let(:subscription) do
+        Subscription.create
+      end
+
+      let!(:pack) do
+        subscription.packs.create
+      end
+
+      before do
+        subscription.reset_counters(:packs)
+      end
+
+      it "resets the appropriate counter" do
+        expect(subscription[:packs_count]).to eq(1)
+      end
+
+      it "persists the change" do
+        expect(subscription.reload[:packs_count]).to eq(1)
+      end
+    end
+  end
+
+  describe ".reset_counters" do
+
     context "when counter is reset" do
 
       let(:person) do

data/spec/mongoid/relations/cyclic_spec.rb

@@ -11,15 +11,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_role)
+        expect(document).to respond_to(:parent_role)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_roles)
+        expect(document).to respond_to(:child_roles)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -30,15 +30,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_entry)
+        expect(document).to respond_to(:parent_entry)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_entries)
+        expect(document).to respond_to(:child_entries)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -62,15 +62,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_node)
+        expect(document).to respond_to(:parent_node)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_nodes)
+        expect(document).to respond_to(:child_nodes)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -81,15 +81,15 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates the parent relation" do
-        document.should respond_to(:parent_apple)
+        expect(document).to respond_to(:parent_apple)
       end
 
       it "creates the child relation" do
-        document.should respond_to(:child_apples)
+        expect(document).to respond_to(:child_apples)
       end
 
       it "sets cyclic to true" do
-        document.cyclic.should be_true
+        expect(document.cyclic).to be true
       end
     end
 
@@ -100,7 +100,7 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates relation with cascading callbacks enabled" do
-        document.class.relations['child_pineapples'].should be_cascading_callbacks
+        expect(document.class.relations['child_pineapples']).to be_cascading_callbacks
       end
     end
   end
@@ -112,15 +112,15 @@ describe Mongoid::Relations::Cyclic do
     end
 
     it "creates the parent relation" do
-      document.should respond_to(:parent_shelf)
+      expect(document).to respond_to(:parent_shelf)
     end
 
     it "creates the child relation" do
-      document.should respond_to(:child_shelf)
+      expect(document).to respond_to(:child_shelf)
     end
 
     it "sets cyclic to true" do
-      document.cyclic.should be_true
+      expect(document.cyclic).to be true
     end
 
     context "when cascading callbacks are enabled" do
@@ -130,7 +130,7 @@ describe Mongoid::Relations::Cyclic do
       end
 
       it "creates relation with cascading callbacks enabled" do
-        document.class.relations['child_mango'].should be_cascading_callbacks
+        expect(document.class.relations['child_mango']).to be_cascading_callbacks
       end
     end
   end
@@ -150,7 +150,7 @@ describe Mongoid::Relations::Cyclic do
     end
 
     it "sets the parent node" do
-      child_one.parent_node.should eq(root)
+      expect(child_one.parent_node).to eq(root)
     end
   end
 end

data/spec/mongoid/relations/eager/belongs_to_spec.rb

@@ -0,0 +1,154 @@
+require "spec_helper"
+
+describe Mongoid::Relations::Eager::BelongsTo do
+
+  describe ".grouped_docs" do
+
+    let(:docs) do
+      Post.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Post.reflect_on_association(:person)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+    end
+
+    it "aggregates by the parent id" do
+      expect(eager.grouped_docs.keys).to eq([person.id])
+    end
+  end
+
+  describe ".set_on_parent" do
+
+    let(:docs) do
+      Post.all.to_a
+    end
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:metadata) do
+      Post.reflect_on_association(:person)
+    end
+
+    let(:eager) do
+      described_class.new([metadata], docs).tap do |b|
+        b.shift_metadata
+      end
+    end
+
+    before do
+      Post.create!(person: person)
+    end
+
+    it "sets the relation into the parent" do
+      docs.each do |doc|
+        expect(doc).to receive(:set_relation).with(:person, :foo)
+      end
+      eager.set_on_parent(person.id, :foo)
+    end
+  end
+
+  describe ".includes" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    before do
+      3.times { |i| Account.create!(person: person, name: "savings#{i}") }
+    end
+
+    context "when including the belongs_to relation" do
+
+      it "queries twice" do
+
+        expect_query(2) do
+          Account.all.includes(:person).each do |account|
+            expect(account.person).to_not be_nil
+          end
+        end
+      end
+    end
+
+    context "when the relation is not polymorphic" do
+
+      let(:eager) do
+        Post.includes(:person).last
+      end
+
+      context "when the eager load has returned documents" do
+
+        let!(:post) do
+          person.posts.create(title: "testing")
+        end
+
+        before { eager }
+
+        it "puts the documents in the parent document" do
+          expect(eager.ivar(:person)).to eq(person)
+        end
+
+        it "does not query when touching the association" do
+          expect_query(0) do
+            expect(eager.person).to eq(person)
+          end
+        end
+
+        it "does not query when updating the association" do
+          expect_query(0) do
+            eager.person.username = "arthurnn"
+          end
+        end
+      end
+
+      context "when the eager load has not returned documents" do
+
+        let!(:post) do
+          Post.create(title: "testing")
+        end
+
+        before { eager }
+
+        it "does not set anything on the parent" do
+          expect(eager.ivar(:person)).to be nil
+        end
+
+        it "has a nil relation" do
+          expect(eager.person).to be nil
+        end
+      end
+    end
+
+    context "when the relation is polymorphic" do
+
+      let!(:movie) do
+        Movie.create(name: "Bladerunner")
+      end
+
+      let!(:rating) do
+        movie.ratings.create(value: 10)
+      end
+
+      it "raises an error" do
+        expect {
+          Rating.includes(:ratable).last
+        }.to raise_error(Mongoid::Errors::EagerLoad)
+      end
+    end
+  end
+end